Lukáš Lalinský
35aa6c4e84
Update date in NEWS
2015-08-23 20:09:22 +02:00
Lukáš Lalinský
54cea3edc3
Reorganize NEWS to put new features first
2015-08-23 12:20:25 +02:00
Lukáš Lalinský
0178d47c85
Don't use const ref to an integer in ChapterFrame
2015-08-23 12:20:25 +02:00
Lukáš Lalinský
71bc17b5e6
Lalala
2015-08-23 12:20:25 +02:00
Tsuda Kageyu
ac38f4ade1
Remove an unused private data member.
2015-08-23 18:25:17 +09:00
Tsuda Kageyu
b9f898698d
Revert "Remove some private data members not needed to carry."
...
This reverts commit 7c17d32b3a .
2015-08-23 18:21:51 +09:00
Tsuda Kageyu
bd564546f4
Fix some typos in comments.
2015-08-14 00:10:19 +09:00
Tsuda Kageyu
d90617959b
Fix some typos in comments.
2015-08-11 09:45:32 +09:00
Tsuda Kageyu
bc106ad81e
Separate two variable initializations.
2015-08-10 00:50:13 +09:00
Tsuda Kageyu
a23f808627
Remove an useless #include.
2015-08-09 13:26:51 +09:00
Tsuda Kageyu
e4cd963b12
Improve a test about splitting OGG pages.
...
Check for #529 .
2015-08-08 15:18:16 +09:00
Tsuda Kageyu
eff92fed98
Improve a test about splitting OGG pages.
...
Check for #529 .
2015-08-07 16:47:13 +09:00
Tsuda Kageyu
80441ff754
Remove a workaround for an older version of GCC.
...
GLIBC's byte swap functions are a good fallback option.
2015-08-07 08:59:16 +09:00
Tsuda Kageyu
edbafdbd88
Remove some redundant code from trefcounter.cpp.
2015-08-07 02:10:56 +09:00
Tsuda Kageyu
98ac8ba569
Add a comment about unused constants.
2015-08-07 02:03:03 +09:00
Tsuda Kageyu
173c58cf49
Merge pull request #580 from TsudaKageyu/negative-seek
...
Fix inconsistent negative seek behavior between Linux and Windows.
2015-08-07 01:32:26 +09:00
Tsuda Kageyu
ec3d050adc
Merge pull request #644 from petrows/master
...
Install target should be checked to avoid conflicts
2015-08-07 01:20:03 +09:00
Tsuda Kageyu
19a7e45997
Merge pull request #639 from TsudaKageyu/remove-cmake-check-float
...
Run-time check for byte order rather than CMake check.
2015-08-07 01:17:27 +09:00
Tsuda Kageyu
49563a9cd0
Merge pull request #640 from TsudaKageyu/cmake-vsprintf
...
CMake check for vsprintf_s/vsnprintf rather than sprintf_s/snprintf.
2015-08-07 01:14:12 +09:00
Tsuda Kageyu
1abe61640a
Merge pull request #645 from FestusHagen/fh1.m_UintAmbiguities_WavePackProperties
...
Silence uint ambiguity error in wavepackproperties.
2015-08-06 16:35:45 +09:00
Festus Hagen
65a6572299
Silence uint ambiguity errors in wavepackproperties.
2015-08-06 03:22:03 -04:00
Peter Petrovich
46e74c9391
Install target check fix
2015-08-05 08:45:27 +03:00
Tsuda Kageyu
7c17d32b3a
Remove some private data members not needed to carry.
2015-08-05 11:54:30 +09:00
Tsuda Kageyu
bfe4ec5df5
Update NEWS.
...
Added support for reading the encoder information of WMA files.
Added support for reading the codec of WAV files.
Added support for multi channel WavPack files.
Added support for reading the nominal bitrate of Ogg Speex files.
Added support for VBR headers in MPEG files.
2015-08-05 02:58:45 +09:00
Tsuda Kageyu
81b7d0046e
Merge branch 'master' of https://github.com/TsudaKageyu/taglib
2015-08-04 23:34:01 +09:00
Tsuda Kageyu
5990c72a01
Fix a typo in NEWS.
2015-08-04 23:27:28 +09:00
Tsuda Kageyu
018e969026
Add warnings about calling File::save() repeatedly.
2015-08-04 15:47:18 +09:00
Tsuda Kageyu
04ec7eae25
Add some supplementary comments.
2015-08-03 22:31:16 +09:00
Tsuda Kageyu
b6e7bb2c84
Update version to 1.10.0.
2015-08-03 16:14:48 +09:00
Tsuda Kageyu
f112d538ea
Merge pull request #612 from TsudaKageyu/flac-id3v1
...
Avoid overwriting the audio stream when adding an ID3v1 tag to a FLAC…
2015-08-03 15:54:16 +09:00
Tsuda Kageyu
ac5ef0291c
Update NEWS.
...
Fixed possible file corruptions when adding an ID3v1 tag to FLAC files.
2015-08-03 15:51:50 +09:00
Tsuda Kageyu
8fa86162c7
Add a test to check if the FLAC audio stream remains intact after adding an ID3v1 tag.
2015-08-03 15:40:30 +09:00
Tsuda Kageyu
fa17b4da6b
Avoid overwriting the audio stream when adding an ID3v1 tag to a FLAC file.
2015-08-03 15:39:27 +09:00
Tsuda Kageyu
076e845912
Run-time check for integer byte order rather than CMake check.
...
It will easily be optimized out.
2015-08-03 13:08:58 +09:00
Tsuda Kageyu
f830177b3b
Correct the order of #includes in tests.
2015-08-03 11:41:55 +09:00
Tsuda Kageyu
0650dc77a1
Fix some comments.
2015-08-02 03:24:25 +09:00
Tsuda Kageyu
c0f537a155
Merge pull request #581 from FestusHagen/fh2.m_FixUintAmbiguitiesInTests
...
Silence uint ambiguity errors in tests.
2015-08-02 02:40:20 +09:00
Tsuda Kageyu
44d9f2bf25
Run-time check for floating point byte order rather than CMake check.
...
It's safer not to use an unofficial CMake script.
2015-08-01 23:40:23 +09:00
Tsuda Kageyu
89e6ad96a4
Check for vsnprintf first.
2015-08-01 23:38:50 +09:00
Tsuda Kageyu
aa1dd0278d
CMake check for vsprintf_s/vsnprintf rather than sprintf_s/snprintf.
2015-08-01 23:38:50 +09:00
Tsuda Kageyu
13dab99af0
Remove unused includes from ConfigureChecks.cmake.
2015-08-01 23:34:36 +09:00
Tsuda Kageyu
03ec83ecca
Add AudioProperties::lengthInSeconds() and lengthInMilliseconds() functions to emulate virtual abstract functions.
2015-08-01 02:23:18 +09:00
Tsuda Kageyu
ce02910c6b
Update NEWS.
...
Marked FLAC::File::streamInfoData() deprecated. It returns an empty ByteVector.
Marked FLAC::File::streamLength() deprecated. It returns zero.
2015-08-01 02:06:35 +09:00
Tsuda Kageyu
f25e30d33f
Revert "Reorder CMake checks for sprintf() variants."
...
This reverts commit c69364d831 .
2015-08-01 01:59:36 +09:00
Tsuda Kageyu
4dcccfbd6a
Update NEWS.
...
New API for the audio length in milliseconds.
2015-08-01 01:46:35 +09:00
Tsuda Kageyu
7ca1b0c4d3
Merge pull request #575 from TsudaKageyu/chunk-offset
...
Stop calculating the offset in RIFF::File::chunkData().
2015-08-01 01:31:17 +09:00
Tsuda Kageyu
11f4e4e1ca
Merge pull request #567 from TsudaKageyu/audioprop-wv
...
(wishlist) WavPack: AudioProperties improvements
2015-08-01 01:30:19 +09:00
Tsuda Kageyu
9759bd2dd7
Merge pull request #566 from TsudaKageyu/audioprop-tta
...
(wishlist) TrueAudio: AudioProperties improvements
2015-08-01 01:30:12 +09:00
Tsuda Kageyu
b28784538a
Merge pull request #565 from TsudaKageyu/audioprop-wav
...
(wishlist) WAV: AudioProperties improvements
2015-08-01 01:30:03 +09:00
Tsuda Kageyu
fdea096c8d
Merge pull request #564 from TsudaKageyu/audioprop-aiff
...
(wishlist) AIFF: AudioProperties improvements
2015-08-01 01:29:46 +09:00
Tsuda Kageyu
a9d030544a
Merge pull request #563 from TsudaKageyu/audioprop-vorbis
...
(wishlist) Ogg Vorbis: AudioProperties improvements
2015-08-01 01:29:35 +09:00
Tsuda Kageyu
8344c4d7f8
Merge pull request #562 from TsudaKageyu/audioprop-speex
...
(wishlist) Ogg Speex: AudioProperties improvements
2015-08-01 01:29:22 +09:00
Tsuda Kageyu
8b1e872f81
Merge pull request #561 from TsudaKageyu/audioprop-opus
...
(wishlist) Ogg Opus: AudioProperties improvements
2015-08-01 01:29:13 +09:00
Tsuda Kageyu
6a778751ee
Merge pull request #560 from TsudaKageyu/audioprop-mpeg
...
(wishlist) MPEG: AudioProperties improvements
2015-08-01 01:29:06 +09:00
Tsuda Kageyu
4328a830f9
Merge pull request #559 from TsudaKageyu/audioprop-mpc
...
(wishlist) MusePak: AudioProperties improvements
2015-08-01 01:27:20 +09:00
Tsuda Kageyu
ae99cbe64e
Merge pull request #558 from TsudaKageyu/audioprop-mp4
...
(wishlist) MP4: AudioProperties improvements
2015-08-01 01:27:15 +09:00
Tsuda Kageyu
692ce897cb
Merge pull request #557 from TsudaKageyu/audioprop-flac
...
(wishlist) FLAC: AudioProperties improvements
2015-08-01 01:27:06 +09:00
Tsuda Kageyu
0ed1c29acc
Merge pull request #556 from TsudaKageyu/audioprop-asf
...
(wishlist) ASF: AudioProperties improvements
2015-08-01 01:26:52 +09:00
Tsuda Kageyu
3c59b7858a
Merge pull request #555 from TsudaKageyu/audioprop-ape
...
(wishlist) APE: AudioProperties improvements
2015-08-01 01:21:59 +09:00
Tsuda Kageyu
2c9f63d9b0
Merge pull request #568 from TsudaKageyu/audioprop-mod
...
(wishlist) MOD: AudioProperties improvements
2015-08-01 01:04:34 +09:00
Tsuda Kageyu
0b43b7136d
FLAC: Remove unused formal parameters.
2015-08-01 00:49:25 +09:00
Tsuda Kageyu
1e752a1e8f
FLAC: Add debug messages to tell some functions are obsolete.
2015-08-01 00:49:23 +09:00
Tsuda Kageyu
29a31859ff
FLAC: Move some public functions to above private ones.
2015-08-01 00:49:22 +09:00
Tsuda Kageyu
0b01461d50
FLAC: Avoid using deprecated functions.
2015-08-01 00:49:22 +09:00
Tsuda Kageyu
a77abedf63
Remove some more data members not needed to carry.
2015-08-01 00:49:22 +09:00
Tsuda Kageyu
21412e2ba2
FLAC: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add bitsPerSample() property besides sampleWidth(). (#360 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-08-01 00:49:21 +09:00
Tsuda Kageyu
dbf9644c8d
WavPack: Remove unused formal parameters.
2015-08-01 00:44:41 +09:00
Tsuda Kageyu
592e14f950
TrueAudio: Remove unused formal parameters.
2015-08-01 00:41:42 +09:00
Tsuda Kageyu
1fb3727c4c
WAV: Remove unused formal parameters.
2015-08-01 00:37:31 +09:00
Tsuda Kageyu
0501fbdd72
AIFF: Remove unused formal parameters.
2015-08-01 00:33:56 +09:00
Tsuda Kageyu
5235abc498
Vorbis: Remove unused formal parameters.
2015-08-01 00:30:13 +09:00
Tsuda Kageyu
d944009904
Speex: Remove unused formal parameters.
2015-08-01 00:22:09 +09:00
Tsuda Kageyu
f729f863cd
Opus: Remove unused formal parameters.
2015-08-01 00:19:20 +09:00
Tsuda Kageyu
c715ec09e4
MPEG: Hide an internal function from the public header.
2015-08-01 00:15:51 +09:00
Tsuda Kageyu
4f621140ce
MPEG: Remove unused formal parameters.
2015-08-01 00:09:59 +09:00
Tsuda Kageyu
bd251aed37
MusePak: Remove unused formal parameters.
2015-08-01 00:04:27 +09:00
Tsuda Kageyu
34ab65aa57
MP4: Hide an internal function from the public header.
2015-07-31 23:59:22 +09:00
Tsuda Kageyu
7f0c547ba6
MP4: Remove unused formal parameters.
2015-07-31 23:55:30 +09:00
Tsuda Kageyu
0ff38ed52b
ASF: Remove unused formal parameters.
2015-07-31 23:39:58 +09:00
Tsuda Kageyu
2b1116cec1
APE: Remove unused formal parameters.
2015-07-31 23:18:50 +09:00
Tsuda Kageyu
88947e7a48
Silence some MSVC specific warnings in tests.
2015-07-31 20:55:23 +09:00
Tsuda Kageyu
5ad69a81dc
Silence some MSVC2015 specific warnings.
2015-07-31 12:23:01 +09:00
Tsuda Kageyu
c9963af848
MP4 atom length is limited up to 31 bits.
...
32-bit value will be negative.
2015-07-31 11:24:36 +09:00
Tsuda Kageyu
f38e32163e
Add some comments to tutils.h.
2015-07-31 10:27:16 +09:00
Tsuda Kageyu
c69364d831
Reorder CMake checks for sprintf() variants.
...
VS2015 has snprintf(), however sprintf_s() is still recommended.
2015-07-31 10:11:01 +09:00
Tsuda Kageyu
3142330bee
Remove sudo from .travis.yml.
...
This allows our tests to run faster on the container-based infrastructure.
2015-07-31 09:06:24 +09:00
Tsuda Kageyu
9b849c5da8
Merge pull request #554 from FestusHagen/fh1.m_FriendlyCppUnitSearch
...
Don't look for CppUnit unless BUILD_TESTS, general cleanup.
2015-07-30 23:55:16 +09:00
Tsuda Kageyu
a197f45ca8
Merge pull request #595 from TsudaKageyu/gcc-warning-test
...
Silence a GCC warning about ignoring a return value in test.
2015-07-30 23:39:04 +09:00
Tsuda Kageyu
6dcecf0e71
Fix a typo in a debug message.
2015-07-30 23:36:44 +09:00
Tsuda Kageyu
47800d1000
Merge pull request #625 from TsudaKageyu/checksum-comment
...
(minor, comment only) Add a supplementary comment to ByteVector::checksum().
2015-07-30 23:30:43 +09:00
Tsuda Kageyu
cc8c3cd1fd
Merge pull request #617 from TsudaKageyu/useless-call
...
Remove an useless function call.
2015-07-30 23:30:18 +09:00
Tsuda Kageyu
58994e330e
Update NEWS.
...
Fixed reading FLAC files with zero-sized padding blocks.
2015-07-30 22:03:02 +09:00
Tsuda Kageyu
572afd437d
Merge pull request #638 from TsudaKageyu/update-news
...
Update NEWS.
2015-07-30 22:00:00 +09:00
Tsuda Kageyu
1eef4177e7
Merge pull request #637 from TsudaKageyu/flac-zero-sized-padding
...
Make FLAC::File tolerant to zero-sized padding blocks.
2015-07-30 21:58:42 +09:00
Tsuda Kageyu
64fac517ed
Update NEWS.
2015-07-30 10:03:47 +09:00
Tsuda Kageyu
f79c766ba4
Avoid creating zero-sized padding blocks.
2015-07-29 23:05:17 +09:00
Tsuda Kageyu
6f944b0291
Make FLAC::File tolerant to zero-sized padding blocks.
2015-07-29 20:52:56 +09:00
Tsuda Kageyu
801c9db810
WAV: Avoid using a magic number.
2015-06-30 15:59:01 +09:00
Tsuda Kageyu
409b135dd5
MPEG: Fix warnings about signed/unsigned mismatch on some compilers.
2015-06-30 11:58:07 +09:00
Tsuda Kageyu
4dd14d4d73
Add a supplementary comment to ByteVector::checksum().
2015-06-27 01:29:16 +09:00
Tsuda Kageyu
44e6419644
ASF: Hide some internal functions from the public header.
2015-06-23 18:22:31 +09:00
Tsuda Kageyu
467658e463
ASF: Make use of List iterators and setAutoDelete().
2015-06-23 17:43:50 +09:00
Tsuda Kageyu
3fcb21642c
ASF: Hide internal class declarations from the public header.
2015-06-23 17:34:33 +09:00
Tsuda Kageyu
472ce9f42c
ASF: Use CodecType enum instead of a magic number.
2015-06-23 11:48:25 +09:00
Tsuda Kageyu
be33340383
Remove an useless function call.
2015-06-22 09:54:17 +09:00
Tsuda Kageyu
91ed3548f1
ASF: Enable ASF::Properties to get the audio codec information.
2015-06-21 02:42:47 +09:00
Tsuda Kageyu
b56f4c4372
APE: Reduce useless File::Find() operations.
2015-06-20 20:41:02 +09:00
Tsuda Kageyu
2155b4fd50
TrueAudio: A bit more accurate calculation of the stream length.
2015-06-20 17:36:00 +09:00
Tsuda Kageyu
e605e96835
MusePak: Avoid seeking a file when not needed.
2015-06-20 17:30:25 +09:00
Tsuda Kageyu
dfee7020da
APE: Find an ID3v2 tag and calculate the stream length in APE::File.
2015-06-20 04:34:34 +09:00
Scott Wheeler
e90b5e5f2f
Merge pull request #614 from TsudaKageyu/win32-pkg-config
...
Enable pkg-config on Windows.
2015-06-19 09:12:32 +02:00
Tsuda Kageyu
642baca4ed
Fix inconsistent negative seek behavior between Linux and Windows.
2015-06-19 02:42:18 +09:00
Tsuda Kageyu
da01fa5745
Enable pkg-config on Windows.
2015-06-19 01:26:12 +09:00
Tsuda Kageyu
78c70cf5bb
MOD: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (always return 0)
2015-06-18 18:03:53 +09:00
Tsuda Kageyu
8f6af3f020
WavPack: A bit more accurate calculation of the stream length.
2015-06-18 18:00:03 +09:00
Tsuda Kageyu
22f250eaa4
WavPack: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add isLossless() property.
Support multi channel. (#92 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:59:06 +09:00
Tsuda Kageyu
eb73612a2b
TrueAudio: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Avoid possible arithmetic overflows. (#520 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:52:36 +09:00
Tsuda Kageyu
9c8e36d3be
WAV: Move property parsing code to Properties.
...
Make use of 'fact' chunk to get the number of total samples.
2015-06-18 17:47:39 +09:00
Tsuda Kageyu
ed25204d75
WAV: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add bitsPerSample() property besides sampleWidth(). (#360 )
Add format() property. (#360 )
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:43:09 +09:00
Tsuda Kageyu
03fd0a3ead
AIFF: Calculate the actual average bitrate even if a file is compressed.
...
Move property parsing code to Properties.
2015-06-18 17:38:41 +09:00
Tsuda Kageyu
aede4ac851
AIFF: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add bitsPerSample() property besides sampleWidth(). (#360 )
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:30:58 +09:00
Tsuda Kageyu
3823afcc87
Ogg Vorbis: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:24:31 +09:00
Tsuda Kageyu
4dba88fa31
Ogg Speex: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add bitrateNominal() property.
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:23:03 +09:00
Tsuda Kageyu
f3d8100c7b
Ogg Opus: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:19:23 +09:00
Tsuda Kageyu
b2c79bc084
MPEG: No need to get the length of an ID3v2 tag twice.
2015-06-18 17:14:12 +09:00
Tsuda Kageyu
f82be353b4
MPEG: Properties::xingHeader() should return null if a VBR header is not found.
2015-06-18 17:14:12 +09:00
Tsuda Kageyu
9ec6d28239
MPEG: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Support VBRI header in addition to Xing. (#136 )
Fix MPEG frame seeker functions. (maybe #190 )
Calculate MPEG frame length accurately.
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:14:04 +09:00
Tsuda Kageyu
3a1c784eec
MusePak: A bit more accurate calculation of the stream length.
2015-06-18 17:05:58 +09:00
Tsuda Kageyu
4a014c8113
MusePak: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 17:05:58 +09:00
Tsuda Kageyu
5d77553759
MP4: Remove useless ByteVector::mid() operations.
2015-06-18 17:00:10 +09:00
Tsuda Kageyu
da14f67e2c
MP4: Do rounding when calculating the bit rate.
2015-06-18 17:00:10 +09:00
Tsuda Kageyu
9226fa76b3
MP4: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add some tests for audio properties.
Add some supplementary comments.
Move parsing code to read() for consistency with other classes.
2015-06-18 17:00:10 +09:00
Tsuda Kageyu
ff36648e92
ASF: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Add bitsPerSample() property. (#360 )
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 16:33:56 +09:00
Scott Wheeler
447a4739c5
Merge pull request #611 from TsudaKageyu/fix-bufsize
...
Fix mismatched file I/O buffer sizes.
2015-06-18 08:22:59 +02:00
Tsuda Kageyu
f15fe869a5
Add a test for APE files with an ID3v2 tag.
2015-06-18 14:41:37 +09:00
Tsuda Kageyu
125d887b85
APE: Use the audio stream length in calculating the bit rate.
2015-06-18 14:41:37 +09:00
Tsuda Kageyu
9a8e41b9d6
APE: AudioProperties improvements
...
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503 )
Enable to read bit depth from older version files. (#360 )
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
2015-06-18 14:41:37 +09:00
Tsuda Kageyu
68ef160dbc
Fix mismatched file I/O buffer sizes.
2015-06-18 11:23:31 +09:00
Scott Wheeler
6d71bdf8b7
Merge pull request #607 from TsudaKageyu/unused-function
...
Remove some unused private function prototypes.
2015-06-15 21:15:08 +02:00
Tsuda Kageyu
b37eaace15
Removed an unused data member from MPE::File.
...
It seems to be related to scan().
2015-06-12 14:07:52 +09:00
Tsuda Kageyu
c1c70edb76
Remove some unused private function prototypes.
2015-06-12 11:50:38 +09:00
Tsuda Kageyu
75159d5d8a
Silence a GCC warning about ignoring a return value in test.
2015-06-10 03:44:30 +09:00
Stephen F. Booth
46862bf537
Merge pull request #594 from TsudaKageyu/typos-in-comment
...
Fix some typos in comments.
2015-06-08 22:19:27 -04:00
Tsuda Kageyu
2b260fd2e8
Fix some typos in comments.
2015-06-09 10:33:32 +09:00
Scott Wheeler
b1a35a8b31
Add const to docs
2015-06-03 01:21:12 +02:00
Stephen F. Booth
88ef556d4e
Merge pull request #591 from TsudaKageyu/wmemcpy
...
Use wmemcpy() rather than memcpy() and sizeof(wchar_t).
2015-06-02 08:19:33 -04:00
Tsuda Kageyu
0c0f123a08
Use wmemcpy() rather than memcpy() and sizeof(wchar_t).
2015-06-01 13:52:55 +09:00
Festus Hagen
48311cca14
Undo comment stacking.
2015-05-31 22:12:18 -04:00
Michael Helmling
db90f4b358
Prefix #ifndef with TAGLIB_ in tpropertymap.h
2015-05-29 19:53:42 +02:00
Festus Hagen
b5d65edab7
Silence uint ambiguity errors in tests.
2015-05-27 14:07:53 -04:00
Scott Wheeler
a06d55ae6f
Merge pull request #577 from TsudaKageyu/frameoffset
...
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). (#190 )
2015-05-26 17:53:24 +02:00
Stephen F. Booth
c5f2e9342d
Merge pull request #578 from TsudaKageyu/test-temp
...
A lot of zero-sized temporary files are left after a test session on …
2015-05-25 08:41:37 -04:00
Tsuda Kageyu
2d778d5a0a
A lot of zero-sized temporary files are left after a test session on Windows.
2015-05-25 15:51:19 +09:00
Stephen F. Booth
0aa75b2e8d
Merge pull request #574 from TsudaKageyu/skip-dup-chunks
...
Skip duplicate chunks when reading AIFF/WAV files.
2015-05-24 14:38:50 -04:00
Tsuda Kageyu
618a939c56
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). ( #190 )
2015-05-25 02:41:27 +09:00
Tsuda Kageyu
2337fbcfc6
Stop calculating the offset in RIFF::File::chunkData().
2015-05-25 00:43:36 +09:00
Tsuda Kageyu
9da20a8a52
Skip duplicate chunks when reading AIFF/WAV files.
...
Similar to #492 .
There is no good reason to use the last chunk rather than the first one.
2015-05-25 00:40:13 +09:00
Stephen F. Booth
4129b919c1
Merge pull request #572 from TsudaKageyu/map-erase2
...
Map::erase() can take a key directly so no need to call find() before…
2015-05-23 08:21:58 -04:00
Tsuda Kageyu
6d6f544010
Map::erase() can take a key directly so no need to call find() beforehand.
2015-05-23 18:12:01 +09:00
Stephen F. Booth
93da3ba6d9
Merge pull request #571 from TsudaKageyu/fuzzed-wv
...
Avoid an infinite loop when reading fuzzed WavPack files. (#482 )
2015-05-22 07:44:41 -04:00
Stephen F. Booth
e064b88049
Merge pull request #570 from TsudaKageyu/audioprop-typo
...
Fix a typo in comment.
2015-05-22 07:41:46 -04:00
Tsuda Kageyu
3094540a4b
Avoid an infinite loop when reading fuzzed WavPack files. ( #482 )
2015-05-22 14:15:10 +09:00
Tsuda Kageyu
8e21dcc3d4
Fix a typo in comment.
2015-05-22 12:06:01 +09:00
Stephen F. Booth
0ea22348cb
Merge pull request #569 from TsudaKageyu/map-erase
...
std::map::erase() can take a key directly and has no-throw guarantee.
2015-05-21 22:46:15 -04:00
Stephen F. Booth
48ca54de1f
Merge pull request #484 from TsudaKageyu/fix-rfind
...
Fix File::rfind() for small files.
2015-05-21 22:44:10 -04:00
Tsuda Kageyu
54de66f275
std::map::erase() can take a key directly and has no-throw guarantee.
2015-05-22 01:26:56 +09:00
Lukáš Lalinský
d4b0ba2a7a
TagLib::XM::Properties is a public class that should be exported
2015-05-20 15:18:01 -07:00
Festus Hagen
abc5743222
Removed missed unnecessary BUILD_TESTS check.
2015-05-20 15:34:05 -04:00
Scott Wheeler
525396d9c2
Merge pull request #550 from TsudaKageyu/fix-test
...
Fix test code to work on some environments.
2015-05-20 19:24:52 +02:00
Tsuda Kageyu
bb9679b51a
Fix test code to work on some environments.
...
const char * is more preferable than string for ifstream constructor.
2015-05-21 02:03:06 +09:00
Festus Hagen
e44cba56b5
Don't look for CppUnit unless BUILD_TESTS, general cleanup.
2015-05-20 11:11:55 -04:00
Scott Wheeler
e4cf012522
Bring the API more in line with the rest of TagLib
...
Like in #255 , this also makes it possible to read values from the
tag in a const function.
2015-05-20 14:26:53 +02:00
Scott Wheeler
a37d423ea8
Merge pull request #549 from TsudaKageyu/win32-test
...
Modify the test code to work on MSVC/Windows.
2015-05-20 13:50:49 +02:00
Tsuda Kageyu
88a4cf34b8
Modify the test code to work on MSVC/Windows.
2015-05-20 20:19:20 +09:00
Scott Wheeler
81261dd128
This should also work Windows and has less duplicated code
2015-05-20 11:53:32 +02:00
Scott Wheeler
3bea9f6bee
Don't use tempnam on UNIX
...
This silences the huge stream of warnings when building the tests.
I think I didn't break the Windows version in the process (though
it may make sense to use the built in Windows functions there
instead), but I don't have a Windows build environment here, so
I can't test.
2015-05-20 11:45:32 +02:00
Scott Wheeler
9cc2d7cfee
Merge pull request #546 from TsudaKageyu/test-surrogate-pair
...
Add a test for strings that contains surrogate pairs.
2015-05-19 19:57:47 +02:00
Scott Wheeler
fe1bf015bb
Merge pull request #548 from TsudaKageyu/render-twice
...
No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag.
2015-05-19 11:28:50 +02:00
Tsuda Kageyu
287078566f
No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag.
2015-05-19 17:39:37 +09:00
Scott Wheeler
60966518e2
Quote path names including user-provided variables
...
This should make these work even if the value contains spaces
Closes #344
2015-05-19 10:15:15 +02:00
Tsuda Kageyu
2268efb49e
Add a test for strings that contains surrogate pairs.
2015-05-19 09:01:47 +09:00
Scott Wheeler
29f535dc8d
Remove *file argument to private members
...
This is already covered by d->file, so there's no reason to pass a pointer
to the member dozens of times.
2015-05-18 23:11:51 +02:00
Scott Wheeler
592522d34c
Moar const fixes
2015-05-18 23:00:16 +02:00
Scott Wheeler
6b9e4e4403
1001 Const fixes (plus iterator rename)
2015-05-18 22:48:55 +02:00
Scott Wheeler
089e44f3db
Remove unnecessary checks for null before delete
...
Closes #343
2015-05-18 21:40:21 +02:00
Scott Wheeler
bd3c4dc1b2
Merge pull request #515 from TsudaKageyu/empty-id3v2-frame
...
Skip empty ID3v2 frames when saving an ID3v2 tag.
2015-05-18 21:36:37 +02:00
Scott Wheeler
bba562b557
Add accessors to manipulate MP4 tags without modifying the internal structure
...
This brings the MP4 API in line closer to other tag formats and makes it
possible to access the tag data from const functions.
"ItemListMap" has been renamed to "ItemMap" (with the old version
deprecated). It seems that the "ListMap" notion was copied probably
from Allan's ApeTag implementation, which incorrectly copied the term
from the XiphTag. Notably, in XiphTag, because a field can have multiple
values, the "ListMap" is a map of lists. Calling things a "ListMap" where
there can be only one value doesn't fit.
Closes #255
2015-05-18 21:18:33 +02:00
Scott Wheeler
451d23ca37
Add isEmpty() to MP4
...
Closes #457
2015-05-18 20:30:19 +02:00
Scott Wheeler
d248f77ab9
Show something useful for ChapterFrame::toString()
...
Closes #517
2015-05-18 19:51:18 +02:00
Tsuda Kageyu
727a11573a
Fix File::rfind() for small files to work just like ByteVector::rfind().
2015-05-19 01:24:37 +09:00
Scott Wheeler
34da0c0dab
Update signature and docs
...
Specifically this allows the frame to be constructed and then to have
the children and embedded frames set later.
2015-05-18 18:19:43 +02:00
Scott Wheeler
7316cd331d
Remove the null termination stuff from the ToC frames too
2015-05-18 18:17:10 +02:00
Scott Wheeler
3a977c55c4
We've moved away from including the null byte in the returned value
...
This does change previous behavior, but the previous behavior was
particularly stupid and inconsistent with everything else in TagLib.
It should be possible to mitigate this by putting the same safety
guards in the TableOfContents
2015-05-18 17:29:52 +02:00
Scott Wheeler
a094ce7dd2
Don't underflow if there are no embedded frames
...
Closes #513
2015-05-18 17:11:18 +02:00
Scott Wheeler
941efcba18
This isn't tracked as part of the elementID anymore
2015-05-18 16:53:12 +02:00
Scott Wheeler
ffb543acbb
Split chapter data and embedded frame data
...
This will allow us to test parsing them separately
2015-05-18 16:45:57 +02:00
Scott Wheeler
fc24b3d22b
Don't require users to include a padding byte explicitly
...
This makes it where the natural construction can be used of something
like:
new ChapterFrame("ID", ... )
Closes #514
2015-05-18 16:41:30 +02:00
Scott Wheeler
a9e064c58e
Also test second constructor
2015-05-18 16:30:37 +02:00
Scott Wheeler
1a5d89d29e
Update signature and docs to be more in-line with TagLib's style
2015-05-18 16:00:47 +02:00
Scott Wheeler
650b581f9e
Merge pull request #544 from TsudaKageyu/advance
...
Use std::advance rather than a loop and increment.
2015-05-18 15:09:28 +02:00
Scott Wheeler
0739dd232a
It doesn't make sense to set the factory after construction
...
Closes #259
2015-05-18 14:21:55 +02:00
Scott Wheeler
41a250a15d
Make this macro work with current Qt versions
...
Closes #499
2015-05-18 12:42:24 +02:00
Tsuda Kageyu
8da0013482
Add a test to check if an empty ID3v2 frame is really skipped.
2015-05-18 19:03:20 +09:00
Scott Wheeler
0288059495
Add astylerc
2015-05-18 11:31:55 +02:00
Tsuda Kageyu
6e40361c0e
Use std::advance rather than a loop and increment.
2015-05-18 09:31:43 +09:00
Lukáš Lalinský
c2570fe115
Merge pull request #521 from TsudaKageyu/gcc-warning
...
Fix a GCC/Clang warning about singed/unsigned comparison.
2015-05-17 10:06:10 -07:00
Lukáš Lalinský
bd91da55ba
Merge pull request #542 from TsudaKageyu/comment-typos
...
Fix some typos in comment.
2015-05-17 10:05:43 -07:00
Tsuda Kageyu
3a3a6a6fda
Fix some typos in comment.
2015-05-18 00:31:46 +09:00
Lukáš Lalinský
64c43b0d3f
Merge pull request #535 from FestusHagen/fh1.m_UintAmbiguity
...
Silenced uint ambiguity error.
2015-05-16 17:03:53 -07:00
Lukáš Lalinský
db2dfa9515
Merge pull request #538 from gogglesmm/optimize-mid-to-uint
...
bytevector.mid(pos,4).toUInt() => bytevector.toUInt(pos)
2015-05-15 20:06:24 -07:00
Lukáš Lalinský
0069debf0c
Merge pull request #536 from FestusHagen/fh1.m_CMakeSubProjectFix
...
Fix for using Taglib as a CMake sub directory project.
2015-05-15 19:48:43 -07:00
Lukáš Lalinský
69563d83a0
Merge pull request #533 from TsudaKageyu/bytevector-resize
...
Fix the wrong padding of ByteVector::resize().
2015-05-15 19:43:38 -07:00
Sander Jansen
60775306ea
Fix code styling
2015-05-15 21:39:34 -05:00
Sander Jansen
4f77420248
replace use of bytevector.mid(pos,4).toUInt() with more optimized bytevector.toUInt(pos)
2015-05-15 21:25:44 -05:00
Tsuda Kageyu
b021ed44e9
Revert the last two commits.
...
But leave the tests unchanged, and add some comments.
2015-05-16 11:16:00 +09:00
Tsuda Kageyu
1f99c93a61
Reduce redundant memset when resizing ByteVector.
2015-05-16 03:46:34 +09:00
Tsuda Kageyu
a924ca0db7
Expand the internal buffer of ByteVector only if really needed.
...
Add tests for all execution paths of ByteVector::resize().
2015-05-14 11:20:35 +09:00
Festus Hagen
e43c1a3c09
Fix for using Taglib as a CMake sub directory project.
2015-05-09 20:29:52 -04:00
Festus Hagen
1e9529380d
Silenced uint ambiguity error.
2015-05-09 14:19:33 -04:00
Tsuda Kageyu
ff8443f33a
Fix the wrong padding of ByteVector::resize().
...
The expanded area will be filled with garbage instead of correct padding in some corner cases.
2015-05-02 02:43:08 +09:00
Lukáš Lalinský
62ab41fa07
Merge pull request #532 from TsudaKageyu/bytevector-detach-test
...
A little robuster tests for ByteVector iterators after detaching.
2015-04-29 10:14:16 -07:00
Tsuda Kageyu
00e3504264
A little robuster tests for ByteVector iterators after detaching.
2015-04-29 17:15:13 +09:00
Lukáš Lalinský
852da79899
Merge pull request #531 from TsudaKageyu/bytevector-detach
...
Fix ByteVector to return correct iterators after detached.
2015-04-28 20:34:53 -07:00
Tsuda Kageyu
ab047f6054
Fix ByteVector to return correct iterators after detached.
2015-04-29 10:28:08 +09:00
Lukáš Lalinský
5bad35c4cb
Merge pull request #527 from TsudaKageyu/wma-guid
...
Fix saving WMA files with some GUID fields.
2015-04-28 10:42:06 -07:00
Tsuda Kageyu
8d708c03e1
Store any GUID fields in Metadata Library Object.
2015-04-28 16:40:24 +09:00
Tsuda Kageyu
f9a0b50830
Fix saving WMA files with some GUID fields.
2015-04-28 12:06:24 +09:00
Tsuda Kageyu
8491266b12
Fix a GCC/Clang warning about singed/unsigned comparison.
2015-04-17 09:38:21 +09:00
Stephen F. Booth
066b5aa57e
Merge pull request #492 from TsudaKageyu/duplicate-id3v2-aiff-wav
...
Check AIFF/WAV files for duplicate tags.
2015-03-25 08:16:41 -04:00
Tsuda Kageyu
5f0a7da481
Take into account the frame header version when skipping an empty frame.
2015-03-24 10:41:39 +09:00
Tsuda Kageyu
d33d684fab
Discard empty ID3v2 frames instead of adding a dummy null byte.
2015-03-24 10:31:52 +09:00
Tsuda Kageyu
4c4be0a263
Add a dummy byte to an empty ID3v2 frame to stick to the ID3v2 spec.
2015-03-22 22:14:21 +09:00
Michael Helmling
f476cf2b45
Merge pull request #511 from TsudaKageyu/tag-prop
...
Fix a bug that Tag::setProperties() clears the date instead of the track number
2015-03-20 10:28:20 +01:00
Tsuda Kageyu
68c0b0591b
Fix a bug that Tag::setProperties() clears the date instead of the track number.
2015-03-20 13:33:13 +09:00
Stephen F. Booth
8fccaf30d2
Merge pull request #479 from TsudaKageyu/fuzzed-mp4
...
Fix an infinite loop when parsing MP4 files.
2015-02-18 08:15:50 -05:00
Tsuda Kageyu
b69973bcf2
Fix infinite loops when parsing MP4 files.
2015-02-18 11:33:10 +09:00
Tsuda Kageyu
30eac7569f
Check AIFF/WAV files for duplicate tags.
...
AIFF/WAV files can have duplicate tags and it leads to memory leak.
2015-02-18 11:31:55 +09:00
Lukáš Lalinský
f6081ed32e
Merge pull request #505 from TsudaKageyu/fuzzed-ape-tests
...
Separate the tests for fuzzed APE files.
2015-02-17 09:22:35 +01:00
Tsuda Kageyu
0839a23902
Separate the tests for fuzzed APE files.
2015-02-17 12:36:57 +09:00
Lukáš Lalinský
f35a279dd1
Merge pull request #496 from TsudaKageyu/fuzzed-mpc
...
Some fixes for fuzzed MPC files.
2015-02-16 19:26:57 +01:00
Tsuda Kageyu
e463d14f2e
Check for EOF to fix a segfault while parsing fuzzed MPC files.
2015-02-17 01:22:39 +09:00
Tsuda Kageyu
829ae2112a
Check the packet size to fix a segfault error while parsing fuzzed MPC files.
2015-02-17 01:22:39 +09:00
Tsuda Kageyu
65664e6855
Check for EOF to fix an infinite loop while parsing fuzzed MPC files.
2015-02-17 01:22:39 +09:00
Tsuda Kageyu
2193d6dd84
Fix an out-of-bounds access and consequent errors while parsing fuzzed MPC files.
...
Consequent errors may vary: segfault, zerodiv and so forth.
2015-02-17 01:22:38 +09:00
Stephen F. Booth
ef786188ad
Merge pull request #502 from TsudaKageyu/fix-save-wav
...
Fix saving ID3v2/INFO tags of WAV files.
2015-01-31 14:12:18 -05:00
Tsuda Kageyu
2b5ee8deb9
Fix saving ID3v2/INFO tags of WAV files.
...
The old tag won't be removed when the new tag is empty.
2015-01-30 14:51:28 +09:00
Scott Wheeler
ed09c9cf87
Merge pull request #494 from TsudaKageyu/fix-zlib
...
Fix a wrong parameter for zlib.
2015-01-06 17:06:10 +01:00
Tsuda Kageyu
9d91610fc0
Fix a wrong parameter for zlib.
...
z_stream.avail_in has to be the length of the input buffer.
It will fail when frameDataLength is smaller than the actual compressed data size.
2015-01-06 18:45:42 +09:00
Stephen F. Booth
aed689c145
Merge pull request #491 from TsudaKageyu/aiff-hasid3v2
...
Implement missing AIFF::File::hasID3v2Tag().
2015-01-05 08:17:21 -05:00
Tsuda Kageyu
c6a63a3a2f
Implement missing AIFF::File::hasID3v2Tag().
2015-01-05 18:20:31 +09:00
Stephen F. Booth
2b0a540228
Merge pull request #490 from TsudaKageyu/remove-uncompr
...
Remove an unused file from taglib/CMakeLists.txt.
2015-01-04 22:31:42 -05:00
Tsuda Kageyu
2685ec1842
Remove an unused file from taglib/CMakeLists.txt.
...
uncompr.c is no longer used since caa53e8
2015-01-05 11:00:47 +09:00
Scott Wheeler
fdea6dcd40
Merge pull request #489 from TsudaKageyu/frame-flag-tests
...
Add some tests for huge memory allocation due to bad ID3v2 frame header ...
2015-01-05 02:03:06 +01:00
Tsuda Kageyu
ed253d3691
Add some tests for huge memory allocation due to bad ID3v2 frame header flags.
...
The tests covers #466 and #486 .
Also fixes a compilation error on some compilers.
2015-01-05 09:34:30 +09:00
Scott Wheeler
57729b834a
Show a debugging message when we have an error reading
2015-01-04 20:13:24 +01:00
Scott Wheeler
caa53e8de5
Read the compressed data as a stream
...
This avoids allocating the complete buffer at first based solely
on the value read from the frame header. This then does a sanity
check at the end of reading to make sure that the two values match.
At present, it just prints a debugging message if the values do not
match.
Fixes #466
2015-01-04 19:58:18 +01:00
Lukáš Lalinský
31982660c8
Merge pull request #485 from TsudaKageyu/oga-segfault
...
Fix a segfault when reading faulty Ogg/FLAC files.
2015-01-01 19:48:23 +01:00
Lukáš Lalinský
bd7b8cc36a
Merge pull request #473 from TsudaKageyu/fix-infotag
...
Fix an infinite loop when parsing an INFO tag.
2015-01-01 19:46:53 +01:00
Tsuda Kageyu
bc9bbfe3fa
Add a check for faulty Ogg/FLAC files.
2015-01-02 00:10:51 +09:00
Tsuda Kageyu
7adea3df22
Separate tests for fuzzed WAV files.
2015-01-01 23:18:43 +09:00
Tsuda Kageyu
5ebb2ece80
Fix a segfault when reading faulty Ogg/FLAC files.
2015-01-01 19:59:30 +09:00
Tsuda Kageyu
0d2e01df61
Fix a segfault when parsing WAV properties.
2014-12-31 01:46:30 +09:00
Tsuda Kageyu
695fb5ec16
Add a test for fuzzed WAV files.
2014-12-31 01:44:25 +09:00
Tsuda Kageyu
3170d47ec3
Fix an infinite loop when parsing an INFO tag.
2014-12-31 01:44:25 +09:00
Stephen F. Booth
79b7c14129
Merge pull request #481 from TsudaKageyu/aiff-c
...
Add support for AIFF-C files.
2014-12-30 10:51:17 -05:00
Tsuda Kageyu
977fb2aeb0
Fix compilation errors on Clang.
2014-12-31 00:41:22 +09:00
Tsuda Kageyu
3b8c7d4e3a
Add support for AIFF-C files.
2014-12-30 23:53:40 +09:00
Lukáš Lalinský
be33389884
Merge pull request #476 from TsudaKageyu/fuzzed-ape
...
Some fixes for fuzzed APE files.
2014-12-29 09:47:10 +01:00
Lukáš Lalinský
59ae61de6e
Merge pull request #456 from TsudaKageyu/id3v2-padding
...
ID3v2 padding won't increase beyond 1% of the file size.
2014-12-29 09:26:55 +01:00
Tsuda Kageyu
16ac2cd240
Added some tests for fuzzed APE files.
2014-12-23 21:02:00 +09:00
Tsuda Kageyu
61543432c0
Fix an excessive loop when parsing an APE file.
2014-12-23 20:58:36 +09:00
Tsuda Kageyu
4a9614bfc3
Fix a division by zero error when parsing an APE file.
2014-12-23 20:54:20 +09:00
Tsuda Kageyu
1a917a38cd
Fix ID3v2 padding size calculation.
2014-12-09 10:54:21 +09:00
Lukáš Lalinský
735e17f504
Merge remote-tracking branch 'TsudaKageyu/64bit-atom'
...
Conflicts:
ConfigureChecks.cmake
2014-12-08 16:52:33 -08:00
Tsuda Kageyu
0731bc7b2e
Remove CMake check for sizeof(long).
2014-12-09 08:55:46 +09:00
Bart van der Velden
fb1c744daf
Compile without warnings with MSVC
2014-12-08 09:42:04 -08:00
Lukáš Lalinský
1bc5acd7a7
Merge pull request #424 from TsudaKageyu/format
...
Unified redundant string format functions. (backport from taglib2)
2014-12-08 09:38:03 -08:00
Lukáš Lalinský
f30f5ccce5
Merge pull request #441 from xhochy/tests-fix-vectorsize
...
Fix ByteVector sizes in some test cases
2014-12-08 09:36:28 -08:00
Lukáš Lalinský
421eb5e97e
Merge pull request #420 from TsudaKageyu/remove-codecvt
...
Replaced codecvt with Win32 API.
2014-12-08 09:14:00 -08:00
Lukáš Lalinský
5e60ec48e9
Merge pull request #454 from TsudaKageyu/duplicate-id3v2
...
Skip duplicate ID3v2 tags in MPEG files.
2014-12-08 09:09:28 -08:00
Lukáš Lalinský
68eca440c9
Merge pull request #458 from achalddave/fix-gcc-errors
...
Fix more uint/TagLib::uint ambiguities
2014-12-08 08:54:27 -08:00
Achal Dave
7b03403791
Fix more uint/TagLib::uint ambiguities
2014-11-18 15:06:10 -08:00
Tsuda Kageyu
d80c4c96c3
ID3v2 padding won't increase beyond 1% of the file size.
2014-10-23 12:38:38 +09:00
Tsuda Kageyu
73b9b9b58d
Avoid reading an entire ID3v2 tag when skipping it.
2014-10-23 08:14:10 +09:00
Lukáš Lalinský
072851869a
Merge pull request #453 from TsudaKageyu/editorconfig
...
Suggestion: Use EditorConfig to help us stick to our coding style.
2014-10-22 19:31:14 +02:00
Tsuda Kageyu
269e78f1a0
Add a test for duplicate ID3v2 tags.
2014-10-21 00:16:43 +09:00
Tsuda Kageyu
71acf3b6f7
Comment on a weird workaround for duplicate ID3v2 tags.
2014-10-20 23:13:15 +09:00
Tsuda Kageyu
e41dc68a6b
Skip duplicate ID3v2 tags in MPEG files.
2014-10-20 21:21:32 +09:00
Tsuda Kageyu
cfad951442
Use EditorConfig to help us stick to our coding style.
...
http://editorconfig.org/
2014-10-20 11:27:30 +09:00
Lukáš Lalinský
23ffb24472
Merge pull request #448 from TsudaKageyu/msvc-error
...
Fix a compilation error on MSVC.
2014-10-16 10:15:51 +02:00
Tsuda Kageyu
a8bfcd81be
Fix a compilation error on MSVC.
2014-10-16 07:19:31 +09:00
Scott Wheeler
bd7419f0bd
Rebuild TRDC from v2.3 fields
...
This fixes an issue that was reported to me via email with the recording
date being thrown away from v2.3 tags.
2014-09-25 23:07:09 +02:00
Scott Wheeler
71c1ce375f
Don't leak
2014-09-25 20:46:47 +02:00
Scott Wheeler
cff8d22818
Missing assignment
2014-09-25 20:46:47 +02:00
Scott Wheeler
0051351ebb
TableOfContents and ChapterFrame can be added to v2.3 or v2.4 tags
2014-09-25 20:01:00 +02:00
Scott Wheeler
82315276db
Take ownership of embedded frames, as documented
...
Previously embedded frames that were created automatically were
never deleted.
Fixes #440
2014-09-18 16:23:28 +02:00
Scott Wheeler
8ea07be47e
Merge branch 'master' of https://github.com/taglib/taglib
2014-09-18 16:12:34 +02:00
Scott Wheeler
eae4605e6e
Merge pull request #439 from xhochy/test-memleaks
...
Fix various memleaks in the tests
2014-09-18 16:11:12 +02:00
Scott Wheeler
b6289c64dd
Break up the mega-lines
2014-09-18 11:21:18 +02:00
Scott Wheeler
e6d7dd08f2
No reason to store this in the d-pointer
2014-09-18 10:24:48 +02:00
Uwe L. Korn
ee283789b7
Fix ByteVector sizes in some test cases
2014-09-14 20:08:31 +01:00
Uwe L. Korn
205569c8d2
Fix various memleaks in the tests
2014-09-14 18:03:27 +01:00
Lukáš Lalinský
4b67beffc8
Merge pull request #434 from DidierMalenfant/master
...
Ignoring files generated when creating an Xcode project via cmake.
2014-08-25 14:09:44 +02:00
Didier Malenfant
b7a514886d
Ignoring files generated when creating an Xcode project via cmake.
2014-08-23 20:37:32 -07:00
Tsuda Kageyu
0e6d8617ae
Revert "Removed an ambiguous cast from FileNameHandle to FileName."
...
This reverts commit 9af7601bae .
2014-08-23 00:04:33 +09:00
Tsuda Kageyu
dfbaee4103
Removed an ambiguous cast from FileNameHandle to FileName.
2014-08-23 00:04:33 +09:00
Tsuda Kageyu
f29c5f45f8
Workaround for 64-bit MP4 atoms.
2014-08-23 00:04:33 +09:00
Lukáš Lalinský
b1a8205561
Merge pull request #430 from TsudaKageyu/const-iterator
...
Reduce useless detach operations by making some non-const iterators cons...
2014-08-21 09:47:36 +02:00
Tsuda Kageyu
2971891c69
Reduce useless detach operations by making some non-const iterators const.
2014-08-21 16:35:35 +09:00
Lukáš Lalinský
d5e3d6ea7c
Merge pull request #421 from TsudaKageyu/fix-wav-strip
...
Fixed a bug on stripping tags when saving .WAV files.
2014-08-20 10:12:43 +02:00
Lukáš Lalinský
20ce66f98b
Merge pull request #422 from TsudaKageyu/detach
...
Added some missing detach()s to List<T>, ByteVector and String.
2014-08-20 10:09:08 +02:00
Stephen F. Booth
aff3351a25
Merge pull request #427 from TsudaKageyu/linebreak
...
Small fixes in line breaking.
2014-08-17 09:01:47 -04:00
Tsuda Kageyu
387890d956
Small fixes in line breaking.
2014-08-16 15:33:39 +09:00
Lukáš Lalinský
8765d40c2c
Merge pull request #426 from TsudaKageyu/string-cmp
...
Added some operators to compare String to string literals.
2014-08-12 18:15:37 +02:00
Tsuda Kageyu
9bb0eb7ee9
Added some operators to compare String to string literals.
2014-08-12 23:58:45 +09:00
Lukáš Lalinský
d34c922c75
Merge pull request #425 from TsudaKageyu/fix-cmake
...
Removed a useless line from ConfigureChecks.cmake.
2014-08-12 09:42:19 +02:00
Tsuda Kageyu
3c727e091e
Removed a useless line from ConfigureChecks.cmake.
2014-08-12 13:42:44 +09:00
Tsuda Kageyu
a055933e10
Unified the same debug messages.
2014-08-12 13:33:25 +09:00
Tsuda Kageyu
20c0aac309
Unified redundant string format functions. (backport from taglib2)
2014-08-11 01:09:07 +09:00
Tsuda Kageyu
929829b2b5
Removed useless strlen() and wcslen().
2014-08-10 01:13:25 +09:00
Tsuda Kageyu
1944588595
Added some missing detach()s to List<T>, ByteVector and String.
2014-08-08 13:12:14 +09:00
Tsuda Kageyu
31a74927e4
Fixed a bug on stripping tags when saving .WAV files.
2014-08-07 18:49:53 +09:00
Tsuda Kageyu
972aa1feef
Replaced codecvt with Win32 API.
2014-08-07 17:35:42 +09:00
Lukáš Lalinský
c23ee5331f
Merge pull request #418 from TsudaKageyu/debug-msg
...
Fixed some debug messages.
2014-08-07 00:37:17 +02:00
Lukáš Lalinský
0f605be198
Merge pull request #414 from TsudaKageyu/fix-floattest
...
Fixed some mistakes in the CMake module for float types.
2014-08-07 00:36:59 +02:00
Tsuda Kageyu
590cb29f99
Improved the CMake check for float/double format. (Intel compiler support)
2014-08-06 20:57:04 +09:00
Tsuda Kageyu
286fd2abec
Fixed some debug messages.
2014-08-06 16:13:15 +09:00
Tsuda Kageyu
f76d76728d
Fixed some mistakes in the CMake module for float types.
2014-08-04 17:51:05 +09:00
Lukáš Lalinský
80f5436370
Merge pull request #413 from TsudaKageyu/msvc-tests3
...
Fixed a test to work with MSVC.
2014-08-04 09:09:20 +02:00
Tsuda Kageyu
043d2bbef5
Fixed a test to work with MSVC.
2014-08-04 15:11:50 +09:00
Lukáš Lalinský
cf59d51d93
Merge pull request #406 from TsudaKageyu/utf16-byteorder
...
Fixed handling UTF-16 byte order.
2014-07-23 10:21:37 +02:00
Lukáš Lalinský
9569b99e4c
Merge pull request #405 from TsudaKageyu/missing-include
...
Added a missing #include.
2014-07-23 10:20:38 +02:00
Tsuda Kageyu
590405d878
Fixed handling UTF-16 byte order.
2014-07-23 15:36:16 +09:00
Tsuda Kageyu
c03b91aed3
Added a missing #include.
2014-07-23 14:56:18 +09:00
Lukáš Lalinský
ee2908a6cf
Merge pull request #399 from TsudaKageyu/float-conv
...
Added float conversion functions to ByteVector.
2014-07-22 12:10:54 +02:00
Tsuda Kageyu
e29f1d39e7
Added float conversion functions to ByteVector.
...
Added CMake checks about IEEE754 compliance.
2014-07-17 12:09:14 +09:00
Lukáš Lalinský
b509106031
Merge pull request #398 from TsudaKageyu/fix-chap
...
Fixed some compilation error on MSVC in CHAP and CTOC frames support.
2014-07-16 22:30:10 +02:00
Tsuda Kageyu
47cd6fad4f
Fixed some compilation error on MSVC in CHAP and CTOC frames support.
2014-07-17 01:43:56 +09:00
Lukáš Lalinský
fb24dfe7cf
Merge pull request #393 from TsudaKageyu/msvc-tests
...
Modified some tests to work with MSVC.
2014-07-16 16:02:10 +02:00
Lukáš Lalinský
f42263e04a
Merge pull request #392 from TsudaKageyu/zlib-source
...
Added a Windows-friendly build option ZLIB_SOURCE.
2014-07-16 15:58:52 +02:00
Lukáš Lalinský
43872f362d
Merge pull request #390 from TsudaKageyu/vector-bounds
...
Fixed out-of-bounds access in findVector().
2014-07-16 15:57:55 +02:00
Lukáš Lalinský
73d3436570
Merge pull request #391 from TsudaKageyu/setlasterror
...
Added some SetLastError()s to get correct error codes in Win32.
2014-07-16 15:56:59 +02:00
Lukáš Lalinský
1e50b8dc25
Merge pull request #394 from ufleisch/master
...
Add genres 148 to 191 to list of ID3v1 genres.
2014-07-16 15:54:03 +02:00
Lukáš Lalinský
4a585c5258
Merge remote-tracking branch 'krejclu6/krejclu6_chapters'
2014-07-16 15:52:41 +02:00
Tsuda Kageyu
5f738a9819
Changed to skip the ZLib check when ZLIB_SOURCE is set.
2014-07-09 09:52:08 +09:00
Tsuda Kageyu
d7995b807f
Fixed the tests to work with MSVC when UNICODE is set.
2014-06-24 01:29:15 +09:00
Urs Fleisch
3e60e339a4
Add genres 148 to 191 to list of ID3v1 genres.
...
This genres were added for Winamp version 5.6, see
<http://en.wikipedia.org/wiki/ID3#List_of_genres >.
2014-06-21 12:34:42 +02:00
Tsuda Kageyu
5feabe0988
Updated INSTALL.
2014-06-20 10:36:09 +09:00
Tsuda Kageyu
29a5129096
Modified some tests to work with MSVC.
2014-06-20 09:06:26 +09:00
Tsuda Kageyu
fadb57e4cd
Added a Windows-friendly build option ZLIB_SOURCE.
2014-06-19 19:54:12 +09:00
Tsuda Kageyu
653b631aea
Added a check for patternSize and removed a useless check.
2014-06-19 16:57:36 +09:00
Tsuda Kageyu
cb3abf15ad
Added a test for out-of-bounds access in findVector().
2014-06-19 13:22:50 +09:00
Tsuda Kageyu
29377fc8f1
Added some SetLastError()s to get correct error codes in Win32.
2014-06-19 12:58:07 +09:00
Tsuda Kageyu
663f10d51d
Fixed out-of-bounds access in findVector().
2014-06-19 12:19:18 +09:00
Lukas Krejci
a192db07c0
Code clean-up.
2014-06-11 17:52:05 +02:00
Lukas Krejci
459adc69ad
Merge branch 'krejclu6_chapters' of https://github.com/krejclu6/taglib into krejclu6_chapters
...
Conflicts:
taglib/mpeg/id3v2/id3v2framefactory.cpp
tests/test_id3v2.cpp
2014-05-18 16:29:54 +02:00
Lukas Krejci
500b3e630b
Uncommenting unit test.
2014-05-18 16:15:35 +02:00
Lukas Krejci
5c5c89e8d9
Added functions for work with embedded frames.
...
Added embedded frames parsing.
Added embedded frames rendering.
Modified constructor of CHAP and CTOC frame, so it can accept list of embedded frames.
Added unit tests for CHAP and CTOC frames parsing and rendering (with support of embedded frames).
Fixed bugs in rendering of CTOC frames.
Added functions for adding and removing child elements in CTOC frames.
2014-05-18 16:15:35 +02:00
Lukáš Krejčí
140fb2b3f6
Removed duplicated CHAP frame testing funtion.
2014-05-18 16:15:35 +02:00
Lukáš Krejčí
98ed58f910
Changed copyright and e-mail in modified files.
2014-05-18 16:15:35 +02:00
Lukáš Krejčí
7d99b8276a
Fixed errors in ChapterFrame constructor.
...
Fixed errors in ChapterFrame method renderFields.
Fixed errors in TableOfContentsFrame method parseFields.
Added ChapterFrame and TableOfContentsFrame headers and sources to CMakeLists.txt.
Added some basic testing of CHAP and CTOC frames parsing.
2014-05-18 16:15:35 +02:00
Lukáš Krejčí
17841e89ae
Fixed error in childElements function.
2014-05-18 16:14:00 +02:00
Lukáš Krejčí
c5f9258462
Finished parseFields, renderFields and asProperty methods of ChapterFrame and TableOfContentsFrame classes.
...
Methods setElementID of ChapterFrame and TableOfContentsFrame classes now automatically terminates new element ID with null.
2014-05-18 16:14:00 +02:00
Lukáš Krejčí
3a1040d55b
Added basic members of ChapterFrame and TableOfContentsFrame classes.
...
Fixed minor bugs in ChapterFrame and TableOfContentsFrame headers.
2014-05-18 16:11:55 +02:00
Lukáš Krejčí
0864634ea6
Created CPP and H files for CTOC and CHAP frames.
2014-05-18 16:11:55 +02:00
Stephen F. Booth
f27e0aaecf
Merge pull request #370 from supermihi/fix162v2
...
Fix #162 : Xiph and APE generic getters return space-concatenated values
2014-04-24 21:35:50 -04:00
Lukáš Lalinský
ecc768d459
Merge pull request #380 from TsudaKageyu/fix-comment
...
Removed a wrong note from a comment in tstring.h.
2014-04-11 10:33:56 +02:00
Tsuda Kageyu
fabc411cb9
Removed a wrong note from a comment in tstring.h.
2014-04-11 17:16:55 +09:00
Lukáš Lalinský
2d528d844a
Merge pull request #356 from TsudaKageyu/string-comment
...
Added some comment about UTF-16 encoding to String::data().
2014-04-10 20:05:55 +02:00
Lukáš Lalinský
c65753c766
Add ALBUMARTIST property mapping for WMA
2014-04-10 20:05:14 +02:00
Lukáš Lalinský
7e10b13962
Merge pull request #372 from TsudaKageyu/cmake-warning
...
Suppressed the warning "Policy CMP0022 is not set" on CMake 2.8.12.
2014-04-10 20:04:17 +02:00
Lukáš Lalinský
05e26119f7
Merge pull request #377 from amigadave/master
...
Add ALBUMARTIST property mapping for MP4
2014-04-10 20:01:36 +02:00
David King
95a59c416b
Add ALBUMARTIST property mapping for MP4
...
https://code.google.com/p/mp4v2/wiki/iTunesMetadata
2014-04-10 17:33:29 +01:00
Tsuda Kageyu
3f557be608
Suppressed the warning "Policy CMP0022 is not set" on CMake 2.8.12.
2014-04-05 21:08:21 +09:00
Lukáš Lalinský
9ca7877587
Merge pull request #371 from TsudaKageyu/cmake-ver
...
Changed cmake_minimum_required from 2.6.0 to 2.8.0.
2014-04-05 13:07:58 +02:00
Tsuda Kageyu
a93ee10134
Changed cmake_minimum_required from 2.6.0 to 2.8.0.
2014-04-05 19:44:47 +09:00
Michael Helmling
1723e9b18a
Fix #162 : Xiph and APE generic getters return space-concatenated values
2014-04-03 21:07:29 +02:00
Lukáš Lalinský
16b8688c1a
Merge pull request #362 from ufleisch/master
...
Add support for synchronized lyrics (SYLT) and event timing codes (ETCO) for ID3v2
2014-03-30 19:21:47 +02:00
Urs Fleisch
3b60af2c0b
Add support for ID3v2 ETCO frames (event timing codes).
2014-03-30 09:28:14 +02:00
Urs Fleisch
eba99c3a70
Add support for ID3v2 SYLT frames (synchronized lyrics).
2014-03-30 09:26:03 +02:00
Tsuda Kageyu
6bcd422afa
Small fix of a comment
2014-03-14 15:12:03 +09:00
Tsuda Kageyu
c357d293a1
Added some comment about UTF-16 encoding to String::data().
2014-03-13 14:38:03 +09:00
Stephen F. Booth
cfb43223dc
Merge pull request #354 from TsudaKageyu/opus-bitrate
...
opus: Estimate the bitrate if possible
2014-03-09 21:37:50 -04:00
Tsuda Kageyu
72cd379f30
opus: Estimate the bitrate if possible
2014-03-10 09:37:10 +09:00
Lukáš Lalinský
a3d724af27
Merge pull request #352 from TsudaKageyu/tagreader-sprintf
...
Avoid using sprintf() in tagreader.cpp to fix an MSVC warning.
2014-02-19 16:34:42 +01:00
Tsuda Kageyu
05e0081414
Avoid using sprintf() in tagreader.cpp to fix an MSVC warning.
2014-02-19 23:35:23 +09:00
Lukáš Lalinský
b658f95e06
Merge pull request #338 from funman/master
...
Also build/install taglib_c.pc when targetting windows
2014-02-17 08:46:13 +01:00
Lukáš Lalinský
2758aed34d
Merge pull request #348 from TsudaKageyu/string-memcpy
...
Reduced a useless memory copy in tstring.cpp.
2014-02-17 08:45:49 +01:00
Lukáš Lalinský
12b25868b7
Merge pull request #349 from TsudaKageyu/install-typo
...
Fixed a typo in INSTALL.
2014-02-17 08:44:54 +01:00
Tsuda Kageyu
1deff52d95
Fixed a typo in INSTALL.
2014-02-17 11:22:40 +09:00
Tsuda Kageyu
69eaa75f64
Reduced a useless memory copy in tstring.cpp.
2014-02-15 20:25:00 +09:00
Lukáš Lalinský
3e0c73bdbc
Merge pull request #347 from TsudaKageyu/xm-seek
...
Changed XM::File::save() to use seek() properly.
2014-02-14 17:21:49 +01:00
Tsuda Kageyu
9e94f8bb6c
Changed XM::File::save() to use seek() properly.
2014-02-14 19:22:53 +09:00
Lukáš Lalinský
aa49723b48
Merge pull request #330 from TsudaKageyu/fix-emptystring
...
Fixed a bug reported at #328
2014-02-05 00:02:47 -08:00
Tsuda Kageyu
167513ae57
Avoid using &d->data[0] when d->data is empty.
2014-02-05 10:35:07 +09:00
Tsuda Kageyu
d0f3e9b186
Use std::string::c_str() rather than &s[0] where a const pointer is required.
2014-01-24 09:48:39 +09:00
Stephen F. Booth
4fc020e0d3
Merge pull request #340 from mineo/patch-1
...
Remove a superfluos 'x'
2014-01-18 13:12:21 -08:00
Wieland Hoffmann
db147e672e
Remove a superfluos 'x'
2014-01-18 18:11:31 +01:00
Rafaël Carré
c45a0694f9
Also build/install taglib.pc when targetting windows
...
.pc file is notably used when cross-compiling windows software
2014-01-13 22:49:17 +01:00
Tsuda Kageyu
584bbc7c78
Fixed conversion from empty String to ByteVector
2013-12-04 09:37:59 +09:00
Lukáš Lalinský
10b804e0ae
Merge pull request #322 from TsudaKageyu/mailaddress
...
Fixed a mail address
2013-11-24 23:25:19 -08:00
Tsuda Kageyu
4f8ab4b63f
Fixed a mail address
2013-11-25 14:12:34 +09:00
Stephen F. Booth
5593c251c8
Merge pull request #321 from TsudaKageyu/nominmax
...
Fixed warnings in MinGW
2013-11-23 19:24:55 -08:00
Tsuda Kageyu
7d7a7be115
Fixed warnings in MinGW
2013-11-23 23:42:20 +09:00
Stephen F. Booth
f733077917
Merge pull request #307 from TsudaKageyu/string-abi
...
Fixed the ABI breakage in TagLib::String
2013-11-15 15:04:30 -08:00
Stephen F. Booth
670493f97f
Merge pull request #310 from TsudaKageyu/backslash
...
Replaced wrongly used slashes with backslashes in some comments
2013-11-15 03:55:04 -08:00
Tsuda Kageyu
d4adc22922
Replaced wrongly used slashes with backslashes in some comments
2013-11-15 15:31:23 +09:00
Stephen F. Booth
34f8cd8a90
Merge pull request #309 from TsudaKageyu/fix-replace
...
Rewrote ByteVector::replace() simpler (fix for the issue #308 )
2013-11-14 07:01:29 -08:00
Tsuda Kageyu
4a7d31c87b
Rewrote ByteVector::replace() simpler
2013-11-14 14:58:14 +09:00
Tsuda Kageyu
3bf30af66c
Fixed ABI breakage in TagLib::String
2013-11-06 17:01:21 +09:00
Lukáš Lalinský
ee9720a997
Merge pull request #304 from funman/master
...
Win32: avoid symbol lookup if UNICODE is defined
2013-10-28 01:12:48 -07:00
Rafaël Carré
69e58b5f3f
Win32: avoid symbol lookup if UNICODE is defined
2013-10-28 04:39:04 +01:00
Lukas Krejci
1ce5385e30
Uncommenting unit test.
2013-10-13 18:38:54 +02:00
Lukas Krejci
5ed2d88f78
Added functions for work with embedded frames.
...
Added embedded frames parsing.
Added embedded frames rendering.
Modified constructor of CHAP and CTOC frame, so it can accept list of embedded frames.
Added unit tests for CHAP and CTOC frames parsing and rendering (with support of embedded frames).
Fixed bugs in rendering of CTOC frames.
Added functions for adding and removing child elements in CTOC frames.
2013-10-13 18:27:43 +02:00
Lukáš Lalinský
aa61823432
Fix the length of the TXXX translation mapping ( closes #283 )
2013-10-08 17:50:01 +02:00
Lukáš Lalinský
2f7af42092
Update version to 1.9.1
2013-10-08 17:46:34 +02:00
Lukáš Lalinský
2d5abd46d2
Added TagLib::MP4::PropertyMap::codec()
2013-10-08 17:41:09 +02:00
Lukáš Lalinský
9b5869ea37
Merge remote-tracking branch 'TsudaKageyu/chunksize'
2013-10-08 16:18:43 +02:00
Lukáš Lalinský
02ebd0bcbe
Change log for 1.9.1
2013-10-08 16:18:30 +02:00
Lukáš Lalinský
5693ab0403
Merge remote-tracking branch 'TsudaKageyu/fix-string'
2013-10-08 16:12:49 +02:00
Lukáš Lalinský
27000438f5
Merge remote-tracking branch 'TsudaKageyu/msvc_wchar_t'
2013-10-08 16:09:01 +02:00
Lukáš Lalinský
a6f759cc9a
These shouldn't be executable either
2013-10-08 16:06:58 +02:00
Lukáš Lalinský
a175b8356b
Reintroduce the old RefCounter from 1.8, which is needed by TagLib::Map<> and TagLib::List<> ( closes #296 )
2013-10-08 16:06:03 +02:00
Tsuda Kageyu
873df184fe
Workaround for when MSVC doesn't have wchar_t as a built-in type
2013-10-08 19:55:44 +09:00
Tsuda Kageyu
079e3e0b87
Fixed detecting RIFF files with invalid chunk sizes
2013-10-07 17:04:55 +09:00
Lukáš Lalinský
95776b5905
These files should not be marked as executable
2013-10-06 17:11:01 +02:00
Lukáš Lalinský
dcfb71bcb4
Update version number to 1.9
2013-10-05 10:53:15 +02:00
Lukáš Lalinský
f2c9ed4f36
Update NEWS
2013-10-05 10:09:09 +02:00
Lukáš Lalinský
2407933087
Merge remote-tracking branch 'TsudaKageyu/wavpack-samplerate'
2013-10-05 09:53:49 +02:00
Stephen F. Booth
2af43ec8bf
Merge pull request #290 from FestusHagen/m_WinInstallNotes
...
Update Windows INSTALL notes.
2013-10-01 19:51:11 -07:00
Festus Hagen
85d76a2428
Update Windows INSTALL notes.
2013-09-30 18:06:55 -04:00
Stephen F. Booth
5a4a05d9bc
Merge pull request #280 from TsudaKageyu/info-fieldlist
...
Added a missing fieldListmap() method to RIFF::Info::Tag
2013-09-28 18:07:26 -07:00
Stephen F. Booth
a2188e6cf9
Merge pull request #285 from TsudaKageyu/algorithm
...
Added missing #include <algorithm> for std::min() and std::max()
2013-09-20 04:59:27 -07:00
Tsuda Kageyu
e6f9a06894
Added missing #include <algorithm> for std::min() and std::max()
2013-09-20 08:26:37 +09:00
Tsuda Kageyu
e125bcb78b
Fixed a possible out-of-bound access when reading WavPack files
2013-09-19 04:09:28 +09:00
Tsuda Kageyu
23b418b4e9
Added a missing fieldListmap() method to RIFF::Info::Tag
2013-09-17 14:59:19 +09:00
Tsuda Kageyu
cf892f2cb8
Fixed a bug in creating String from ByteVector
2013-09-13 03:47:03 +09:00
Lukáš Lalinský
c12b6697f9
Merge remote-tracking branch 'TsudaKageyu/byteorder-detection'
2013-07-21 14:42:50 +02:00
Tsuda Kageyu
89fcab5669
Fixed an MSVC specific runtime error only in debug mode
2013-07-17 23:35:41 +09:00
Tsuda Kageyu
35ca010df6
Introduced the runtime byte order detection when config.h is missing
2013-07-17 15:02:02 +09:00
Tsuda Kageyu
0f58646bfb
Added a test for APE::Item
2013-07-14 11:35:10 +09:00
Tsuda Kageyu
4d126c49e9
Fixed a crash of APE::Item::toString() when the data type is binary
2013-07-14 02:47:48 +09:00
Lukáš Lalinský
3a636c752b
Merge remote-tracking branch 'TsudaKageyu/string-api-master'
2013-07-11 10:08:05 +02:00
Lukáš Lalinský
ff5ab030c5
Merge remote-tracking branch 'TsudaKageyu/fix-opus'
2013-07-11 10:06:35 +02:00
Lukáš Lalinský
ff3b1466e1
Merge remote-tracking branch 'TsudaKageyu/comment-update'
2013-07-11 10:05:29 +02:00
Lukáš Lalinský
89cb785f22
Merge remote-tracking branch 'TsudaKageyu/has-tags'
2013-07-11 10:03:28 +02:00
Tsuda Kageyu
30f62ba887
Updated the relevant comments
2013-07-04 22:14:42 +09:00
Tsuda Kageyu
1503909824
Added the methods to check which kind of tags the file actually has.
2013-07-04 18:11:33 +09:00
Tsuda Kageyu
75b685fa53
Updated the related comments
2013-06-24 01:29:33 +09:00
Tsuda Kageyu
62d55223b2
Added conversion from String to const wchar_t*
2013-06-24 01:13:25 +09:00
Tsuda Kageyu
418a6c79cb
Comment update: Added some supplementary explanations and fixed some spellings.
2013-06-23 02:08:10 +09:00
Tsuda Kageyu
ab417fd9e3
Changed the style to follow TagLib's one
2013-06-22 18:06:40 +09:00
Tsuda Kageyu
35cdcd3b95
Added a missing check if an Opus file is open
2013-06-22 16:12:57 +09:00
Tsuda Kageyu
a845f70c49
Added some test cases for FileRef about unsupported files
2013-06-21 15:29:00 +09:00
Lukáš Lalinský
7e866e11ad
Merge remote-tracking branch 'FestusHagen/sw_initorder'
2013-06-21 08:01:50 +02:00
Festus Hagen
6acbcfc68a
Fix file modes 2.
2013-06-20 18:50:14 -04:00
Festus Hagen
02c81aaac2
Fix file modes.
2013-06-20 18:37:06 -04:00
Festus Hagen
550510ff3f
Silence Initialization Order Warnings 2.
2013-06-20 16:40:05 -04:00
Lukáš Lalinský
5051010835
Move byteSwap to a (private) shared include file, rather than having the same code in tstring.cpp and tbytevector.cpp
2013-06-20 15:22:06 +02:00
Lukáš Lalinský
fdb8a6b065
Reintroduce HAVE_CONFIG_H so that TagLib can be built without CMake
2013-06-20 15:07:25 +02:00
Lukáš Lalinský
6d4299ea94
Merge remote-tracking branch 'TsudaKageyu/debug-msg3'
2013-06-20 13:40:26 +02:00
Tsuda Kageyu
b84b3afc9c
Making use of std::bitset::to_string()
2013-06-15 13:21:07 +09:00
Festus Hagen
451616f99a
Silence Initialization Order Warnings.
2013-06-11 17:20:46 -04:00
Tsuda Kageyu
496b58e0c9
Updated the comment for DebugListener class
2013-06-11 19:23:46 +09:00
Tsuda Kageyu
886236b978
Removed getDebugListener()
2013-06-10 16:29:33 +09:00
Tsuda Kageyu
6d2e0e8050
Moved a macro from taglib_config.h to config.h
2013-06-10 01:19:47 +09:00
Tsuda Kageyu
2f29ed003c
Added a CMake option that allows to show debug messages in release mode
2013-06-09 23:52:05 +09:00
Tsuda Kageyu
12953b3fdc
Removed TAGLIB_EXPORT from getDebugListener
2013-06-08 22:26:13 +09:00
Tsuda Kageyu
448648d61b
Simplified DebugListener class
2013-06-08 21:40:30 +09:00
Lukáš Lalinský
241465eaac
Merge branch 'revert-changes' of https://github.com/TsudaKageyu/taglib
2013-06-08 12:58:53 +02:00
Tsuda Kageyu
dce00b96b8
Revert "Fixed some MSVC specific warnings"
...
This reverts commit 93f304a91d .
2013-06-08 13:14:06 +09:00
Tsuda Kageyu
3b2d620671
Enabled users to define custom debug message listeners
2013-06-08 09:59:36 +09:00
Tsuda Kageyu
e18546560e
Enabled users to define custom debug message listeners
2013-06-08 03:05:50 +09:00
naiar
fc9abc7a33
fixed build failure
2013-06-07 20:00:13 +09:00
Tsuda Kageyu
98d010f460
Merge pull request #232 from TsudaKageyu/remove-shlwapi
...
Removed the dependency on shlwapi.dll in Win32
2013-06-05 21:59:11 -07:00
Tsuda Kageyu
36d7f9ba32
Removed the dependency on shlwapi.dll in Win32
2013-06-06 13:45:23 +09:00
Tsuda Kageyu
c4c5b06643
Merge pull request #231 from TsudaKageyu/containsat
...
Fixed behavior change of ByteVector::containsAt()
2013-06-01 12:03:34 -07:00
Tsuda Kageyu
767a6ec4a2
Added some tests for containsAt()
2013-06-02 04:00:34 +09:00
Tsuda Kageyu
860a605c8d
Fixed behavior change of ByteVector::containsAt()
2013-06-02 03:45:13 +09:00
Tsuda Kageyu
df5bf232eb
Merge pull request #230 from TsudaKageyu/gcc42-3
...
Fixed compilation error with GCC4.2
2013-06-01 10:49:07 -07:00
Tsuda Kageyu
90a4bae6cc
Fixed compilation error with GCC4.2
2013-06-02 02:37:15 +09:00
Tsuda Kageyu
3ae452ee2a
Merge pull request #229 from TsudaKageyu/gcc42-2
...
Fixed compilation error with GCC4.2
2013-06-01 10:11:52 -07:00
Tsuda Kageyu
bc2d3ea72e
Fixed compilation error with GCC4.2
2013-06-02 02:05:11 +09:00
Tsuda Kageyu
9ccc4878d0
Merge pull request #228 from TsudaKageyu/gcc42
...
Fixed compilation error with GCC4.2
2013-06-01 08:05:29 -07:00
Tsuda Kageyu
6365f36c75
Fixed compilation error with GCC4.2
2013-06-01 23:55:52 +09:00
Tsuda Kageyu
da3d9b1c55
Merge pull request #226 from TsudaKageyu/file-comments
...
Fixed comments for File constructors
2013-05-30 22:34:21 -07:00
Tsuda Kageyu
f77a84486e
Fixed comments for File constructors
2013-05-30 02:04:10 +09:00
Tsuda Kageyu
cf9f2a436b
Merge pull request #224 from TsudaKageyu/memoryleak
...
Fixed memory leak of ByteVector
2013-05-27 08:20:38 -07:00
Tsuda Kageyu
e73afa3325
Fixed memory leak of ByteVector
2013-05-28 00:02:09 +09:00
Tsuda Kageyu
dfee045d46
Merge pull request #222 from TsudaKageyu/vc-filename
...
Fixed some MSVC specific warnings
2013-05-26 06:03:49 -07:00
Tsuda Kageyu
93f304a91d
Fixed some MSVC specific warnings
2013-05-26 14:38:36 +09:00
Tsuda Kageyu
ddabffc7ef
Merge pull request #221 from TsudaKageyu/fix-shlwapi
...
Fixed shlwapi.h and shlwapi.lib detection for MSVC
2013-05-25 12:20:57 -07:00
Tsuda Kageyu
42d268c2c9
Fixed shlwapi.h and shlwapi.lib detection for MSVC
2013-05-26 04:17:18 +09:00
Tsuda Kageyu
e7c0f3322d
Merge pull request #220 from FestusHagen/cmake_shlwapi
...
Added FindShlwapi.cmake in lieu of pragma comment() in fileref.h.
2013-05-25 12:04:08 -07:00
Festus Hagen
b3f3eeeec7
Added FindShlwapi.cmake in lieu of pragma comment() in fileref.h.
2013-05-25 01:58:49 -04:00
Tsuda Kageyu
54fbe15611
Merge pull request #219 from joelverhagen/master
...
Windows build fails on master (due to RefCounter not being exported)
2013-05-23 18:44:15 -07:00
Joel Verhagen
d7523d7843
Added TAGLIB_EXPORT to RefCounter for Windows build
2013-05-23 13:42:51 -04:00
Tsuda Kageyu
ca801c5411
Merge pull request #215 from TsudaKageyu/smallfile
...
Fixed bugs on manipulating small files
2013-05-23 02:22:48 -07:00
Tsuda Kageyu
4667ba02e5
Fixed bugs on manipulating small files
2013-05-23 17:45:16 +09:00
Tsuda Kageyu
3151336050
Merge pull request #209 from TsudaKageyu/bytevector
...
Changed behavior of ByteVector::toNumber() when overrun
2013-05-20 13:50:59 -07:00
Tsuda Kageyu
848f8c316e
Changed behavior of ByteVector::toNumber() when overrun
2013-05-21 05:36:01 +09:00
Tsuda Kageyu
2303da48a2
Merge pull request #204 from TsudaKageyu/number
...
Changed String::number() to use a standard function
2013-05-18 22:59:02 -07:00
Tsuda Kageyu
bbec1c7f81
Changed String::number() to use a standard function
2013-05-19 14:39:45 +09:00
Tsuda Kageyu
79f3edebc0
Added myself to AUTHORS
2013-05-19 11:59:37 +09:00
Tsuda Kageyu
d49d0a6888
Merge pull request #203 from TsudaKageyu/fix-filestream
...
Fixed initialization of FileStream
2013-05-18 19:21:36 -07:00
Tsuda Kageyu
5c3f096fe4
Fixed initialization of FileStream
2013-05-19 11:09:43 +09:00
Tsuda Kageyu
7060d53cf3
Merge pull request #202 from TsudaKageyu/fix-filestream
...
Small refactoring of FileStream
2013-05-18 10:49:31 -07:00
Tsuda Kageyu
dcf11b9586
Small refactoring of FileStream
2013-05-19 02:33:17 +09:00
Tsuda Kageyu
229d69864d
Merge pull request #201 from TsudaKageyu/unicodefile
...
Small change in Win9x support
2013-05-18 07:41:07 -07:00
Tsuda Kageyu
36d9fc1973
Small change in Win9x support
2013-05-18 23:30:15 +09:00
Tsuda Kageyu
d06f480f82
Merge pull request #199 from TsudaKageyu/fix-zlib
...
Fixed the test for ID3V2's compressed frame
2013-05-16 04:38:24 -07:00
Tsuda Kageyu
f9efcfb8d6
Fixed the test for ID3V2's compressed frame
2013-05-16 20:29:58 +09:00
Lukáš Krejčí
cbd6f73431
Removed duplicated CHAP frame testing funtion.
2013-05-04 21:25:55 +02:00
Tsuda Kageyu
db06166330
Merge pull request #187 from TsudaKageyu/config
...
Removed config.h and moved macros into taglib_config.h
2013-05-03 08:03:51 -07:00
Tsuda Kageyu
5d8f781467
Fixed mismatched macro names
2013-05-03 21:05:55 +09:00
Tsuda Kageyu
03adafbfd9
Removed TAGLIB_HAVE_STD_WSTRING macro that affects the public ABI
2013-05-03 18:28:28 +09:00
Tsuda Kageyu
198530547d
Removed RefCounter implementation from a public header
2013-05-03 13:53:32 +09:00
Tsuda Kageyu
4b6745b59b
Merge pull request #188 from TsudaKageyu/string-comment
...
Fixed comments in tstring.h
2013-05-02 21:10:26 -07:00
Tsuda Kageyu
6f0bf734d5
Fixed comments in tstring.h
2013-05-03 13:03:38 +09:00
Tsuda Kageyu
23bd3784a1
Separated public and private config.h
2013-05-03 11:44:36 +09:00
Tsuda Kageyu
8f8ef3788f
Prefixed public variables
2013-05-02 23:26:06 +09:00
Tsuda Kageyu
b0938a3cf1
Removed config.h and moved macros into taglib_config.h
2013-05-02 20:41:59 +09:00
Tsuda Kageyu
a2688a1ff0
Merge pull request #180 from TsudaKageyu/master
...
Fixed possible memory leak
2013-04-30 09:39:23 -07:00
Tsuda Kageyu
d6fc2ef4aa
Fixed possible memory leak
2013-05-01 01:32:48 +09:00
Tsuda Kageyu
9f29804f60
Merge pull request #178 from rakuco/clear-mbstate_t-correctly
...
Correctly initialize std::mbstate_t.
2013-04-29 15:06:57 -07:00
Raphael Kubo da Costa
289b6abb43
Correctly initialize std::mbstate_t.
...
mbstate_t is an opaque type that is often a union or a struct, so setting it
directly to 0 is incorrect and causes build failures with some compilers
such as clang.
2013-04-29 23:56:07 +03:00
Tsuda Kageyu
55f1224d6e
Merge pull request #176 from TsudaKageyu/master
...
Add some error handling to tfilestream.cpp
2013-04-27 17:37:17 -07:00
Tsuda Kageyu
395743eb49
Add some error handling to tfilestream.cpp
2013-04-28 09:14:37 +09:00
Tsuda Kageyu
62827269b6
Merge pull request #175 from TsudaKageyu/master
...
Comment update
2013-04-27 11:10:37 -07:00
Tsuda Kageyu
d2273a7218
Comment update
2013-04-28 03:06:59 +09:00
Tsuda Kageyu
bd85cf8928
Merge pull request #174 from TsudaKageyu/alignment
...
Fixed detection of alignment-tolerant CPUs
2013-04-27 11:02:31 -07:00
Tsuda Kageyu
f3cbb883f2
Fixed detection of alignment-tolerant CPUs
2013-04-28 02:57:51 +09:00
Lukáš Krejčí
65006952f3
Changed copyright and e-mail in modified files.
2013-04-27 16:09:15 +02:00
Lukáš Krejčí
4815dbba68
Fixed errors in ChapterFrame constructor.
...
Fixed errors in ChapterFrame method renderFields.
Fixed errors in TableOfContentsFrame method parseFields.
Added ChapterFrame and TableOfContentsFrame headers and sources to CMakeLists.txt.
Added some basic testing of CHAP and CTOC frames parsing.
2013-04-27 15:42:23 +02:00
Lukáš Krejčí
bcad792e75
Fixed error in childElements function.
2013-04-26 23:16:06 +02:00
Tsuda Kageyu
a80222efa5
Merge pull request #171 from TsudaKageyu/string-test
...
Add some tests for String
2013-04-26 04:35:57 -07:00
Tsuda Kageyu
5e13e0c838
Add some tests for String
2013-04-26 19:43:10 +09:00
Tsuda Kageyu
58765ac40a
Merge pull request #170 from TsudaKageyu/master
...
Small bug fix in tstring.cpp
2013-04-26 01:52:15 -07:00
Tsuda Kageyu
6e35e56d7f
Small bug fix in tstring.cpp
2013-04-26 17:32:39 +09:00
Tsuda Kageyu
a9cdbb7e75
Merge pull request #166 from TsudaKageyu/cmake_test
...
Refactor out some stuff to CMake tests
2013-04-25 18:54:37 -07:00
Tsuda Kageyu
8c71428d4f
Add missing HAVE_WIN_ATOMIC block
2013-04-23 16:25:18 +09:00
Tsuda Kageyu
2c85b4d178
Fix mistaken preprocessor conditionals
2013-04-23 10:42:45 +09:00
Tsuda Kageyu
3293cee11e
Skip unnecessary CMake tests
2013-04-23 08:47:48 +09:00
Tsuda Kageyu
27990d0623
Merge pull request #169 from TsudaKageyu/win9x-unicode
...
Improve Unicode file name handling in Win9x
2013-04-22 10:10:14 -07:00
Tsuda Kageyu
986ee3c44a
Improve Unicode file name handling in Win9x
2013-04-23 01:59:02 +09:00
Tsuda Kageyu
dfb3962511
Merge pull request #168 from TsudaKageyu/fix-win9x
...
Fix a change breaks compatibility with Win9x
2013-04-22 08:28:34 -07:00
Tsuda Kageyu
3e89f7cb40
Fix a change breaks compatibility with Win9x
2013-04-23 00:15:54 +09:00
Tsuda Kageyu
8c233f4552
Merge pull request #167 from TsudaKageyu/filesize
...
Improve getting file size in Win32
2013-04-21 16:29:26 -07:00
Tsuda Kageyu
c2896fd629
Improve getting file size in Win32
2013-04-22 08:01:25 +09:00
Lukáš Krejčí
fcfd9f59fe
Finished parseFields, renderFields and asProperty methods of ChapterFrame and TableOfContentsFrame classes.
...
Methods setElementID of ChapterFrame and TableOfContentsFrame classes now automatically terminates new element ID with null.
2013-04-21 16:16:57 +02:00
Tsuda kageyu
49b07a2662
Refactor out some stuff to CMake tests
2013-04-21 22:24:12 +09:00
Tsuda Kageyu
529d78f54b
Merge pull request #165 from TsudaKageyu/sign-ext
...
Fix unexpected sign extension
2013-04-21 00:15:02 -07:00
Tsuda kageyu
dc89bdd3f0
Fix unexpected sign extension
2013-04-21 16:06:12 +09:00
Lukáš Krejčí
4be1279430
Added basic members of ChapterFrame and TableOfContentsFrame classes.
...
Fixed minor bugs in ChapterFrame and TableOfContentsFrame headers.
2013-04-20 16:49:57 +02:00
Lukáš Krejčí
08ae0e8c63
Created CPP and H files for CTOC and CHAP frames.
2013-04-20 15:52:52 +02:00
Tsuda Kageyu
81a9f0474d
Merge pull request #161 from TsudaKageyu/fix-syncdata
...
Fix reading corrupted ID3v2 syncdata
2013-04-19 17:43:16 -07:00
Tsuda kageyu
8a7d1dd796
Fix reading corrupted ID3v2 syncdata
2013-04-20 09:40:01 +09:00
Tsuda Kageyu
457b1abac8
Merge pull request #160 from TsudaKageyu/fix-cast-align
...
Fix -Wcast-align violation
2013-04-19 14:43:42 -07:00
Tsuda kageyu
e8498b9264
Fix -Wcast-align violation
2013-04-20 05:54:06 +09:00
Tsuda Kageyu
3eeff8b933
Merge pull request #158 from TsudaKageyu/fix-errmsg
...
Fix an error message in Win32
2013-04-18 14:30:37 -07:00
Tsuda kageyu
d959ab89f1
Fix an error message in Win32
2013-04-19 06:13:27 +09:00
Tsuda Kageyu
b081fb2833
Merge pull request #157 from TsudaKageyu/file-win32
...
Fix improper file handling in Win32
2013-04-18 06:38:48 -07:00
Tsuda kageyu
e0805b039c
Fix improper file handling in Win32
2013-04-18 22:16:59 +09:00
Tsuda Kageyu
c352b5e0c7
Merge pull request #155 from TsudaKageyu/gcc-warnings
...
Fix some GCC specific warnings
2013-04-18 04:09:30 -07:00
Tsuda kageyu
a71749a6b5
Fix some GCC specific warnings
2013-04-18 19:52:52 +09:00
Tsuda Kageyu
a188778eb8
Merge pull request #154 from TsudaKageyu/tonumber
...
ByteVector::toUInt() takes offset and length
2013-04-18 03:26:21 -07:00
Tsuda kageyu
439f27640a
ByteVector::toUInt() takes offset and length
2013-04-18 18:36:19 +09:00
Tsuda Kageyu
c9209cc99e
Merge pull request #150 from TsudaKageyu/detect-codecvt
...
Detect <codecvt> header automatically
2013-04-17 08:42:14 -07:00
Tsuda kageyu
1370a1cc83
Detect <codecvt> header automatically
2013-04-18 00:32:14 +09:00
Tsuda Kageyu
266e8f5ae4
Merge pull request #149 from TsudaKageyu/fileref-string
...
Fix improper string handling
2013-04-17 07:55:33 -07:00
Tsuda kageyu
ccaac6c336
Fix improper string handling
2013-04-17 23:47:09 +09:00
Tsuda Kageyu
88005640d5
Merge pull request #148 from TsudaKageyu/reset-smart-pointer
...
Revert changes concerning the smart pointer
2013-04-17 07:08:36 -07:00
Tsuda kageyu
1f4e06ea7c
Revert changes concerning the smart pointer
2013-04-17 22:54:56 +09:00
Tsuda Kageyu
b6c9fb2da1
Merge pull request #147 from TsudaKageyu/shared_ptr
...
Use shared_ptr if possible regardless of C++11 support
2013-04-17 06:03:28 -07:00
Tsuda kageyu
66f5f396ff
Use shared_ptr if possible regardless of C++11 support
2013-04-17 21:41:23 +09:00
Tsuda Kageyu
c9628aae49
Merge pull request #145 from TsudaKageyu/classname
...
Changed some class names
2013-04-16 20:51:33 -07:00
Tsuda kageyu
bb5d3f0600
Changed some class names
2013-04-17 12:45:14 +09:00
Tsuda Kageyu
1f819ce2c5
Merge pull request #144 from TsudaKageyu/restore-abi2
...
Restore ABI changed in pull request #60
2013-04-16 20:38:29 -07:00
Tsuda kageyu
593eda7d9d
Restore ABI changed in pull request #60
2013-04-17 12:28:00 +09:00
Tsuda Kageyu
14dab7c649
Merge pull request #143 from TsudaKageyu/restore-abi
...
Restore ABI breaking change
2013-04-16 19:41:55 -07:00
Tsuda kageyu
94a07fa39a
Restore ABI breaking change
2013-04-17 11:33:01 +09:00
Tsuda Kageyu
492a0f8199
Merge pull request #142 from TsudaKageyu/shared_ptr
...
Use std::shared_ptr<T> if C++11 is available
2013-04-16 19:27:42 -07:00
Tsuda kageyu
24736b919a
Use std::shared_ptr<T> if C++11 is available
2013-04-17 11:12:42 +09:00
Tsuda Kageyu
38220a57ce
Merge pull request #141 from TsudaKageyu/smart-ptr
...
Replace RefCounter with a smart pointer
2013-04-16 18:38:41 -07:00
Tsuda kageyu
b14dc1572d
Replace RefCounter with a smart pointer
2013-04-17 10:10:25 +09:00
Tsuda Kageyu
21964f3cbc
Merge pull request #139 from TsudaKageyu/refactor-string
...
Small refactoring of tstring.cpp
2013-04-16 06:47:28 -07:00
Tsuda kageyu
c13921b7c7
Small refactoring of tstring.cpp
2013-04-16 21:47:12 +09:00
Tsuda Kageyu
39fef2705c
Merge pull request #138 from TsudaKageyu/refector-bytevector
...
Small refactoring of tbytevector.cpp
2013-04-16 05:34:59 -07:00
Tsuda kageyu
8c427c7de9
Small refactoring of tbytevector.cpp
2013-04-16 19:57:04 +09:00
Tsuda Kageyu
0bb995abd0
Merge pull request #137 from TsudaKageyu/refactor-bytevector
...
Small refactoring of tbytevector.cpp
2013-04-15 22:55:22 -07:00
Tsuda kageyu
0195eef865
Small refactoring of tbytevector.cpp
2013-04-16 14:35:47 +09:00
Tsuda Kageyu
cc3dbd84ce
Merge pull request #134 from TsudaKageyu/fix-byteswap
...
Bug fix for #132
2013-04-15 14:02:17 -07:00
Tsuda kageyu
5e6285afab
Bug fix for #132
2013-04-16 05:53:36 +09:00
Tsuda Kageyu
df28a1335a
Merge pull request #133 from TsudaKageyu/fix-byteswap
...
Bug fix for #132
2013-04-15 12:22:37 -07:00
Tsuda kageyu
88a0871784
Bug fix for #132
2013-04-16 04:06:29 +09:00
Tsuda Kageyu
f0edca2f8c
Merge pull request #132 from TsudaKageyu/byteswap
...
Add cross-platform byte order conversions
2013-04-15 08:26:32 -07:00
Tsuda Kageyu
f5462e3e19
Add cross-platform byte order conversions
2013-04-16 00:12:37 +09:00
Lukáš Lalinský
53c5a97b4c
Add tests for newline handling in String ( #125 )
2013-04-15 10:47:43 +02:00
Lukáš Lalinský
a3352fd899
Use the first instance of a MP4 atom ( #126 )
...
When a file contains multiple MP4 atoms with the same name, use the first
one. This is consistent with iTunes and other popular software.
2013-04-15 10:13:47 +02:00
Jingmin Wei
4a85e1e1ca
Allow the second byte of MPEG header to contain 0xFF
...
0xFF in the second byte means MPEG Version 1, Layer I, no CRC protection.
http://mpgedit.org/mpgedit/mpeg_format/MP3Format.html
2013-04-15 09:46:08 +02:00
Lukáš Lalinský
94efe5c187
Merge pull request #116 from ufleisch/tagduplication
...
Parameter to disable duplication between ID3v1 and ID3v2 tags, #115 .
2013-04-14 23:47:59 -07:00
Tsuda Kageyu
bef59a0b9a
Merge pull request #131 from TsudaKageyu/vc-warning
...
Fix VC++ specific warnings
2013-04-14 13:29:29 -07:00
Tsuda Kageyu
86142343ee
Fix VC++ specific warnings
2013-04-15 05:23:39 +09:00
Tsuda Kageyu
5b2458ed66
Merge pull request #130 from TsudaKageyu/improve-string
...
Some improvements of String
2013-04-14 13:17:31 -07:00
Tsuda Kageyu
b52cd44c25
Some improvements of String
2013-04-15 05:03:54 +09:00
Tsuda Kageyu
40997e7fc9
Merge pull request #122 from TsudaKageyu/reduce-copy
...
Reduce unnecessary memory copies by ByteVector
2013-04-06 06:32:26 -07:00
Tsuda Kageyu
a4e68a0304
Reduce unnecessary memory copies by ByteVector
2013-04-05 22:07:58 +09:00
Urs Fleisch
703736fbcb
Parameter to disable duplication between ID3v1 and ID3v2 tags, #115 .
2013-03-23 13:56:31 +01:00
Tsuda Kageyu
fd45808555
Merge pull request #104 from TsudaKageyu/test-warnings
...
Fix warnings in test_flacpicture.cpp
2013-03-19 06:03:23 -07:00
Tsuda Kageyu
e9fec47411
Fix warnings in test_flacpicture.cpp
2013-03-19 21:54:56 +09:00
Stephen F. Booth
6029352c09
Merge pull request #96 from nightingale-media-player/master
...
Make textual lyric frames use UTF8
2013-01-20 07:56:30 -08:00
rsjtdrjgfuzkfg
077208d17a
Create UTF8-Lyrics per default.
2013-01-18 17:21:35 +01:00
Michael Helmling
08863dec0b
Found and fixed more missing property interface forwarders.
...
Probably due to a copy-and-paste error the implementation of
File::removeUnsupportedProperties() contained cases for several type
which do not reimplement this method; for others the implementation was
missing and is now included.
In addition, the formats Speex and Opus suffered from the same bug as
OggFLAC in the commit before, which is now fixed.
2013-01-03 23:20:15 +01:00
Michael Helmling
80af92a715
Add forwarders for the property interface to Ogg::FLAC::File.
...
Fixes an infinite method resolution recursion in File::properties() and
File::setProperties(). Thanks to Sebastian Rachuj for pointing out this bug.
2013-01-03 23:00:17 +01:00
Lukáš Lalinský
237e0ec23c
Merge pull request #93 from magcius/master
...
c: Add support for TAGLIB_STATIC to the C bindings
2013-01-01 03:00:27 -08:00
Jasper St. Pierre
d52e97dfcd
c: Add support for TAGLIB_STATIC to the C bindings
...
Otherwise, we'll fail with dllimport/dllexport linking errors on
Windows.
2013-01-01 04:28:00 -05:00
Michael Helmling
8329d6ac1a
Update documentation of the property map interface in TagLib::File.
2012-12-27 11:38:01 +01:00
Michael Helmling
f1d723077f
Consistently handle invalid and deprecated tags in setProperties()
...
This commit reverts the use of strip() in setProperties() because the
latter function should not change the file before save() is called.
Instead, the following policy is now consistently applied for file formats
with multiple tag types:
- the recommended tag type is created, if it does not exist
- deprecated tags are updated, if they exist, but not created
- illegal tag types are ignored by setProperties(), but used in properties()
if no others exist.
The only tag types considered "illegal" so far are APEv2 in MPEG and ID3 in FLAC.
2012-12-26 22:46:37 +01:00
Michael Helmling
a095c468b2
Revert "Add a test to show a problem with properties() and duplication."
...
This reverts commit 6e3391a846 . The "problem" demonstrated in there won't be fixed due to lack of significance.
2012-12-20 17:30:19 +01:00
Michael Helmling
b14e6a3570
Update for pull request #89 : Change how setProperties() updates tags.
...
For file types supporting more than one tag format, setProperties() now always creates the most modern one. Deprecated tags are stripped.
2012-12-20 17:28:50 +01:00
Michael Helmling
6e3391a846
Add a test to show a problem with properties() and duplication.
2012-12-10 21:22:11 +01:00
Michael Helmling
c0ca5c97d5
Fix issue #88 by changing the behavior of setProperties().
...
For file types that support multiple tag standards (for example, FLAC
files can have ID3v1, ID3v2, and Vorbis comments) setProperties is now
called for all existing tags instead of only for the most recommended
one.
This fixes the problem that under some circumstances it was not possible
to delete a value using setProperties() because upon save() the call to
Tag::duplicate recovered that value from the ID3v1 tag.
2012-12-10 20:56:16 +01:00
Michael Helmling
d5cf6d72e2
Merge remote-tracking branch 'official/master'
2012-12-10 19:55:29 +01:00
Michael Helmling
9eb0f2941f
Add a test case for the return value of setProperties()
2012-12-10 19:55:23 +01:00
naota
3fa295d99d
Include sys/stat.h to define S_* properly
...
Without including sys/stat.h, this file failed to build on FreeBSD with the following error.
In file included from /var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/test_trueaudio.cpp:5:0:
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h: In function 'std::string copyFile(const string&, const string&)':
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:62: error: 'S_IRUSR' was not declared in this scope
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:72: error: 'S_IWUSR' was not declared in this scope
In file included from /var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/test_mpeg.cpp:6:0:
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h: In function 'std::string copyFile(const string&, const string&)':
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:62: error: 'S_IRUSR' was not declared in this scope
/var/tmp/portage/media-libs/taglib-1.8/work/taglib-1.8/tests/utils.h:36:72: error: 'S_IWUSR' was not declared in this scope
gmake[2]: *** [tests/CMakeFiles/test_runner.dir/test_mpeg.cpp.o] Error 1
2012-11-28 07:54:08 +09:00
Lukáš Lalinský
812f63502b
Implement the PropertyMap interface for WMA
2012-11-23 09:32:00 +01:00
Lukáš Lalinský
353eb9f00f
Implement the PropertyMap interface for MP4
2012-11-22 10:40:22 +01:00
Lukáš Lalinský
1b813d9d6c
Document sort names
2012-11-21 17:26:17 +01:00
Lukáš Lalinský
c5dade5ee7
Use names that are consistent with Vorbis Comments
2012-11-21 17:24:32 +01:00
Lukáš Lalinský
e75d6f616c
Add support for reading MusicBrainz IDs from ID3v2 tags to PropertyMap
2012-11-21 17:21:30 +01:00
Lukáš Lalinský
15b601f053
Use PropertyMap in tagreader
2012-11-21 14:40:26 +01:00
Lukáš Lalinský
45317ef7f2
Revert "Fix opening of read-only files on Windows"
...
This reverts commit ade8dc1a21 .
2012-11-20 18:34:51 +01:00
Lukáš Lalinský
3da792152a
Merge pull request #85 from TsudaKageyu/fix-readonly
...
Fix reading read-only files in Win32
2012-11-20 09:23:16 -08:00
Tsuda Kageyu
3f6da779d2
Fix compilation in non-Win32
2012-11-20 22:46:03 +09:00
Tsuda Kageyu
57b8ae6e1c
Fix reading read-only files in Win32
2012-11-20 22:20:34 +09:00
Lukáš Lalinský
ade8dc1a21
Fix opening of read-only files on Windows
...
The CreateFile* functions return INVALID_HANDLE_VALUE on error, not NULL.
http://article.gmane.org/gmane.comp.kde.devel.taglib/2346
2012-11-20 14:15:16 +01:00
Lukáš Lalinský
c6f7ad3e83
Revert "Add a tool to inspect audio files, only MP4 is implemented for now"
...
This reverts commit 45b0279b41 .
2012-11-12 16:14:32 +01:00
Lukáš Lalinský
dbe6be778b
Build also examples
2012-11-11 16:44:01 +01:00
Lukáš Lalinský
45b0279b41
Add a tool to inspect audio files, only MP4 is implemented for now
2012-11-11 16:43:36 +01:00
Lukáš Lalinský
3a5aeb4573
Parse covr atoms with type 0 (fixes issue #84 )
2012-11-11 16:04:08 +01:00
Lukáš Lalinský
72745846f4
Update NEWS
2012-11-11 14:49:31 +01:00
Lukáš Lalinský
9e788bb8c2
Fix tests when compiled with clang on Linux
2012-11-11 14:26:10 +01:00
Lukáš Lalinský
56fbe7e14d
Make travis run tests also with clang
2012-11-10 20:51:17 +01:00
Lukáš Lalinský
44155f6771
Merge pull request #79 from gonemad/master
...
Check if file is open before reading tags
2012-11-04 01:27:43 -07:00
Lukáš Lalinský
341711c04b
Merge pull request #83 from jmarshallnz/more_itunes_hacks
...
A small fix, and some additional iTunes hacks (v2.2 frames in v2.3 tag)
2012-11-04 01:26:26 -07:00
Jonathan Marshall
be6187e893
adds new iTunes hack for v2.2 frames stored in a v2.3 tag (iTunes v8.1.1.10 for example)
2012-11-04 19:54:28 +13:00
Jonathan Marshall
c42bdeab43
fixes noop frame id size check in ID3v2::FrameFactory::createFrame
2012-11-04 19:52:10 +13:00
gonemad
7d7c58cb8e
Merge branch 'master' of https://github.com/taglib/taglib
2012-10-18 20:17:35 -04:00
Lukáš Lalinský
044da877e6
Make sure we build the tests
2012-10-13 13:38:35 +02:00
Lukáš Lalinský
2d7686b5fa
Actually run the tests
2012-10-13 13:36:33 +02:00
Lukáš Lalinský
074f6db6d8
Needs sudo
2012-10-13 13:34:44 +02:00
Lukáš Lalinský
7a884af0ef
Experimenting with Travis CI
2012-10-13 13:33:36 +02:00
Lukáš Lalinský
e568e1019d
Remove useless debug print
2012-10-13 09:11:20 +02:00
Lukáš Lalinský
ca543039a5
Include Opus in docs
2012-10-13 09:06:09 +02:00
Lukáš Lalinský
5e7b1da632
Add support for Ogg Opus
2012-10-13 08:55:23 +02:00
gonemad
6b9ef6421f
Fixed indents
2012-10-11 22:10:19 -04:00
gonemad
d15c8453ac
Added check if file is open before attempting to read tags
2012-10-11 21:20:03 -04:00
Lukáš Lalinský
1e660dda71
Partial changelog for 1.9
2012-10-10 17:09:03 +02:00
Lukáš Lalinský
2a77afc593
Merge remote-tracking branch 'nightingale/master'
2012-10-10 16:45:36 +02:00
Tsuda Kageyu
a9df3e48f7
Fix a bug in updating MP4 tags
2012-10-10 21:17:05 +09:00
rsjtdrjgfuzkfg
c8994ede3f
Restrict url frame generation to W??? Frames to prevent known non-text non-url frameIDs to be handled as url when containing only one String. No longer describe the default comment as "COMMENT".
2012-10-08 20:19:12 +02:00
Lukáš Lalinský
7e255733e0
Merge remote-tracking branch 'TsudaKageyu/id3v1-genrenumber'
2012-10-08 13:23:17 +02:00
Julien Ramseier
72f9a96cce
Fix missing CppUnit include directive
2012-10-07 15:41:40 +02:00
Stephen F. Booth
1308ff6479
Merge pull request #73 from ArnaudBienner/master
...
Corrupted FLAC files scan can result in heavy CPU consumption: fix
2012-10-07 05:29:02 -07:00
Arnaud Bienner
b7a15092d8
Faster FLAC::FilePrivate destructor
2012-10-07 03:07:53 +02:00
Arnaud Bienner
ad9ffc62e6
Consider FLAC file as being invalid if a 0 length block is found
2012-10-07 03:04:02 +02:00
Tsuda Kageyu
46e613dcca
Add reading/writing ID3v1 genre in number
2012-10-04 19:23:10 +09:00
Urs Fleisch
2d7414733e
Crash when saving xm files ( fixes #68 )
2012-09-30 15:42:16 +02:00
Lukáš Lalinský
9f597bab1b
Change some variables to follow the TagLib naming convention
2012-09-30 10:50:19 +02:00
Lukáš Lalinský
321b9b5a8b
Merge remote-tracking branch 'TsudaKageyu/filestream'
2012-09-30 10:43:58 +02:00
Lukáš Lalinský
60a3a4e455
Various uint fixes
...
We really need to get rid of TagLib::uint...
2012-09-30 10:22:10 +02:00
Lukáš Lalinský
57e5cc8c17
Merge remote-tracking branch 'TsudaKageyu/infotag-patch'
2012-09-30 10:15:56 +02:00
Lukáš Lalinský
5250673fa0
Merge pull request #70 from FestusHagen/taglib-config_cmd
...
Win32 taglib-config.cmd support.
2012-09-30 01:06:49 -07:00
Lukáš Lalinský
ab5e19a016
Merge pull request #69 from FestusHagen/SW_MinGW
...
Silence warnings with MinGW 4.6.3.
2012-09-29 06:54:36 -07:00
Festus Hagen
8790e9de01
Silence warnings with MinGW 4.6.3.
2012-09-29 09:01:44 -04:00
Festus Hagen
1086d4476d
Win32 taglib-config.cmd support.
2012-09-28 21:41:45 -04:00
Lukáš Lalinský
7b80418122
Fix the version number
2012-09-26 20:30:53 +02:00
Stephen F. Booth
02d034f53f
Merge pull request #65 from TsudaKageyu/tagsondisk
...
Add MPEG::FILE::Has*Tag functions
2012-09-08 05:14:30 -07:00
Tsuda Kageyu
e7126db97c
Add MPEG::FILE::Has*Tag functions
2012-09-08 14:13:20 +09:00
Tsuda Kageyu
4582ea3b27
Fixed CMakeLists.txt
2012-09-08 01:17:15 +09:00
Tsuda Kageyu
43e100fd37
FileStream improvement in Win32
2012-09-07 23:48:06 +09:00
Tsuda Kageyu
071a1477b5
Fixed an API change
2012-09-07 08:16:30 +09:00
Tsuda Kageyu
61c8013f2c
Added missing comments
2012-09-07 08:16:28 +09:00
Tsuda Kageyu
9c8c215c30
Support INFO tags of RIFF wave files.
2012-09-07 08:16:26 +09:00
Lukáš Lalinský
aa34afda79
Merge remote-tracking branch 'TsudaKageyu/substr-bug'
2012-09-06 20:03:15 +02:00
Lukáš Lalinský
942ec58de5
Add tests for String::substr
2012-09-06 20:03:08 +02:00
Lukáš Lalinský
082a36147b
Add change log, update SOVERSION
2012-09-06 19:57:10 +02:00
Lukáš Lalinský
f11b206fe8
Do not delete the IOStream object in TagLib::File
2012-09-06 19:43:52 +02:00
Lukáš Lalinský
e37f6ed752
Update CMakeLists.txt
2012-09-06 19:30:45 +02:00
Lukáš Lalinský
d2f20e8d2a
Merge branch 'master' of https://github.com/moeeka/taglib
2012-09-06 19:24:22 +02:00
Rupert Daniel
f194a55c0f
Updated OWNE implementaion with minor changes after pull review
2012-09-06 12:11:20 +01:00
Rupert Daniel
719187794e
Implementation of the ID3v2.4 OWNE frame.
2012-09-05 16:37:46 +01:00
Tsuda Kageyu
74b94613a0
Bug fix in String::substr()
2012-09-05 19:46:52 +09:00
Lukáš Lalinský
33d0be110b
Fix ambiguous reference to uint in tests
2012-09-03 19:55:55 +02:00
Tsuda Kageyu
df12b4ffc6
Refectored the FileStream constructor.
2012-09-03 01:45:28 +09:00
Tsuda Kageyu
d16c24ae21
Merge branch 'master' of https://github.com/taglib/taglib into security-warnings
2012-09-02 23:40:11 +09:00
Lukáš Lalinský
1c35918834
Merge remote-tracking branch 'TsudaKageyu/warnings'
2012-09-02 15:25:41 +02:00
Tsuda Kageyu
d163f36d35
Fix Visual C++ specific warnings about security
2012-08-23 21:57:12 +09:00
Tsuda Kageyu
590cd4c9f6
Fix warnings with VS2010
2012-08-23 20:54:18 +09:00
Tsuda Kageyu
6c0227ee13
Fix compilation errors with Visual Studio 2010
2012-08-23 19:58:21 +09:00
Lukáš Lalinský
9bb57fe0a7
Merge remote-tracking branch 'TsudaKageyu/id3v2-comment-update'
2012-08-23 11:00:32 +02:00
tsuda.kageyu@gmail.com
3fecdbf428
Comment update for ID3v2::Tag::setLatin1StringHandler()
2012-08-23 17:57:00 +09:00
Lukáš Lalinský
356c7a5d6e
Merge remote-tracking branch 'TsudaKageyu/cross-border-delete'
2012-08-23 10:51:47 +02:00
tsuda.kageyu@gmail.com
4b4f70253b
Comment update for ID3v1::Tag::setStringHandler()
2012-08-23 17:45:25 +09:00
Lukáš Lalinský
8b61a06fda
Merge remote-tracking branch 'TsudaKageyu/id3v2-brokenlatin1-patch'
2012-08-23 10:22:43 +02:00
Lukáš Lalinský
6801ac2515
Merge remote-tracking branch 'poiru/master'
2012-08-23 10:19:08 +02:00
Lukáš Lalinský
29d17bb8e9
Merge remote-tracking branch 'supermihi/master'
2012-08-23 10:17:05 +02:00
tsuda.kageyu@gmail.com
fe8053c7d5
Support broken Latin-1 encodings in ID3V2
2012-08-23 12:19:51 +09:00
tsuda.kageyu@gmail.com
eb63ee8ec6
Remove possible cross binary boundary delete
2012-08-23 11:09:22 +09:00
Lukáš Lalinský
e86e5f906b
ID3 frame IDs with 0 should be recognized as valid
...
http://article.gmane.org/gmane.comp.kde.devel.taglib/2275
2012-08-17 07:50:48 +02:00
Lukáš Lalinský
60e82e6694
Ignore additional files
2012-08-17 07:34:44 +02:00
Birunthan Mohanathas
fc6e02da35
Update header comments to reflect c4163a2
2012-08-02 17:25:20 +03:00
Michael Helmling
4140c5f2eb
Check PropertyMap keys format-specifically instead of globally.
...
Instead of statically forbidding certain keys in PropertyMap, now the
setProperties() implementations of the different formats check if the
keys are valid for that particular specification and include them in
the returned PropertyMap otherwise.
This should remove an unneccessary complification for programmers since
now there's only one step, namely calling setProperties(), where
problems might occur.
Also the previous implementation leads to problems with invalid keys:
because taglib doesn't use exceptions, something like
map.insert("FORBIDDEN KEY", "some value");
would lead to the value being inserted under String::null, which
smells like the source of strange bugs.
2012-07-30 20:52:30 +02:00
Michael Helmling
fc3fc10f60
add id3v2 frame delete test
2012-07-23 20:53:25 +02:00
BSDKaffee
3bc123aed6
- Disambiguate uint and ushort references
2012-07-15 01:57:53 -04:00
Lukáš Lalinský
3b392f2402
Changelog for 1.8 beta
2012-07-14 21:53:09 +02:00
Lukáš Lalinský
8ff0feb28e
Cast to long
2012-07-14 21:21:03 +02:00
Lukáš Lalinský
61ed295af8
Merge remote-tracking branch 'poiru/master'
2012-07-14 21:09:54 +02:00
Lukáš Lalinský
09af2a7b57
Merge remote-tracking branch 'robinst/mpeg-file-id3vxtag-docs-inexistent-tags'
2012-07-14 21:08:59 +02:00
Lukáš Lalinský
050ff3835d
Revert "Install examples if built."
...
This reverts commit 52e96e48c5 .
2012-07-14 21:06:53 +02:00
Lukáš Lalinský
674ae0fa6d
Merge remote-tracking branch 'kensington/master'
2012-07-14 21:06:08 +02:00
Lukáš Lalinský
411d318f34
Merge remote-tracking branch 'robinst/dont-copy-from-id3v1-when-only-saving-id3v2'
2012-07-14 21:03:16 +02:00
Lukáš Lalinský
fbb1c7e554
Merge branch 'mpc_sv8'
2012-07-11 14:15:37 +02:00
Lukáš Lalinský
fd818857e0
More Musepack tests
2012-07-11 14:15:12 +02:00
Lukáš Lalinský
930168f990
Refactoring of the Musepack SV8 properties code
2012-07-11 14:13:41 +02:00
Alex Novichkov
291d925fc1
MPC v8 audio properties
2012-07-11 13:08:10 +02:00
Scott Wheeler
7c4c455a40
Use '0' here instead of 'NULL'
...
0 is used throughout the rest of the TagLib source, and generally
preferred in C++:
http://www2.research.att.com/~bs/bs_faq2.html#null
2012-07-03 12:26:20 +02:00
Stephen F. Booth
f429d6f406
Merge pull request #41 from EliaCereda/master
...
Properly initialize frame
2012-06-30 07:33:25 -07:00
Elia Cereda
c68fe9ad7b
Fixed error "Branch condition evaluates to a garbage value" (from Xcode 4.3.3 Static Analyzer, mpeg/id3v2/id3v2tag.cpp:377)
...
This error occurs when the frame variable is left uninitialized because its id doesn't match any of the ids in the if and else-id cases. Initializing it on declaration fixes this issue.
2012-06-30 16:25:33 +02:00
Stephen F. Booth
81aac3a590
Merge pull request #39 from robinst/install-build-tests-option
...
Mention -DBUILD_TESTS=on in "Unit Tests" of INSTALL
2012-06-11 04:57:04 -07:00
Robin Stocker
7279b4fb7b
Don't duplicate from ID3v1 to ID3v2 when saving only ID3v2
...
When saving only v2 with stripOthers (which means stripping v1), the
data from v1 would still be duplicated to v2. Likewise for the other way
around.
This is not the expected outcome when e.g. a frame was removed in v2,
because it would be added again on save from the v1 data. The test shows
that.
This changes save to only duplicate the data when the other tag type
will not be stripped.
2012-06-10 18:53:25 +02:00
Robin Stocker
b0ac79c60e
Mention -DBUILD_TESTS=on in "Unit Tests" of INSTALL
2012-06-10 18:26:06 +02:00
Robin Stocker
382aec46f7
Fix docs of MPEG::File::ID3v(1|2)Tag for inexistent tag
...
Since 37e2d629 , the ID3v1 and ID3v2 tags are always created at the end
of MPEG::File::read. So contrary to what the documentation said, a null
pointer is never returned.
To check if a tag contains data, refer to isEmpty() in the
documentation.
2012-06-10 15:27:54 +02:00
Michael Palimaka
b5ad68d64b
Add custom 'check' target that depends on the test_runner target for backwards compatibility.
2012-05-17 03:42:36 +10:00
Michael Palimaka
52e96e48c5
Install examples if built.
2012-05-16 04:37:25 +10:00
Michael Palimaka
5bcfecb6cc
Use ctest instead of custom target.
2012-05-16 04:00:22 +10:00
Lukáš Lalinský
2c2a486313
Merge branch 'stable'
...
Conflicts:
CMakeLists.txt
NEWS
2012-04-20 18:30:07 +02:00
Birunthan Mohanathas
06597123b8
Remove trailing whitespace
2012-04-19 13:09:45 +03:00
Birunthan Mohanathas
e5ede410bc
Tabs to spaces
2012-04-19 13:04:42 +03:00
Vinnie Falco
dafb3af742
Remove 'using namespace std' in tmap.h
2012-04-17 22:05:09 -07:00
Lukáš Lalinský
089643f115
Merge remote-tracking branch 'vinniefalco/rename_enums'
2012-04-17 08:49:02 +02:00
Vinnie Falco
26f458b87f
Resolve scope resolution for APE::Footer definitions in apefooter.cpp
2012-04-15 07:58:50 -07:00
Vinnie Falco
c22791318c
Resolve ambiguous File symbol in apetag.cpp
2012-04-15 07:57:02 -07:00
Vinnie Falco
5081e3cf4f
Rename anonymous enumeration symbols to be unique trueaudiofile.cpp
2012-04-15 02:41:27 -07:00
Vinnie Falco
1bde4cea09
Rename anonymous enumeration symbols to be unique in wavpackfile.cpp
2012-04-15 02:40:46 -07:00
Vinnie Falco
0907e86a94
Rename anonymous enumeration symbols to be unique in apefile.cpp
2012-04-15 02:40:23 -07:00
Vinnie Falco
742a3a1dbb
Rename anonymous enumeration symbols to be unique in mpcfile.cpp
2012-04-15 02:39:19 -07:00
Vinnie Falco
04a4a6b8d4
Rename anonymous enumeration symbols to be unique in flacfile.cpp
2012-04-15 02:38:15 -07:00
Jeff Mitchell
b216b448c5
Fix compilation
2012-04-12 18:41:40 -04:00
Stephen F. Booth
4f8a6fdfaf
Verify that an APE text item isn't empty before use
2012-04-12 10:53:32 -04:00
Stephen F. Booth
32a4ac6599
Preserve source code backward compatibility
2012-04-10 18:06:58 -04:00
Stephen F. Booth
ca26a9ad3e
Added support for APE tag binary items
2012-04-10 07:24:12 -04:00
Stephen F. Booth
bd03e352cc
Allow tag items to be replaced
2012-04-07 08:54:22 -04:00
Stephen F. Booth
69ac59f5f0
Added sampleFrames() to audio properties
2012-04-06 18:30:13 -04:00
Stephen F. Booth
2297a6d531
Added missing tmap.h
2012-04-06 18:29:56 -04:00
Lukáš Lalinský
2a4850f211
Merge branch 'stable'
...
Conflicts:
CMakeLists.txt
2012-03-18 09:22:53 +01:00
Lukáš Lalinský
3c7b05a900
Merge branch 'stable'
...
Conflicts:
NEWS
2012-03-17 10:59:34 +01:00
Lukáš Lalinský
8e67b40bdc
Fix compilation errors
2012-03-17 10:45:52 +01:00
Lukáš Lalinský
76222cb1eb
Merge branch 'master' of https://github.com/supermihi/taglib
2012-03-17 10:41:02 +01:00
Birunthan Mohnathas
138dfca682
Additional change to previous fix.
2012-03-12 22:13:58 +02:00
Birunthan Mohnathas
c4163a26e8
Fixed memory leak of FrameFactory singleton.
2012-03-12 18:56:08 +02:00
Birunthan Mohnathas
4496efe33b
Fixed (huge) memory leak with ASF.
2012-03-12 18:44:08 +02:00
Lukáš Lalinský
3a760b060c
Merge branch 'stable'
...
Conflicts:
taglib/riff/aiff/aiffproperties.cpp
taglib/trueaudio/trueaudioproperties.cpp
tests/test_wav.cpp
2012-03-10 09:16:37 +01:00
Lukáš Lalinský
dcdf4fd954
Avoid uint overflow in case the length + index is over UINT_MAX
2012-03-10 08:46:20 +01:00
Lukáš Lalinský
ab8a0ee893
Don't store the output of ByteVector::toUInt() in int, use uint instead
2012-03-04 12:01:21 +01:00
Lukáš Lalinský
77d61c6eca
Make sure to not try dividing by zero
2012-03-04 11:51:05 +01:00
Michael Helmling
f5a2518273
Fixed handling of UnknownFrames in ID3v2.
...
- If an unknown frame with id "XXXX" occurs, an entry
"UNKNOWN/XXXX" is added to unsupportedData().
The removeUnsupportedProperties() method in turn
removes all unknown frames with id "XXXX" if it
encounters a string "UNKNOWN/XXXX" in the given list.
- Implemented findByDescription() to UnsynchronizedLyricsFrame
in order to support removal of lyrics frames with unsupported
keys.
- Adapted id3v2 test case to new QuodLibet policy.
2012-02-26 19:21:57 +01:00
Michael Helmling
6e6d823992
Removed quodlibet special case handling
2012-02-26 18:38:03 +01:00
Michael Helmling
f859fcf82a
Add support for Unknown TXXX frames.
2012-02-26 18:07:02 +01:00
Michael Helmling
37c87e0317
Fixed identation
2012-02-26 10:56:18 +01:00
Michael Helmling
0a3b998ca5
Fix USLT frame creation in Frame::createTextualFrame()
2012-02-26 10:43:08 +01:00
Michael Helmling
fa0656e3c6
remove Tests/Examples build from CMakeLists
2012-02-26 10:37:59 +01:00
Michael Helmling
b05c3161c7
Added ID3v2 PropertyMap interface documentation.
2012-02-25 19:11:31 +01:00
Michael Helmling
79670beca1
some cosmetic changes
2012-02-25 18:59:53 +01:00
Michael Helmling
9fd22023cd
Merge remote-tracking branch 'official/master'
2012-02-25 18:51:30 +01:00
Michael Helmling
b8d5246f88
Moved APE test to correct place; added MOD tag test.
2012-02-25 18:46:19 +01:00
Michael Helmling
05b5e06928
added APE tag PropertyMap test
2012-02-25 18:32:00 +01:00
Michael Helmling
d28cc83fb4
Added another test for ID3v2 PropertyMap interface; fixed various bugs
2012-02-25 18:22:17 +01:00
Michael Helmling
495a028da3
removed debug messages
2012-02-19 15:15:25 +01:00
Michael Helmling
23d303a896
fixed bugs preventing tests from running
2012-02-19 15:13:31 +01:00
Michael Helmling
6c054af3ed
Added some functions, started to fix bugs.
2012-02-19 12:15:28 +01:00
Michael Helmling
70c3264279
fixed tests
2012-02-15 22:09:28 +01:00
Michael Helmling
cfa5ac6569
Fixed id3v2 test
2012-02-15 21:56:02 +01:00
Michael Helmling
de51307de7
Added lots of missing includes
2012-02-15 21:54:19 +01:00
Michael Helmling
140f4a57e2
fixed lots of bugs found by 'make'
2012-02-14 22:11:30 +01:00
Michael Helmling
8a8e9b702c
Ported xm.
2012-02-14 21:35:50 +01:00
Michael Helmling
d6215365a1
Ported wavpack.
2012-02-14 21:34:43 +01:00
Michael Helmling
2185d52f56
Ported trueaudio.
2012-02-14 21:32:36 +01:00
Michael Helmling
48aaaf8dc4
Ported s3m; removed old id3v2dicttools.
2012-02-14 21:29:30 +01:00
Michael Helmling
d2c43d7174
ID3 interface complete; vorbis done; wav done
2012-02-14 21:27:14 +01:00
Lukáš Lalinský
cdfb447042
Add explicitly declared default constructor to StringHandler
2012-02-04 21:22:52 +01:00
Lukáš Lalinský
2d00b690de
Merge branch 'master' of https://github.com/poiru/taglib
2012-02-04 20:38:14 +01:00
Stephen F. Booth
51675f3399
Added sampleFrames to FLACProperties
2012-02-04 11:34:40 -05:00
Stephen F. Booth
fa662a23db
Check if the header is TTA1 before parsing
2012-02-04 08:39:45 -05:00
Stephen F. Booth
dc628204c0
Added sampleFrames() for TTA files
2012-02-04 08:30:34 -05:00
Birunthan Mohanathas
9564956a7f
Removed space.
2012-02-02 18:12:37 +02:00
Birunthan Mohnathas
1f2248d24b
Additional change to previous fix.
2012-02-02 17:50:58 +02:00
Birunthan Mohnathas
06424598bb
Fixed memory leak.
2012-02-02 15:03:41 +02:00
Stephen F. Booth
7b3f279294
Correctly handle non-integral bit depths
2012-01-30 22:31:15 -05:00
Michael Helmling
a8632f710f
More progress in ID3 ... setProperties() will get messy :(
2012-01-22 22:06:24 +01:00
Michael Helmling
0c8e5bbec8
Implemented asProperties() in all relevant textual frames.
2012-01-22 17:08:02 +01:00
Michael Helmling
a5e45f196b
Started to work on ID3v2.
2012-01-21 23:05:59 +01:00
Michael Helmling
e4d955d6ef
Migration to new PropertyMap ... done ape to mod.
2012-01-21 14:52:24 +01:00
Michael Helmling
18ae797df4
Add unsupportedData() to PropertyMap, simplified [] behavior.
2012-01-17 18:09:30 +01:00
Michael Helmling
d11189b975
Basic implementation of a PropertyMap.
...
Implemented key/valuelist property map with
case-insensitive ASCII keys and StringList values.
Todo:
- subclass StringList to add flags indicating whether a value could
be written to the specific file format
- add member attribute indicating list of frames that could not be
parsed into the PropertyMap representation.
2012-01-16 22:37:30 +01:00
Michael Helmling
67d896e6a7
Implemented the most easy comments on the pull request.
2012-01-14 22:02:17 +01:00
Michael Helmling
ea41cd8903
Merge remote-tracking branch 'official/master'
2012-01-14 20:57:15 +01:00
Lukáš Lalinský
d904281c6b
Make it possible to generate an XML report
2012-01-14 10:16:54 +01:00
Lukáš Lalinský
40bf52e70f
Reverse the version check, similarly to what mp4v2 does
2012-01-10 17:18:20 +01:00
Lukáš Lalinský
b981b6dde7
Check also for the deprecated GIF type
2012-01-08 15:54:15 +01:00
Lukáš Lalinský
c237998983
Support non-UTF8 free-form atoms
2012-01-08 13:17:42 +01:00
Urs Fleisch
5ff810e98d
Support for ID3v2.2 frames used by iTunes (TCP, TS2, TSA, TSC, TSP, TST)
...
https://bugs.kde.org/show_bug.cgi?id=290330
2012-01-05 16:33:29 +01:00
Michael Helmling
7875d02a8f
Merge remote-tracking branch 'official/master'
2012-01-04 19:49:50 +01:00
Scott Wheeler
baafb3e290
Funny that there managed to be no operator!= for String for so long.
2012-01-01 16:01:18 +01:00
Michael Helmling
c4cef55158
Added tests and information about ignored id3 frames.
...
The ID3v2::toDict() function now has an optional
StringList* argument which will contain information
about frames that could not be converted to the dict
interface.
There are some dict tests for APE and FLAC now, and the
ID3v2 test was enlarged.
2012-01-01 14:42:48 +01:00
Michael Helmling
0eaf3a3fbd
Implemented dict interface for more formats.
...
Now supported: MOD files (IT, MOD, S3M, XM), RIFF files
(AIFF, WAV), TrueAudio, WavPack.
2011-11-02 21:02:35 +01:00
Michael Helmling
292a377d1e
Merge remote-tracking branch 'official/master'
2011-10-30 18:28:52 +01:00
Lukáš Lalinský
6ea8599313
Detect RIFF files with invalid chunk sizes
...
The bug report has a WAVE file with zero-sized 'data' chunk, which causes
TagLib to iterate over the file, 8 bytes in each iteration. The new code
adds a check for the chunk name, which forces it to mark the file as
invalid if the chunk name doesn't contain ASCII characters.
https://bugs.kde.org/show_bug.cgi?id=283412
2011-10-08 18:41:15 +02:00
Michael Helmling
772bc9f7c4
Further cleanup and simplification in id3v2dicttools
2011-09-12 21:52:11 +02:00
Michael Helmling
0c2ca20ec2
Restructured and simplified ID3v2Tag::fromDict().
2011-09-11 22:07:49 +02:00
Michael Helmling
2d31075047
Splitted ID3v2Tag::toDict() into several functions.
...
This should simplify future transition to virtual functions.
2011-09-11 18:22:15 +02:00
Graham Perks
837c9ef288
Add cmake option for visibility=hidden
2011-09-09 10:17:54 -05:00
Michael Helmling
0356249368
Merge remote-tracking branch 'official/master'
2011-09-01 16:33:39 +02:00
Michael Helmling
5647b2e293
Made im/export functions nonvirtual. Added similar functions to File and
...
its subclasses. TagLib::File contains a bunch of dynamic_casts to call
the correct specializations.
2011-08-28 22:58:40 +02:00
Lukáš Lalinský
686bcf55a9
Add support for iPhone ringtones
2011-08-28 11:02:34 +02:00
Michael Helmling
fa8159a9d0
Added toDict and fromDict methods for APE tags.
2011-08-27 22:30:20 +02:00
Michael Helmling
58db919e43
More support for the unified dictionary interface.
...
Addded fromDict() function to ID3v2Tag. Added fromDict() and
toDict() functions to the TagUnion class (uses the first non-empty tag).
Added fromDict() and toDict() functions for the generic Tag class, only
handling common tags without duplicates. Addded preliminary mp3 test
case. Python3 bindings now available on my github site.
2011-08-27 01:18:21 +02:00
Michael Helmling
b262180857
Some preliminary work for unified dictionary tag interface support.
...
- toDict() and fromDict() for XiphComments
- toDict() for ID3v2 Tags
2011-08-26 21:48:40 +02:00
Tim De Baets
bec3875b94
Added removePicture() to FLAC::File
2011-08-16 01:57:01 +02:00
Urs Fleisch
ce53d13af1
Add suport for more MP4 metadata atoms
...
https://bugs.kde.org/show_bug.cgi?id=275784
2011-08-13 17:07:41 +02:00
Mathias Panzenböck
4868bb5690
ByteVector::replace: test shrinking
2011-08-06 19:43:17 +02:00
Jonathan Liu
7cc36db760
Use the default frame factory when it's necessary to parse ID3v2 tags in APE files
...
https://bugs.kde.org/show_bug.cgi?id=278773
2011-08-06 11:05:20 +02:00
Lukáš Lalinský
028f831417
Basic tests for ByteVector::replace()
2011-08-05 18:47:53 +02:00
Lukáš Lalinský
303af305db
Merge remote branch 'panzi/master'
2011-08-05 18:35:24 +02:00
Johannes Pfau
22b57f4463
Add taglib_free function to C binding
2011-08-05 13:17:42 +02:00
Mathias Panzenböck
11c993e9f0
use DATA() macro
2011-08-01 15:33:27 +02:00
Mathias Panzenböck
3b14dc3e94
ByteVector::replace: forgot detach() and opt. when pattern not found
2011-08-01 15:14:58 +02:00
Mathias Panzenböck
ad7645f8e9
ByteVector::replace performance improvements
2011-08-01 04:13:55 +02:00
Lukáš Lalinský
fb2decb7de
Reformatting
2011-07-28 19:16:32 +02:00
Lukáš Lalinský
3a837e7fc7
Reformatting
2011-07-28 19:06:35 +02:00
Lukáš Lalinský
0730076a0f
Merge remote-tracking branch 'gperks/master'
...
Conflicts:
taglib/asf/asfpicture.cpp
taglib/it/itproperties.h
2011-07-28 19:03:46 +02:00
Lukáš Lalinský
364a840d83
Merge remote-tracking branch 'setosha/ASFPicture_warning_fix'
2011-07-28 18:53:57 +02:00
Scott Wheeler
e9cd383139
Merge pull request #14 from sbooth/master
...
Some non-PCM wave files can cause SIG_ARITHMETIC
2011-07-28 05:45:11 -07:00
Stephen F. Booth
a41b32bbb2
Don't crash when wav files have a 0 for bit per channel (sampleWidth)
...
I've seen this in a wav that has an audio format of MP3 (0x55)
2011-07-28 08:36:14 -04:00
Scott Wheeler
98d6b97798
Fix warning
2011-07-27 23:22:23 +02:00
Scott Wheeler
019fe4843f
ByteVector works on chars, not unsigned chars, so there needs to be a cast before the comparison
2011-07-27 23:14:54 +02:00
Scott Wheeler
bb25953767
These methods can't be protected since they're called from IT::File
...
In general this code could use a fair bit of tidying up both stylistically and semantically.
2011-07-27 23:07:38 +02:00
Scott Wheeler
4795831b4a
Fix spelling / formatting in comments.
2011-07-27 23:06:06 +02:00
Graham Perks
19484c059d
Document ENABLE_STATIC_RUNTIME
2011-07-27 14:35:24 -05:00
Graham Perks
10ea76ff11
Add build option for Visual Studio to link with the static runtime (/MT vs /MD), pass -DENABLE_STATIC_RUNTIME=ON to cmake
2011-07-27 14:25:26 -05:00
Graham Perks
5f84bbf61a
Correction to OS X build; include basic Windows build instructions
2011-07-27 10:54:33 -05:00
Graham Perks
8b647e5fa7
Fix for VS2010 which had been throwing out "cannot access protected member declared in class 'TagLib::Mod::Properties'" errors.
2011-07-26 21:45:32 -05:00
Graham Perks
0341079b92
Misc typo corrections
2011-07-26 21:45:28 -05:00
Graham Perks
1a53bfd71a
Example cmake for OS X to build a static library
2011-07-26 11:12:27 -05:00
Graham Perks
6aa41d8180
Updated OS X build instructions
2011-07-25 17:56:42 -05:00
Scott Wheeler
101a624c46
Merge branch 'master' of github.com:taglib/taglib
2011-07-21 00:06:50 +02:00
Lukáš Lalinský
3b4e4357e6
Only include config.h if HAVE_CONFIG_H is defined
2011-07-20 22:06:28 +02:00
Scott Wheeler
3baf0a413d
Missing const
2011-07-18 21:27:59 +02:00
Anton Sergunov
68c6a7da7a
ASFPicture fix warning
...
class/struct thing
Signed-off-by: Anton Sergunov <setosha@gmail.com >
2011-07-01 16:12:04 +07:00
Mathias Panzenböck
2fd10b5fd5
corrected comments
2011-06-28 02:55:03 +02:00
Mathias Panzenböck
a50886c3c7
Merge branch 'master' of https://github.com/taglib/taglib
2011-06-28 01:37:48 +02:00
Mathias Panzenböck
2119494cd1
added uninstall target
2011-06-26 21:58:51 +02:00
Scott Wheeler
843070ba18
Tabs be gone
2011-06-26 21:37:01 +02:00
Mathias Panzenböck
57bf96d169
Merge branch 'master' of https://github.com/taglib/taglib
2011-06-26 20:58:32 +02:00
Lukáš Lalinský
937d69f91d
Fix indentation
2011-06-25 12:17:31 +02:00
Mathias Panzenböck
f3447ae38d
style fixes for enum value names
2011-06-25 01:54:22 +02:00
Mathias Panzenböck
89861cf77a
style fixes: { on same line with if/else/for
2011-06-25 01:10:19 +02:00
Mathias Panzenböck
a04d7d0bbc
Merge branch 'master' of https://github.com/taglib/taglib
...
Conflicts:
taglib/CMakeLists.txt
tests/CMakeLists.txt
2011-06-24 23:59:11 +02:00
Stephen F. Booth
39e8cbbefb
Added sampleFrames() to AIFFProperties and WAVProperties
2011-06-24 10:43:13 -04:00
Lukáš Lalinský
6b063862c3
Remove the old qmake project file, you can use CMake to build a framework now
2011-06-24 09:00:23 +02:00
Lukáš Lalinský
aec8880592
Update INSTALL to not mention the optional file formats and add info about building a framework
2011-06-24 08:59:38 +02:00
Lukáš Lalinský
dd846904cb
Remove the options to disable MP4/ASF support
2011-06-24 08:49:50 +02:00
Mathias Panzenböck
c7fd4cd2fc
IT: the max. 8000 bytes msg. length have to include the NUL
2011-06-24 01:53:20 +02:00
Mathias Panzenböck
57526c6c37
IT: add term. NUL to messages
2011-06-24 01:50:43 +02:00
Mathias Panzenböck
af92db9dc0
IT: unit tests
2011-06-24 01:31:15 +02:00
Mathias Panzenböck
2d6274a36a
Test FLAC: cleanup copied file
2011-06-24 01:21:17 +02:00
Mathias Panzenböck
9c27c45eb8
IT: strings require term. NUL. mod files: tableLength -> lengthInPatterns
...
Also added enums for S3M/IT/XM flags.
2011-06-24 01:11:10 +02:00
Mathias Panzenböck
e71806b6df
IT: volume is only a byte in size
2011-06-23 20:48:04 +02:00
Lukáš Lalinský
0b34d4f8ee
Enable MP4/ASF by default
2011-06-23 20:18:38 +02:00
Mathias Panzenböck
26613473cf
forgot to remove debug code
2011-06-23 20:17:54 +02:00
Mathias Panzenböck
561cfdb0ec
S3M: unit tests and bug fixes (NUL char. is not optional in S3M strings)
2011-06-23 20:08:05 +02:00
Mathias Panzenböck
e810f2f61f
Merge branch 'master' of https://github.com/taglib/taglib
2011-06-23 17:40:36 +02:00
Mathias Panzenböck
7236ef4d0f
S3M+IT: fix reading, IT: untested support for message writing
...
IT: reading was off starting with global volume because of wrong read size.
S3M+IT: correctly read the number of used patterns.
IT: fixed reading of message tag and implemented writing of message tag
(not tested yet).
I also added S3M+IT test files. TODO: Unit tests using them.
2011-06-23 05:41:23 +02:00
Anton Sergunov
b2517aa4a0
default constructor MP4::Tag::Tag()
2011-06-21 00:54:39 +07:00
Mathias Panzenböck
e202c658f0
Merge branch 'master' of https://github.com/taglib/taglib
2011-06-20 14:31:09 +02:00
Wolfgang Plaschg
7448bb353b
Include of "tag_c.h" after system libraries.
2011-06-20 03:08:24 +02:00
Mathias Panzenböck
aeb528ade2
XM: forgot smaple count
2011-06-20 02:31:17 +02:00
Mathias Panzenböck
d1cb8ae09d
IT: support channels property
2011-06-20 02:19:16 +02:00
Mathias Panzenböck
4b44f25048
comments++
2011-06-20 01:05:12 +02:00
Mathias Panzenböck
4b754b1bc6
more correct IT parsing and property naming
2011-06-20 00:43:42 +02:00
Mathias Panzenböck
b3d44394bf
more correct S3M parsing and property naming
2011-06-19 22:46:33 +02:00
Mathias Panzenböck
5477ede3ea
updated comments
2011-06-19 19:37:45 +02:00
Mathias Panzenböck
03534170fa
comments++
2011-06-19 19:35:27 +02:00
Mathias Panzenböck
b30b8c4ab5
IT: no longer allow wrong sample/instrument magic
2011-06-19 06:03:09 +02:00
Mathias Panzenböck
e09c2c5a19
untested(!) comment write support for s3m and it files
2011-06-19 05:42:16 +02:00
Mathias Panzenböck
6afb7c04b3
comment writing support and more tests for mod and xm
2011-06-19 04:27:51 +02:00
Mathias Panzenböck
0143c3ee63
comments++
2011-06-18 04:28:48 +02:00
Mathias Panzenböck
a31b0bcf8c
xm: no \n too much in comment if there are no samples
2011-06-18 03:38:18 +02:00
Mathias Panzenböck
5ad69f6f2a
fixed mod property names and added unit test for xm
2011-06-18 03:31:49 +02:00
Lukáš Lalinský
b63508ec3e
We still need these includes
2011-06-17 15:09:37 +04:00
Mathias Panzenböck
fe356c31b4
added unit test for one flavour of .mod files
2011-06-17 05:18:49 +02:00
Mathias Panzenböck
eec5e33e0d
added check for readOnly in save methods
2011-06-14 15:34:16 +02:00
Mathias Panzenböck
868ce3dd21
added myself to AUTHORS
2011-06-14 15:23:11 +02:00
Mathias Panzenböck
1e6d645ce9
fixed a comment
2011-06-14 03:56:32 +02:00
Mathias Panzenböck
65fb9733b9
added mod (+aliases) to defaultFileExtensions
2011-06-14 03:49:33 +02:00
Mathias Panzenböck
f75f5ac9bb
added .mod file support
2011-06-14 03:47:08 +02:00
Mathias Panzenböck
812826fe3a
Mod::File -> Mod::FileBase
2011-06-14 01:47:07 +02:00
Mathias Panzenböck
3192334006
more indentation fixes
2011-06-14 01:30:54 +02:00
Mathias Panzenböck
9b2bb4af34
code formatting fixes
2011-06-14 01:18:38 +02:00
Mathias Panzenböck
54e9656474
converted tabs to spaces
2011-06-14 01:09:55 +02:00
Mathias Panzenböck
f6dbd32ed3
refactored for ABI compat and write support of some tags of s3m/it/xm files
...
tags that can be written:
* s3m: title
* it: title
* xm: title, trackerName
2011-06-14 00:46:23 +02:00
Mathias Panzenböck
5332fb5cf8
added read-only support for s3m, it and xm
2011-06-13 03:19:21 +02:00
Lukáš Lalinský
c3c88b4f55
Merge remote branch 'lalinsky/abstract-io'
2011-06-09 18:58:45 +02:00
Lukáš Lalinský
8eb32577bd
Merge branch 'abstract-io'
2011-06-09 18:58:05 +02:00
Lukáš Lalinský
0ed2477dfa
Add an empty default implementation of IOStream::clear()
2011-06-09 18:52:48 +02:00
Frank Lai
b3646a0734
Be more careful when parsing Vorbis Comments
2011-06-09 18:44:54 +02:00
Frank Lai
8ed9b0da2c
Support for reading ALAC audio properties
2011-06-09 18:41:43 +02:00
Frank Lai
93564a2daa
ALAC file encoded by iTunes
2011-06-09 18:40:22 +02:00
Lukáš Lalinský
0a790f0017
Add a (failing) test for reading ALAC audio properties
2011-06-08 19:03:43 +02:00
Lukáš Lalinský
a224e7cd6d
Install the new headers
2011-05-28 22:06:41 +02:00
Lukáš Lalinský
088dbfa832
Merge remote branch 'taglib/master' into abstract-io
2011-05-28 22:04:07 +02:00
Stephen F. Booth
a04da3f159
Added read-only support to FileStream
2011-05-28 13:29:06 -04:00
Lukáš Lalinský
dc062a0844
Make RefCounter compile on OS X with the 10.4 SDK
...
The 10.4 SDK defines OSAtomic functions as int32_t, while 10.5 and newer SDKs
define them as volatile int32_t. This caused a compilation error when
compiling against the 10.4 SDK.
I'd have prefered a preprocessor-based solution, but I couldn't find any
macro that says the SDK version, so I copied this cast solution from
Apple's WebKit. I assume then know what they are doing if they have to
workaround their own API. :)
2011-05-15 00:07:29 +02:00
Scott Wheeler
efeccbf726
Don't lead the scanned blocks on save
2011-05-09 19:06:08 +02:00
Lukáš Lalinský
6b7ed4a5d5
Merge pull request #2 from wplaschg/master
...
Added ignore rules for MSVC 2008 build results
2011-05-09 10:02:21 -07:00
Wolfgang Plaschg
adb0984c87
Adding ignore rules for MSVC 2008 build results
2011-05-09 16:23:38 +02:00
Lukáš Lalinský
a38d2b2995
Simplify static builds
2011-05-08 15:57:34 +02:00
Lukáš Lalinský
b5b8387aee
Don't install pkg-config files when building a framework
2011-05-08 15:50:44 +02:00
Lukáš Lalinský
c337694165
Make it possible to build an OS X framework
2011-05-08 15:46:19 +02:00
Lukáš Lalinský
b2e3a477e9
Always make a copy of the ID3v1 genre name strings
...
http://thread.gmane.org/gmane.comp.kde.devel.taglib/1876
2011-05-02 22:41:01 +02:00
Lukáš Lalinský
81734919d2
Add info about BUILD_EXAMPLES to the INSTALL file
2011-04-19 12:45:11 +02:00
Lukáš Lalinský
d03ef3c312
Use the PUBLIC_HEADER property to prepare for building an OS X framework
2011-04-18 16:52:47 +02:00
Lukáš Lalinský
e92ed0a830
Remove unnecessary code from tfile.cpp
2011-04-12 14:35:31 +02:00
Lukáš Lalinský
65ca29b3e2
Add a ByteVector-backed stream class
2011-04-12 14:28:02 +02:00
Lukáš Lalinský
26c130c387
Duplicate contructors of File subclasses to accept IOStream*
2011-04-11 23:31:44 +02:00
Lukáš Lalinský
8b59bb5957
Make it possible to actually pass a IOStream instance to File
2011-04-11 23:15:46 +02:00
Lukáš Lalinský
b53a577e38
Add FileStream as a copy of File's methods
2011-04-11 23:12:58 +02:00
Lukáš Lalinský
0b0cbc2e34
Add an abstract IOStream class
2011-04-11 22:46:56 +02:00
Lukáš Lalinský
4cda0eeb7b
Make it possible to run the test suite out of the source tree
2011-04-11 18:32:40 +02:00
Lukáš Lalinský
2fa8c93776
The website has more up-to-date links
2011-04-09 20:15:00 +02:00
Lukáš Lalinský
266200d77e
Add myself to the AUTHORS file
2011-04-09 20:09:51 +02:00
Lukáš Lalinský
aa84b8b674
Obsolete comment now that we are not in kdesupport
2011-04-09 20:07:15 +02:00
Lukáš Lalinský
ee920a461c
Clean up the library CMakeLists.txt file
2011-04-09 20:05:50 +02:00
Lukáš Lalinský
1596dc7c69
Clean up the main CMakeLists.txt file
2011-04-09 19:51:23 +02:00
Lukáš Lalinský
f3d3af9355
Don't set unnecessary compiler options
2011-04-09 19:42:56 +02:00
Lukáš Lalinský
9653796640
Merge branch 'master' of github.com:taglib/taglib
2011-04-09 19:19:49 +02:00
Lukáš Lalinský
a4a097d2f8
Merge branch 'stable'
2011-04-09 19:16:01 +02:00
Lukáš Lalinský
5eda17aa96
NEWS entries
2011-04-06 00:08:42 +02:00
Lukáš Lalinský
8878c9158c
Upgrade IPLS (2.3) to TIPL (2.4)
2011-04-05 17:08:25 +02:00
Lukáš Lalinský
3715b96477
Protect against incorrect ID3v2 version parameter
2011-04-05 15:36:23 +02:00
Lukáš Lalinský
aa57db3a39
Convert frames TIPL and TMCL (2.4) to IPLS (2.3)
2011-04-05 15:16:17 +02:00
Lukáš Lalinský
f9d38129b8
Merge branch 'master' into id3v23
2011-04-05 14:37:36 +02:00
Lukáš Lalinský
0c6e2a0aa9
NEWS entry
2011-03-30 09:19:25 +02:00
Martijn van Rheenen
e16829190a
Fix DRM detection in WMA files
2011-03-30 09:15:28 +02:00
Lukáš Lalinský
7a6647cb99
Untested version of DRM checking in WMA files
2011-03-29 15:49:24 +02:00
Lukáš Lalinský
97cd58bc65
Check for the presence of the drms atom in MP4 files
2011-03-29 15:41:17 +02:00
M.A. Brand Consulting
8f42d5b594
Make it possible to build a static version of the C bindings
...
https://bugs.kde.org/show_bug.cgi?id=268441
2011-03-19 08:28:35 +01:00
Lukáš Lalinský
158152cb46
Use the same SO versioning as we had with automake/libtool
...
http://article.gmane.org/gmane.comp.kde.devel.taglib/1826
2011-03-19 08:18:34 +01:00
Lukáš Lalinský
71e224fed8
Don't overwrite fields that already exist
...
We can have multiple fields in the Vorbis Comment (e.g. two artist names),
but TagUnion only takes the first one, so it will effectively strip the
extra fields.
https://bugs.kde.org/show_bug.cgi?id=268854
2011-03-19 07:37:28 +01:00
Lukáš Lalinský
80decd737d
Define NOMINMAX so that windows.h doesn't define it's own versions
...
http://article.gmane.org/gmane.comp.kde.devel.taglib/1833
http://www.devx.com/tips/Tip/14540
2011-03-19 07:26:55 +01:00
Lukáš Lalinský
d169a670e0
Merge branch 'master' into id3v23
2011-03-17 09:16:29 +01:00
Scott Wheeler
a6cb74ad5d
Ignore docs and OS X dylibs
2011-03-17 08:01:33 +01:00
Scott Wheeler
27aa8cc293
These aren't needed anymore now that we're not in kdesupport
2011-03-17 07:57:24 +01:00
Lukáš Lalinský
d3df66f196
Convert TDRC to TYER+TDAT+TIME
2011-03-16 22:54:58 +01:00
Lukáš Lalinský
1453a7b157
Clean-up temporary files
2011-03-16 17:19:11 +01:00
Lukáš Lalinský
e8d0551c9a
Simple ID3v2.4 => ID3v2.3 frame migration
2011-03-16 17:14:36 +01:00
Lukáš Lalinský
061b381ea8
Make sure we don't write UTF8 or UTF16BE to ID3v2.3 tags
2011-03-15 21:57:49 +01:00
Lukáš Lalinský
1802237c75
Support for writing structuraly correct ID3v2.3 tags
...
We don't use the tag footer, extended header or unsynchronization, so we
only need to change the frame size format.
Note that this doesn't write correct ID3v2.3 tags, just tags that have
the correct structure. The content is sill incorrect, unless you add
the right frames manually to the tag instance.
2011-03-15 20:50:47 +01:00
Lukáš Lalinský
4bdcc9662e
Partial protection against broken WMA files
...
This fixes the problem on the reported file, but in general this code
needs a lot more checks.
https://bugs.kde.org/show_bug.cgi?id=268401
2011-03-13 21:33:57 +01:00
Lukáš Lalinský
41f1828719
Use the memory barrier variants on OS X
2011-03-12 23:21:54 +01:00
Lukáš Lalinský
223b85d345
Use GCC automic builtins where possible
2011-03-12 23:19:01 +01:00
Lukáš Lalinský
ee49b781eb
Add .gitignore
2011-03-11 15:16:05 +01:00
Lukáš Lalinský
065fcd5077
Merge branch 'release-1.7'
2011-03-11 14:16:11 +01:00
Nick Shaforostoff
38219b88b3
ups, revert my accidentally commited debug output
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1224409 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-03-10 17:30:22 +00:00
Nick Shaforostoff
0cdfa793e9
use atomic refcounting on mac and win32, todo for linux
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@1224407 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2011-03-10 17:29:30 +00:00