mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-07-18 21:14:23 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fix unexpected sign extension

Browse Source
This commit is contained in:
Tsuda kageyu
2013-04-21 16:06:12 +09:00
parent 81a9f0474d
commit dc89bdd3f0
1 changed files with 5 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
taglib/toolkit/tbytevector.cpp
View File

@ -227,18 +227,13 @@ T toNumber(const ByteVector &v, size_t offset, size_t length, bool mostSignifica
return 0;
}
if(length >= sizeof(T)) {
return toNumber<T>(v, offset, mostSignificantByteFirst);
T sum = 0;
for(size_t i = 0; i < length; i++) {
const size_t shift = (mostSignificantByteFirst ? length - 1 - i : i) * 8;
sum |= static_cast<T>(static_cast<uchar>(v[offset + i])) << shift;
}
else {
T sum = 0;
for(size_t i = 0; i < length; i++) {
const size_t shift = (mostSignificantByteFirst ? length - 1 - i : i) * 8;
sum |= static_cast<T>(static_cast<uchar>(v[offset + i]) << shift);
}
return sum;
}
return sum;
}
template <class T>