Stephen Booth
c1c60ebeea
Use fixed width types ( #1258 )
...
Use fixed width types in `byteSwap` functions
2024-12-22 07:02:05 -06:00
Urs Fleisch
3bc0ea0ecb
Preserve unicode encoding when downgrading to ID3v2.3 ( #1259 ) ( #1260 )
2024-12-22 12:07:25 +01:00
Christian Schmitz
225c73e181
Fixed warning about shadowing variable ( #1254 )
...
You can't name parameter and structure field the same as complier frequently complain about this.
2024-11-22 06:55:34 +01:00
Urs Fleisch
90f62a3c94
Do not store too large FLAC metadata blocks ( #1249 ) ( #1250 )
...
The size of FLAC metadata blocks is stored in only 24 bits. Remove
blocks exceeding this limit when saving FLAC and Ogg FLAC files.
2024-11-14 17:43:18 +01:00
Urs Fleisch
5b6f9ef848
Fix segfaults with String and ByteVector nullptr arguments ( #1247 ) ( #1248 )
2024-11-02 06:39:21 +01:00
Urs Fleisch
e3de03501f
Version 2.0.2
2024-08-24 06:40:41 +02:00
Urs Fleisch
1bd0d711ca
Support older utfcpp versions with utf8cpp CMake target ( #1243 ) ( #1244 )
...
This affects for example openSUSE Leap 15.6, which installs
utfcpp 3.2.1 in its own folder.
Now not only utf8::cpp, but also utf8cpp is supported as a CMake
target.
2024-08-15 12:44:17 +02:00
nekiwo
7c85fcaa81
Remove 'using namespace std' to avoid potential conflicts in example files ( #1241 )
...
Co-authored-by: nekiwo <nekiwo@users.noreply.github.com>
2024-08-05 21:54:33 +02:00
Urs Fleisch
cbe54d2f40
Support free form tags with MP4 properties ( #1239 ) ( #1240 )
2024-07-29 20:24:33 +02:00
Urs Fleisch
c4ed590032
tagwriter option -p not working properly ( #1236 ) ( #1237 )
...
The -p option of tagwriter sample does not work.
This is because the picture file is open in text mode instead of binary.
Also, the isFile function does not work on Windows in 32 bit mode with
large files. Using _stat64 instead of stat solves the problem.
2024-07-19 12:25:46 +02:00
Stephen Booth
f3fb4d83a4
Skip unknown MP4 boxes ( #1231 )
2024-05-18 06:45:10 +02:00
Urs Fleisch
3d4428726e
Fix parsing of ID3v2.2 frames ( #1228 )
2024-05-18 06:43:00 +02:00
Urs Fleisch
ebf4c5bbb1
Version 2.0.1
2024-04-09 19:55:08 +02:00
Urs Fleisch
20cec27ac0
C bindings: Support UTF-8 for property values
2024-04-01 08:45:52 +02:00
Urs Fleisch
99bc87ccff
Fix WASM build by inverting wchar_t size check
...
When building WASM with emscripten
cmake -DCMAKE_TOOLCHAIN_FILE=/path/to/Emscripten.cmake ...
all SIZEOF_ variables which should be defined in ConfigureChecks.cmake
are empty and the wchar_t check fails with "LESS" "2", the other
checks seem to pass since they start with NOT. Instead of explicitly
skipping the check for "if(NOT EMSCRIPTEN)" as is done in vcpkg's
disable-wchar-t-check-emscripten.patch, the check is inverted to
start with NOT, so the build still has a chance to run for compilers
which behave like emscripten.
2024-03-25 20:14:19 +01:00
Urs Fleisch
7951f572b5
Avoid offset_t conflict on Illumos
...
Taken from NetBSD patch-taglib_toolkit_taglib.h.
2024-03-25 20:14:19 +01:00
Urs Fleisch
59ff35772e
Fix building with -DBUILD_TESTING=ON -DBUILD_BINDINGS=OFF
2024-03-25 20:14:19 +01:00
Urs Fleisch
3784628155
Provide equal operator for MP4::Item
...
This is needed to generate MP4::ItemMap bindings with SWIG.
2024-03-25 20:13:55 +01:00
Urs Fleisch
e60df53152
Add virtual to abstract overridden destructor
...
This is redundant, but required by SWIG.
2024-03-25 20:13:55 +01:00
Urs Fleisch
1ae8e18db5
Windows: Suppress yet another MSVC C4251 warning
2024-03-25 20:13:55 +01:00
Urs Fleisch
0896fb9092
Detect utf8cpp by header if cmake config is not found ( #1217 )
2024-02-03 06:28:40 +01:00
Jonas Kvinge
920d97606b
FileStream: Fix opening long paths on Windows ( #1216 )
...
To make sure paths longer than MAX_PATH (260) can be opened, prefix local
paths with `\\?\`, and UNC paths with `\\?\UNC\`.
I've tested on Windows 10 22H2 (Build 19045.3930), even when setting
LongPathsEnabled to 1 in the registry, it still won't open files with long
paths without prefixing them.
For more information see:
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
2024-01-28 16:22:14 +01:00
Urs Fleisch
0d2c31b102
Clarify 2.0 source compatibility, remove obsolete URL ( #1214 )
2024-01-28 07:17:05 +01:00
Urs Fleisch
c8c4e5faec
Fix 'get() != pointer()' assertion copying ByteVectorList/StringList ( #1211 )
...
This reverts dfef09f13
but keeps the assignments as a comment so these
functions do not look like they can be defaulted even though they cannot.
2024-01-27 10:56:31 +01:00
Urs Fleisch
0ebb14b855
Version 2.0
2024-01-24 05:10:43 +01:00
Rosen Penev
89af92333c
clang-tidy: use dynamic_cast
...
Found with cppcoreguidelines-pro-type-static-cast-downcast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Rosen Penev
b356fabe12
clang-tidy: avoid else after return
...
Found with: readability-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Rosen Penev
8a65068f3b
clang-tidy: fix wrong cast
...
Found with bugprone-misplaced-widening-cast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Rosen Penev
e1ac724cfe
convert const double to const auto
...
Fixes some Wconversion warnings.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Urs Fleisch
a08acdcf23
Remove unused types from taglib.h
2024-01-21 20:46:27 +01:00
Urs Fleisch
1799b98c17
Inspection: Table is not correctly formatted
2024-01-21 20:46:27 +01:00
Urs Fleisch
e49390c7c5
Inspection: Type can be replaced with auto
2024-01-21 20:46:27 +01:00
Urs Fleisch
7bcfb96098
Inspection: Code redundancies
2024-01-21 20:46:27 +01:00
Urs Fleisch
580b0b0c82
Inspection: Possibly unused #include directive
2024-01-21 20:46:27 +01:00
Urs Fleisch
5fc3e5c192
Inspection: Possibly uninitialized class member
2024-01-21 20:46:27 +01:00
Urs Fleisch
570b40bdcd
Inspection: Polymorphic class with non-virtual public destructor
2024-01-21 20:46:27 +01:00
Urs Fleisch
c3d73a26ff
Inspection: Parameter names do not match
2024-01-21 20:46:27 +01:00
Urs Fleisch
790815bcf4
Inspection: Missing include guard
2024-01-21 20:46:27 +01:00
Urs Fleisch
1a5c417558
Inspection: Function is not implemented
2024-01-21 20:46:27 +01:00
Urs Fleisch
d87b2dad48
Inspection: Expression can be simplified
2024-01-21 20:46:27 +01:00
Urs Fleisch
613355665c
Inspection: Variable can be moved to inner scope
2024-01-21 20:46:27 +01:00
Urs Fleisch
dfe2aa5253
Inspection: Variable can be moved to init statement
2024-01-21 20:46:27 +01:00
Urs Fleisch
5d921c6325
Inspection: Variable can be made constexpr
2024-01-21 20:46:27 +01:00
Urs Fleisch
710522e6e1
Inspection: Result of a postfix operator is discarded
2024-01-21 20:46:27 +01:00
Urs Fleisch
6b17aa3694
Inspection: Parameter can be made pointer to const
2024-01-21 20:46:27 +01:00
Urs Fleisch
b4f77a4d52
Inspection: Member function can be made const
2024-01-21 20:46:27 +01:00
Urs Fleisch
c907d8b273
Inspection: Functional-style cast is used instead of a C++ cast
2024-01-21 20:46:27 +01:00
Urs Fleisch
98175168f3
Inspection: Declaration and assignment can be joined
2024-01-21 20:46:27 +01:00
Urs Fleisch
73aff544b3
Inspection: C-style cast is used instead of a C++ cast
2024-01-21 20:46:27 +01:00
Rosen Penev
9cbb6615d5
clang-tidy: use using
...
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00