mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

clang-tidy: use dynamic_cast

Browse Source 
Found with cppcoreguidelines-pro-type-static-cast-downcast

Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2024-01-21 18:07:46 -08:00 committed by Urs Fleisch
parent b356fabe12
commit 89af92333c
1 changed files with 18 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

36
tests/test_id3v2framefactory.cpp
View File

@ -225,13 +225,13 @@ public:
factory);
},
[](const File &f) {
return static_cast<const MPEG::File &>(f).hasID3v2Tag();
return dynamic_cast<const MPEG::File &>(f).hasID3v2Tag();
},
[](File &f) {
return static_cast<MPEG::File &>(f).ID3v2Tag(true);
return dynamic_cast<MPEG::File &>(f).ID3v2Tag(true);
},
[](File &f) {
return static_cast<MPEG::File &>(f).strip();
return dynamic_cast<MPEG::File &>(f).strip();
}
);
}
@ -249,13 +249,13 @@ public:
factory);
},
[](const File &f) {
return static_cast<const FLAC::File &>(f).hasID3v2Tag();
return dynamic_cast<const FLAC::File &>(f).hasID3v2Tag();
},
[](File &f) {
return static_cast<FLAC::File &>(f).ID3v2Tag(true);
return dynamic_cast<FLAC::File &>(f).ID3v2Tag(true);
},
[](File &f) {
static_cast<FLAC::File &>(f).strip();
dynamic_cast<FLAC::File &>(f).strip();
return f.save();
}
);
@ -274,13 +274,13 @@ public:
TrueAudio::Properties::Average, factory);
},
[](const File &f) {
return static_cast<const TrueAudio::File &>(f).hasID3v2Tag();
return dynamic_cast<const TrueAudio::File &>(f).hasID3v2Tag();
},
[](File &f) {
return static_cast<TrueAudio::File &>(f).ID3v2Tag(true);
return dynamic_cast<TrueAudio::File &>(f).ID3v2Tag(true);
},
[](File &f) {
static_cast<TrueAudio::File &>(f).strip();
dynamic_cast<TrueAudio::File &>(f).strip();
return f.save();
}
);
@ -299,13 +299,13 @@ public:
fileName, true, RIFF::WAV::Properties::Average, factory);
},
[](const File &f) {
return static_cast<const RIFF::WAV::File &>(f).hasID3v2Tag();
return dynamic_cast<const RIFF::WAV::File &>(f).hasID3v2Tag();
},
[](File &f) {
return static_cast<RIFF::WAV::File &>(f).ID3v2Tag();
return dynamic_cast<RIFF::WAV::File &>(f).ID3v2Tag();
},
[](File &f) {
static_cast<RIFF::WAV::File &>(f).strip();
dynamic_cast<RIFF::WAV::File &>(f).strip();
return true;
}
);
@ -324,10 +324,10 @@ public:
fileName, true, RIFF::AIFF::Properties::Average, factory);
},
[](const File &f) {
return static_cast<const RIFF::AIFF::File &>(f).hasID3v2Tag();
return dynamic_cast<const RIFF::AIFF::File &>(f).hasID3v2Tag();
},
[](File &f) {
return static_cast<RIFF::AIFF::File &>(f).tag();
return dynamic_cast<RIFF::AIFF::File &>(f).tag();
},
[](File &f) {
f.setProperties({});
@ -352,7 +352,7 @@ public:
return !f.tag()->isEmpty();
},
[](File &f) {
return static_cast<DSF::File &>(f).tag();
return dynamic_cast<DSF::File &>(f).tag();
},
[](File &f) {
f.setProperties({});
@ -374,13 +374,13 @@ public:
fileName, true, DSDIFF::Properties::Average, factory);
},
[](const File &f) {
return static_cast<const DSDIFF::File &>(f).hasID3v2Tag();
return dynamic_cast<const DSDIFF::File &>(f).hasID3v2Tag();
},
[](File &f) {
return static_cast<DSDIFF::File &>(f).ID3v2Tag(true);
return dynamic_cast<DSDIFF::File &>(f).ID3v2Tag(true);
},
[](File &f) {
static_cast<DSDIFF::File &>(f).strip();
dynamic_cast<DSDIFF::File &>(f).strip();
return true;
}
);