mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Inspection: Expression can be simplified

Browse Source
This commit is contained in:
Urs Fleisch 2024-01-20 21:37:02 +01:00
parent 613355665c
commit d87b2dad48
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
taglib/ape/apetag.cpp
View File

@ -255,7 +255,7 @@ PropertyMap APE::Tag::setProperties(const PropertyMap &origProps)
for(const auto &[tagName, val] : std::as_const(props)) {
if(!checkKey(tagName))
invalid.insert(tagName, val);
else if(!(itemListMap().contains(tagName)) || !(itemListMap()[tagName].values() == val)) {
else if(!itemListMap().contains(tagName) || itemListMap()[tagName].values() != val) {
if(val.isEmpty())
removeItem(tagName);
else {

2
taglib/mpeg/id3v2/id3v2framefactory.cpp
View File

@ -72,7 +72,7 @@ namespace
bool ok;
int number = genreCode.toInt(&ok);
if((ok && number >= 0 && number <= 255 &&
!(ID3v1::genre(number) == s)) ||
ID3v1::genre(number) != s) ||
genreCode == "RX" || genreCode == "CR")
newfields.append(genreCode);
}

2
taglib/ogg/xiphcomment.cpp
View File

@ -220,7 +220,7 @@ PropertyMap Ogg::XiphComment::setProperties(const PropertyMap &properties)
for(const auto &[key, sl] : properties) {
if(!checkKey(key))
invalid.insert(key, sl);
else if(!d->fieldListMap.contains(key) || !(sl == d->fieldListMap[key])) {
else if(!d->fieldListMap.contains(key) || sl != d->fieldListMap[key]) {
if(sl.isEmpty())
// zero size string list -> remove the tag with all values
removeFields(key);