mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-25 12:10:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

tagwriter option -p not working properly (#1236) (#1237)

Browse Source 
The -p option of tagwriter sample does not work.
This is because the picture file is open in text mode instead of binary.
Also, the isFile function does not work on Windows in 32 bit mode with
large files. Using _stat64 instead of stat solves the problem.
This commit is contained in:
Urs Fleisch 2024-07-19 12:25:46 +02:00 committed by GitHub
parent f3fb4d83a4
commit c4ed590032
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
examples/tagwriter.cpp
View File

@ -48,10 +48,11 @@ bool isArgument(const char *s)
bool isFile(const char *s)
{
struct stat st;
#ifdef _WIN32
return ::stat(s, &st) == 0 && (st.st_mode & (S_IFREG));
struct _stat64 st;
return ::_stat64(s, &st) == 0 && (st.st_mode & S_IFREG);
#else
struct stat st;
return ::stat(s, &st) == 0 && (st.st_mode & (S_IFREG | S_IFLNK));
#endif
}
@ -180,7 +181,7 @@ int main(int argc, char *argv[])
return 1;
}
ifstream picture;
picture.open(value.toCString());
picture.open(value.toCString(), ios::in | ios::binary);
stringstream buffer;
buffer << picture.rdbuf();
picture.close();