Urs Fleisch
59ff35772e
Fix building with -DBUILD_TESTING=ON -DBUILD_BINDINGS=OFF
2024-03-25 20:14:19 +01:00
Urs Fleisch
3784628155
Provide equal operator for MP4::Item
...
This is needed to generate MP4::ItemMap bindings with SWIG.
2024-03-25 20:13:55 +01:00
Urs Fleisch
e60df53152
Add virtual to abstract overridden destructor
...
This is redundant, but required by SWIG.
2024-03-25 20:13:55 +01:00
Urs Fleisch
1ae8e18db5
Windows: Suppress yet another MSVC C4251 warning
2024-03-25 20:13:55 +01:00
Urs Fleisch
0896fb9092
Detect utf8cpp by header if cmake config is not found ( #1217 )
2024-02-03 06:28:40 +01:00
Jonas Kvinge
920d97606b
FileStream: Fix opening long paths on Windows ( #1216 )
...
To make sure paths longer than MAX_PATH (260) can be opened, prefix local
paths with `\\?\`, and UNC paths with `\\?\UNC\`.
I've tested on Windows 10 22H2 (Build 19045.3930), even when setting
LongPathsEnabled to 1 in the registry, it still won't open files with long
paths without prefixing them.
For more information see:
https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry
2024-01-28 16:22:14 +01:00
Urs Fleisch
0d2c31b102
Clarify 2.0 source compatibility, remove obsolete URL ( #1214 )
2024-01-28 07:17:05 +01:00
Urs Fleisch
c8c4e5faec
Fix 'get() != pointer()' assertion copying ByteVectorList/StringList ( #1211 )
...
This reverts dfef09f13
but keeps the assignments as a comment so these
functions do not look like they can be defaulted even though they cannot.
2024-01-27 10:56:31 +01:00
Urs Fleisch
0ebb14b855
Version 2.0
2024-01-24 05:10:43 +01:00
Rosen Penev
89af92333c
clang-tidy: use dynamic_cast
...
Found with cppcoreguidelines-pro-type-static-cast-downcast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Rosen Penev
b356fabe12
clang-tidy: avoid else after return
...
Found with: readability-else-after-return
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Rosen Penev
8a65068f3b
clang-tidy: fix wrong cast
...
Found with bugprone-misplaced-widening-cast
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Rosen Penev
e1ac724cfe
convert const double to const auto
...
Fixes some Wconversion warnings.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-22 18:35:30 +01:00
Urs Fleisch
a08acdcf23
Remove unused types from taglib.h
2024-01-21 20:46:27 +01:00
Urs Fleisch
1799b98c17
Inspection: Table is not correctly formatted
2024-01-21 20:46:27 +01:00
Urs Fleisch
e49390c7c5
Inspection: Type can be replaced with auto
2024-01-21 20:46:27 +01:00
Urs Fleisch
7bcfb96098
Inspection: Code redundancies
2024-01-21 20:46:27 +01:00
Urs Fleisch
580b0b0c82
Inspection: Possibly unused #include directive
2024-01-21 20:46:27 +01:00
Urs Fleisch
5fc3e5c192
Inspection: Possibly uninitialized class member
2024-01-21 20:46:27 +01:00
Urs Fleisch
570b40bdcd
Inspection: Polymorphic class with non-virtual public destructor
2024-01-21 20:46:27 +01:00
Urs Fleisch
c3d73a26ff
Inspection: Parameter names do not match
2024-01-21 20:46:27 +01:00
Urs Fleisch
790815bcf4
Inspection: Missing include guard
2024-01-21 20:46:27 +01:00
Urs Fleisch
1a5c417558
Inspection: Function is not implemented
2024-01-21 20:46:27 +01:00
Urs Fleisch
d87b2dad48
Inspection: Expression can be simplified
2024-01-21 20:46:27 +01:00
Urs Fleisch
613355665c
Inspection: Variable can be moved to inner scope
2024-01-21 20:46:27 +01:00
Urs Fleisch
dfe2aa5253
Inspection: Variable can be moved to init statement
2024-01-21 20:46:27 +01:00
Urs Fleisch
5d921c6325
Inspection: Variable can be made constexpr
2024-01-21 20:46:27 +01:00
Urs Fleisch
710522e6e1
Inspection: Result of a postfix operator is discarded
2024-01-21 20:46:27 +01:00
Urs Fleisch
6b17aa3694
Inspection: Parameter can be made pointer to const
2024-01-21 20:46:27 +01:00
Urs Fleisch
b4f77a4d52
Inspection: Member function can be made const
2024-01-21 20:46:27 +01:00
Urs Fleisch
c907d8b273
Inspection: Functional-style cast is used instead of a C++ cast
2024-01-21 20:46:27 +01:00
Urs Fleisch
98175168f3
Inspection: Declaration and assignment can be joined
2024-01-21 20:46:27 +01:00
Urs Fleisch
73aff544b3
Inspection: C-style cast is used instead of a C++ cast
2024-01-21 20:46:27 +01:00
Rosen Penev
9cbb6615d5
clang-tidy: use using
...
Found with modernize-use-using
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
8b7b48cc9b
clang-tidy: add ending namespace comments
...
Found with llvm-namespace
2024-01-19 21:57:55 +01:00
Rosen Penev
be8d71dad8
MSVC: fix signed/unsigned comparison
...
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
6abbe579a2
clang-tidy: remove virtual from prot destructors
...
Found with cppcoreguidelines-virtual-class-destructor
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
208fc93aaa
cppcheck: match function argument names
...
Found with funcArgNamesDifferent
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
769feafbe0
cppcheck: include system headers with <>
...
Found with missingInclude
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
dfef09f134
cppcheck: assign d to a value
...
Found with operatorEqVarError, missingMemberCopy
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
3a003c1229
cppcheck: add const
...
Found with constVariablePointer, constParameterPointer
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
8b9a260d18
clang-tidy: fix doubled cases
...
Found with bugprone-branch-clone
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
c2eb6b59b5
clang-tidy: avoid endl
...
Found with performance-avoid-endl
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
99ba7635be
clang-tidy: remove pointless const
...
Found with cppcoreguidelines-avoid-const-or-ref-data-members
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Rosen Penev
82b5ded8ee
tvariant: fix -Wconversion warning
...
char -> wchar_t. Just directly use int and remove the cast.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
2024-01-19 21:57:55 +01:00
Urs Fleisch
0318201fbd
Make classes with destructor as only virtual member non-virtual
...
These classes are probably not meant to be used polymorphically.
2024-01-17 21:25:44 +01:00
Urs Fleisch
6c1ba88eab
Make Frame::Header::size(), Frame::headerSize() const
2024-01-17 21:25:44 +01:00
Urs Fleisch
fb0f7dfa57
More API documentation corrections
2024-01-17 20:54:56 +01:00
Urs Fleisch
c5d798a50d
Correct the API documentation
2024-01-04 17:18:23 +01:00
Urs Fleisch
ef013b76db
Add checks for the expected sizes of new public classes
2024-01-02 14:16:22 +01:00