mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

MSVC: fix signed/unsigned comparison

Browse Source 
Signed-off-by: Rosen Penev <rosenp@gmail.com>
This commit is contained in:
Rosen Penev 2023-12-17 15:00:59 -08:00 committed by Urs Fleisch
parent 6abbe579a2
commit be8d71dad8
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
taglib/mpeg/id3v2/id3v2framefactory.cpp
View File

@ -122,7 +122,7 @@ std::pair<Frame::Header *, bool> FrameFactory::prepareFrameHeader(
// A quick sanity check -- make sure that the frameID is 4 uppercase Latin1
// characters. Also make sure that there is data in the frame.
if(frameID.size() != (version < 3 ? 3 : 4) ||
if(frameID.size() != (version < 3U ? 3U : 4U) ||
header->frameSize() <= static_cast<unsigned int>(header->dataLengthIndicator() ? 4 : 0) ||
header->frameSize() > data.size())
{

4
taglib/toolkit/tfilestream.cpp
View File

@ -28,6 +28,7 @@
#ifdef _WIN32
# include <windows.h>
#else
# include <climits>
# include <cstdio>
# include <unistd.h>
#endif
@ -326,7 +327,8 @@ void FileStream::removeBlock(offset_t start, size_t length)
ByteVector buffer(bufferLength);
for(unsigned int bytesRead = -1; bytesRead != 0;) {
unsigned int bytesRead = UINT_MAX;
while(bytesRead != 0) {
seek(readPosition);
bytesRead = static_cast<unsigned int>(readFile(d->file, buffer));
readPosition += bytesRead;