mirror of
https://github.com/taglib/taglib.git
synced 2026-08-27 12:47:01 -04:00
manuaudioandUrs Fleisch
d841424d48
The mdhd duration is a signed 64 bit field in version 1 and the timescale sitting beside it is a 32 bit field that may be 1, so a 4 KB file can declare 2^62 units of a one-hertz clock. The millisecond length is then ~4.6e21 and the conversion to int is undefined: taglib/mp4/mp4properties.cpp:207:34: runtime error: 4.61169e+21 is outside the range of representable values of type 'int' The version 0 path reaches the same line with a 32 bit duration: taglib/mp4/mp4properties.cpp:207:34: runtime error: 4.29497e+12 is outside the range of representable values of type 'int' The mvhd fallback a few lines above feeds the same expression, so it is covered by the same guard. Leave the field at its default rather than converting. For the record, the other conversions in this file were checked and are not affected. The esds and alac nominal bitrates divide a 32 bit value by 1000.0, which cannot leave int's range, and the three calculateMdatLength() estimates are integer arithmetic on a long long rather than a double conversion. One report per file before the change, none after. The 18 MP4 files in tests/data report identical channels, sample rate, bitrate and length before and after, and the suite runs 576 tests either way. Assisted-By: Claude Code (Claude Opus 5)
TagLib
TagLib Audio Metadata Library
TagLib is a library for reading and editing the metadata of several popular audio formats. Currently, it supports various metadata containers such as ID3v1, ID3v2 and Vorbis comments for MP3, MP4, AAC, Ogg, Opus, FLAC, Speex, APE, MPC, WavPack, WAV, AIFF, TrueAudio, Matroska, WebM, ASF, WMA, DSF, DFF and tracker (MOD, XM, S3M, IT) files.
TagLib is distributed under the GNU Lesser General Public License (LGPL) and Mozilla Public License (MPL). Essentially that means that it may be used in proprietary applications, but if changes are made to TagLib they must be contributed back to the project. Please review the licenses if you are considering using TagLib in your project.