mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-08-14 06:17:00 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use Requires.private for zlib with pkg-config (#1380)

Browse Source 
Express dependency on zlib using Requires.private in pkg-config .pc
file instead of adding -lz to the libs.

This will cause the following changes when using TagLib with
pkg-config:
- When using a dynamic library, -lz will no longer be present in
  in linker command, but being linked transitively.
- When using a static library, pkg-config must be used with the
  --static command line argument, then libs will still contain
  -lz, which is needed when linking statically.
- The flags needed for zlib will be provided by pkg-config,
  so if -lz is not appropriate (e.g. with MSVC), correct
  linker flags will be provided.
This commit is contained in:
Urs Fleisch
2026-08-01 06:19:41 +02:00
committed by GitHub
parent 18572e90a6
commit e8f1e058d6
2 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
INSTALL.md
+10 -5
View File
@@ -174,6 +174,8 @@ locations defined when building TagLib. Since we did not give a
```
PKG_CONFIG_PATH=$HOME/pkg/lib/pkgconfig pkg-config --libs --cflags taglib
-I/usr/local/include -I/usr/local/include/taglib -L/usr/local/lib -ltag
PKG_CONFIG_PATH=$HOME/pkg/lib/pkgconfig pkg-config --static --libs --cflags taglib
-I/usr/local/include -I/usr/local/include/taglib -L/usr/local/lib -ltag -lz
```
@@ -182,21 +184,21 @@ parameters affecting the installation location.
- Using the default prefix `-DCMAKE_INSTALL_PREFIX=/usr/local`:
```
-I/usr/local/include -I/usr/local/include/taglib -L/usr/local/lib -ltag -lz
-I/usr/local/include -I/usr/local/include/taglib -L/usr/local/lib -ltag
```
- Using an absolute prefix `-DCMAKE_INSTALL_PREFIX=/usr`:
```
-I/usr/include/taglib -ltag -lz
-I/usr/include/taglib -ltag
```
- Using absolute lib and include directories
`-DCMAKE_INSTALL_LIBDIR=/abs-lib -DCMAKE_INSTALL_INCLUDEDIR=/abs-include -DCMAKE_INSTALL_PREFIX=/usr`:
```
-I/abs-include -I/abs-include/taglib -L/abs-lib -ltag -lz
-I/abs-include -I/abs-include/taglib -L/abs-lib -ltag
```
- Using relative lib and include directories
`-DCMAKE_INSTALL_LIBDIR=rel-lib -DCMAKE_INSTALL_INCLUDEDIR=rel-include -DCMAKE_INSTALL_PREFIX=/usr`:
```
-I/usr/rel-include -I/usr/rel-include/taglib -L/usr/rel-lib -ltag -lz
-I/usr/rel-include -I/usr/rel-include/taglib -L/usr/rel-lib -ltag
```
This is the output of
```
@@ -213,7 +215,10 @@ PKG_CONFIG_PATH=$HOME/pkg/lib/pkgconfig pkg-config --define-prefix --libs --cfla
```
You can use pkg-config from CMake, however, relocation with `--define-prefix`
is not supported.
is not supported, you would have to use something like
`set(PKG_CONFIG_EXECUTABLE pkg-config --define-prefix)` or
`set(PKG_CONFIG_EXECUTABLE pkg-config --static --define-prefix)` if linking a
static TagLib.
```
cmake_minimum_required(VERSION 3.6.0)
taglib.pc.cmake
+2 -1
View File
@@ -6,6 +6,7 @@ includedir=@CMAKE_PC_INCLUDEDIR@
Name: TagLib
Description: Audio meta-data library
Requires:
Requires.private: zlib
Version: @TAGLIB_LIB_VERSION_STRING@
Libs: -L${libdir} -ltag@TAGLIB_INSTALL_SUFFIX@ @ZLIB_LIBRARIES_FLAGS@
Libs: -L${libdir} -ltag@TAGLIB_INSTALL_SUFFIX@
Cflags: -I${includedir} -I${includedir}/taglib@TAGLIB_INSTALL_SUFFIX@