Commit Graph

380 Commits

Author SHA1 Message Date
Scott Wheeler
e6fa8c4976 bump version
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 03:01:04 +00:00
Scott Wheeler
d8e6b9f4ee Add a C accessor to isValid()
BUG:153944


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@766868 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-26 20:20:40 +00:00
Scott Wheeler
fdbfa6d6f6 pedantry
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764837 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-22 17:33:48 +00:00
Scott Wheeler
abb8173104 Use XXX for an unknown language, per the spec.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764647 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-22 10:02:47 +00:00
Lukáš Lalinský
b8435c1ad5 Tweaks to preparing UTF-16 strings with BOM
- '\xFF\xFE' and '\xFE\xFF' are valid, but empty, UTF-16 strings -- don't print a warning
 - print a warning on strings that don't start with a valid BOM

BUG:156076


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764385 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-21 16:40:07 +00:00
Lukáš Lalinský
49bcce586a Add a test case for reading APIC frames with descriptions in UTF-16 including BOM
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764373 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-21 15:46:12 +00:00
Michael Pyne
aebb9a8690 Adapt API docs for FileRef class to match current function signatures.
Patch by Vincent Castellano

CCMAIL:surye80@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@747837 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-13 02:45:12 +00:00
Lukáš Lalinský
6efe9cfcf2 Add an option to define NO_ITUNES_HACKS.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743543 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 10:13:13 +00:00
Lukáš Lalinský
6cc989eb55 Fix saving of ID3v1 tags to TrueAudio files with removed ID3v2 tags.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743541 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 10:08:43 +00:00
Lukáš Lalinský
c4a21adb8e Add a hack to read ID2v2.4 frames with v2.3-like sizes, written by iTunes.
The code is inside a '#ifndef NO_ITUNES_HACKS' block, so I hope it's ok to add it.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 09:15:23 +00:00
Lukáš Lalinský
fed2c020fe Fix TTA audio properties reading.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740388 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-23 06:54:22 +00:00
Rolf Eike Beer
5506647153 Fix build when building complete kdesupport at once
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740189 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 19:18:18 +00:00
Lukáš Lalinský
46fbd11d8f Use correct frame sizes when calculating length of MPEG 2 or 2.5 streams.
CCBUG:130185


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740177 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 18:55:47 +00:00
Lukáš Lalinský
e06495a7e3 Support for URL link framesSupport for URL link frames, patch by Urs Fleisch.
BUG:151079
CCMAIL:ufleisch@users.sourceforge.net


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740080 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:48:01 +00:00
Lukáš Lalinský
bb9e6fe65f Split BUILD_TESTS to BUILD_TESTS and BUILD_EXAMPLES.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740072 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:20:21 +00:00
Lukáš Lalinský
51a5ae46b1 Revert r735160 and r735161, and set BUILD_TESTS to OFF if CppUnit is not found.
CCMAIL:michael.pyne@kdemail.net


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740071 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:17:15 +00:00
Scott Wheeler
363dbf569f Do this the way the other BIC notes are listed.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@739325 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-20 21:14:20 +00:00
Scott Wheeler
f8736f0fe9 Ran my whitespace fixing script -- tabs -> spaces, removes trailing spaces.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@738725 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-19 14:44:09 +00:00
Scott Wheeler
b2e2f0bdba These were missing private copy constructors / assignment operators to make them non-copyable.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@738702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-19 13:59:33 +00:00
Michael Pyne
438927762c This also breaks compilation of kdesupport. CppUnit won't be found since I commented
out the configure check is fixed.  Once the configure check is fixed this can be
commented back in.

CCMAIL:lalinsky@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735161 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-11 03:30:44 +00:00
Michael Pyne
fd1ad5972d Unbreak compilation for kdesupport users with CppUnit by commenting out the test suite.
This needs to be fixed to fail gracefully for users without CppUnit available.

CCMAIL:lalinsky@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-11 03:24:31 +00:00
Lukáš Lalinský
049f77f0d9 TrueAudio support.
This is last of the three formats implemented for libtunepimp, now used also by various players.

BUG:114982


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735116 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:55:14 +00:00
Lukáš Lalinský
2462905fe0 Fix ID3v2::UniqueFileIdentifier frame parsing.
According to the spec, the identifier contains arbitrary binary data (which
includes \0). That means splitting it on \0 and checking if we have only
two parts is wrong, because it rejects valid frames.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735109 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:20:33 +00:00
Lukáš Lalinský
41bc6f0686 Fix off-by-one error in ByteVector::find.
In case where the pattern has the same length as the bytevector, it should
degrade to A == B, not just return "not found" (e.g. A.find(A) should
return 0, not -1).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:16:56 +00:00
Lukáš Lalinský
b44cee48f4 Add methods RelativeVolumeFrame::identification and RelativeVolumeFrame::setIdentification.
BUG:150481


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735098 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 21:32:32 +00:00
Lukáš Lalinský
673b77c3ac - Fixed crash in AttachedPictureFrame and GeneralEncapsulatedObjectFrame
caused by using uninitialized pointer. (BUG:151078)
- Make Frame::readStringField to actually read the string field.
- Fixed parsing of APIC frames -- there is one-byte type between mime type
  and description. The code worked only thanks to the previous bug.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 18:03:25 +00:00
Lukáš Lalinský
db0be6b8c6 Add a CppUnit-based test suite (only very few things is covered for now, but it's a start).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734995 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:46:04 +00:00
Lukáš Lalinský
2302f65964 Speex support.
BUG:129196


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734977 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:07:09 +00:00
Lukáš Lalinský
bb438484da Use Unicode filenames on Windows (this time the correct patch).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734975 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:06:16 +00:00
Lukáš Lalinský
7b0c053359 Revert r734944 -- this one wasn't meant to go in.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:05:18 +00:00
Lukáš Lalinský
7c4dfa9188 Ignore all autotools and cmake generated files.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 15:58:10 +00:00
Lukáš Lalinský
b98be427f9 Use Unicode filenames on Windows.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734944 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 15:16:49 +00:00
Lukáš Lalinský
5a495c5c11 WavPack support.
CCBUG:114982


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@733568 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-06 18:50:09 +00:00
Lukáš Lalinský
b83bf359fc Decode unsynch-encoded tag (ID3v2.3) and frame (ID3v2.4) data before parsing them.
BUG:138829


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@733565 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-06 18:27:47 +00:00
Lukáš Lalinský
0d7ed811fe Use separate DLL export macro for libtag_c and use the right DEFINE_SYMBOL.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@732908 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-05 02:04:10 +00:00
Lukáš Lalinský
074d47460e Remove duplicate check for zlib and make zlib optional.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@732907 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-05 01:58:56 +00:00
Scott Wheeler
0da49842dd SVN_SILENT didn't mean for that to go in
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@727756 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-10-21 17:37:28 +00:00
Scott Wheeler
1bdb67fafa More TAGLIB_EXPORTs from Lukas.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@727755 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-10-21 17:35:40 +00:00
Scott Wheeler
5b03541038 Got permission from all (non-trivial) contributors to dual license under the MPL.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@723791 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-10-10 18:22:58 +00:00
Scott Wheeler
09f1e77112 Install header.
CCMAIL:taglib-devel@kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@723447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-10-09 17:46:48 +00:00
Scott Wheeler
99b0c6e2f4 Note OGA as the new extension for Ogg FLAC.
(Note: for the bug report, this won't actually make things work in Amarok, in fact, this change
wasn't needed at all for it to work there.)

BUG:149987


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@717998 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-09-27 21:41:12 +00:00
Scott Wheeler
14eda582ee Add a few checks to make sure that we don't blow up when trying to read zero-byte
values.

BUG:150250


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@717984 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-09-27 20:52:50 +00:00
Christian Ehrlicher
2eda04f934 more win32 fixes
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@712894 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-09-15 16:01:02 +00:00
Christian Ehrlicher
860b839551 win32 install fixes
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@712787 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-09-15 10:12:27 +00:00
Christian Ehrlicher
0668b26865 we also need config.h on win32!
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@712779 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-09-15 09:03:22 +00:00
Kevin Krammer
ab1939b8fb Unfix compiler warning. Compiler warnings good, BIC changes bad.
Make it a bit more obvious for the next poor fellow


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706333 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-08-29 23:33:30 +00:00
Kevin Krammer
a4d6e9a615 Fixing compiler warning about missing virtual destructor in class with virtual methods
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706328 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-08-29 22:57:23 +00:00
Adriaan de Groot
317de487ba Still need the C++ runtime for the C bindings on Solaris; need stdlib.h for various prototypes.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@705364 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-08-27 20:05:44 +00:00
Adriaan de Groot
38e140962a Need ostream for std::ostream in some STLs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@705359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-08-27 19:41:38 +00:00
Adriaan de Groot
7d2d0670b6 Actually, forcing a particular STL implementation on the C bindings is a bad idea.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@705222 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-08-27 13:58:19 +00:00