mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Unfix compiler warning. Compiler warnings good, BIC changes bad.

Browse Source 
Make it a bit more obvious for the next poor fellow


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706333 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
This commit is contained in:
Kevin Krammer 2007-08-29 23:33:30 +00:00
parent a4d6e9a615
commit ab1939b8fb
4 changed files with 6 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
taglib/fileref.cpp
View File

@ -48,10 +48,6 @@ List<const FileRef::FileTypeResolver *> FileRef::FileRefPrivate::fileTypeResolve
// public members
////////////////////////////////////////////////////////////////////////////////
FileRef::FileTypeResolver::~FileTypeResolver()
{
}
FileRef::FileRef()
{
d = new FileRefPrivate(0);

7
taglib/fileref.h
View File

@ -89,10 +89,9 @@ namespace TagLib {
class FileTypeResolver
{
public:
/*!
* Destroys this FileTypeResolver instance.
*/
virtual ~FileTypeResolver();
// do not fix compiler warning about missing virtual destructor
// since this would not be binary compatible
// let Scott fix it whenever he thinks BIC changes can next be applied
/*!
* This method must be overridden to provide an additional file type
* resolver. If the resolver is able to determine the file type it should

4
taglib/mpeg/id3v1/id3v1tag.cpp
View File

@ -53,10 +53,6 @@ const ID3v1::StringHandler *ID3v1::Tag::TagPrivate::stringHandler = new StringHa
// StringHandler implementation
////////////////////////////////////////////////////////////////////////////////
ID3v1::StringHandler::~StringHandler()
{
}
String ID3v1::StringHandler::parse(const ByteVector &data) const
{
return String(data, String::Latin1).stripWhiteSpace();

4
taglib/mpeg/id3v1/id3v1tag.h
View File

@ -56,10 +56,12 @@ namespace TagLib {
class StringHandler
{
public:
// do not fix compiler warning about missing virtual destructor
// since this would not be binary compatible
// let Scott fix it whenever he thinks BIC changes can next be applied
/*!
* Destroys this StringHandler instance.
*/
virtual ~StringHandler();
/*!
* Decode a string from \a data. The default implementation assumes that
* \a data is an ISO-8859-1 (Latin1) character array.