mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Fixing compiler warning about missing virtual destructor in class with virtual methods

Browse Source 
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706328 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
This commit is contained in:
Kevin Krammer 2007-08-29 22:57:23 +00:00
parent 317de487ba
commit a4d6e9a615
4 changed files with 18 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
taglib/fileref.cpp
View File

@ -48,6 +48,10 @@ List<const FileRef::FileTypeResolver *> FileRef::FileRefPrivate::fileTypeResolve
// public members
////////////////////////////////////////////////////////////////////////////////
FileRef::FileTypeResolver::~FileTypeResolver()
{
}
FileRef::FileRef()
{
d = new FileRefPrivate(0);
@ -171,7 +175,7 @@ File *FileRef::create(const char *fileName, bool readAudioProperties,
return new FLAC::File(fileName, readAudioProperties, audioPropertiesStyle);
if(s.substr(s.size() - 4, 4).upper() == ".MPC")
return new MPC::File(fileName, readAudioProperties, audioPropertiesStyle);
}
}
return 0;
}

6
taglib/fileref.h
View File

@ -56,7 +56,7 @@ namespace TagLib {
class TAGLIB_EXPORT FileRef
{
public:
//! A class for pluggable file type resolution.
/*!
@ -89,6 +89,10 @@ namespace TagLib {
class FileTypeResolver
{
public:
/*!
* Destroys this FileTypeResolver instance.
*/
virtual ~FileTypeResolver();
/*!
* This method must be overridden to provide an additional file type
* resolver. If the resolver is able to determine the file type it should

4
taglib/mpeg/id3v1/id3v1tag.cpp
View File

@ -53,6 +53,10 @@ const ID3v1::StringHandler *ID3v1::Tag::TagPrivate::stringHandler = new StringHa
// StringHandler implementation
////////////////////////////////////////////////////////////////////////////////
ID3v1::StringHandler::~StringHandler()
{
}
String ID3v1::StringHandler::parse(const ByteVector &data) const
{
return String(data, String::Latin1).stripWhiteSpace();

4
taglib/mpeg/id3v1/id3v1tag.h
View File

@ -56,6 +56,10 @@ namespace TagLib {
class StringHandler
{
public:
/*!
* Destroys this StringHandler instance.
*/
virtual ~StringHandler();
/*!
* Decode a string from \a data. The default implementation assumes that
* \a data is an ISO-8859-1 (Latin1) character array.