Commit Graph

2101 Commits

Author SHA1 Message Date
4bac99e3da Add some notes about ByteVector::isNull() and ByteVector::null. 2015-11-17 13:06:03 +09:00
6b7a2c4cf7 Add some notes about String::isNull() and String::null. 2015-11-17 11:41:13 +09:00
1a942627bf Add String::clear() method to clear the string. 2015-11-17 11:29:52 +09:00
3128f425b8 vsnprintf()/vsprintf() does not necessarily return -1 when failed. 2015-11-17 11:06:19 +09:00
3f968933f4 Use std::wstring::empty() rather than size() == 0.
Depending on the implementation, empty() can be more efficient than size().
2015-11-17 10:49:30 +09:00
67f44071cd Fix the usage of boost::endian::endian_reverse(). 2015-11-14 14:49:59 +09:00
11fbf394a3 Skip duplicate ID3v2 tags and treat them as an extra blank of the first one.
This enables all the file formats to handle duplicate ID3v2 tags properly and erase them automatically.
2015-11-13 11:55:56 +09:00
a25e1e9f90 Correct the ID3v2 padding size calculation. 2015-11-13 11:44:12 +09:00
091ab9dee0 Reduce memory reallocation when rendering an ID3v2 tag.
Prevent an ID3v2 padding from being ridiculously large.
2015-11-13 11:35:37 +09:00
c353a71ce5 Remove an unused private data member. 2015-11-13 11:23:27 +09:00
762581fe3f Add a method to check if an MP4 file on disk actually has a tag. 2015-11-13 11:14:12 +09:00
8f147034d6 Add a test about handing "COMMENT" and "DESCIPRION" fields in XiphComment. 2015-11-13 11:07:50 +09:00
6775cef651 Make use of the Boost Endian library for byte swapping.
It's likely to be better at choosing the most efficient method than our CMake tests.
2015-11-13 10:58:23 +09:00
86c7e905ba Silence some MSVC security warnings by replacing strdup() with _strdup().
Backported from taglib2.
2015-11-13 10:06:01 +09:00
ba5137bf2d Use always "COMMENT" field when updating XiphComment.
The recommended field name for additional comments is "COMMENT".
It's the same behavior as "DATE" or "TRACKNUMBER" field.
2015-11-12 17:37:22 +09:00
b3cea6cca7 Fix XiphComment::setComment() for the case that a Vorbis comment has the "COMMENT" field. 2015-11-12 17:16:47 +09:00
a533b9c665 Hide private things from a public header.
Some functions and a variable in tstring.h are not needed to be exposed in a public header.
2015-11-12 15:36:02 +09:00
ec8e611909 Fix an instance reference to a static data member. 2015-11-12 14:48:24 +09:00
c66e6b27d9 Small cleanups in CMakeLists.txt. 2015-11-12 14:41:15 +09:00
1d379fdb2f Small cleanups in audioproperties.cpp. 2015-11-12 14:24:04 +09:00
47813c5a7f A bit more accurate calculation of the AIFF audio length.
Actually, it's unlikely to improve the accuracy, but prevents a useless round-trip conversion between double and int.
2015-11-12 14:10:09 +09:00
94ff9124c7 Skip both ID3v1 and APE tags when seeking the last MPEG frame. 2015-11-12 13:52:46 +09:00
9f697fce8e 1.10 v1.10 2015-11-11 22:41:59 +01:00
320d0f5ad7 Use List::isEmpty() than size() > 0.
Small revision of pokowaka's fix. isEmpty() is a little better than size() > 0, since std::list::empty() is guaranteed to be an O(1) operation.
2015-11-06 16:13:43 +09:00
77087cf865 Merge pull request #675 from garima-g/patch-1
Add self-assignment check in operator=
2015-11-05 15:43:03 +09:00
8b4a27beb4 Add self-assignment check in operator=
Method 'operator=' should check its argument with 'this' pointer.
2015-11-05 11:19:44 +05:30
998ebf4ce6 Add self-assignment check in operator=
Method 'operator=' should check its argument with 'this' pointer.
2015-11-05 11:16:34 +05:30
ccaf650214 Add self-assignment check in operator=
Method 'operator=' should check its argument with 'this' pointer.
2015-11-05 11:12:24 +05:30
9fad0b28a5 Add self-assignment check in operator=
Method 'operator=' should check its argument with 'this' pointer.
2015-11-05 11:09:20 +05:30
153820bf12 Merge pull request #669 from pokowaka/bad_access
Fixes access violation
2015-10-12 14:30:00 +02:00
29be00dc59 Fixes access violation
- Fixes access violation when setting empty stringlist on integer
  properties in mp4 tag
- Add a unit test that validates the fix.
2015-10-09 22:11:27 -07:00
ab30ec3a6f Merge pull request #664 from pbhd/master
add options R, I, D for replace/insert/delete of arbitrary tags
2015-09-23 23:09:55 -04:00
0a90687805 add options R, I, D for replace/insert/delete of arbitrary tags 2015-09-23 14:11:40 +02:00
e750cb491d FileRef: Allow an IOStream to be used 2015-09-15 15:01:40 +02:00
1ff30e55da Revert "Stop exporting std::string and std::wstring in a public header."
This reverts commit 0e981adcc6.
2015-09-11 19:59:20 +09:00
0e981adcc6 Stop exporting std::string and std::wstring in a public header. 2015-09-11 09:14:22 +09:00
a18d402bd9 asftag.cpp: run astyle on added parts 2015-09-09 10:32:31 +02:00
dc994a65f0 ASF: full picture handling 2015-09-09 10:31:24 +02:00
4998dedcf4 mp4tag.cpp: run astyle on added parts 2015-09-09 10:31:08 +02:00
794d9fd27b MP4: full picture handling 2015-09-09 10:27:03 +02:00
35cf4afdba apetag.cpp: run astyle 2015-09-09 10:26:26 +02:00
8ecfba0c30 APE: full picture handling 2015-09-09 10:24:37 +02:00
ace203a6e9 id3v2tag: run astyle on added parts 2015-09-09 10:23:53 +02:00
ccb1d036f2 ID3v2: full picture handling 2015-09-09 10:21:15 +02:00
6dbc340899 Examples: adds picture handling 2015-09-09 10:20:03 +02:00
34931b1d3f tpicture.h,tpicturemap.h: updates comments 2015-09-09 10:18:17 +02:00
612c84731c tpicture: use accessors by values instead of const ref 2015-09-09 10:15:31 +02:00
9e95156319 tpicture: use d as for private ptr 2015-09-09 09:58:42 +02:00
7ed8763a33 tpicture.h,tpicturemap.h: change copyright 2015-09-09 09:58:40 +02:00
3ea69ed165 tpicture*: run astyle 2015-09-09 09:43:22 +02:00