mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-05-27 21:20:26 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add self-assignment check in operator=

Browse Source 
Method 'operator=' should check its argument with 'this' pointer.
This commit is contained in:
garima-g 2015-11-05 11:12:24 +05:30
parent 9fad0b28a5
commit ccaf650214
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
taglib/asf/asfattribute.cpp
View File

@ -72,10 +72,12 @@ ASF::Attribute::Attribute(const ASF::Attribute &other)
ASF::Attribute &ASF::Attribute::operator=(const ASF::Attribute &other)
{
if(d->deref())
delete d;
d = other.d;
d->ref();
if(&other != this) {
if(d->deref())
delete d;
d = other.d;
d->ref();
}
return *this;
}