mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-06-03 00:58:12 -04:00
Code Issues Packages Projects Releases Wiki Activity

Add self-assignment check in operator=

Browse Source 
Method 'operator=' should check its argument with 'this' pointer.
This commit is contained in:
garima-g 2015-11-05 11:16:34 +05:30
parent ccaf650214
commit 998ebf4ce6
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
taglib/mp4/mp4coverart.cpp
View File

@ -54,11 +54,12 @@ MP4::CoverArt::CoverArt(const CoverArt &item) : d(item.d)
MP4::CoverArt &
MP4::CoverArt::operator=(const CoverArt &item)
{
if(d->deref()) {
delete d;
if(&item != this) {
if(d->deref())
delete d;
d = item.d;
d->ref();
}
d = item.d;
d->ref();
return *this;
}