mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-06-04 01:28:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Use always "COMMENT" field when updating XiphComment.

Browse Source 
The recommended field name for additional comments is "COMMENT".
It's the same behavior as "DATE" or "TRACKNUMBER" field.
This commit is contained in:
Tsuda Kageyu 2015-11-12 17:37:22 +09:00
parent b3cea6cca7
commit ba5137bf2d
1 changed files with 5 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
taglib/ogg/xiphcomment.cpp
View File

@ -36,7 +36,6 @@ class Ogg::XiphComment::XiphCommentPrivate
public:
FieldListMap fieldListMap;
String vendorID;
String commentField;
};
////////////////////////////////////////////////////////////////////////////////
@ -82,16 +81,10 @@ String Ogg::XiphComment::album() const
String Ogg::XiphComment::comment() const
{
if(!d->fieldListMap["DESCRIPTION"].isEmpty()) {
d->commentField = "DESCRIPTION";
return d->fieldListMap["DESCRIPTION"].toString();
}
if(!d->fieldListMap["COMMENT"].isEmpty()) {
d->commentField = "COMMENT";
if(!d->fieldListMap["COMMENT"].isEmpty())
return d->fieldListMap["COMMENT"].toString();
}
if(!d->fieldListMap["DESCRIPTION"].isEmpty())
return d->fieldListMap["DESCRIPTION"].toString();
return String::null;
}
@ -137,14 +130,8 @@ void Ogg::XiphComment::setAlbum(const String &s)
void Ogg::XiphComment::setComment(const String &s)
{
if(d->commentField.isEmpty()) {
if(!d->fieldListMap["DESCRIPTION"].isEmpty())
d->commentField = "DESCRIPTION";
else
d->commentField = "COMMENT";
}
addField(d->commentField, s);
removeField("DESCRIPTION");
addField("COMMENT", s);
}
void Ogg::XiphComment::setGenre(const String &s)