diff --git a/taglib/fileref.cpp b/taglib/fileref.cpp index 0b0a49a3..afc19796 100644 --- a/taglib/fileref.cpp +++ b/taglib/fileref.cpp @@ -48,10 +48,6 @@ List FileRef::FileRefPrivate::fileTypeResolve // public members //////////////////////////////////////////////////////////////////////////////// -FileRef::FileTypeResolver::~FileTypeResolver() -{ -} - FileRef::FileRef() { d = new FileRefPrivate(0); diff --git a/taglib/fileref.h b/taglib/fileref.h index b4f1c46e..774d8f90 100644 --- a/taglib/fileref.h +++ b/taglib/fileref.h @@ -89,10 +89,9 @@ namespace TagLib { class FileTypeResolver { public: - /*! - * Destroys this FileTypeResolver instance. - */ - virtual ~FileTypeResolver(); + // do not fix compiler warning about missing virtual destructor + // since this would not be binary compatible + // let Scott fix it whenever he thinks BIC changes can next be applied /*! * This method must be overridden to provide an additional file type * resolver. If the resolver is able to determine the file type it should diff --git a/taglib/mpeg/id3v1/id3v1tag.cpp b/taglib/mpeg/id3v1/id3v1tag.cpp index b336a484..f6fb501e 100644 --- a/taglib/mpeg/id3v1/id3v1tag.cpp +++ b/taglib/mpeg/id3v1/id3v1tag.cpp @@ -53,10 +53,6 @@ const ID3v1::StringHandler *ID3v1::Tag::TagPrivate::stringHandler = new StringHa // StringHandler implementation //////////////////////////////////////////////////////////////////////////////// -ID3v1::StringHandler::~StringHandler() -{ -} - String ID3v1::StringHandler::parse(const ByteVector &data) const { return String(data, String::Latin1).stripWhiteSpace(); diff --git a/taglib/mpeg/id3v1/id3v1tag.h b/taglib/mpeg/id3v1/id3v1tag.h index baef325b..a0ef6bb4 100644 --- a/taglib/mpeg/id3v1/id3v1tag.h +++ b/taglib/mpeg/id3v1/id3v1tag.h @@ -56,10 +56,12 @@ namespace TagLib { class StringHandler { public: + // do not fix compiler warning about missing virtual destructor + // since this would not be binary compatible + // let Scott fix it whenever he thinks BIC changes can next be applied /*! * Destroys this StringHandler instance. */ - virtual ~StringHandler(); /*! * Decode a string from \a data. The default implementation assumes that * \a data is an ISO-8859-1 (Latin1) character array.