Commit Graph

18 Commits

Author SHA1 Message Date
Igor Kushnir
68e9f06a13 GridComicsView: ignore unhandled key presses
When a key not handled by Grid view is pressed while it has focus, the
following warning appears in Library's output
qrc:/qml/GridComicsView.qml:776: Error: Cannot assign [undefined] to int
AND the top-left cover is selected. The added early return fixes both
issues.
2021-05-28 19:35:05 +02:00
Luis Ángel San Martín
890f9846b3 Support HTML content in the synopsis within the current comic banner 2021-03-07 08:55:51 +01:00
Luis Ángel San Martín
0f6b203d34 Embrace HTML coming from Comic Vine 2021-03-06 09:05:35 +01:00
Igor Kushnir
f88af80379 Library: fix InfoComicsView crashes
InfoComicsView constructor is the only function that connects to
FlowView's currentCoverChanged signal. Neither of the slots connected to
this signal handles the argument value index==-1. So when FlowView emits
this signal with index==-1, YACReaderLibrary crashes. Returning early
from either ComicsView::updateInfoForIndex() or
InfoComicsView::setCurrentIndex() when index==-1 is not sufficient - the
crash happens in the other slot then. Let us skip emitting the signal in
FlowView if index==-1 rather than return early from both slots.

Steps to reproduce 1:
1. Launch YACReaderLibrary version that matches the version of the
default library database. Alternatively, select a compatible library
after starting the application.
2. If InfoComicsView is not active, switch to it.
3. (optional) Switch to another comics view out of InfoComicsView.
4. Quit YACReaderLibrary. The application crashes during exit - after
the "YACReaderLibrary closed with exit code : 0" message is printed.

Steps to reproduce 2:
1. Launch a YACReaderLibrary version newer than the version of the
default library database.
2. Click the "No" button in the "Update needed" dialog that pops up.
3. Change between comics views until InfoComicsView becomes active. If
this view was active at the beginning, switch through all the views to
get back to it. At this point YACReaderLibrary crashes.
2021-02-01 11:27:18 +02:00
Luis Ángel San Martín
901d0ab03a Fix Potential fix for GridComicsView in Qt 13 2019-08-11 10:15:44 +02:00
Jeremy Douglass
6f2a4bf243 Add Up Down navigation to FlowView
Adds vertical navigation (up down) to FlowView. This corresponds visually to the File Name list display -- especially when the flow pane is hidden, pressing up-down is the intuitive way to navigate up-down in the list.
2019-05-30 18:15:33 +02:00
Felix Kauselmann
7bfb42be24 rating menu: Remove unneeded qml files 2018-08-11 11:34:12 +02:00
Felix Kauselmann
833e501d7c Remove redundant MenuBar in GridComicsView.qml to avoid crashes on macOS
This fix was originally proposed by @ShawnCarnell on YACReader's old
Bitbucket repository.
2018-08-11 11:31:13 +02:00
Felix Kauselmann
02eda8eeb5 Use QQuickWidget instead of QQuickView to avoid displacement bugs on Windows and Linux 2018-08-11 11:26:12 +02:00
Felix Kauselmann
d3b8f4d5b8 Normalize line endings for .qml files 2018-08-05 13:14:30 +02:00
toto
06246e34d3 ComicInfoView translation
Add translation to ComicInfoView.qml
2018-06-14 22:35:34 +02:00
Luis Ángel San Martín
1c4eb4d1c6 Fix comicRating possition after context menu workaround 2018-05-25 19:31:32 +02:00
Luis Ángel San Martín
786c28bba0 Add workaround for rating context menu crashing in macos
For now we will have two different versions of the rating component.
2018-05-24 19:02:01 +02:00
Luis Ángel San Martín
4deec13cff Fix background color of the current comic list in macosx 2018-04-26 22:17:11 +02:00
Luis Ángel San Martín
3cff8b59e7 Add some undefined values wrapping. 2018-04-24 16:32:21 +02:00
Luis Ángel San Martín
1f7ec3950f ComicInfo.qml is now ComicInfoView.qml 2018-04-23 19:23:15 +02:00
Luis Ángel San Martín
f6d389ff35 Add current/next comic view to GridView. 2018-04-23 19:22:51 +02:00
Felix Kauselmann
2cbbf8d433 Headless server: simplify system config logger 2018-01-28 13:32:56 +01:00