mirror of
https://github.com/YACReader/yacreader
synced 2025-05-28 03:10:27 -04:00
f88af80379
InfoComicsView constructor is the only function that connects to FlowView's currentCoverChanged signal. Neither of the slots connected to this signal handles the argument value index==-1. So when FlowView emits this signal with index==-1, YACReaderLibrary crashes. Returning early from either ComicsView::updateInfoForIndex() or InfoComicsView::setCurrentIndex() when index==-1 is not sufficient - the crash happens in the other slot then. Let us skip emitting the signal in FlowView if index==-1 rather than return early from both slots. Steps to reproduce 1: 1. Launch YACReaderLibrary version that matches the version of the default library database. Alternatively, select a compatible library after starting the application. 2. If InfoComicsView is not active, switch to it. 3. (optional) Switch to another comics view out of InfoComicsView. 4. Quit YACReaderLibrary. The application crashes during exit - after the "YACReaderLibrary closed with exit code : 0" message is printed. Steps to reproduce 2: 1. Launch a YACReaderLibrary version newer than the version of the default library database. 2. Click the "No" button in the "Update needed" dialog that pops up. 3. Change between comics views until InfoComicsView becomes active. If this view was active at the beginning, switch through all the views to get back to it. At this point YACReaderLibrary crashes. |
||
|---|---|---|
| .. | ||
| ComicInfoView.qml | ||
| FlowView.qml | ||
| GridComicsView.qml | ||
| info-favorites.png | ||
| info-favorites@2x.png | ||
| info-indicator-light.png | ||
| info-indicator-light@2x.png | ||
| info-indicator.png | ||
| info-rating.png | ||
| info-rating@2x.png | ||
| info-shadow-light.png | ||
| info-shadow-light@2x.png | ||
| info-shadow.png | ||
| info-tag.png | ||
| info-tag@2x.png | ||
| info-tick.png | ||
| info-tick@2x.png | ||
| info-top-shadow.png | ||
| InfoComicsView.qml | ||
| InfoFavorites.qml | ||
| InfoRating.qml | ||
| InfoTick.qml | ||
| page-macosx.png | ||
| page-macosx@2x.png | ||
| page.png | ||
| reading.png | ||
| star_menu.png | ||
| star_menu@2x.png | ||
| star-macosx.png | ||
| star-macosx@2x.png | ||
| star.png | ||
| tick.png | ||
| YACReaderScrollView.qml | ||
| YACReaderScrollViewStyle.qml | ||
