58 Commits

Author SHA1 Message Date
Scott Wheeler
9a2f90be89 Re-add automake/autoconf stuff. I'm tempted to delete the CMake stuff while I'm
at it, but I'll leave it for now...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@587989 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-24 16:17:47 +00:00
Laurent Montel
0b428130f3 Now taglib compiles with cmake
Remove old build system


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@587949 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-24 14:45:33 +00:00
Laurent Montel
e3cf99c87a Add cmake support
All compile need to test now


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@586714 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-20 12:52:28 +00:00
Scott Wheeler
fdb603c88f It makes more sense to return iterators here. (The return types weren't there
in the last release, so this isn't API breakage.)


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@585152 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-09-16 12:09:48 +00:00
Scott Wheeler
f8d1b7bb4f Update the TCON (genre) frame as we create it so that we don't keep ID3v2.3
formatted data sitting around waiting to be written to 2.4 tags.

BUG:132018


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@578687 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-29 23:06:14 +00:00
Scott Wheeler
784f71409b Add a warning note to File::save()
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@573841 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-17 10:31:52 +00:00
Scott Wheeler
071c691a9a Make removeField() actually remove the map content, not just
empty the list.  Also added an erase method to Map that works on keys
rather than itterators.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572681 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 15:25:48 +00:00
Scott Wheeler
71a392fe81 The non-const functions here should call detach.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@572630 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-08-13 12:29:26 +00:00
Scott Wheeler
a6aeaef64e oops
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 23:26:25 +00:00
Scott Wheeler
6a66c36a0c Here's another easy one that helps out on ginormus strings.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552198 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 22:50:09 +00:00
Scott Wheeler
e83f93b2c0 A couple more optimizations for splitting vectors. One of them makes search
faster in the simple case (no need for Boyer-Moore for a one-character search)
and append a null vector rather than instantiating a new one when we find empty
fields.

This gets the reading time down to 6 seconds here for the reported bug, which
still isn't great, but it's starting to get close to acceptable.  I'll see if I
can get it a little tighter...

BUG:122183


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 22:38:20 +00:00
Scott Wheeler
eb1b7c8255 This is much, much faster on large byte vectors and gets the current bug down
to where it can read the tag in around 18 seconds unstead of 30 minutes.

I'm going to see if I can find the other hot paths now...

CCBUG:122183


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@552178 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-06-16 20:36:36 +00:00
Scott Wheeler
c35d249195 Add a wide string export fuction.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@508477 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-02-11 21:18:03 +00:00
Scott Wheeler
59b9831868 Switch this to "rb" and "rb+" since Windows seems to barf on it without the "b"
and it doesn't make a difference at all on UNIX.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@503213 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2006-01-28 13:40:05 +00:00
Scott Wheeler
f9c5ecaf53 SVN_SILENT a couple of missing docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@471683 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-10-18 12:33:48 +00:00
Scott Wheeler
603068695c A couple of things pointed out by a colleage -- fix ByteVector::size()
and make the return type semantics consistant for methods that modify
the object (specifically, return a reference instead of void).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@460002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-12 16:52:07 +00:00
Scott Wheeler
5d64692084 Just a couple of docs updates.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@457702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-09-06 11:39:26 +00:00
Scott Wheeler
3de9ba2e9f Bug in UTF-8 rendering. Small change, but well, without the "break;" it was doing
the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well,
ungood.

(Sorry Dan, that's bad news for those files -- but this bug was only introduced 4
days ago, so it just hadn't been caught yet.)

BUG:109604


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438731 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 21:34:18 +00:00
Scott Wheeler
f7467bd1f9 Don't actually install the tdebug.h header.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:51:52 +00:00
Scott Wheeler
eb592f0933 Don't include tdebug.h in any installed header. I'll remove it from installation
shortly.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:26:00 +00:00
Scott Wheeler
54b442d584 SVN_SILENT another place to update the version
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 08:03:37 +00:00
Scott Wheeler
111b0dc6eb Make sure that buffer allocations for file reads aren't completely bogus.
Specifically make sure that we don't actually allocate a buffer for a read that
extends beyond the end of the file.

BUG:101401


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:49:29 +00:00
Scott Wheeler
59fd610999 Finally took Tommi's suggestion here and introduced a version of the ByteVectorList::split()
that takes a maximum number of values.  This should probably be used more widely in
places where the max is known ahead of time for this to be a more useful fix than nailing
just this special case.  Anyway, fixes the bug.

BUG:103622


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438030 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:11:20 +00:00
Scott Wheeler
ddd8c2f4c9 SVN_SILENT missing docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-22 09:03:15 +00:00
Scott Wheeler
016a2c7b03 Add UTF16LE support. Patch mostly by Umesh Shankar.
BUG:106815


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437399 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 18:45:12 +00:00
Scott Wheeler
ec86c487e8 Add a mechanism for extending the file type resolution in JuK using FileRefs.
This is generally much better thought out than the current method of creating
FileRefs using the native mime system and also allows for extension to additional
file formats.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:45:23 +00:00
Scott Wheeler
fc8c7d357b Do a bounds check before trying to find the mid.
CCMAIL:Felix Hupfeld <hupfeld@zib.de>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 20:45:05 +00:00
Scott Wheeler
af8b4c7291 Don't dereference the iterator before checking to make sure that we're not
at the end of the list.  Thanks to Gunnar Roth for catching this one.

BUG:96926


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@378404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-01-14 13:04:36 +00:00
Scott Wheeler
4175270a45 1.3.1
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@361202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-07 16:10:40 +00:00
Scott Wheeler
90772906db Make sure that the type conversion happens so that this number ends up being
the appropriate seek location.  I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64.  Can you confirm Hamish?

BUG:86806


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 23:27:29 +00:00
Scott Wheeler
200c608f4f CVS_SILENT this comment belongs here now
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:20:00 +00:00
Scott Wheeler
a18866a48b Make sure that there's (a) data in a bytevector that we're trying to convert
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.

BUG:92028


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:11:41 +00:00
Scott Wheeler
e10bc468c8 Some API overview updates.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345123 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-08 22:38:00 +00:00
Allan Sandfeld Jensen
d0095d3cd7 Convert from ByteVectorList to StringList
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 15:26:23 +00:00
Scott Wheeler
740f868333 Make sure that we're not setting the string size to -1.
CCMAIL:ismail donmez <kde@myrealbox.com>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336760 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-07 20:23:10 +00:00
Scott Wheeler
43a570f5b2 Add overloads here so that the return type is in fact StringList.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336601 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-06 21:51:32 +00:00
Scott Wheeler
65bf71cd61 Return a reference to the current list from append().
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336591 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-06 21:07:46 +00:00
Scott Wheeler
62ca49decb Mark HEAD as TagLib 1.3
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332793 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-26 03:39:34 +00:00
Allan Sandfeld Jensen
cda53a3db4 Add support for reading musepack(mpc)-files and parsing APE-tags(v1 and v2).
Bumb version to have something to check for in JuK and kfile_mpc


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@330294 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-17 13:39:27 +00:00
Allan Sandfeld Jensen
05221f8206 Add find and erase semantics like those in tlist.h
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328830 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-13 18:28:50 +00:00
Waldo Bastian
6879050c54 Valgrind says home-brew strdup() is broken
Fixes saving of MP3 meta-info from properties dialog


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328336 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-12 16:07:27 +00:00
Scott Wheeler
420541441c Switch the return type of File::save() from void to bool to provide a little
bit of feedback on whether or not the safe operation worked.

CCMAIL:83882@bugs.kde.org


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@323165 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-23 18:35:52 +00:00
Scott Wheeler
b69dd382c6 Add iterators and operator[] to the string class.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@319064 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-06-09 13:33:05 +00:00
Scott Wheeler
05e484830c Don't die on invalid input.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@315934 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-29 20:12:36 +00:00
Scott Wheeler
b29a821ed4 documentation fixes
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@310850 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-13 00:08:00 +00:00
Scott Wheeler
6a2cdbcc45 A small regression -- when assigning a ByteVector to a String make sure to
not include the trailing null characters.  (This was introduced after the
last release.)


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@309070 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-05-06 12:36:31 +00:00
Scott Wheeler
de4bd42ef0 Add new type and templatize the "fromNumber" conversion.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:29:22 +00:00
Scott Wheeler
cf6506668d Oops. Make the docs accurate.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306703 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:21:30 +00:00
Scott Wheeler
33bc1a1533 Changed my mind on the last one -- use explicit types rather than trying
to figure things out.  This also allows the number conversion to be
templatized.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306699 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-27 01:09:31 +00:00
Scott Wheeler
31b46c03ac Add a toInt() method that correctly adjusts for the signedness bit even on
different variable sized byte vectors.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@306690 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-04-26 23:00:21 +00:00