mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-11-04 08:45:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Make sure that there's (a) data in a bytevector that we're trying to convert

Browse Source 
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.

BUG:92028


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
This commit is contained in:
Scott Wheeler
2004-10-28 22:11:41 +00:00
parent 790c1b16c6
commit a18866a48b
2 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
ape/apeitem.cpp
View File

@ -123,8 +123,13 @@ bool APE::Item::isEmpty() const
}
}
void APE::Item::parse(const ByteVector& data)
void APE::Item::parse(const ByteVector &data)
{
if(data.size() < 10) {
debug("APE::Item::parse() -- no data in item");
return;
}
uint valueLength = data.mid(0, 4).toUInt(false);
uint flags = data.mid(4, 4).toUInt(false);

6
toolkit/tbytevector.cpp
View File

@ -189,6 +189,12 @@ namespace TagLib {
T toNumber(const std::vector<char> &data, bool mostSignificantByteFirst)
{
T sum = 0;
if(data.size() <= 0) {
debug("ByteVectorMirror::toNumber<T>() -- data is empty, returning 0");
return sum;
}
uint size = sizeof(T);
uint last = data.size() > size ? size - 1 : data.size() - 1;