mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-06-04 01:28:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Valgrind says home-brew strdup() is broken

Browse Source 
Fixes saving of MP3 meta-info from properties dialog


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@328336 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
This commit is contained in:
Waldo Bastian 2004-07-12 16:07:27 +00:00
parent 9a365f9e7e
commit 6879050c54
2 changed files with 2 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
toolkit/taglib.h
View File

@ -71,18 +71,6 @@ namespace TagLib {
uint refCount;
};
/*!
* A simple strdup implementation since the standard one creates some wierdness
* with delete.
*/
static inline char *strdup(const char *s)
{
const int l = ::strlen(s);
char *buffer = new char[l];
::memcpy(buffer, s, l);
return buffer;
}
#endif // DO_NOT_DOCUMENT
}

4
toolkit/tfile.cpp
View File

@ -41,7 +41,7 @@ public:
~FilePrivate()
{
delete [] name;
free((void *)name);
}
FILE *file;
@ -57,7 +57,7 @@ public:
File::File(const char *file)
{
d = new FilePrivate(strdup(file));
d = new FilePrivate(::strdup(file));
d->readOnly = !isWritable(file);
d->file = fopen(file, d->readOnly ? "r" : "r+");