Some encoders write a valid data chunk but with a slightly too-large
declared chunkSize, or place the data chunk beyond the declared RIFF
boundary. The previous behaviour called break, abandoning all remaining
chunks and making the file appear empty to taglib.
Lenient parsers (ffmpeg, QuickTime) handle this case by clamping the
chunk size to the bytes that actually remain in the file. Adopt the
same strategy: when chunkSize would exceed the file length, clamp it
and continue parsing rather than stopping early.
Read, write, and remove Broadcast Audio Extension (BEXT, EBU Tech 3285)
and iXML metadata chunks in WAV files. BEXT is widely used in broadcast
and professional audio for originator, description, time reference, and
loudness metadata. iXML is used by field recorders and DAWs for scene,
take, and track metadata.
MPEG::File::isSupported() scans for frame sync bytes that can appear
in other files, causing them to be misidentified as MP3.
This also includes a test with such a file.
When using for example
examples/tagwriter -C GENRE \
"name=GENRE,targetTypeValue=50,value=Soft Rock;name=GENRE,targetTypeValue=50,value=Classic Rock" \
path/to/file.mka
the GENRE key was included twice and tagreader displayed the two genre
tags twice.
A crafted file can have blockSamples set to 0 and a blockSize so big
that when adding 8 it overflows and offset is 0 so it goes back to the
same position and loops forever
When building for macOS < 10.14, the API for std::optional and
std::variant is restricted
error: 'value' is unavailable: introduced in macOS 10.14
error: 'get<..>' is unavailable: introduced in macOS 10.14
There was also an issue with Android armeabi-v7a where long is not
64 bit and a static assertion failed.
Make AttachedFile immutable. This is consistent with SimpleTag and
Chapter and avoids using attached files which do not have all required
attributes.
Provide methods to insert and remove a single simple tag, so that
they can be modified without setting all of them while still not
exposing internal lists to the API.
Use DATE_RECORDED instead of DATE_RELEASED for year() and the "DATE"
property. This is more consistent with other tag formats, e.g. for ID3v2
"TDRC" is used, which is the recording time.
A complex property can be set with
-C <complex-property-key> <key1=val1,key2=val2,...>
The second parameter can be set to "" to delete complex properties with the
given key. The set complex property values, a simple shorthand syntax can be
used. Multiple maps are separated by ';', values within a map are assigned
with key=value and separated by a ','. Types are automatically detected,
double quotes can be used to force a string. A ByteVector can be constructed
from the contents of a file with the path is given after "file://". There is
no escape, but hex codes are supported, e.g. "\x2C" to include a ',' and \x3B
to include a ';'.
Examples:
Set a GEOB frame in an ID3v2 tag:
examples/tagwriter -C GENERALOBJECT \
'data=file://file.bin,description=My description,fileName=file.bin,mimeType=application/octet-stream' \
file.mp3
Set an APIC frame in an ID3v2 tag (same as -p file.jpg 'My description'):
examples/tagwriter -C PICTURE \
'data=file://file.jpg,description=My description,pictureType=Front Cover,mimeType=image/jpeg' \
file.mp3
Set an attached file in a Matroska file:
examples/tagwriter -C file.bin \
'fileName=file.bin,data=file://file.bin,mimeType=application/octet-stream' \
file.mka
Set simple tag with target type in a Matroska file:
examples/tagwriter -C PART_NUMBER \
name=PART_NUMBER,targetTypeValue=20,value=2 file.mka
Set simple tag with binary value in a Matroska file:
examples/tagwriter -C BINARY \
name=BINARY,data=file://file.bin,targetTypeValue=60 file.mka
When trying to read a packet from the last page the readPages() method
would return false for all packets on the last page.
Move the lastPage check just before trying to create the next page, and
after the packetIndex check of the last fetched page.
