mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-01-30 20:10:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix reading of last page in ogg stream

Browse Source 
When trying to read a packet from the last page the readPages() method
would return false for all packets on the last page.

Move the lastPage check just before trying to create the next page, and
after the packetIndex check of the last fetched page.
This commit is contained in:
Stefan Brüns
2026-01-13 02:15:22 +01:00
committed by Urs Fleisch
parent b4a4b42254
commit 8c7d3368da
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
taglib/ogg/oggfile.cpp
View File

@ -191,13 +191,16 @@ bool Ogg::File::readPages(unsigned int i)
const Page *page = d->pages.back();
packetIndex = nextPacketIndex(page);
offset = page->fileOffset() + page->size();
// Enough pages have been fetched.
if(packetIndex > i) {
return true;
}
else if(page->header()->lastPageOfStream()) {
return false;
}
}
// Enough pages have been fetched.
if(packetIndex > i)
return true;
// Read the next page and add it to the page list.
auto nextPage = new Page(this, offset);
@ -208,9 +211,6 @@ bool Ogg::File::readPages(unsigned int i)
nextPage->setFirstPacketIndex(packetIndex);
d->pages.append(nextPage);
if(nextPage->header()->lastPageOfStream())
return false;
}
}