mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-02-21 23:53:02 -05:00
Code Issues Packages Projects Releases Wiki Activity

Do not allow unknown frames embedded in CTOC and CHAP (#1306)

Browse Source 
This prevents the parsing of frames with specially constructed recursive
frame hierarchies from taking an extremely long time.
This commit is contained in:
Urs Fleisch
2026-02-15 08:38:14 +01:00
committed by GitHub
parent f4117f873c
commit b7f0225f0d
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
taglib/mpeg/id3v2/frames/chapterframe.cpp
View File

@ -30,6 +30,7 @@
#include "tbytevectorlist.h"
#include "tdebug.h"
#include "tpropertymap.h"
#include "unknownframe.h"
using namespace TagLib;
using namespace ID3v2;
@ -259,7 +260,7 @@ void ChapterFrame::parseFields(const ByteVector &data)
return;
// Checks to make sure that frame parsed correctly.
if(frame->size() <= 0) {
if(frame->size() <= 0 || dynamic_cast<UnknownFrame *>(frame)) {
delete frame;
return;
}

3
taglib/mpeg/id3v2/frames/tableofcontentsframe.cpp
View File

@ -29,6 +29,7 @@
#include "tpropertymap.h"
#include "tdebug.h"
#include "unknownframe.h"
using namespace TagLib;
using namespace ID3v2;
@ -269,7 +270,7 @@ void TableOfContentsFrame::parseFields(const ByteVector &data)
return;
// Checks to make sure that frame parsed correctly.
if(frame->size() <= 0) {
if(frame->size() <= 0 || dynamic_cast<UnknownFrame *>(frame)) {
delete frame;
return;
}