Unfortunately, MSVC exports everything (not only public members) when
__declspec(dllexport) is set at the class level via TAGLIB_EXPORT, which
leads to many "needs to have dll-interface to be used by clients" 4251
warnings issued by MSVC, because the std::unique_ptr pimpls are
exported too. As it is not possible to "unexport" private members,
such a warning has to be explicitly suppressed for these cases or
all public and protected class member now have to be exported
for classes derived from a template (StringList, ByteVectorList,
PropertyMap).
In order to achieve this, the TagLib_File type of the C bindings is now
a FileRef and no longer a File. The support for the .oga extension has been
ported to FileRef(), so that taglib_file_new() should still behave the
same, but additionally also support content based file type detection.
Use of FileRef::file() is discouraged, but was necessary to access the
properties. It was also not clear whether to access the properties via
tag() or file(). With the property methods on FileRef, it should become
the "simple usage" interface it was meant to be.
As the destructor was the only virtual method on FileRef, it is now made
non-virtual. Probably, it is not useful as a virtual base class.
* clang-tidy: make deleted members public
One oversight of modernize-use-equals-delete is that the C++11 way of
doing this is to make it public, which makes the warning still trigger.
Signed-off-by: Rosen Penev <[email protected]>
* clang-tidy: add missing deleted functions
Found with cppcoreguidelines-special-member-functions
Signed-off-by: Rosen Penev <[email protected]>
* unique_ptr conversions
unique_ptr is a safer and cleaner way to handle d pointers.
Also added missing = default.
Signed-off-by: Rosen Penev <[email protected]>
---------
Signed-off-by: Rosen Penev <[email protected]>
* clang-tidy: replace RefCounter with shared_ptr
The latter is C++11.
Found with clang-analyzer-webkit.NoUncountedMemberChecker
Signed-off-by: Rosen Penev <[email protected]>
* remove trefcounter
It is now unused.
Signed-off-by: Rosen Penev <[email protected]>
---------
Signed-off-by: Rosen Penev <[email protected]>
This ensures that d-pointers exist where they're expected, and that
classes are virtual that we expect to be virtual, as well as ensuring
that we get a failure if the class size changes when it shouldn't.
This also fixes the issues that were discovered by adding these tests.
FileRef doesn't work with ByteVectorStream as reported at #796, since ByteVectorStream is not associated with a file name and FileRef detects file types based on file extensions.
This commit makes FileRef to work with ByteVectorStream by enabling it to detect file types based on the actual content of a stream.
Patch by Vincent Castellano
CCMAIL:[email protected]
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@747837 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Make it a bit more obvious for the next poor fellow
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@706333 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
Urs Fleisch
Rosen PenevandUrs Fleisch
Scott Wheeler
Hugo Beauzée-LuyssenandUrs Fleisch
Tsuda Kageyu
Lukáš Lalinský
Festus Hagen
Nick Shaforostoff
Lukáš Lalinský
Scott Wheeler
Andrew Coles
Michael Pyne
Kevin Krammer
Christian Ehrlicher
Brad Hards
Laurent Montel