Lukáš Lalinský
9bb57fe0a7
Merge remote-tracking branch 'TsudaKageyu/id3v2-comment-update'
2012-08-23 11:00:32 +02:00
tsuda.kageyu@gmail.com
3fecdbf428
Comment update for ID3v2::Tag::setLatin1StringHandler()
2012-08-23 17:57:00 +09:00
Lukáš Lalinský
356c7a5d6e
Merge remote-tracking branch 'TsudaKageyu/cross-border-delete'
2012-08-23 10:51:47 +02:00
tsuda.kageyu@gmail.com
4b4f70253b
Comment update for ID3v1::Tag::setStringHandler()
2012-08-23 17:45:25 +09:00
Lukáš Lalinský
8b61a06fda
Merge remote-tracking branch 'TsudaKageyu/id3v2-brokenlatin1-patch'
2012-08-23 10:22:43 +02:00
Lukáš Lalinský
6801ac2515
Merge remote-tracking branch 'poiru/master'
2012-08-23 10:19:08 +02:00
Lukáš Lalinský
29d17bb8e9
Merge remote-tracking branch 'supermihi/master'
2012-08-23 10:17:05 +02:00
tsuda.kageyu@gmail.com
fe8053c7d5
Support broken Latin-1 encodings in ID3V2
2012-08-23 12:19:51 +09:00
tsuda.kageyu@gmail.com
eb63ee8ec6
Remove possible cross binary boundary delete
2012-08-23 11:09:22 +09:00
Lukáš Lalinský
e86e5f906b
ID3 frame IDs with 0 should be recognized as valid
...
http://article.gmane.org/gmane.comp.kde.devel.taglib/2275
2012-08-17 07:50:48 +02:00
Lukáš Lalinský
60e82e6694
Ignore additional files
2012-08-17 07:34:44 +02:00
Birunthan Mohanathas
fc6e02da35
Update header comments to reflect c4163a2
2012-08-02 17:25:20 +03:00
Michael Helmling
4140c5f2eb
Check PropertyMap keys format-specifically instead of globally.
...
Instead of statically forbidding certain keys in PropertyMap, now the
setProperties() implementations of the different formats check if the
keys are valid for that particular specification and include them in
the returned PropertyMap otherwise.
This should remove an unneccessary complification for programmers since
now there's only one step, namely calling setProperties(), where
problems might occur.
Also the previous implementation leads to problems with invalid keys:
because taglib doesn't use exceptions, something like
map.insert("FORBIDDEN KEY", "some value");
would lead to the value being inserted under String::null, which
smells like the source of strange bugs.
2012-07-30 20:52:30 +02:00
Michael Helmling
fc3fc10f60
add id3v2 frame delete test
2012-07-23 20:53:25 +02:00
BSDKaffee
3bc123aed6
- Disambiguate uint and ushort references
2012-07-15 01:57:53 -04:00
Lukáš Lalinský
3b392f2402
Changelog for 1.8 beta
v1.8beta
2012-07-14 21:53:09 +02:00
Lukáš Lalinský
8ff0feb28e
Cast to long
2012-07-14 21:21:03 +02:00
Lukáš Lalinský
61ed295af8
Merge remote-tracking branch 'poiru/master'
2012-07-14 21:09:54 +02:00
Lukáš Lalinský
09af2a7b57
Merge remote-tracking branch 'robinst/mpeg-file-id3vxtag-docs-inexistent-tags'
2012-07-14 21:08:59 +02:00
Lukáš Lalinský
050ff3835d
Revert "Install examples if built."
...
This reverts commit 52e96e48c521ad55a7a83fd87d138513d48e6ed9.
2012-07-14 21:06:53 +02:00
Lukáš Lalinský
674ae0fa6d
Merge remote-tracking branch 'kensington/master'
2012-07-14 21:06:08 +02:00
Lukáš Lalinský
411d318f34
Merge remote-tracking branch 'robinst/dont-copy-from-id3v1-when-only-saving-id3v2'
2012-07-14 21:03:16 +02:00
Lukáš Lalinský
fbb1c7e554
Merge branch 'mpc_sv8'
2012-07-11 14:15:37 +02:00
Lukáš Lalinský
fd818857e0
More Musepack tests
2012-07-11 14:15:12 +02:00
Lukáš Lalinský
930168f990
Refactoring of the Musepack SV8 properties code
2012-07-11 14:13:41 +02:00
Alex Novichkov
291d925fc1
MPC v8 audio properties
2012-07-11 13:08:10 +02:00
Scott Wheeler
7c4c455a40
Use '0' here instead of 'NULL'
...
0 is used throughout the rest of the TagLib source, and generally
preferred in C++:
http://www2.research.att.com/~bs/bs_faq2.html#null
2012-07-03 12:26:20 +02:00
Stephen F. Booth
f429d6f406
Merge pull request #41 from EliaCereda/master
...
Properly initialize frame
2012-06-30 07:33:25 -07:00
Elia Cereda
c68fe9ad7b
Fixed error "Branch condition evaluates to a garbage value" (from Xcode 4.3.3 Static Analyzer, mpeg/id3v2/id3v2tag.cpp:377)
...
This error occurs when the frame variable is left uninitialized because its id doesn't match any of the ids in the if and else-id cases. Initializing it on declaration fixes this issue.
2012-06-30 16:25:33 +02:00
Stephen F. Booth
81aac3a590
Merge pull request #39 from robinst/install-build-tests-option
...
Mention -DBUILD_TESTS=on in "Unit Tests" of INSTALL
2012-06-11 04:57:04 -07:00
Robin Stocker
7279b4fb7b
Don't duplicate from ID3v1 to ID3v2 when saving only ID3v2
...
When saving only v2 with stripOthers (which means stripping v1), the
data from v1 would still be duplicated to v2. Likewise for the other way
around.
This is not the expected outcome when e.g. a frame was removed in v2,
because it would be added again on save from the v1 data. The test shows
that.
This changes save to only duplicate the data when the other tag type
will not be stripped.
2012-06-10 18:53:25 +02:00
Robin Stocker
b0ac79c60e
Mention -DBUILD_TESTS=on in "Unit Tests" of INSTALL
2012-06-10 18:26:06 +02:00
Robin Stocker
382aec46f7
Fix docs of MPEG::File::ID3v(1|2)Tag for inexistent tag
...
Since 37e2d629, the ID3v1 and ID3v2 tags are always created at the end
of MPEG::File::read. So contrary to what the documentation said, a null
pointer is never returned.
To check if a tag contains data, refer to isEmpty() in the
documentation.
2012-06-10 15:27:54 +02:00
Michael Palimaka
b5ad68d64b
Add custom 'check' target that depends on the test_runner target for backwards compatibility.
2012-05-17 03:42:36 +10:00
Michael Palimaka
52e96e48c5
Install examples if built.
2012-05-16 04:37:25 +10:00
Michael Palimaka
5bcfecb6cc
Use ctest instead of custom target.
2012-05-16 04:00:22 +10:00
Lukáš Lalinský
2c2a486313
Merge branch 'stable'
...
Conflicts:
CMakeLists.txt
NEWS
2012-04-20 18:30:07 +02:00
Lukáš Lalinský
059f2243b3
Prepare 1.7.2 release
v1.7.2
2012-04-20 17:57:13 +02:00
Lukáš Lalinský
cce6ad46c9
Reverse the version check, similarly to what mp4v2 does
2012-04-20 17:52:12 +02:00
Birunthan Mohanathas
06597123b8
Remove trailing whitespace
2012-04-19 13:09:45 +03:00
Birunthan Mohanathas
e5ede410bc
Tabs to spaces
2012-04-19 13:04:42 +03:00
Vinnie Falco
dafb3af742
Remove 'using namespace std' in tmap.h
2012-04-17 22:05:09 -07:00
Lukáš Lalinský
089643f115
Merge remote-tracking branch 'vinniefalco/rename_enums'
2012-04-17 08:49:02 +02:00
Vinnie Falco
26f458b87f
Resolve scope resolution for APE::Footer definitions in apefooter.cpp
2012-04-15 07:58:50 -07:00
Vinnie Falco
c22791318c
Resolve ambiguous File symbol in apetag.cpp
2012-04-15 07:57:02 -07:00
Vinnie Falco
5081e3cf4f
Rename anonymous enumeration symbols to be unique trueaudiofile.cpp
2012-04-15 02:41:27 -07:00
Vinnie Falco
1bde4cea09
Rename anonymous enumeration symbols to be unique in wavpackfile.cpp
2012-04-15 02:40:46 -07:00
Vinnie Falco
0907e86a94
Rename anonymous enumeration symbols to be unique in apefile.cpp
2012-04-15 02:40:23 -07:00
Vinnie Falco
742a3a1dbb
Rename anonymous enumeration symbols to be unique in mpcfile.cpp
2012-04-15 02:39:19 -07:00
Vinnie Falco
04a4a6b8d4
Rename anonymous enumeration symbols to be unique in flacfile.cpp
2012-04-15 02:38:15 -07:00