Commit Graph

177 Commits

Author SHA1 Message Date
Scott Wheeler
585bf5afca note other bindings
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438757 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-26 00:37:39 +00:00
Scott Wheeler
3de9ba2e9f Bug in UTF-8 rendering. Small change, but well, without the "break;" it was doing
the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well,
ungood.

(Sorry Dan, that's bad news for those files -- but this bug was only introduced 4
days ago, so it just hadn't been caught yet.)

BUG:109604


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438731 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 21:34:18 +00:00
Scott Wheeler
f7467bd1f9 Don't actually install the tdebug.h header.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438704 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:51:52 +00:00
Scott Wheeler
eb592f0933 Don't include tdebug.h in any installed header. I'll remove it from installation
shortly.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438692 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-25 19:26:00 +00:00
Scott Wheeler
052a1d2720 Add a list of the default file extensions that TagLib knows about, as requested
by Stefan.  Also did a few additional updates on the API docs.

CCMAIL:Stefan Gehn <mETz81@web.de>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438212 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 16:25:33 +00:00
Scott Wheeler
54b442d584 SVN_SILENT another place to update the version
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438078 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-24 08:03:37 +00:00
Scott Wheeler
111b0dc6eb Make sure that buffer allocations for file reads aren't completely bogus.
Specifically make sure that we don't actually allocate a buffer for a read that
extends beyond the end of the file.

BUG:101401


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:49:29 +00:00
Scott Wheeler
59fd610999 Finally took Tommi's suggestion here and introduced a version of the ByteVectorList::split()
that takes a maximum number of values.  This should probably be used more widely in
places where the max is known ahead of time for this to be a more useful fix than nailing
just this special case.  Anyway, fixes the bug.

BUG:103622


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438030 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 23:11:20 +00:00
Scott Wheeler
073dee2e41 This is a better way of doing this too... Now I have to remember to
update the configure.in.in in the root...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438007 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 21:46:39 +00:00
Scott Wheeler
ea2ac9fe64 Add pkg-config file.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438006 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 21:43:09 +00:00
Scott Wheeler
02f9b248a7 Bump to 1.4
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@438002 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-23 20:58:43 +00:00
Scott Wheeler
ddd8c2f4c9 SVN_SILENT missing docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-22 09:03:15 +00:00
Scott Wheeler
02925797d2 Go ahead and increment the libtool version in preparation for 1.4.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437529 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-22 08:33:45 +00:00
Scott Wheeler
016a2c7b03 Add UTF16LE support. Patch mostly by Umesh Shankar.
BUG:106815


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437399 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 18:45:12 +00:00
Scott Wheeler
366a4bfe3f Hmm, that last one wasn't really quite ready. Now we actually check our list
of FileTypeResolvers.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437391 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 18:10:10 +00:00
Scott Wheeler
ec86c487e8 Add a mechanism for extending the file type resolution in JuK using FileRefs.
This is generally much better thought out than the current method of creating
FileRefs using the native mime system and also allows for extension to additional
file formats.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:45:23 +00:00
Scott Wheeler
87824b1737 Continuing going through my pile-o-patches:
Make it possible to save files using the save() with a tag mask
without stripping the tags that do not fit the mask.  I still need
to do a little testing on this to make sure that the offsets are
still computed correctly.

BUG:96460


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437380 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:33:36 +00:00
Scott Wheeler
ca839d884f If there is no value set for DESCRIPTION, also check COMMENT.
BUG:98714


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437379 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:30:03 +00:00
Scott Wheeler
a2972c8ae0 Add accessors for the image description.
BUG:94258


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437378 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 17:27:37 +00:00
Scott Wheeler
c756813a21 Fix up the RVA2 handling. I'm still not thrilled with the API, but this
should be functional enough to hold over to the next binary
incompatible change and has a minimum of differences to the previous
API.

I did a slightly nasty hack so that the API docs will see just methods
with an optional argument, but those are actually two separate methods
(for BC).

Brian, please feel free to take a look at this prior to 1.4 going out.

BUG:107025



git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437115 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-21 00:10:57 +00:00
Scott Wheeler
e321ae7774 Fix from Felix Berger to get RVA2 frames a little closer
to working.  The more complicated fix for #107025 will
follow shortly.

BUG:95545


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@437091 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-20 22:23:34 +00:00
Thiago Macieira
19a0504dfd Adding and updating svn:ignore
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@435313 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-16 14:39:38 +00:00
Scott Wheeler
35a8c9a38b Misspelling.
BUG:107847


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@434245 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-13 12:22:34 +00:00
Scott Wheeler
1857e61a9d Instead of returning 0 on finding a deprecated frame type, create an
UnknownFrame and set the flag to discard it on write.

As a special bonus this meant implementing the discard-on-tag-alter
flag.

BUG:100515


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 23:57:23 +00:00
Scott Wheeler
6ceb7a8151 Patch from Umesh Shankar to make sure that the frameID is current.
CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415233 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 22:38:01 +00:00
Scott Wheeler
10d8a4deac Check to make sure that there's content before trying to return it.
Almost the same as a patch from Clemens Fuchslocher 

CCMAIL:clemens@allesdurcheinander.de


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415211 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 21:27:51 +00:00
Scott Wheeler
fc8c7d357b Do a bounds check before trying to find the mid.
CCMAIL:Felix Hupfeld <hupfeld@zib.de>


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 20:45:05 +00:00
Allan Sandfeld Jensen
7e325a26aa Double-deleting won't make it much better
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:41:17 +00:00
Scott Wheeler
c125032f0e ...or this
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402894 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:37:56 +00:00
Scott Wheeler
9b1eb2f5d6 Didn't mean to check this in.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:36:17 +00:00
Scott Wheeler
60f73eb537 fix memory leaks
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:35:55 +00:00
Allan Sandfeld Jensen
abbf24ade7 Decode samplerate correctly.
BUG: 99829


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-02 20:53:11 +00:00
Allan Sandfeld Jensen
119bfc86db Sorry, that was actually wrong.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-03-18 00:10:21 +00:00
Allan Sandfeld Jensen
a89ce9ce0c Support the new OggFLAC 1.0 standard from FLAC 1.1.2
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398574 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-03-18 00:02:27 +00:00
Scott Wheeler
1aff3947ef Nice catch from Gunnar Roth -- the iterator was invalid here.
BUG:94662


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@385470 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-02-02 19:04:54 +00:00
Scott Wheeler
af8b4c7291 Don't dereference the iterator before checking to make sure that we're not
at the end of the list.  Thanks to Gunnar Roth for catching this one.

BUG:96926


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@378404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-01-14 13:04:36 +00:00
Benjamin Meyer
3c9f7ec7d6 startsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@371832 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-12-19 05:45:33 +00:00
Scott Wheeler
d1eb678b77 Make the private class a friend so that it can access the protected Header
class.
BUG:93869


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@369269 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-12-08 16:50:10 +00:00
Benjamin Meyer
a2b316f3fa convert "" comparison to use built in empty() function
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@365215 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-22 20:08:11 +00:00
Scott Wheeler
4175270a45 1.3.1
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@361202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-07 16:10:40 +00:00
Scott Wheeler
16a9b68154 ...and now implement the missing contructor.
BUG:92803


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:43:24 +00:00
Scott Wheeler
baed5abcac Clean up includes and actually install apeitem.h. Prior to this the APE
API wasn't usable.  Fortunately I'm planning on releasing a 1.3.1 tomorrow.

CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>
CCBUG:92803


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:31:55 +00:00
Scott Wheeler
e5e3adc58f Since these headers weren't even usable when installed, might as well go
ahead and remove the deprecated crap...


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360969 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:24:40 +00:00
Scott Wheeler
a3e62fb32e Do bounds checking before assuming that just because we've been told that
there are actually more items that there actually are.

BUG:92028


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-31 20:30:47 +00:00
Scott Wheeler
df700f96f6 Add some text explaining the APE format since it's non-obvious trying to
find it online and it's poorly written once found.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-31 19:27:24 +00:00
Scott Wheeler
6ac3849f13 CVS_SILENT back in here again -- checking in formatting before content...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359015 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-30 16:14:35 +00:00
Scott Wheeler
4b47288bca Don't write a track number if the track is larger than 255.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358768 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-29 13:48:55 +00:00
Scott Wheeler
90772906db Make sure that the type conversion happens so that this number ends up being
the appropriate seek location.  I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64.  Can you confirm Hamish?

BUG:86806


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 23:27:29 +00:00
Scott Wheeler
200c608f4f CVS_SILENT this comment belongs here now
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:20:00 +00:00
Scott Wheeler
a18866a48b Make sure that there's (a) data in a bytevector that we're trying to convert
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.

BUG:92028


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:11:41 +00:00