Tsuda Kageyu
a6701ddcda
Remove some private data members not needed to belong to private classes.
2015-11-30 15:43:18 +09:00
Tsuda Kageyu
31d1f11969
Use a const pointer to initialize a const pointer.
2015-11-30 15:00:32 +09:00
Tsuda Kageyu
f9e558eef5
Avoid trying to remove tag chunks when an AIFF file doesn't have an ID3v2 tag.
2015-11-30 14:17:26 +09:00
Tsuda Kageyu
fcdf7c2ae2
Add some tests to check if the internal flags are updated when writing WAV files.
2015-11-30 13:46:43 +09:00
Tsuda Kageyu
8c424badad
Avoid writing an empty ID3v2 tag in an AIFF file.
2015-11-30 13:42:25 +09:00
Tsuda Kageyu
f1b683b582
Remove some private data members not needed to be carried.
2015-11-30 13:09:11 +09:00
Tsuda Kageyu
5e37f0101d
Remove some private data members not needed to be carried.
2015-11-30 12:53:52 +09:00
Tsuda Kageyu
b541ec8b68
Remove some private data members not needed to be carried.
2015-11-30 12:35:29 +09:00
Tsuda Kageyu
1fa677e2ef
Add some tests about splitting/merging Ogg pages.
2015-11-29 01:57:15 +09:00
Festus Hagen
463e8f313a
Append TIME to TDRC, adjusted test_id3v2.cpp as appropriate.
2015-11-27 17:54:20 -05:00
Tsuda Kageyu
8130b30397
Close temporary files regardless if the tests are successful or not.
...
delete statements are skipped when assertions fail.
2015-11-27 15:20:16 +09:00
Tsuda Kageyu
6b836c6ba7
Add ENABLE_CCACHE build option to allow users opt in to use ccache.
2015-11-27 12:15:03 +09:00
Tsuda Kageyu
f5a3f2b6c1
Update NEWS.
2015-11-27 09:37:29 +09:00
Tsuda Kageyu
4b8e39e8f0
Merge branch 'fh1.m_AddBuildBindingsOption' of https://github.com/FestusHagen/taglib into FestusHagen-fh1.m_AddBuildBindingsOption
...
# Conflicts:
# CMakeLists.txt
2015-11-27 09:35:13 +09:00
Tsuda Kageyu
67cbf2c0a8
Silence a GCC warning in tests about ignoring a return value.
2015-11-27 02:45:33 +09:00
Tsuda Kageyu
3f84621d58
Small cleanups in CMakeLists.txt.
2015-11-27 02:27:24 +09:00
Tsuda Kageyu
f180445be5
Fix saving APE files.
...
This fixes the issue reported at #624 .
2015-11-27 00:22:07 +09:00
Tsuda Kageyu
cbc279b899
Merge pull request #685 from g-coder/patch-2
...
Added ccache support for faster compilation
2015-11-26 20:03:17 +09:00
g-coder
e1bcb101f0
Update CMakeLists.txt
2015-11-26 15:51:42 +05:30
g-coder
14f3b6c928
Added ccache support for faster compilation
...
ccache is a compiler cache. It speeds up recompilation by caching previous compilations and detecting when the same compilation is being done again. It provides support for C/C++ languages.
It makes compilation fast if it is available on the machine.
https://ccache.samba.org/
2015-11-26 15:12:23 +05:30
Tsuda Kageyu
b6361ddde5
Fix saving MPEG files.
...
This fixes all the issues reported at #618 .
2015-11-25 01:56:07 +09:00
Tsuda Kageyu
66dd0b8a6f
Small cosmetic fixes.
2015-11-25 00:12:18 +09:00
Tsuda Kageyu
94b7828990
Fix saving MP4 files.
...
This fixes the issue reported at #619 .
2015-11-24 23:41:10 +09:00
Tsuda Kageyu
fa4289e044
Fix instance references to a static member function.
2015-11-24 16:36:50 +09:00
Tsuda Kageyu
3612c2cc24
Small cosmetic fix.
2015-11-24 15:45:38 +09:00
Tsuda Kageyu
477aba9465
Merge pull request #676 from TsudaKageyu/string-hide-private
...
Hide private things from a public header.
2015-11-23 17:48:06 +09:00
Tsuda Kageyu
a640074a21
Hide some private functions from a public header.
2015-11-23 03:26:38 +09:00
Tsuda Kageyu
25ffbcb4b9
Hide a private static variable.
...
This is so-called Scott Mayers' singleton pattern.
2015-11-23 01:32:12 +09:00
Tsuda Kageyu
e44de9f37f
Remove duplicate tags when saving AIFF files.
...
Just the same way as WAV already does.
2015-11-22 21:03:33 +09:00
Tsuda Kageyu
2b7d6fef47
Reduce redundant ref()/deref() operations.
2015-11-22 20:11:08 +09:00
Tsuda Kageyu
ae633105d6
Fix an instance reference to a static data member.
2015-11-22 19:43:17 +09:00
Tsuda Kageyu
6978131d22
Silence some GCC warnings about no return statement.
2015-11-22 18:42:49 +09:00
Tsuda Kageyu
83a0bc3710
Avoid using obsolete XiphComment::removeField().
2015-11-22 18:30:56 +09:00
Tsuda Kageyu
6477132301
Update NEWS.
2015-11-22 16:23:53 +09:00
Tsuda Kageyu
559c6b28c9
Merge pull request #681 from TsudaKageyu/xiph-remove-fields
...
Add alternative methods to XiphComment::removeField() that may cause …
2015-11-22 16:19:15 +09:00
Tsuda Kageyu
e9f70a59b2
Merge branch 'genversion' of https://github.com/ufleisch/taglib into ufleisch-genversion
...
# Conflicts:
# CMakeLists.txt
2015-11-22 10:38:35 +09:00
Tsuda Kageyu
f34d73d319
Make FileRef::FileTypeResolver work properly.
2015-11-21 18:29:41 +09:00
Tsuda Kageyu
ef3ce1e38a
Style fixes in fileref.cpp.
2015-11-21 17:06:26 +09:00
Tsuda Kageyu
8724184d56
Fix a typo in a comment.
2015-11-21 10:32:32 +09:00
Tsuda Kageyu
61dabe61a7
Update NEWS.
2015-11-21 10:30:48 +09:00
Tsuda Kageyu
de0fc83066
Style fixes in fileref.cpp.
2015-11-21 10:29:37 +09:00
Tsuda Kageyu
c3807e59cd
Merge pull request #528 from chouquette/master
...
FileRef: Allow an IOStream to be used
2015-11-21 09:51:03 +09:00
Tsuda Kageyu
b592f78238
Unify common functions for finding tags.
...
Several classes have exactly identical functions for finding tags.
This also hides the functions from public headers.
2015-11-21 09:30:04 +09:00
Tsuda Kageyu
84e3582332
Add alternative methods to XiphComment::removeField().
...
Using XiphComment::removeField() may lead to a linkage error, however we can't fix the method itself without breaking the ABI or changing its behavior.
So we added some alternative method and marked the old one deprecated.
2015-11-20 23:28:32 +09:00
Tsuda Kageyu
ce1c03faa3
Update NEWS.
2015-11-20 23:08:43 +09:00
Tsuda Kageyu
94c941928a
Merge pull request #654 from TsudaKageyu/xiph-setcomment
...
Fix XiphComment::setComment() for the case that a Vorbis comment has …
2015-11-20 23:02:51 +09:00
Tsuda Kageyu
8c6fe45453
Avoid using String::null where an empty string is required.
...
String::null is not necessarily be empty or remains the same instance.
Using it in a public header may lead to a linkage error.
2015-11-20 22:21:47 +09:00
Tsuda Kageyu
c4fe65787c
Avoid using String::isNull() where it is considered to be confused with isEmpty().
2015-11-20 20:59:13 +09:00
Tsuda Kageyu
29b0568dec
Revert "Add a test about handing "COMMENT" and "DESCIPRION" fields in XiphComment."
...
This reverts commit 8f147034d6
.
2015-11-20 14:18:40 +09:00
Tsuda Kageyu
7d0a651f3e
Revert "Use always "COMMENT" field when updating XiphComment."
...
This reverts commit ba5137bf2d
.
2015-11-20 14:18:23 +09:00