mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2025-06-04 01:28:21 -04:00
Code Issues Packages Projects Releases Wiki Activity

Avoid writing an empty ID3v2 tag in an AIFF file.

Browse Source
This commit is contained in:
Tsuda Kageyu 2015-11-30 13:42:25 +09:00
parent f1b683b582
commit 8c424badad
2 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
taglib/riff/aiff/aifffile.cpp
View File

@ -117,9 +117,12 @@ bool RIFF::AIFF::File::save()
removeChunk("ID3 ");
removeChunk("id3 ");
d->hasID3v2 = false;
setChunkData("ID3 ", d->tag->render());
d->hasID3v2 = true;
if(tag() && !tag()->isEmpty()) {
setChunkData("ID3 ", d->tag->render());
d->hasID3v2 = true;
}
return true;
}

11
tests/test_aiff.cpp
View File

@ -64,14 +64,23 @@ public:
{
RIFF::AIFF::File f(newname.c_str());
CPPUNIT_ASSERT(!f.hasID3v2Tag());
f.tag()->setTitle(L"TitleXXX");
f.save();
CPPUNIT_ASSERT(f.hasID3v2Tag());
}
{
RIFF::AIFF::File f(newname.c_str());
CPPUNIT_ASSERT(f.hasID3v2Tag());
CPPUNIT_ASSERT_EQUAL(String(L"TitleXXX"), f.tag()->title());
f.tag()->setTitle("");
f.save();
CPPUNIT_ASSERT(!f.hasID3v2Tag());
}
{
RIFF::AIFF::File f(newname.c_str());
CPPUNIT_ASSERT(!f.hasID3v2Tag());
}
}