Scott Wheeler
16a9b68154
...and now implement the missing contructor.
...
BUG:92803
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:43:24 +00:00
Scott Wheeler
baed5abcac
Clean up includes and actually install apeitem.h. Prior to this the APE
...
API wasn't usable. Fortunately I'm planning on releasing a 1.3.1 tomorrow.
CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>
CCBUG:92803
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:31:55 +00:00
Scott Wheeler
e5e3adc58f
Since these headers weren't even usable when installed, might as well go
...
ahead and remove the deprecated crap...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360969 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:24:40 +00:00
Scott Wheeler
a3e62fb32e
Do bounds checking before assuming that just because we've been told that
...
there are actually more items that there actually are.
BUG:92028
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-31 20:30:47 +00:00
Scott Wheeler
df700f96f6
Add some text explaining the APE format since it's non-obvious trying to
...
find it online and it's poorly written once found.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-31 19:27:24 +00:00
Scott Wheeler
6ac3849f13
CVS_SILENT back in here again -- checking in formatting before content...
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359015 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-30 16:14:35 +00:00
Scott Wheeler
4b47288bca
Don't write a track number if the track is larger than 255.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358768 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-29 13:48:55 +00:00
Scott Wheeler
90772906db
Make sure that the type conversion happens so that this number ends up being
...
the appropriate seek location. I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64. Can you confirm Hamish?
BUG:86806
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 23:27:29 +00:00
Scott Wheeler
200c608f4f
CVS_SILENT this comment belongs here now
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:20:00 +00:00
Scott Wheeler
a18866a48b
Make sure that there's (a) data in a bytevector that we're trying to convert
...
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.
BUG:92028
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:11:41 +00:00
Scott Wheeler
790c1b16c6
More cleanups and some API docs additions.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358636 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:05:43 +00:00
Scott Wheeler
a92f6b94dd
Semantic and style cleanups. render() should be const. Use for() loops to
...
loop through lists rather than while, fix bracket style.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358627 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 21:22:33 +00:00
Scott Wheeler
d58cde9eca
This line is redundant.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-20 23:34:55 +00:00
Scott Wheeler
9087eacd37
Add some more docs on how to use the ID3v1::StringHandler in the ID3v1::Tag
...
documentation.
BUG:90634
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356354 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-20 23:15:08 +00:00
Scott Wheeler
3d5ab8fd10
Move the sanity check before the unknown frame stuff. As the code currently
...
is if a bogus frame is hit it may try to parse it as an UnknownFrame rather
than just discarding it.
CCMAIL:Espen Tveit <espen.tveit@gmail.com>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@355686 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-18 15:31:12 +00:00
Scott Wheeler
11f732d198
Forgot this. Time to redo the tarballs.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345358 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 02:23:31 +00:00
Scott Wheeler
06fbb10a4a
CVS_SILENT missing doc for the namespace
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345357 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 02:13:40 +00:00
Scott Wheeler
d4561d3345
1.3 -- bump the libtool version
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345355 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 01:54:20 +00:00
Scott Wheeler
68982059d0
misplace conditional
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345352 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 01:42:56 +00:00
Scott Wheeler
133f50e356
Patch from Allan to add support for compressed frames.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345351 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 01:29:49 +00:00
Allan Sandfeld Jensen
cd50355a4c
Remove some annoying debuging code.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345343 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-09 23:49:49 +00:00
Scott Wheeler
a51d1cb117
Scott's silly nitpicks...
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345141 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-09 00:28:57 +00:00
Scott Wheeler
e10bc468c8
Some API overview updates.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345123 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-08 22:38:00 +00:00
Scott Wheeler
c142f9e47c
Mention the return type.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344197 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-05 17:55:47 +00:00
Scott Wheeler
20fb2bd1ec
Don't try to do stuff to files that aren't valid.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-05 17:54:00 +00:00
Allan Sandfeld Jensen
fa643093bd
Cleaning up. Better documentation and remove dead code.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343588 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-02 19:32:19 +00:00
Allan Sandfeld Jensen
07f56ac534
Fix typo.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343576 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-02 18:50:26 +00:00
Allan Sandfeld Jensen
f086fdaba5
Set APELocation to the beginning of the APE-tag
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340956 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-25 15:37:53 +00:00
Allan Sandfeld Jensen
c538ac3912
Some extra documentation.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 21:57:07 +00:00
Allan Sandfeld Jensen
e5944a6f46
Find the starting position.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 20:39:32 +00:00
Allan Sandfeld Jensen
3ab81ed05d
Update interface. Just needs more documentation now.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340209 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 20:38:47 +00:00
Allan Sandfeld Jensen
d0095d3cd7
Convert from ByteVectorList to StringList
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 15:26:23 +00:00
Allan Sandfeld Jensen
bdee6dcf73
APE-tags for mp3s.
...
Currently they are for special purposes only, and thus not used as a part
of the union tag.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@338184 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-15 21:14:12 +00:00
Scott Wheeler
60959a1b5b
add api docs
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336790 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-08 06:04:42 +00:00
Scott Wheeler
740f868333
Make sure that we're not setting the string size to -1.
...
CCMAIL:ismail donmez <kde@myrealbox.com>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336760 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-07 20:23:10 +00:00
Scott Wheeler
47ddbca63b
CVS_SILENT forgot a short description
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336647 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-07 01:39:26 +00:00
Scott Wheeler
2a48666f80
Adding support for the Unique File Identifier ID3v2 frame type (UFID).
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336640 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-07 00:59:16 +00:00
Scott Wheeler
c3c54b570a
Add support for custom ID3v2 text frames (TXXX).
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336629 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-06 23:41:56 +00:00
Scott Wheeler
43a570f5b2
Add overloads here so that the return type is in fact StringList.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336601 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-06 21:51:32 +00:00
Scott Wheeler
65bf71cd61
Return a reference to the current list from append().
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336591 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-06 21:07:46 +00:00
Scott Wheeler
4aaa73f613
Here's an oops -- this *really* should have been virtual. I'm not sure how
...
I missed that. I'll come up with something -- probably a functor or similar
to work around this at some point.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@336480 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-06 01:54:28 +00:00
Scott Wheeler
cc6bf884a3
Ignore compressed and encrypted ID3v2 frames rather than just blindly giving
...
back the compressed/encrypted data as a string.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335256 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-02 19:35:47 +00:00
Scott Wheeler
ae2113e716
Always explicitly check for divide by zero conditions.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@335132 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-02 12:51:14 +00:00
Allan Sandfeld Jensen
650b561eda
Create a correct footer
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@334982 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-01 23:30:06 +00:00
Allan Sandfeld Jensen
15f864a779
A few changes to make the interface more flexible. It can now remove
...
tags including ID3v2.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@334981 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-01 23:29:42 +00:00
Scott Wheeler
06122de67f
Standard stuff -- make it fit with the coding style of the rest of TagLib
...
and make it build. There are still some missing API docs and I'm not sure
how I feel about non-opaque types (Item in this case) since they're not used
elsewhere in the API, but this will do for now.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333117 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-27 02:35:47 +00:00
Scott Wheeler
b7d9398052
This is wrong -- this would indicate a BIC library release. Please see
...
"info:/libtool/Updating version info" when changing the libtool version
string.
CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com>
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333116 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-27 02:00:01 +00:00
Allan Sandfeld Jensen
dbc0fe07c9
Make mpc use the new APETag-structure
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333012 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-26 19:04:40 +00:00
Allan Sandfeld Jensen
73c2311010
Refactoring.
...
APE-tags are not native to musepack, so I am moving it out.
Seperated footer-decoding the same way header-decoding is seperated in
ID3v2.
Fixed a bug with the version in the footer. Should be 2000 (read 2.000) not 2.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@333011 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-26 19:03:28 +00:00
Scott Wheeler
1ad5582391
missing const
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@332913 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-07-26 13:44:59 +00:00