diff --git a/taglib/ape/apetag.cpp b/taglib/ape/apetag.cpp index 4d75c7aa..9c359aad 100644 --- a/taglib/ape/apetag.cpp +++ b/taglib/ape/apetag.cpp @@ -255,7 +255,7 @@ PropertyMap APE::Tag::setProperties(const PropertyMap &origProps) for(const auto &[tagName, val] : std::as_const(props)) { if(!checkKey(tagName)) invalid.insert(tagName, val); - else if(!(itemListMap().contains(tagName)) || !(itemListMap()[tagName].values() == val)) { + else if(!itemListMap().contains(tagName) || itemListMap()[tagName].values() != val) { if(val.isEmpty()) removeItem(tagName); else { diff --git a/taglib/mpeg/id3v2/id3v2framefactory.cpp b/taglib/mpeg/id3v2/id3v2framefactory.cpp index d96ccc0f..073704be 100644 --- a/taglib/mpeg/id3v2/id3v2framefactory.cpp +++ b/taglib/mpeg/id3v2/id3v2framefactory.cpp @@ -72,7 +72,7 @@ namespace bool ok; int number = genreCode.toInt(&ok); if((ok && number >= 0 && number <= 255 && - !(ID3v1::genre(number) == s)) || + ID3v1::genre(number) != s) || genreCode == "RX" || genreCode == "CR") newfields.append(genreCode); } diff --git a/taglib/ogg/xiphcomment.cpp b/taglib/ogg/xiphcomment.cpp index 9903c51c..0e7b520e 100644 --- a/taglib/ogg/xiphcomment.cpp +++ b/taglib/ogg/xiphcomment.cpp @@ -220,7 +220,7 @@ PropertyMap Ogg::XiphComment::setProperties(const PropertyMap &properties) for(const auto &[key, sl] : properties) { if(!checkKey(key)) invalid.insert(key, sl); - else if(!d->fieldListMap.contains(key) || !(sl == d->fieldListMap[key])) { + else if(!d->fieldListMap.contains(key) || sl != d->fieldListMap[key]) { if(sl.isEmpty()) // zero size string list -> remove the tag with all values removeFields(key);