[email protected]
0e10cd2ae8
fix(amd64-386): sample oscillator hard crash
...
The sample-based oscillators converted the samplepos to an integer
and did samplepos < loop_end comparison to check if we are past
looping. Unfortunately, the < comparison was done in signed math.
Normally, this should never happen, but if the x87 FPU stack
overflowed exactly at right position, we then got 0x80000000 in
samplepos, which is equal to -2147483648. Thus, we considered that
sample is not looping and read the sample table at position
-2147483648, well out of bound. TL;DR changing jl to jb makes sure
we always wrap within to sample table, no matter what.
Fixes #149 .
2024-09-22 09:04:47 +03:00
[email protected]
4ee355bb45
fix(tracker/gioui): DPI scaling of the numeric updown icons
...
Closes #150 .
2024-09-21 14:01:32 +03:00
[email protected]
7d6daba3d2
fix(vm/compiler/bridge): empty patch should not crash native synth
...
Fixes #148 .
2024-09-16 19:58:23 +03:00
[email protected]
2b38e11643
feat: include version info in the binaries
2024-09-15 19:45:00 +03:00
[email protected]
f8c522873c
docs: update CHANGELOG.md for v0.4.1
2024-09-08 19:27:42 +03:00
[email protected]
e49f699f62
feat(tracker/gioui): clicking a parameter slider (etc.) selects it
...
Closes #112 .
2024-09-08 14:46:24 +03:00
[email protected]
6924b63e02
test(vm): disabled units should not affect NecessaryFeatures for vm
...
Closes #140 .
2024-09-08 11:22:05 +03:00
[email protected]
6fc9277113
fix(tracker): unit search gains focus when adding a unit on last row
2024-09-07 21:29:37 +03:00
[email protected]
877556b428
feat(tracker): do not wrap around when playing or moving cursor
...
The wrapping was usually unwanted behaviour. The user can use the
looping (Ctrl-L) to loop the song forever if this is really desired.
2024-09-07 18:52:52 +03:00
[email protected]
5e65410d27
fix(sointu): use proper modulo in SongPos
...
The previous implementations used remained, not modulo, which could
cause issues with negative values.
2024-09-07 18:45:14 +03:00
[email protected]
4e1fdf57d9
fix(tracker/gioui): advance row by step when inputting a note
...
Closes #144 .
2024-09-07 17:45:32 +03:00
[email protected]
1daaf1829c
fix(tracker): ensure numVoices of loaded instrument is ok
2024-09-07 15:25:06 +03:00
[email protected]
74972b5ff4
fix(tracker): ID collisions in ClearUnit and Instruments.unmarshal
2024-09-07 15:25:06 +03:00
[email protected]
9da6c2216c
test(tracker): fuzz testing of ID collisions and file read/writes
2024-09-07 15:16:53 +03:00
[email protected]
61e7da5dab
test(tracker): test loading presets in fuzz tests
2024-09-06 22:03:52 +03:00
[email protected]
59fb39d9b3
fix(tracker/gioui): move alert popups north to not overlay buttons
...
Closes #142 .
2024-09-06 22:01:00 +03:00
[email protected]
9cb573d965
feat(tracker/gioui): cursor indicates split bars can be resized
...
Closes #145 .
2024-09-06 20:29:33 +03:00
[email protected]
d46605c638
fix: assign new IDs to loaded instruments
...
Fixes #146 .
2024-09-06 20:19:27 +03:00
[email protected]
569958547e
fix(amd64-386): do not optimize away phase modulations with unisons
2024-08-17 11:06:18 +03:00
[email protected]
012ed10851
test: add unit test for unisons with phase = 0
...
This demonstrates a bug found by Virgill:
the x86 templates optimize away the phase
modulation when all phases are set to 0,
but the unisons need the phase modulation
internally to offset the phase of the different
unison oscillators.
2024-08-17 11:06:17 +03:00
[email protected]
5bc6dc6015
test(vm): test that disabled units do not affect results
2024-08-14 19:43:13 +03:00
[email protected]
350402f8f3
fix(vm): prevent crash when only disabled delay units & test it
2024-08-14 19:41:44 +03:00
[email protected]
75bd9c591e
fix: do not include delay times from disabled delay units
...
Closes #139 .
2024-08-14 15:41:13 +03:00
[email protected]
2667c3c72c
docs: update CHANGELOG.md for v0.4.0
2024-08-10 15:29:49 +03:00
[email protected]
e09af5ab34
fix(tracker): loading preset did not update the ids
...
When a preset was loaded, its IDs were not updated,
causing ID collisions in the song and send targets
going wrong.
2024-08-10 15:20:25 +03:00
[email protected]
db2d9cac9d
fix(vm): x87 native filter unit was denormalizing and eating up CPU
...
When voice was silent, the exponential decays in the filter unit
were causing the high pass component to eventually denormalize,
causing high CPU loads. The solution is the same as in the delay
unit: add and subtract a small number from the value, causing
essentially a flush to zero.
https://en.wikipedia.org/wiki/Subnormal_number
Fixes #68 .
2024-06-19 18:58:20 +03:00
[email protected]
a14e21dff6
ci: macos-latest is now arm64 and breaks, use macos-12 for now
2024-05-05 13:19:25 +03:00
[email protected]
58916d3c6d
docs: update README.md, to recommend using nasm instead of yasm
2024-05-05 11:37:42 +03:00
[email protected]
84d90cf0f3
fix(vm/compiler): use more yasm-compatible syntax
...
Closes #134 .
2024-05-05 11:34:47 +03:00
[email protected]
10d20cd26f
fix(vm/compiler): export as su_pow, instead of su_power
...
The export redefinition of label, even though the labels were on the
same line. This was an issue for yasm.
Related to #134 .
2024-05-05 11:33:47 +03:00
[email protected]
4a8d4c5a29
fix(vm/compiler/templates): modulating delaytime in wasm could crash
...
The modulated delay time was converted to int with i32.trunc_f32_u.
This throws runtime error if the modulations caused the delaytime
to become negative, because _u implied that it should be unsigned
integer and negative numbers were out of range. Using
i32.trunc_f32_s fixed this.
2024-04-08 20:06:20 +03:00
[email protected]
f074c392f6
docs: add anticore to contributors
2024-04-08 19:05:20 +03:00
[email protected]
6d4529971c
feat(vm/compiler): export su_power function in case user needs it
2024-04-05 15:49:00 +03:00
[email protected]
beb84d7652
fix(tracker/gioui): deleting a cell in the order list did not work
2024-03-14 20:37:09 +02:00
[email protected]
c55b27b23b
fix(tracker): recording creates empty track when no notes triggered
2024-03-10 20:01:13 +02:00
[email protected]
e488cd391b
fix(gioui): scroll wheel works in tables, not just table row titles
2024-03-02 00:40:06 +02:00
[email protected]
7f20bd8baf
fix(tracker): remember to tell player when m.d.Loop is updated
2024-03-01 23:54:19 +02:00
[email protected]
07bf8f6cdf
fix(gioui): draw cursor in front of play marker in order editor
2024-03-01 23:31:05 +02:00
[email protected]
f0f391356c
fix(gioui): arrow keys leave table row/col titles
2024-03-01 23:25:30 +02:00
[email protected]
b18a284252
feat(gioui): + and - keys add/subtract elements in tables
...
Closes #65 .
2024-03-01 22:43:27 +02:00
[email protected]
1c020fffa3
refactor(gioui): update gioui to v0.5.0
2024-03-01 22:11:44 +02:00
[email protected]
267973e061
build: upgrade deprecated actions and fix warnings
2024-02-24 19:06:42 +02:00
[email protected]
6b3aaf6cc9
docs: update README.md
2024-02-24 15:34:40 +02:00
[email protected]
dfc72cd2c4
build: build VSTi instrument binaries also for linux
2024-02-23 20:15:44 +02:00
[email protected]
8a9cbdea62
build: update vst2 to latest version, because it compiles on linux
2024-02-23 19:56:09 +02:00
[email protected]
edee3452f4
feat(tracker): load presets from os.UserConfigDir()/sointu/presets/
...
This is related to #125 , but is very crude way of implementing it.
2024-02-20 20:17:59 +02:00
[email protected]
b70db4d394
docs: add links to 21 and Tausendeins
2024-02-20 19:39:32 +02:00
[email protected]
d5af39e324
docs: add link to Phosphorescent Purple Pixel Peaks
2024-02-20 19:33:46 +02:00
[email protected]
aa1b4d371b
fix(tracker): notify player that loop changed when resetting song
2024-02-20 19:28:59 +02:00
[email protected]
dc12f58082
feat(tracker): add ability to loop part of song during playback
...
Closes #128 .
2024-02-20 19:10:15 +02:00
[email protected]
aa7a2e56fa
feat(gioui): flip the unit parameter slider scroll wheel behaviour
...
Closes #112 .
2024-02-19 21:49:51 +02:00
[email protected]
17312bbe4e
feat: add ability to disable units temporarily
...
Quite often the user wants to experiment what particular unit(s) add
to the sound. This commit adds ability to disable any set of units
temporarily, without actually deleting them. Ctrl-D disables and
re-enables the units. Disabled units are considered non-existent in
the patch.
Closes #116 .
2024-02-19 21:36:14 +02:00
[email protected]
2b3f6d8200
fix(tracker): unit searching to work more reliably
2024-02-17 20:54:46 +02:00
[email protected]
db6c9f6052
fix: warn user if sample rate other than 44100 Hz
...
Closes #129 .
2024-02-17 19:45:36 +02:00
[email protected]
954b306cc8
docs: update CHANGELOG.md to have links to issues
2024-02-17 19:22:14 +02:00
[email protected]
aec756f921
feat(sointu-track): accept filename as command line parameter
...
Closes #122 .
2024-02-17 19:17:47 +02:00
[email protected]
ca4a98eb50
fix(gioui): reduce the default height of popup menus so they fit
...
Closes #121 .
2024-02-17 19:03:49 +02:00
[email protected]
65cfcb045c
build: update setup-go to v5 and ask go version >=1.21.0
2024-02-17 18:28:25 +02:00
[email protected]
bb32403c78
build: require go 1.21 as it is needed by slices package
2024-02-17 18:22:31 +02:00
[email protected]
d92426a100
feat!: rewrote the GUI and model for better testability
...
The Model was getting unmaintanable mess. This is an attempt to refactor/rewrite the Model so that data of certain type is exposed in standardized way, offering certain standard manipulations for that data type, and on the GUI side, certain standard widgets to tied to that data.
This rewrite closes #72 , #106 and #120 .
2024-02-17 18:16:06 +02:00
[email protected]
6d3c65e11d
fix(templates): avoid clobbering ebx in su_load_gmdls
...
Fixes #130
2024-02-16 20:09:20 +02:00
[email protected]
c08a319eb7
docs: add link to NR4's tool
2023-11-20 08:55:22 +02:00
[email protected]
8227691523
test: the filenames of test_gain and test_gain_stereo were flipped
2023-10-23 22:05:28 +03:00
[email protected]
04fbc9f6a7
feat(vm): add dbgain unit, where gain is defined in decibels
...
Closes #78
2023-10-23 21:57:29 +03:00
[email protected]
f698986718
docs: update CHANGELOG.md
2023-10-23 18:22:15 +03:00
[email protected]
a38a0f4235
fix(tracker/gioui): text.Shaper should not be a global variable
...
text.Shaper is not thread safe, which caused crash when adding
multiple VSTI plugins to a DAW project. This change fixes that
crash. Further refactorings need to consider where that text.Shaper
should actually reside.
2023-10-22 19:10:24 +03:00
[email protected]
3c85f1155c
perf(cmd/sointu-vsti): avoid reallocations of events array
...
Always appending to the end and consuming from the front cause the
capacity of the slice regularly running out, resulting in new
allocation. With this change, we increment index when consuming
events and append to the end, and when we reset, we move index to 0
and empty slice. This way, we always reuse the allocated memory.
2023-10-21 10:47:26 +03:00
[email protected]
1040eb585d
build: require go 1.19; did not build on go 1.18
2023-10-21 00:11:58 +03:00
[email protected]
6eb025d7ba
refactor(tracker): remove unused variable RECOVERY_FILE
2023-10-20 18:41:21 +03:00
[email protected]
9ec8f48f82
feat(tracker): move unnecessary members from modelData to Model
2023-10-20 17:59:27 +03:00
[email protected]
391b14493c
feat(tracker): undo entire modelData, not just Song
...
The modelData is moving towards clear meaning: it's the part of the
GUI state that is undone and also recovered from disk. This changes
the recovery data so that the undo and redo stacks are not undone,
but that is unlikely a good idea anyway, as it grows the recovery
data into unreasonable sizes.
This has also the nice benefit of undoing the cursor position, which
closes #64 .
2023-10-20 17:59:26 +03:00
[email protected]
486bab4185
style(tracker): rename NUM_RENDER_TRIES to numRenderTries
2023-10-20 16:38:44 +03:00
[email protected]
1e47c5004c
style(tracker): remove unused PlayerPlayingMessage type
2023-10-20 16:37:19 +03:00
[email protected]
900f1611b1
docs(tracker): add go doc comments to GmDlsEntry/-Entries
2023-10-20 16:36:09 +03:00
[email protected]
beb06727b0
refactor: move UnitNames to top level package
2023-10-20 01:59:30 +03:00
[email protected]
b6ec5d1a04
style(tracker): group code into less number of files
2023-10-20 01:50:38 +03:00
[email protected]
ff8e662857
refactor(tracker): move NoteStr and NoteAsValue to gioui package
2023-10-20 01:40:14 +03:00
[email protected]
a60814bab7
refactor(tracker): make struct to hold all per voice data in Player
2023-10-20 01:26:41 +03:00
[email protected]
0ce5ca3003
refactor(tracker): send Songs/Patches etc. from Model to Player
2023-10-20 00:54:03 +03:00
[email protected]
14a0306064
docs(tracker): add go doc comments to Player
2023-10-19 23:28:57 +03:00
[email protected]
d342fb860b
refactor(tracker): put all recording data into struct Recording
2023-10-19 23:28:57 +03:00
[email protected]
453f45c48a
refactor(tracker): rename SongPoint to ScorePoint etc.
2023-10-19 22:28:44 +03:00
[email protected]
50ccfe03da
refactor(tracker): split Volume to PeakVolume and AverageVolume
2023-10-19 22:28:44 +03:00
[email protected]
1a8a317464
docs(tracker): improve package go doc comments
2023-10-19 22:28:44 +03:00
[email protected]
a9517f1511
docs: make the list of prods using sointu a markdown list
2023-10-19 14:30:01 +03:00
[email protected]
9073adadb3
fix(tracker/gioui): scroll bars move in sync with the cursor
2023-10-19 14:25:03 +03:00
[email protected]
b772940b1f
fix(tracker/gioui): preset menu scrollbar fits on screen
2023-10-19 14:22:19 +03:00
[email protected]
d6abb14b08
feat(tracker/gioui): add scrollbars to menus
2023-10-19 14:07:09 +03:00
[email protected]
64270eaf68
refactor: rename FindSendTarget to FindUnit
2023-10-19 13:31:34 +03:00
[email protected]
43707e5fd6
style(vm): group public/private member types; delete unused types
2023-10-19 13:07:24 +03:00
[email protected]
fdad626279
style(vm): replace sointu.Unit{...} with {...} when allowed
2023-10-19 13:00:34 +03:00
[email protected]
960bddfae0
refactor(vm): use vm.GoSynther{}.Synth instead of vm.Synth
...
vm.Synth was used only in a few places, reduce the number of
exported functions. Also, if we ever add some global configuration
to GoSynther e.g. samplerate, we have a mechanism to do so, instead
of the Synth function.
2023-10-19 12:52:05 +03:00
[email protected]
7675121a78
style(vm): group public/private member types and rename privates
2023-10-19 12:47:38 +03:00
[email protected]
e28891abd5
refactor: move ConstructPatterns into compiler package
...
ConstructPatterns was never used except during compilation, so it
makes sense to have it closer where it is used. We could consider
making it even private function, as the pattern table construction
is quite specific to how compiler compiles and probably not that
reusable elsewhere.
2023-10-19 12:38:18 +03:00
[email protected]
e010b2da9d
docs: improve go doc comments for vm package
2023-10-19 11:54:12 +03:00
[email protected]
98a73795c7
style: move Play and Synth to audio.go
...
With this grouping, everything that deals with AudioBuffers is in
Audio. song.go and patch.go do not know anything about AudioBuffers
or Synths.
2023-10-19 11:32:30 +03:00
[email protected]
5bbec75120
refactor: rename sointu.Render as AudioBuffer.Fill
...
The Render name misleading as it did not do the same thing as normal
Synth.Render, because it disregarded time limits. Conceptually, as
the function modifies the state of the synth, it would be better to
be synth.Fill(audioBuffer), but we cannot define methods on
interfaces; therefore, it is audioBuffer.Fill(synth) now.
2023-10-19 11:14:44 +03:00
[email protected]
ff4155a08e
fix(tracker): notify player when recovery file is loaded
2023-10-19 10:59:07 +03:00
[email protected]
15a340317f
docs: add go doc comments to 4klang conversion functions
2023-10-19 10:52:52 +03:00
[email protected]
b6815f70cb
feat: remove unreleased parameter from Play function
...
The VMs now release all envelopes by default, so this mechanism was
useless / did not actually start them as unreleased even when you
thought they did.
2023-10-19 10:42:20 +03:00
[email protected]