Albert Astals Cid
bff22e2a76
GIT_SILENT Upgrade Qt5 version requirement to 5.11.0.
2019-07-04 19:23:58 +02:00
l10n daemon script
0196444a99
GIT_SILENT Upgrade ECM and KF5 version requirements for 5.59.0 release.
2019-06-01 16:38:28 +00:00
l10n daemon script
90f340df24
GIT_SILENT Upgrade ECM and KF5 version requirements for 5.58.0 release.
2019-05-04 22:44:00 +00:00
Albert Astals Cid
1a9b5d6cb6
tga: don't try to read more than max_palette_size into palette
2019-05-01 01:51:42 +02:00
Albert Astals Cid
96b1d7e7bc
tga: memset dst if read fails
2019-05-01 01:51:39 +02:00
Albert Astals Cid
bcce48012e
tga: memset the whole palette array, not only the palette_size
2019-05-01 01:44:47 +02:00
Albert Astals Cid
0db5c89c5f
Initialize the unread bits of _starttab
...
oss-fuzz #14446
2019-04-25 23:08:17 +02:00
Albert Astals Cid
6fea48c4ee
xcf: Fix uninitialized memory use on broken documents
...
oss-fuzz #14312
2019-04-17 20:09:49 +02:00
Albert Astals Cid
645daec1ef
ras: Don't overread input on malformed files
2019-04-17 20:03:52 +02:00
Albert Astals Cid
aaa285a3b9
xcf: layer is const in copy and merge, mark it as such
2019-04-17 17:37:28 +02:00
Albert Astals Cid
35e64c44d8
No & is a bit faster here
2019-04-17 17:37:28 +02:00
Albert Astals Cid
26b796f67d
const & is a bit faster here
2019-04-17 17:37:28 +02:00
Albert Astals Cid
4692a34a1c
QStringLiteral is a bit faster here
2019-04-17 17:37:28 +02:00
l10n daemon script
c0656c5181
GIT_SILENT Upgrade ECM and KF5 version requirements for 5.57.0 release.
2019-04-07 07:18:46 +00:00
Albert Astals Cid
83d1ca90d9
Fix compilation
...
Summary:
Seems only gcc can do a constexpr with strlen.
This fixes the build with clang, hopefully to with MSVC?
Reviewers: svuorela
Reviewed By: svuorela
Subscribers: svuorela, apol, pino, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20149
2019-03-31 22:18:16 +02:00
Albert Astals Cid
fd4fb6f596
ora:kra: qstrcmp -> memcmp
...
i..e don't check strings but memory
Makes oss-fuzz happier.
Reviewers: svuorela
Reviewed By: svuorela
Subscribers: apol, pino, security-team, rempt, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20143
2019-03-31 21:32:07 +02:00
Albert Astals Cid
a24ece396a
autotests: Also exercise canRead
2019-03-31 20:58:26 +02:00
Albert Astals Cid
9fc6967f4f
Fix RGBHandler::canRead
...
Summary:
As one can see in SGIImage::readImage the accepted images are
_stream >> u16;
if (u16 != 0x01da) {
return false;
}
_stream >> _rle;
if (_rle > 1) {
return false;
}
so not only \x01\xda\x01 but also \x01\xda\x00
Reviewers: svuorela
Reviewed By: svuorela
Subscribers: svuorela, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D20145
2019-03-31 19:44:21 +02:00
Albert Astals Cid
bd704045e6
xcf: Don't crash with files with unsupported layer modes
2019-03-31 01:35:33 +01:00
Laurent Montel
af7a89fea7
GIT_SILENT: add gitignore
2019-03-04 07:03:36 +01:00
l10n daemon script
5989bba56a
GIT_SILENT Upgrade ECM and KF5 version requirements for 5.56.0 release.
2019-03-02 13:27:12 +00:00
Albert Astals Cid
20100a1e0e
ras: fix crash on broken files
...
Replace QVector::operator[] with QVector::value() since we can't know for
sure the values will be on range so use value() that gives us a 0 if the
index is not on range
oss-fuzz/13462
2019-03-01 23:33:35 +01:00
Laurent Montel
297b168a52
Use auto here too
2019-02-28 23:03:25 +01:00
Laurent Montel
f1c6c15b06
compile without foreach
...
Summary: compile without foreach
Reviewers: dfaure, apol
Reviewed By: apol
Subscribers: apol, kde-frameworks-devel
Tags: #frameworks
Differential Revision: https://phabricator.kde.org/D19317
2019-02-28 23:02:41 +01:00
Albert Astals Cid
156bac5e54
ras: protect the palette QVector too
...
oss-fuzz/13068
2019-02-13 23:50:36 +01:00
Albert Astals Cid
d79c11d280
ras: tweak max file check
...
better to do - 32 than + 32 otherwise we may overflow
oss-fuzz/13017
2019-02-11 22:57:33 +01:00
Albert Astals Cid
aeec934839
xcf: Fix uninitialized memory use on broken documents
...
oss-fuzz/12871
2019-02-08 23:27:03 +01:00
Albert Astals Cid
0c4f2f8e62
add const, helps understand the function better
2019-02-08 23:07:56 +01:00
Albert Astals Cid
4a8da73f0e
ras: tweak max size that "fits" in a QVector
...
oss-fuzz/12951
2019-02-07 22:14:22 +01:00
Albert Astals Cid
039d7d8fbe
ras: don't assert because we try to allicate a huge vector
...
oss-fuzz/12915
2019-02-06 22:06:58 +01:00
Albert Astals Cid
b072484dbb
ras: Protect against divide by zero
...
oss-fuzz/12905
2019-02-05 19:51:24 +01:00
Albert Astals Cid
bad90cea4b
xcf: Don't divide by 0
...
oss-fuzz/12815
2019-02-03 14:06:33 +01:00
Albert Astals Cid
a51cbd865f
tga: fail gracefully if readRawData errors
...
oss-fuzz/12818
2019-02-03 13:49:11 +01:00
Albert Astals Cid
1a31500e55
ras: fail gracefully on height*width*bpp > length
...
oss-fuzz/12822
2019-02-03 13:38:44 +01:00
l10n daemon script
dd95a5bd0e
GIT_SILENT Upgrade ECM and KF5 version requirements for 5.55.0 release.
2019-02-02 17:22:00 +00:00
Albert Astals Cid
8d0b625538
xcf: Fix fix for opacity being out of bounds
...
If max opacity is 255 we want the min between opacity and 255 and not the max
2019-02-01 11:30:28 +01:00
Albert Astals Cid
8e48d67568
Uncomment the qdebug includes
...
i've wasted enough time uncommenting and commenting them again
2019-01-31 01:37:09 +01:00
Albert Astals Cid
8b8330b0fe
tga: Fix Use-of-uninitialized-value on broken files
...
oss-fuzz/12776
2019-01-31 01:35:39 +01:00
Albert Astals Cid
e7f3c0be44
max opacity is 255
...
Fixes oss-fuzz/12782
2019-01-31 01:25:38 +01:00
Albert Astals Cid
c3152506e2
xcf: Fix assert in files with two PROP_COLORMAP
...
It's most probably a broken file but better if we don't assert ^_^
oss-fuzz/12780
2019-01-31 01:19:52 +01:00
Albert Astals Cid
de7a9a8457
ras: Fix assert because of ColorMapLength being too big
...
oss-fuzz/12785
2019-01-31 01:03:17 +01:00
Albert Astals Cid
c2d2a9be66
pcx: Fix crash on fuzzed file
...
oss-fuzz/12784
2019-01-31 00:56:25 +01:00
Albert Astals Cid
4ee92527c4
xcf: Implement robustness for when PROP_APPLY_MASK is not on the file
...
fixes oss-fuzz/12754
2019-01-29 22:34:04 +01:00
Albert Astals Cid
1bad780baa
xcf: loadHierarchy: Obey the layer.type and not the bpp
...
Otherwise we end up doing uninitialized memory reads on broken/fuzzed
files
oss-fuzz/12761
2019-01-29 20:36:15 +01:00
Albert Astals Cid
18e17d3a7a
tga: Don't support more than 8 alpha bits
...
Fixes undefined left shift with negative values
oss-fuzz/12764
2019-01-29 12:39:52 +01:00
Albert Astals Cid
e34f53d6ae
ras: Return false if allocating the image failed
...
Probably because it's too huge
2019-01-29 12:32:23 +01:00
Albert Astals Cid
6dcea7fd01
rgb: Fix integer overflow in fuzzed file
...
oss-fuzz/12763
2019-01-29 11:19:58 +01:00
Albert Astals Cid
4751e897ce
rgb: Fix Heap-buffer-overflow in fuzzed file
...
oss-fuzz/12757
2019-01-29 10:54:25 +01:00
Albert Astals Cid
ac725cca68
psd: Fix crash on fuzzed file
...
oss-fuzz/12752
2019-01-29 10:53:30 +01:00
Albert Astals Cid
f61d64e0e5
xcf: Initialize x/y_offset
...
https://gitlab.gnome.org/GNOME/gimp/raw/master/devel-docs/xcf.txt
When reading old XCF files that lack this property, assume (0,0).
2019-01-28 21:51:10 +01:00