d869e1230b
ConcurrentQueueTest::randomCalls() built in Debug mode often crashes when concurrent_queue_test.cpp is modified and ConcurrentQueueTest is launched from Qt Creator so that the test is built and immediately run. The crash is an assertion failure that occurs most of the time under the described circumstances at different test data rows: void YACReader::ConcurrentQueue::finalizeJobs(int): Assertion `jobsLeft >= count' failed. The assertion fails because ConcurrentQueue::enqueue() adds a job into the queue first and then increments jobsLeft. If the job is immediately picked up and executed very fast, ConcurrentQueue::nextJob() can try to finalize it before enqueue() increments jobsLeft. Simply reordering the modifications of jobsLeft and _queue in enqueue() ensures that jobsLeft is always non-negative and eliminates the assertion failures. Note that ConcurrentQueue::finalizeJobs() is the only other function that modifies (decreases) jobsLeft. finalizeJobs() is always called *after* the queue's size is reduced. So the following invariant is now maintained at all times and documented: jobsLeft >= _queue.size().
| Build | Master | Develop |
|---|---|---|
| Code Validation | ||
| Linux | ||
| Windows x86 | ||
| Windows x64 | ||
| MacOS | ||
| Publish Build |
YACReader
"Yet another comic reader"
License
This software has been developed by Luis Ángel San Martín Rodríguez (luisangelsm@gmail.com) under GPL v3 license (see COPYING.txt).
Getting YACReader
Official releases:
https://github.com/YACReader/yacreader/releases
As a package:
From OBS build service:
Building from source:
See INSTALL.md
Contact
- Project home page : www.yacreader.com
- e-mail:
- Social:
- Facebook - http://www.facebook.com/YACReader
- Twitter - https://twitter.com/yacreader
- YouTube - https://www.youtube.com/user/yacreader
- Instagram - https://www.instagram.com/yacreader/
If you need help or have any suggestion, please, send me an e-mail.
Contributing
If you are interested in contributing to the project the first step should be to contact me so we can plan together the best approach, you can send an e-mail or just open an issue in this repo. For small bug fixes it is usually ok to open a PR directly.
Contributions are not restricted to code, you can help the project by bringing new UI/UX ideas, designing new assets, writing manuals or tutorials, translating the apps, etc. If you are interested in DevOps, YACReader uses Azure Pipelines for CI/CD, any improvements in that area are welcome. Testing pre-releases is also really appreciated.
Code
YACReader uses clang-format to ensure a common style and avoid deviances from it. CI checks this and will fail if the correct format is not used. clang-format needs to be called recursively in all the folders because some of them have the own .clang-format file, mainly to exclude changing the format in third-party libraries which are included in the source code. I recommend to configure your development tools to use clang-format, you can try to use it manually, but please, do it always before committing changes. I recommend using QtCreator configured properly, you can find a tutorial here.
CI/CD
Any PR will be validated through CI, and it will not be merged if CI fails.
Pull Requests
The base and target branch for any PR should always be develop.
Donations
YACReader is free but it needs money to keep being alive, so please, if you like YACReader, visit the home page and make a donation.