mirror of
https://github.com/YACReader/yacreader
synced 2025-05-28 03:10:27 -04:00
bb964c8566
GoToFlow shared its YACReaderFlow flow object with SlideInitializer
objects it created. GoToFlow modified the flow object in the main thread
and SlideInitializer modified the flow object in its own thread without
any thread synchronization. The only reason this usually worked was the
timing: SlideInitializer finished its work before the next time GoToFlow
heavily accessed the flow object. This was a data race and thus
undefined behavior.
Additionally, this commit eliminates a memory leak:
a new SlideInitializer object was constructed each time a comic was
opened in YACReader. These objects were never destroyed.
SlideInitializer called PictureFlow::triggerRender() from its own
thread. This function restarted triggerTimer, which QTimer's API forbids
doing from another thread. This commit eliminates the following errors
from YACReader's standard output:
QObject::killTimer: Timers cannot be stopped from another thread
QObject::startTimer: Timers cannot be started from another thread
Without this fix YACReader on GNU/Linux often uses an entire CPU core
from launch till exit if hardware acceleration is disabled (#56).
The data race could alternatively be fixed by adding thread
synchronization code into most GoToFlow member functions. But the code
in SlideInitializer::run() is executed only once per opened comic; it is
not slow enough to justify creating a dedicated thread and suffer the
overhead of thread synchronization while the comic is being read.
I have tested several 550 pages long 1 GB comic books.
SlideInitializer::run() took up to 25 milliseconds in the worst case,
but usually 2-4 times less. For smaller 30-page comics it usually takes
less than a millisecond.
Even though mutexGoToFlow was locked in SlideInitializer::run(), there
is no need to lock it in the code moved to GoToFlow::setNumSlides():
this function is called in the main thread like all the other GoToFlow's
member functions that access the flow object. PageLoader does not have
access to the flow object.
|
||
|---|---|---|
| common | ||
| compressed_archive | ||
| custom_widgets | ||
| dependencies | ||
| files | ||
| images | ||
| QsLog | ||
| release | ||
| shortcuts_management | ||
| tests/compressed_archive_test | ||
| YACReader | ||
| YACReaderLibrary | ||
| YACReaderLibraryServer | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| .travis.yml | ||
| appveyor.yml | ||
| background.png | ||
| CHANGELOG.md | ||
| cleanOSX.sh | ||
| compileOSX.sh | ||
| config.pri | ||
| COPYING.txt | ||
| icon.icns | ||
| INSTALL.md | ||
| mktarball.sh | ||
| README.txt | ||
| releaseOSX.sh | ||
| YACReader.1 | ||
| YACReader.desktop | ||
| YACReader.pro | ||
| YACReader.svg | ||
| YACReaderLibrary.1 | ||
| YACReaderLibrary.desktop | ||
| YACReaderLibrary.svg | ||
LICENSE ******* This software has been developed by Luis Ángel San Martín Rodríguez (luisangelsm@gmail.com) under GPL v3 license (for more details read COPYING.txt). CONTACT ******* Project home page : www.yacreader.com e-mail: info@yacreader.com support@yacreader.com Social: Facebook - http://www.facebook.com/YACReader Twitter - https://twitter.com/yacreader YouTube - https://www.youtube.com/user/yacreader If you need help or have any suggestion, please, send me an e-mail. DONATIONS ********* YACReader is free but it needs money to still be alive, so please, if you like YACReader, visit the home page and make a donation.