Commit Graph

543 Commits

Author SHA1 Message Date
Luis Ángel San Martín
f875e7d304 Disable sort includes in the folders where clang format is disabled
For me this is a bug, DisableFormat should stop any kind of changes.
2019-08-24 11:11:52 +02:00
Luis Ángel San Martín
607b7b4d6f Remove QMAKE_MAC_SDK from all projects 2019-08-24 11:11:50 +02:00
Luis Ángel San Martín
fafcfdd2dc Give the OK to the connection asap 2019-08-24 11:07:36 +02:00
Luis Ángel San Martín
4f4c562a33 Add setting to disable the continue reading banner in the grid view 2019-08-11 11:47:14 +02:00
Luis Ángel San Martín
901d0ab03a Fix Potential fix for GridComicsView in Qt 13 2019-08-11 10:15:44 +02:00
Luis Ángel San Martín
4126fc71c3 Remove unused variables 2019-06-01 16:04:48 +02:00
Luis Ángel San Martín
f29724e404 Annotate overridden methods 2019-06-01 16:04:48 +02:00
Luis Ángel San Martín
e2276cbc1c More auto 2019-06-01 16:04:48 +02:00
Luis Ángel San Martín
268bebbddd Use nullptr instead of 0 2019-06-01 16:04:48 +02:00
Luis Ángel San Martín
bb334cfd50 Use auto to avoid duplicating the type name 2019-06-01 16:04:48 +02:00
Luis Ángel San Martín
e3ec56aa43 Format code using clang-format 2019-05-30 19:46:37 +02:00
Luis Ángel San Martín
8b54744723 Add .clang-format files
Third party code should be excluded from automatic formating: QsLog and QtWebApp
2019-05-30 18:58:54 +02:00
Luis Ángel San Martín
ca34e99ec4
Merge pull request #57 from vedgy/misc-code-fixes
Miscellaneous code fixes
2019-05-30 18:24:53 +02:00
Luis Ángel San Martín
6c628318fe
Merge pull request #54 from vedgy/fix-crash-at-exit
Library: fix a crash at exit when server is disabled
2019-05-30 18:22:06 +02:00
Luis Ángel San Martín
7b712e144a
Merge pull request #53 from selmf/light_gl_flow_refactoring
Light gl flow refactoring
2019-05-30 18:21:05 +02:00
Jeremy Douglass
6f2a4bf243 Add Up Down navigation to FlowView
Adds vertical navigation (up down) to FlowView. This corresponds visually to the File Name list display -- especially when the flow pane is hidden, pressing up-down is the intuitive way to navigate up-down in the list.
2019-05-30 18:15:33 +02:00
Igor Kushnir
c1810b9e54 Library: do not needlessly retrieve all comics from the DB
The siblings variable is unused. So the ComicModel::getAllComics() call
is redundant unless there is some unobvious side effect (I hope not).
2019-05-24 14:53:52 +03:00
Igor Kushnir
92cf54980c Library: eliminate QPainter warnings
There were many run-time warnings in YACReaderLibrary built in Debug
mode with hardware acceleration disabled and with ClassicComicsView
as the active comics view:
    QWidget::paintEngine: Should no longer be called
    QPainter::begin: Paint device returned engine == 0, type: 1

The ComicFlowWidgetSW::paintEvent() implementation now corresponds to
ComicFlowWidgetGL::paintEvent(), which has been fixed earlier.

QWidget::repaint() calls paintEvent() immediately.
PictureFlow::paintEvent() calls d->renderer->paint(). So the
d->renderer->paint() call in PictureFlow::updateMarks() was redundant.
2019-05-22 17:37:04 +03:00
Igor Kushnir
8522b11e37 Library: fix a crash at exit when server is disabled
Startup::stop() called from LibraryWindow::closeEvent() crashes if
listener is not initialized.
2019-05-19 13:50:53 +03:00
Felix Kauselmann
caca3191f9 Flow: Remove glu dependency 2019-05-06 07:38:33 +02:00
Luis Ángel San Martín
eeb303a5c1 Avoid parsing non supported dates from comic vine 2019-04-28 09:30:15 +02:00
Luis Ángel San Martín
44db4397e8 Avoid parsing null values from comic vine 2019-04-28 09:28:50 +02:00
Luis Ángel San Martín
54a0610a06 Fix out of bounds crash 2019-04-28 09:28:15 +02:00
François Gannaz
8c8521a8dc Library: reorder initialization of ResponseParser 2019-04-01 11:25:16 +02:00
François Gannaz
ebcb52bf16 Library: bugfix a 'switch case' that had no 'break' 2019-04-01 11:25:16 +02:00
François Gannaz
0453bf126a Library: unused method parameter, so comment out the name 2019-04-01 11:25:16 +02:00
François Gannaz
9aff260f06 Library: unused method parameter, so comment out the name 2019-04-01 11:25:16 +02:00
François Gannaz
6467e2a510 Library: unused method parameter, so comment out the name 2019-04-01 11:25:16 +02:00
François Gannaz
3657745f8b Library: reorder initialization of YACReaderHttpSession 2019-04-01 11:25:16 +02:00
François Gannaz
8fa62c3a20 Library: unused method parameter, so comment out the name 2019-04-01 11:25:16 +02:00
François Gannaz
7cb57d886a Library: fix misleading indentation 2019-04-01 11:25:16 +02:00
François Gannaz
f351e41fa0 Library: add missing 'case' to a 'switch' 2019-04-01 11:25:16 +02:00
François Gannaz
11c99efa30 Library: explicit braces to avoid ambiguous 'else' (hidden in macro) 2019-04-01 11:25:16 +02:00
François Gannaz
62db328ab5 Library: explicit braces to avoid ambiguous 'else' 2019-04-01 11:25:16 +02:00
François Gannaz
20bcd2235a Library: explicit braces to avoid ambiguous 'else' 2019-04-01 11:25:16 +02:00
François Gannaz
6f9d03847a Library: typecast in comparison of int and long u int 2019-04-01 11:25:16 +02:00
François Gannaz
5927b1be45 Library: remove unused variables (shadowed by object attributes) 2019-04-01 11:25:16 +02:00
François Gannaz
6093e003e9 Library: add missing 'default' to non-exhaustive 'switch' 2019-04-01 11:25:16 +02:00
François Gannaz
b77eaf6d9c Library: reorder initialization of FolderModel 2019-04-01 11:25:16 +02:00
François Gannaz
9c3720ceb9 Library: fix misleading indentation 2019-04-01 11:25:16 +02:00
François Gannaz
fb97cfa1dc Library: explicit {} on ambiguous 'if if else' 2019-04-01 11:25:16 +02:00
François Gannaz
2189e19a91 Library: fix misleading indentation 2019-04-01 11:25:16 +02:00
François Gannaz
3babc0980e Library: remove unused variable 2019-04-01 11:25:16 +02:00
François Gannaz
66941510f0 Library: fix misleading indentation 2019-04-01 11:25:16 +02:00
François Gannaz
2274e49ed0 Library: fix misleading indentation 2019-04-01 11:25:16 +02:00
François Gannaz
c044e93446 Library: typecast in comparison of int and quint64 2019-04-01 11:25:16 +02:00
François Gannaz
f7b4b7a5d1 Library: add missing 'case' to a 'switch' 2019-04-01 11:25:16 +02:00
François Gannaz
3062d8826e Library: reorder initialization of LibraryWindow 2019-04-01 11:25:16 +02:00
Luis Ángel San Martín
c2fdcfde00
Merge pull request #30 from jlesage/fix-stack-overflow
Fixed potential stack overflow.
2019-02-18 17:19:50 +01:00
Luis Ángel San Martín
88f886078f
Merge pull request #4 from selmf/qquickwidget-port
Qquickwidget port
2019-02-18 17:18:00 +01:00
Jocelyn Le Sage
b3583b9bf3 Fixed potential stack overflow. 2018-09-01 08:10:18 -04:00
votagif
d13d85c6a4
Update yacreaderlibrary_ru.ts
Text correction, minor corrections.
2018-08-25 07:49:51 +03:00
Felix Kauselmann
097f4f1445 Fix qml qrc files 2018-08-15 14:43:14 +02:00
Felix Kauselmann
7bfb42be24 rating menu: Remove unneeded qml files 2018-08-11 11:34:12 +02:00
Felix Kauselmann
833e501d7c Remove redundant MenuBar in GridComicsView.qml to avoid crashes on macOS
This fix was originally proposed by @ShawnCarnell on YACReader's old
Bitbucket repository.
2018-08-11 11:31:13 +02:00
Felix Kauselmann
02eda8eeb5 Use QQuickWidget instead of QQuickView to avoid displacement bugs on Windows and Linux 2018-08-11 11:26:12 +02:00
Felix Kauselmann
ab96056b0e Normalize line endings
Normalize the line endings for a bunch of files previously not covered 
by .gitattributes.
2018-08-07 11:09:02 +02:00
Felix Kauselmann
d3b8f4d5b8 Normalize line endings for .qml files 2018-08-05 13:14:30 +02:00
Felix Kauselmann
0e9a3a6407 Stop QtWebApp from eating out debug messages
QtWebapp installs a custom logger/message handler which reroutes all
debug messages to it's custom logger class.

As the default logging level for QtWebApp's logger is set to "critical"
this means that all debug messages are sent to nirvana. Solution:
Replace QtWebApp's messageHandler with our own (using QsLog).
2018-08-04 12:31:34 +02:00
Felix Kauselmann
3530528282 Add a commandline option to set YACReaderLibrary opengl renderer on windows. 2018-08-04 12:31:34 +02:00
Felix Kauselmann
afad6c7ab7 Add parser option for setting loglevel to YACReaderLibrary and YACReaderLibraryServer 2018-08-04 12:31:34 +02:00
Felix Kauselmann
d5a11fb16b Add .gitattributes rules for text and binary handling 2018-07-30 15:04:04 +02:00
Luis Ángel San Martín
6538d418c7 Update translations. 2018-06-16 08:28:50 +02:00
toto
06246e34d3 ComicInfoView translation
Add translation to ComicInfoView.qml
2018-06-14 22:35:34 +02:00
toto
0b552bc726 Translate
French translation
2018-06-14 22:35:34 +02:00
Luis Ángel San Martín
8921b016a5 Avoid null values for issues' title coming from Comic Vine 2018-05-31 18:31:32 +02:00
Luis Ángel San Martín
1a91206a2d
Merge branch 'develop' into 9.5.0_bugfixes 2018-05-31 18:12:52 +02:00
Luis Ángel San Martín
229afbc9a9 Fix crash caused by accessing the UI thread from a background thread.
ComicVineDialog was calling close from background, plus accepted is emmited from a background thread, so it needs a QueuedConnection.
2018-05-31 18:09:41 +02:00
Luis Ángel San Martín
26c2226032 Change endpoints for getting comic info and opening a comic. 2018-05-30 19:23:39 +02:00
Luis Ángel San Martín
0100da5480 Make comicdownloadinfocontroller_v2 provide all the needed information. 2018-05-30 19:02:52 +02:00
Luis Ángel San Martín
dba264c31f Remove old commented code. 2018-05-29 17:12:34 +02:00
Luis Ángel San Martín
79db01cffc Do not close the connection in librariescontroller_v2 2018-05-29 17:12:22 +02:00
Luis Ángel San Martín
550795e418 Do not close the connection in covercontroller_v2 2018-05-29 17:12:09 +02:00
Luis Ángel San Martín
9cc4f65fc8 Use older api currentSecsSinceEpoch was introduced in Qt 5.8 2018-05-28 21:18:11 +02:00
Felix Kauselmann
1ccb40624c Remove potential memleak in folder model code 2018-05-26 11:32:59 +02:00
Felix Kauselmann
ca3bc94f25 Fix potential memleak caused by unused QAction pointer in SortVolumeComics 2018-05-26 11:09:28 +02:00
Felix Kauselmann
9851884021 Backport two nullpointer reference fixes from QtWebApp 1.7.4 2018-05-26 10:30:14 +02:00
Luis Ángel San Martín
1c4eb4d1c6 Fix comicRating possition after context menu workaround 2018-05-25 19:31:32 +02:00
Luis Ángel San Martín
1cd33197cc Set hasBeenOpened as true if currentPage > 1
I have seen comics opened with hasBeenOpened to false.
2018-05-25 19:28:20 +02:00
Luis Ángel San Martín
d909598732 Add missing include.
This fixes compilation windows debug.
2018-05-25 19:26:17 +02:00
Luis Ángel San Martín
786c28bba0 Add workaround for rating context menu crashing in macos
For now we will have two different versions of the rating component.
2018-05-24 19:02:01 +02:00
Luis Ángel San Martín
6faea2b5a7 Disabled minimize to system tray for now.
App icon needs some work to look ok in Windows 10 system tray and macos is not ready yet to fully support this.
2018-05-23 17:24:04 +02:00
Luis Ángel San Martín
a8655b1037 All lists should load the coverSizeRatio 2018-05-22 18:58:33 +02:00
Luis Ángel San Martín
450997762e Current comic view only makes sense for folders and reading lists. 2018-05-22 18:45:12 +02:00
Luis Ángel San Martín
4be84c6845 Set TraceLevel for logging only in debug builds. 2018-05-22 18:16:55 +02:00
Luis Ángel San Martín
66d1bd1046 Merge branch 'server_2.0' into develop 2018-05-22 18:10:24 +02:00
Luis Ángel San Martín
317f2b839f Remove setting last time opened.
The value should come from the client.
2018-05-21 23:14:51 +02:00
Luis Ángel San Martín
1b63dc01db Remove comment. 2018-05-21 23:14:12 +02:00
Luis Ángel San Martín
66aa2c60c6 Fix comparison 2018-05-21 23:14:02 +02:00
Luis Ángel San Martín
8ea201ece9 Use usigned long long to fix compiler error 2018-05-21 23:13:47 +02:00
Luis Ángel San Martín
e77d613002 Update last time opened when updating reading progress from ios client. 2018-05-21 22:13:07 +02:00
Luis Ángel San Martín
38e3b40e8f Process last time opened in sync controller 2018-05-21 22:10:53 +02:00
Luis Ángel San Martín
d6c563e881 If a comic doesn't have library and id info, then try to update the info in all the libraries. 2018-05-21 19:52:29 +02:00
Luis Ángel San Martín
6cfd09a8b8 Add method for updating reading comic information given a hash. 2018-05-21 19:51:30 +02:00
Luis Ángel San Martín
0e4ffb15a6 Fix update from remote client.
current page has to be set before checking for read.
2018-05-21 19:50:28 +02:00
Felix Kauselmann
15e5618454 Add a simple qml error logger to YACReaderLibrary 2018-05-21 15:16:20 +02:00
Luis Ángel San Martín
5c876e6785 Make YACReader send info for the next comic.
Now we can set the next comic as reading.
2018-05-20 17:43:28 +02:00
Luis Ángel San Martín
50c9238376 Only try to set the next comic as read if there is a next comic. 2018-05-20 17:42:49 +02:00
Luis Ángel San Martín
c93e86af12 Fix loading some missing fields from database 2018-05-20 15:33:11 +02:00
Luis Ángel San Martín
e405f14256 Set next comic as reading from update comic controller. 2018-05-20 14:49:32 +02:00