mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2025-05-28 03:10:27 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,216 Commits 11 Branches 36 Tags 75 MiB
be547081f2
Commit Graph

2216 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Felix Kauselmann
be547081f2 Fix huge memleak in server code caused by thread pingpong fix. 
Stopped QThreads don't process events, so cleanup signals get lost.
Prevent this from happening by keeping the threads alive and the comic
inside the thread (as we already do in the viewer). Cleanup happens by
connecting the comic's destroyed() signal to the thread's quit() slot.
 2019-09-24 08:21:14 +02:00
Felix Kauselmann
cc71f419cc Revert "Backout changeset c42e71e42d7968ddb6c63fd39011669503b9122c" 
This reverts commit 040664d3ba.
 2019-09-24 08:12:38 +02:00
Luis Ángel San Martín
68ae40fda7 Fix restoring the window from a minimized state 2019-09-22 15:04:54 +02:00
Luis Ángel San Martín
6990ba0765 Use showNormal in macos and show in other platforms 2019-09-22 13:27:06 +02:00
Luis Ángel San Martín
1ddf0038b8 Use Trigger in linux, we have seen some setups were double click is not reported 2019-09-22 13:14:02 +02:00
Luis Ángel San Martín
94d17a1d5c Use "show" instead of "showNormal" to keep maximized geometry 2019-09-22 13:08:10 +02:00
Luis Ángel San Martín
4a958b9291
Merge pull request #83 from YACReader/feature/update_check_new_version_to_use_github 
Get the latest version number from the code in master
 2019-09-22 13:00:58 +02:00
Luis Ángel San Martín
8603b8ca14 Get the latest version number from the code in master 2019-09-22 12:27:51 +02:00
Luis Ángel San Martín
eab114aa66
Merge pull request #50 from selmf/mac_tray_icon 
Minimize to tray, start to tray.
 2019-09-22 12:26:02 +02:00
Luis Ángel San Martín
fc85f77d15 Use LibraryWindow::closeApp to exit from the system tray context menu 2019-09-21 12:12:19 +02:00
Luis Ángel San Martín
9fafa06063 Move call forward 2019-09-21 12:11:56 +02:00
Luis Ángel San Martín
674fa21717 Pass a more specific instance of our main window 2019-09-21 12:11:39 +02:00
Luis Ángel San Martín
ef8216b338 Make closeApp work with no event 
And exit using QApplication.exit so we don't mess with window events to exit the app
 2019-09-21 12:11:03 +02:00
Luis Ángel San Martín
7ac331ed41 Do not force macos sdk for now 
This was commited by mistake
 2019-09-21 11:06:51 +02:00
Luis Ángel San Martín
8e99d9e59f Extract the system tray functionality to its own class 
LibraryWindow is already a monster, so we'll try to not make it bigger.
 2019-09-21 10:47:01 +02:00
Luis Ángel San Martín
3c07e7269a Update the UI string about system tray support 2019-09-21 10:45:34 +02:00
Luis Ángel San Martín
5b78ef2dae Use new property name and set false as default 2019-09-21 10:44:28 +02:00
Luis Ángel San Martín
b5f3799753 Restore the code to start the app into the system tray 2019-09-21 10:44:03 +02:00
Luis Ángel San Martín
3923da2344 Add new define to remember if we have notified the user about close to tray 2019-09-21 10:42:38 +02:00
Luis Ángel San Martín
80cd4f64f8 Rename setting 
We are going to use close to system tray instead of minimize, easier to handle it at a crossplatform level
 2019-09-21 10:42:15 +02:00
Luis Ángel San Martín
63e16e44b7 Better macos tray icon 2019-09-20 16:38:11 +02:00
Luis Ángel San Martín
403e657062 A new trayicon is needed for macos 2019-09-20 13:41:26 +02:00
Luis Ángel San Martín
6031c81d81 Add better icons for the system tray in macos and windows 
I would like to design specific icons for the system tray at some point, but for now this is what we have.
 2019-09-20 10:07:20 +02:00
Luis Ángel San Martín
4377ad935c Fixed more merge problems 2019-09-19 22:54:08 +02:00
Luis Ángel San Martín
8f845727ae Fixed more merge problems 2019-09-19 22:49:00 +02:00
Luis Ángel San Martín
a0f682be7b Merge went bad 
Hopefully this is all that got messed up
 2019-09-19 22:32:07 +02:00
Luis Ángel San Martín
a632480422 Format 2019-09-19 21:16:56 +02:00
Felix Kauselmann
e587f59ddb Add support for minimize and start to tray. 2019-09-19 20:22:14 +02:00
Luis Ángel San Martín
23c597d444
Merge pull request #82 from YACReader/feature/improve-azure-pipelines 
CI improvements
 2019-09-19 08:08:13 +02:00
Luis Ángel San Martín
122806b0e3 Booleans are True/False in azure pipelines 
We need lower case
 2019-09-18 23:26:55 +02:00
Luis Ángel San Martín
fa874ddcd1 Keep track about codesign in the logs 2019-09-18 23:26:13 +02:00
Luis Ángel San Martín
9b994bbf1e If PRs come from a fork do not codesign macos apps 
It fails in Azure Pipelines due to security reasons
 2019-09-18 22:21:05 +02:00
Luis Ángel San Martín
7618cbea73 Add support for skipping codesign in compileOSX.sh 2019-09-18 22:20:30 +02:00
Luis Ángel San Martín
8b923aeb18 Inline release script into compileOSX 2019-09-18 22:19:54 +02:00
Luis Ángel San Martín
f04bb93a42 Extract code format validation to its own job 
It makes no sense to start building things if code validation is going to fail.
 2019-09-18 21:51:01 +02:00
Luis Ángel San Martín
7fbfb961eb
Update README.md 
Update contact section to use lists

This was properly laidout before moving to markdown
 2019-09-18 18:34:25 +02:00
Luis Ángel San Martín
3f82ab2ae4
Update README.md 
Fix link in README
 2019-09-18 18:30:27 +02:00
Luis Ángel San Martín
3219d00a28
Merge pull request #67 from vedgy/goto_flow-fixes 
goto_flow fixes
 2019-09-18 18:12:29 +02:00
Igor Kushnir
6efc31682c Reader: eliminate duplicate calls to GoToFlow::preload() 
GoToFlow::setNumSlides() is called each time a comic is opened. So when
e.g. three comics were opened one after another without restarting
YACReader, each of the PictureFlow::centerIndexChanged* signals was
connected to GoToFlow::preload three times, which multiplied the number
of calls to preload() accordingly.

During my testing PictureFlow::centerIndexChanged* signals were never
emitted before the first call to GoToFlow::setNumSlides(), so connecting
in GoToFlow::GoToFlow() should not cause extra calls to preload().
 2019-09-18 18:12:03 +02:00
Igor Kushnir
28b8fca729 Reader: make PageLoader::working atomic to fix a data race 
This data member is modified in PageLoader's own thread and accessed
without locking from an external thread in the public busy() function.

Reorder setting working and img in PageLoader::run() to avoid a data
race in PageLoader::result() called from GoToFlow::updateImageData().
 2019-09-18 18:12:03 +02:00
Luis Ángel San Martín
dbcd042e6c
Merge pull request #66 from vedgy/store-geometry-in-reader-config 
Store geometry instead of pos&size in Reader config
 2019-09-18 18:11:15 +02:00
Igor Kushnir
82719573b5 Reader: store geometry instead of pos&size in Configuration 
Qt documentation recommends calling saveGeometry() in closeEvent().

This commit fixes the following bug on my GNU/Linux with Xfce system:
    1. Move the top of the YACReader window to the top of the screen.
    2. Restart YACReader (exit and run again).
    2. Enter full screen mode.
    4. Restart YACReader.
    5. Exit full screen mode.
At this point YACReader's title bar is hidden beyond the top of the
screen, i.e. the window has moved up.
 2019-09-18 18:10:40 +02:00
Igor Kushnir
eb9075c917 Reader: remove unused code from Configuration 2019-09-18 18:10:40 +02:00
Igor Kushnir
39ab598363 Reader: clean unused code up 
closeEvent is accepted by default, so this commit does not change the
application behavior. But Qt documentation recommends not relying on the
default value as subclasses may choose to clear it in their constructor.
 2019-09-18 18:10:40 +02:00
Luis Ángel San Martín
86c4b6158b
Merge pull request #65 from vedgy/add-horizontal-wheel-support 
Reader: add support for horizontal mouse wheel
 2019-09-18 17:10:29 +02:00
Igor Kushnir
8820c8769b Reader: add support for horizontal mouse wheel 
Without this commit the horizontal wheel on a two-wheel mouse acts the
same as the vertical wheel in YACReader.

horizontalScroller is used analogously to verticalScroller in
Viewer::scrollTo(). So I made the horizontal wheel work analogously to
the vertical wheel except for moving to the next or previous page.
 2019-09-18 15:32:35 +02:00
Luis Ángel San Martín
15277d00b7 README.txt has been renamed to README.md 
this fixes installing YACReader using qmake -install
 2019-09-16 23:46:26 +02:00
Luis Ángel San Martín
a6bfd44aec Remove clear from sql query 
It was committed by mistake
 2019-09-16 23:44:30 +02:00
Luis Ángel San Martín
e4dec39eaa
Merge pull request #79 from YACReader/feature/github_releases_from_azure_pipelines 
Try to do a release to github
 2019-09-16 22:33:42 +02:00
Luis Ángel San Martín
c2ef314be2 Disable adding a changelog based on commits 
It is too verbose.
 2019-09-16 21:51:02 +02:00