Merge pull request #5 from selmf/thread_ping_pong

Thread ping pong
This commit is contained in:
Luis Ángel San Martín 2019-09-24 11:45:16 +02:00 committed by GitHub
commit b906bf964f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 70 additions and 35 deletions

View File

@ -381,8 +381,8 @@ Render::Render()
Render::~Render()
{
if (comic != nullptr) {
comic->moveToThread(QApplication::instance()->thread());
if (comic != 0) {
//comic->moveToThread(QApplication::instance()->thread());
comic->deleteLater();
}
@ -607,8 +607,8 @@ void Render::setRotation(int degrees)
void Render::setComic(Comic *c)
{
if (comic != nullptr) {
comic->moveToThread(QApplication::instance()->thread());
if (comic != 0) {
//comic->moveToThread(QApplication::instance()->thread());
comic->disconnect();
comic->deleteLater();
}

View File

@ -57,9 +57,10 @@ void ComicController::service(HttpRequest &request, HttpResponse &response)
comicFile->moveToThread(thread);
connect(comicFile, SIGNAL(errorOpening()), thread, SLOT(quit()));
connect(comicFile, SIGNAL(errorOpening(QString)), thread, SLOT(quit()));
connect(comicFile, SIGNAL(imagesLoaded()), thread, SLOT(quit()));
//connect(comicFile, SIGNAL(errorOpening()), thread, SLOT(quit()));
//connect(comicFile, SIGNAL(errorOpening(QString)), thread, SLOT(quit()));
//connect(comicFile, SIGNAL(imagesLoaded()), thread, SLOT(quit()));
connect(comicFile, SIGNAL(destroyed()), thread, SLOT(quit()));
connect(thread, SIGNAL(started()), comicFile, SLOT(process()));
connect(thread, SIGNAL(finished()), thread, SLOT(deleteLater()));

View File

@ -53,23 +53,21 @@ void ComicControllerV2::service(HttpRequest &request, HttpResponse &response)
Comic *comicFile = FactoryComic::newComic(libraries.getPath(libraryId) + comic.path);
if (comicFile != nullptr) {
QThread *thread = nullptr;
thread = new QThread();
if (comicFile != NULL) {
QThread *thread = new QThread();
comicFile->moveToThread(thread);
connect(comicFile, SIGNAL(errorOpening()), thread, SLOT(quit()));
connect(comicFile, SIGNAL(errorOpening(QString)), thread, SLOT(quit()));
connect(comicFile, SIGNAL(imagesLoaded()), thread, SLOT(quit()));
//connect(comicFile, SIGNAL(errorOpening()), thread, SLOT(quit()));
//connect(comicFile, SIGNAL(errorOpening(QString)), thread, SLOT(quit()));
//connect(comicFile, SIGNAL(imagesLoaded()), thread, SLOT(quit()));
connect(comicFile, SIGNAL(destroyed()), thread, SLOT(quit()));
connect(thread, SIGNAL(started()), comicFile, SLOT(process()));
connect(thread, SIGNAL(finished()), thread, SLOT(deleteLater()));
comicFile->load(libraries.getPath(libraryId) + comic.path);
if (thread != nullptr)
thread->start();
thread->start();
if (remoteComic) {
QLOG_TRACE() << "remote comic requested";

View File

@ -234,6 +234,21 @@ void Comic::updateBookmarkImage(int index)
emit bookmarksUpdated();
//emit bookmarksLoaded(*bm);
}
if (bm->isBookmark(index)) {
QImage p;
p.loadFromData(_pages[index]);
bm->setBookmark(index, p);
emit bookmarksUpdated();
//emit bookmarksLoaded(*bm);
}
if (bm->getLastPage() == index) {
QImage p;
p.loadFromData(_pages[index]);
bm->setLastPage(index, p);
emit bookmarksUpdated();
//emit bookmarksLoaded(*bm);
}
}
//-----------------------------------------------------------------------------
void Comic::setPageLoaded(int page)
@ -378,7 +393,7 @@ bool FileComic::load(const QString &path, const ComicDB &comic)
return true;
} else {
//QMessageBox::critical(NULL,tr("Not found"),tr("Comic not found")+" : " + path);
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
return false;
}
@ -519,11 +534,32 @@ QList<QVector<quint32>> FileComic::getSections(int &sectionIndex)
sections.append(section2);
//out << "SPLIT" << endl;
idx++;
}
if (sectionIndex == sectionCount) //found
{
if (section.indexOf(realIdx) != 0) {
QVector<quint32> section1;
QVector<quint32> section2;
foreach (quint32 si, section) {
if (si < realIdx) {
section1.append(si);
} else {
section2.append(si);
}
}
sectionIndex++;
sections.append(section1);
sections.append(section2);
//out << "SPLIT" << endl;
} else {
sections.append(section);
}
} else {
sections.append(section);
}
} else {
sections.append(section);
}
//out << "se han encontrado : " << sections.count() << " sectionIndex : " << sectionIndex << endl;
@ -534,13 +570,13 @@ void FileComic::process()
{
CompressedArchive archive(_path);
if (!archive.toolsLoaded()) {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening(tr("7z not found"));
return;
}
if (!archive.isValid()) {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening(tr("Format not supported"));
return;
}
@ -551,7 +587,7 @@ void FileComic::process()
if (_fileNames.size() == 0) {
//QMessageBox::critical(NULL,tr("File error"),tr("File not found or not images in file"));
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
return;
}
@ -587,14 +623,14 @@ void FileComic::process()
for (int i = sectionIndex; i < sections.count(); i++) {
if (_invalidated) {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
return;
}
archive.getAllData(sections.at(i), this);
}
for (int i = 0; i < sectionIndex; i++) {
if (_invalidated) {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
return;
}
archive.getAllData(sections.at(i), this);
@ -609,7 +645,7 @@ void FileComic::process()
emit imageLoaded(sortedIndex);
emit imageLoaded(sortedIndex,_pages[sortedIndex]);
}*/
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit imagesLoaded();
}
@ -664,7 +700,7 @@ void FolderComic::process()
if (nPages == 0) {
//TODO emitir este mensaje en otro sitio
//QMessageBox::critical(NULL,QObject::tr("No images found"),QObject::tr("There are not images on the selected folder"));
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
} else {
if (_firstPage == -1) {
@ -687,7 +723,7 @@ void FolderComic::process()
int i = _firstPage;
while (count < nPages) {
if (_invalidated) {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
return;
}
@ -703,7 +739,7 @@ void FolderComic::process()
count++;
}
}
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit imagesLoaded();
}
@ -742,7 +778,7 @@ bool PDFComic::load(const QString &path, int atPage)
//emit bookmarksLoaded(*bm);
return true;
} else {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
return false;
}
@ -763,7 +799,7 @@ bool PDFComic::load(const QString &path, const ComicDB &comic)
return true;
} else {
//QMessageBox::critical(NULL,tr("Not found"),tr("Comic not found")+" : " + path);
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
return false;
}
@ -790,12 +826,12 @@ void PDFComic::process()
if (!pdfComic) {
//delete pdfComic;
//pdfComic = 0;
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
return;
}
if (pdfComic->isLocked()) {
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit errorOpening();
return;
}
@ -830,7 +866,7 @@ void PDFComic::process()
for (int i = buffered_index; i < nPages; i++) {
if (_invalidated) {
delete pdfComic;
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
return;
}
@ -839,14 +875,14 @@ void PDFComic::process()
for (int i = 0; i < buffered_index; i++) {
if (_invalidated) {
delete pdfComic;
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
return;
}
renderPage(i);
}
delete pdfComic;
moveToThread(QCoreApplication::instance()->thread());
//moveToThread(QCoreApplication::instance()->thread());
emit imagesLoaded();
}