mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2025-05-25 18:00:46 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

Don't use scroll animations on macos by default, it where hdpi scroll is most likely to be used

Browse Source
This commit is contained in:
Luis Ángel San Martín Rodríguez 2025-01-06 10:24:16 +01:00
parent 1cd8635808
commit 31971c2348
4 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.md
View File

@ -3,6 +3,8 @@
Version counting is based on semantic versioning (Major.Feature.Patch)
## WIP (9.15.1)
### YACReader
* Don't use scroll animations on macos by default, it where hdpi scroll is most likely to be used.
### YACReaderLibrary
* Improve flexibility of the open comic in third party app setting so more complex commands can be used. e.g. `open -a "/Applications/My Reader.app" "{comic_file_path}"`.

11
YACReader/configuration.h
View File

@ -84,7 +84,16 @@ public:
bool getDoNotTurnPageOnScroll() { return settings->value(DO_NOT_TURN_PAGE_ON_SCROLL, false).toBool(); }
bool getUseSingleScrollStepToTurnPage() { return settings->value(USE_SINGLE_SCROLL_STEP_TO_TURN_PAGE, false).toBool(); }
void setDisableScrollAnimation(bool b) { settings->setValue(DISABLE_SCROLL_ANIMATION, b); }
bool getDisableScrollAnimation() { return settings->value(DISABLE_SCROLL_ANIMATION, false).toBool(); }
bool getDisableScrollAnimation()
{
#ifdef Q_OS_MACOS
auto defaultValue = true;
#else
auto defaultValue = false;
#endif
return settings->value(DISABLE_SCROLL_ANIMATION, defaultValue).toBool();
}
};
#endif

8
YACReader/options_dialog.cpp
View File

@ -286,7 +286,13 @@ void OptionsDialog::restoreOptions(QSettings *settings)
doNotTurnPageOnScroll->setChecked(settings->value(DO_NOT_TURN_PAGE_ON_SCROLL, false).toBool());
useSingleScrollStepToTurnPage->setChecked(settings->value(USE_SINGLE_SCROLL_STEP_TO_TURN_PAGE, false).toBool());
disableScrollAnimations->setChecked(settings->value(DISABLE_SCROLL_ANIMATION, false).toBool());
#ifdef Q_OS_MACOS
auto defaultDisableScrollAnimationsValue = true;
#else
auto defaultDisableScrollAnimationsValue = false;
#endif
disableScrollAnimations->setChecked(settings->value(DISABLE_SCROLL_ANIMATION, defaultDisableScrollAnimationsValue).toBool());
}
void OptionsDialog::updateColor(const QColor &color)

3
custom_widgets/whats_new_dialog.cpp
View File

@ -54,6 +54,7 @@ YACReader::WhatsNewDialog::WhatsNewDialog(QWidget *parent)
" &#8226; Bump PDF render size<br/>"
" &#8226; Fix trackpad scrolling, it makes using trackpads more responsive and natural<br/>"
" &#8226; Added more info to Help -> System info<br/>"
" &#8226; Don't use scroll animations on macos by default, it where hdpi scroll is most likely to be used and it causes scroll issues. (new 9.15.1)<br/>"
"<br/>"
"<span style=\"font-weight:600\">YACReaderLibrary</span><br/>"
" &#8226; Fix headers in the table view getting stuck in a non-movable state<br/>"
@ -69,6 +70,8 @@ YACReader::WhatsNewDialog::WhatsNewDialog(QWidget *parent)
" &#8226; Fix occasional crashes when using automatic library updates<br/>"
" &#8226; Add setting to hide the \"Continue Reading...\" banner from the home view<br/>"
" &#8226; Improve Grid and Flow Info comics view scroll performance<br/>"
" &#8226; Improve flexibility of the open comic in third party app setting so more complex commands can be used. e.g. `open -a \"/Applications/My Reader.app"
"{comic_file_path}\"` (new 9.15.1)<br/>"
"<br/>"
"<span style=\"font-weight:600\">YACReaderLibraryServer</span><br/>"
" &#8226; New command --system-info to print information about the execution environment and available resources (including what image formats are supported and what libraries are used by the app).<br/>"