diff --git a/CHANGELOG.md b/CHANGELOG.md index 511fe01c..64b27a84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,8 @@ Version counting is based on semantic versioning (Major.Feature.Patch) ## WIP (9.15.1) +### YACReader +* Don't use scroll animations on macos by default, it where hdpi scroll is most likely to be used. ### YACReaderLibrary * Improve flexibility of the open comic in third party app setting so more complex commands can be used. e.g. `open -a "/Applications/My Reader.app" "{comic_file_path}"`. diff --git a/YACReader/configuration.h b/YACReader/configuration.h index a1694117..fe29803e 100644 --- a/YACReader/configuration.h +++ b/YACReader/configuration.h @@ -84,7 +84,16 @@ public: bool getDoNotTurnPageOnScroll() { return settings->value(DO_NOT_TURN_PAGE_ON_SCROLL, false).toBool(); } bool getUseSingleScrollStepToTurnPage() { return settings->value(USE_SINGLE_SCROLL_STEP_TO_TURN_PAGE, false).toBool(); } void setDisableScrollAnimation(bool b) { settings->setValue(DISABLE_SCROLL_ANIMATION, b); } - bool getDisableScrollAnimation() { return settings->value(DISABLE_SCROLL_ANIMATION, false).toBool(); } + bool getDisableScrollAnimation() + { +#ifdef Q_OS_MACOS + auto defaultValue = true; +#else + auto defaultValue = false; +#endif + + return settings->value(DISABLE_SCROLL_ANIMATION, defaultValue).toBool(); + } }; #endif diff --git a/YACReader/options_dialog.cpp b/YACReader/options_dialog.cpp index 5d006a6a..6f443dbb 100644 --- a/YACReader/options_dialog.cpp +++ b/YACReader/options_dialog.cpp @@ -286,7 +286,13 @@ void OptionsDialog::restoreOptions(QSettings *settings) doNotTurnPageOnScroll->setChecked(settings->value(DO_NOT_TURN_PAGE_ON_SCROLL, false).toBool()); useSingleScrollStepToTurnPage->setChecked(settings->value(USE_SINGLE_SCROLL_STEP_TO_TURN_PAGE, false).toBool()); - disableScrollAnimations->setChecked(settings->value(DISABLE_SCROLL_ANIMATION, false).toBool()); + +#ifdef Q_OS_MACOS + auto defaultDisableScrollAnimationsValue = true; +#else + auto defaultDisableScrollAnimationsValue = false; +#endif + disableScrollAnimations->setChecked(settings->value(DISABLE_SCROLL_ANIMATION, defaultDisableScrollAnimationsValue).toBool()); } void OptionsDialog::updateColor(const QColor &color) diff --git a/custom_widgets/whats_new_dialog.cpp b/custom_widgets/whats_new_dialog.cpp index 68195d2e..c0947291 100644 --- a/custom_widgets/whats_new_dialog.cpp +++ b/custom_widgets/whats_new_dialog.cpp @@ -54,6 +54,7 @@ YACReader::WhatsNewDialog::WhatsNewDialog(QWidget *parent) " • Bump PDF render size
" " • Fix trackpad scrolling, it makes using trackpads more responsive and natural
" " • Added more info to Help -> System info
" + " • Don't use scroll animations on macos by default, it where hdpi scroll is most likely to be used and it causes scroll issues. (new 9.15.1)
" "
" "YACReaderLibrary
" " • Fix headers in the table view getting stuck in a non-movable state
" @@ -69,6 +70,8 @@ YACReader::WhatsNewDialog::WhatsNewDialog(QWidget *parent) " • Fix occasional crashes when using automatic library updates
" " • Add setting to hide the \"Continue Reading...\" banner from the home view
" " • Improve Grid and Flow Info comics view scroll performance
" + " • Improve flexibility of the open comic in third party app setting so more complex commands can be used. e.g. `open -a \"/Applications/My Reader.app" + "{comic_file_path}\"` (new 9.15.1)
" "
" "YACReaderLibraryServer
" " • New command --system-info to print information about the execution environment and available resources (including what image formats are supported and what libraries are used by the app).
"