mirror/yacreader
1
0
Fork 0
mirror of https://github.com/YACReader/yacreader synced 2025-05-27 19:00:29 -04:00
Code Issues Actions Packages Projects Releases Wiki Activity

QsLog: Use dedicated logging thread to avoid segfaults at app shutdown

Browse Source 
When shutting down our apps, we clean up some ressources after app.exec()
has finished. As our logger runs on the apps main thread, it can no longer
respond to any debug messages generated during the cleanup phase.

This can lead to segfaults and error masking.

Solution: Run QsLog in a dedicated thread.
This commit is contained in:
Felix Kauselmann 2022-11-12 14:09:07 +01:00 committed by Luis Ángel San Martín
parent 35466e5080
commit 21b8b70657
2 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGELOG.md
View File

@ -8,6 +8,9 @@ Version counting is based on semantic versioning (Major.Feature.Patch)
* Fixed drag&drop in the comics grid view.
* Detect back/forward mouse buttons to move back and forward through the browsing history.
### All apps
* Run logger in a dedicated thread to avoid segfaults at application shutdown
## 9.10
### YACReader

2
third_party/QsLog/QsLog.pri vendored
View File

@ -1,7 +1,7 @@
INCLUDEPATH += $$PWD
#DEFINES += QS_LOG_LINE_NUMBERS # automatically writes the file and line for each log message
#DEFINES += QS_LOG_DISABLE # logging code is replaced with a no-op
#DEFINES += QS_LOG_SEPARATE_THREAD # messages are queued and written from a separate thread
DEFINES += QS_LOG_SEPARATE_THREAD # messages are queued and written from a separate thread
#DEFINES += QS_LOG_WIN_PRINTF_CONSOLE # Use fprintf instead of OutputDebugString on Windows
#DEFINES += QS_LOG_WINDOW # allows easily showing log messages in a UI