Commit Graph

  • 545c9ebeb7 ignoring Stephan Kulow 2006-08-05 18:04:04 +00:00
  • 23bd433cde Default to ID3v2.4 in the header (fixes the bug just reported on the list) Scott Wheeler 2006-06-25 20:27:17 +00:00
  • 3856f38655 Don't overrun the buffer if the first byte is 0xff Scott Wheeler 2006-06-20 20:41:30 +00:00
  • a6aeaef64e oops Scott Wheeler 2006-06-16 23:26:25 +00:00
  • 6a66c36a0c Here's another easy one that helps out on ginormus strings. Scott Wheeler 2006-06-16 22:50:09 +00:00
  • e83f93b2c0 A couple more optimizations for splitting vectors. One of them makes search faster in the simple case (no need for Boyer-Moore for a one-character search) and append a null vector rather than instantiating a new one when we find empty fields. Scott Wheeler 2006-06-16 22:38:20 +00:00
  • eb1b7c8255 This is much, much faster on large byte vectors and gets the current bug down to where it can read the tag in around 18 seconds unstead of 30 minutes. Scott Wheeler 2006-06-16 20:36:36 +00:00
  • ebf56779f4 Allan's commit was in the wrong branch -- don't corrupt files on write... Scott Wheeler 2006-06-09 09:48:28 +00:00
  • 88aa8c125d This comes from strdup, so it should be freed rather than deleted. Patch from Jon Burgess. Scott Wheeler 2006-06-08 12:22:18 +00:00
  • ef34e50406 Initialize tag to avoid possible crashes Allan Sandfeld Jensen 2006-05-14 19:18:47 +00:00
  • f181d1d18b SVN_SILENT accidentally inserted tabs Scott Wheeler 2006-05-08 20:49:01 +00:00
  • 3f3026b349 Add a function to set the default ID3v2 encoding in the C API. Scott Wheeler 2006-05-08 20:45:42 +00:00
  • 02cf970e0d Patch from John Stirling to fix bitmasks for header fields. Scott Wheeler 2006-05-08 20:08:33 +00:00
  • fca59f432e docs typo Scott Wheeler 2006-04-20 20:31:25 +00:00
  • 985630d59a SVN_SILENT Scott Wheeler 2006-03-02 15:13:54 +00:00
  • 3a24d31b43 Two things: - Fix the channel mode, copyright and original flags, as noticed by Bjoern Petersen. - Check in the "findByDescription()" function that I've had sitting around for a while. Scott Wheeler 2006-03-02 15:02:27 +00:00
  • c35d249195 Add a wide string export fuction. Scott Wheeler 2006-02-11 21:18:03 +00:00
  • 361ce1635a Alright -- most of this code is just more cleanups, and the bugfix part of it is relatively small. Basically it took a while for me to be convinced that the ID3v2 location was always going to be before the FLAC data stream pointer. I've added a check to make sure that it stays that way, but I don't expect us to actually hit that code. Scott Wheeler 2006-01-29 17:47:38 +00:00
  • 142ddfadc9 A prelude to bugfixing. A few more cleanups. Scott Wheeler 2006-01-29 16:59:40 +00:00
  • 286d474dae Cleanups -- no functional changes. Scott Wheeler 2006-01-29 16:06:07 +00:00
  • 99fbe7ff25 Fix up the stuff here for appending values to an APE::Item and round out the API a bit. Based on Michael's patch... Scott Wheeler 2006-01-28 15:18:31 +00:00
  • 4841a5c39c If a frame has both compression and encryption, since we currently don't support encrypted frames, don't try to decompress it. Decryption is supposed to be applied before decompression, so currently the decompression isn't possible. Scott Wheeler 2006-01-28 14:00:48 +00:00
  • 59b9831868 Switch this to "rb" and "rb+" since Windows seems to barf on it without the "b" and it doesn't make a difference at all on UNIX. Scott Wheeler 2006-01-28 13:40:05 +00:00
  • 1aa0550c58 Another method that didn't actually have an implementation around. Also picked some default values for some of the d-pointer members. Scott Wheeler 2005-11-24 10:27:45 +00:00
  • 18d80d1ea0 Actually implement this constructor... Scott Wheeler 2005-11-23 10:36:06 +00:00
  • 2d06d23ec6 Missing class name on the method declaration. I'm sure this caused some fun symbol conflicts... Scott Wheeler 2005-11-23 10:27:33 +00:00
  • f9c5ecaf53 SVN_SILENT a couple of missing docs Scott Wheeler 2005-10-18 12:33:48 +00:00
  • 5bb7dbe457 Silly second declaration of the variable here that triggers an infinite loop in some cases (I'm surprised that it doesn't happen in more...this code has been around for a while.). Scott Wheeler 2005-09-27 14:34:32 +00:00
  • 603068695c A couple of things pointed out by a colleage -- fix ByteVector::size() and make the return type semantics consistant for methods that modify the object (specifically, return a reference instead of void). Scott Wheeler 2005-09-12 16:52:07 +00:00
  • 5d64692084 Just a couple of docs updates. Scott Wheeler 2005-09-06 11:39:26 +00:00
  • 78c4c18e37 Fix the documentation for this method. Scott Wheeler 2005-09-04 20:06:27 +00:00
  • fa61e63ac8 Leave the year field blank if it's set to zero (i.e. cleared). Scott Wheeler 2005-08-10 08:33:28 +00:00
  • b16c8587ab Forgot that this doesn't work for those not using my hacked up build environment for TagLib. Scott Wheeler 2005-07-27 07:29:41 +00:00
  • b84fdcfa04 Last docs updates and a small function signature change. I'm pretty sure that's it for 1.4. Scott Wheeler 2005-07-27 00:25:40 +00:00
  • 585bf5afca note other bindings Scott Wheeler 2005-07-26 00:37:39 +00:00
  • 3de9ba2e9f Bug in UTF-8 rendering. Small change, but well, without the "break;" it was doing the UTF-8 rendering and the UTF16-LE rendering to the same string, which was, well, ungood. Scott Wheeler 2005-07-25 21:34:18 +00:00
  • f7467bd1f9 Don't actually install the tdebug.h header. Scott Wheeler 2005-07-25 19:51:52 +00:00
  • eb592f0933 Don't include tdebug.h in any installed header. I'll remove it from installation shortly. Scott Wheeler 2005-07-25 19:26:00 +00:00
  • 052a1d2720 Add a list of the default file extensions that TagLib knows about, as requested by Stefan. Also did a few additional updates on the API docs. Scott Wheeler 2005-07-24 16:25:33 +00:00
  • 54b442d584 SVN_SILENT another place to update the version Scott Wheeler 2005-07-24 08:03:37 +00:00
  • 111b0dc6eb Make sure that buffer allocations for file reads aren't completely bogus. Specifically make sure that we don't actually allocate a buffer for a read that extends beyond the end of the file. Scott Wheeler 2005-07-23 23:49:29 +00:00
  • 59fd610999 Finally took Tommi's suggestion here and introduced a version of the ByteVectorList::split() that takes a maximum number of values. This should probably be used more widely in places where the max is known ahead of time for this to be a more useful fix than nailing just this special case. Anyway, fixes the bug. Scott Wheeler 2005-07-23 23:11:20 +00:00
  • 073dee2e41 This is a better way of doing this too... Now I have to remember to update the configure.in.in in the root... Scott Wheeler 2005-07-23 21:46:39 +00:00
  • ea2ac9fe64 Add pkg-config file. Scott Wheeler 2005-07-23 21:43:09 +00:00
  • 02f9b248a7 Bump to 1.4 Scott Wheeler 2005-07-23 20:58:43 +00:00
  • ddd8c2f4c9 SVN_SILENT missing docs Scott Wheeler 2005-07-22 09:03:15 +00:00
  • 02925797d2 Go ahead and increment the libtool version in preparation for 1.4. Scott Wheeler 2005-07-22 08:33:45 +00:00
  • 016a2c7b03 Add UTF16LE support. Patch mostly by Umesh Shankar. Scott Wheeler 2005-07-21 18:45:12 +00:00
  • 366a4bfe3f Hmm, that last one wasn't really quite ready. Now we actually check our list of FileTypeResolvers. Scott Wheeler 2005-07-21 18:10:10 +00:00
  • ec86c487e8 Add a mechanism for extending the file type resolution in JuK using FileRefs. Scott Wheeler 2005-07-21 17:45:23 +00:00
  • 87824b1737 Continuing going through my pile-o-patches: Scott Wheeler 2005-07-21 17:33:36 +00:00
  • ca839d884f If there is no value set for DESCRIPTION, also check COMMENT. Scott Wheeler 2005-07-21 17:30:03 +00:00
  • a2972c8ae0 Add accessors for the image description. Scott Wheeler 2005-07-21 17:27:37 +00:00
  • c756813a21 Fix up the RVA2 handling. I'm still not thrilled with the API, but this should be functional enough to hold over to the next binary incompatible change and has a minimum of differences to the previous API. Scott Wheeler 2005-07-21 00:10:57 +00:00
  • e321ae7774 Fix from Felix Berger to get RVA2 frames a little closer to working. The more complicated fix for #107025 will follow shortly. Scott Wheeler 2005-07-20 22:23:34 +00:00
  • 19a0504dfd Adding and updating svn:ignore Thiago Macieira 2005-07-16 14:39:38 +00:00
  • 35a8c9a38b Misspelling. Scott Wheeler 2005-07-13 12:22:34 +00:00
  • 1857e61a9d Instead of returning 0 on finding a deprecated frame type, create an UnknownFrame and set the flag to discard it on write. Scott Wheeler 2005-05-17 23:57:23 +00:00
  • 6ceb7a8151 Patch from Umesh Shankar to make sure that the frameID is current. Scott Wheeler 2005-05-17 22:38:01 +00:00
  • 10d8a4deac Check to make sure that there's content before trying to return it. Scott Wheeler 2005-05-17 21:27:51 +00:00
  • fc8c7d357b Do a bounds check before trying to find the mid. Scott Wheeler 2005-05-17 20:45:05 +00:00
  • 7e325a26aa Double-deleting won't make it much better Allan Sandfeld Jensen 2005-04-03 16:41:17 +00:00
  • c125032f0e ...or this Scott Wheeler 2005-04-03 16:37:56 +00:00
  • 9b1eb2f5d6 Didn't mean to check this in. Scott Wheeler 2005-04-03 16:36:17 +00:00
  • 60f73eb537 fix memory leaks Scott Wheeler 2005-04-03 16:35:55 +00:00
  • abbf24ade7 Decode samplerate correctly. BUG: 99829 Allan Sandfeld Jensen 2005-04-02 20:53:11 +00:00
  • 119bfc86db Sorry, that was actually wrong. Allan Sandfeld Jensen 2005-03-18 00:10:21 +00:00
  • a89ce9ce0c Support the new OggFLAC 1.0 standard from FLAC 1.1.2 Allan Sandfeld Jensen 2005-03-18 00:02:27 +00:00
  • 1aff3947ef Nice catch from Gunnar Roth -- the iterator was invalid here. Scott Wheeler 2005-02-02 19:04:54 +00:00
  • af8b4c7291 Don't dereference the iterator before checking to make sure that we're not at the end of the list. Thanks to Gunnar Roth for catching this one. Scott Wheeler 2005-01-14 13:04:36 +00:00
  • 3c9f7ec7d6 startsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo". Benjamin Meyer 2004-12-19 05:45:33 +00:00
  • d1eb678b77 Make the private class a friend so that it can access the protected Header class. BUG:93869 Scott Wheeler 2004-12-08 16:50:10 +00:00
  • a2b316f3fa convert "" comparison to use built in empty() function Benjamin Meyer 2004-11-22 20:08:11 +00:00
  • 4175270a45 1.3.1 Scott Wheeler 2004-11-07 16:10:40 +00:00
  • 16a9b68154 ...and now implement the missing contructor. Scott Wheeler 2004-11-06 14:43:24 +00:00
  • baed5abcac Clean up includes and actually install apeitem.h. Prior to this the APE API wasn't usable. Fortunately I'm planning on releasing a 1.3.1 tomorrow. Scott Wheeler 2004-11-06 14:31:55 +00:00
  • e5e3adc58f Since these headers weren't even usable when installed, might as well go ahead and remove the deprecated crap... Scott Wheeler 2004-11-06 14:24:40 +00:00
  • a3e62fb32e Do bounds checking before assuming that just because we've been told that there are actually more items that there actually are. Scott Wheeler 2004-10-31 20:30:47 +00:00
  • df700f96f6 Add some text explaining the APE format since it's non-obvious trying to find it online and it's poorly written once found. Scott Wheeler 2004-10-31 19:27:24 +00:00
  • 6ac3849f13 CVS_SILENT back in here again -- checking in formatting before content... Scott Wheeler 2004-10-30 16:14:35 +00:00
  • 4b47288bca Don't write a track number if the track is larger than 255. Scott Wheeler 2004-10-29 13:48:55 +00:00
  • 90772906db Make sure that the type conversion happens so that this number ends up being the appropriate seek location. I'm pretty sure that this is what was causing Ogg length information to not work on x86_64. Can you confirm Hamish? Scott Wheeler 2004-10-28 23:27:29 +00:00
  • 200c608f4f CVS_SILENT this comment belongs here now Scott Wheeler 2004-10-28 22:20:00 +00:00
  • a18866a48b Make sure that there's (a) data in a bytevector that we're trying to convert to an integer before trying to convert it and (b) make sure that there's data in an APE::Item before trying to parse it. Scott Wheeler 2004-10-28 22:11:41 +00:00
  • 790c1b16c6 More cleanups and some API docs additions. Scott Wheeler 2004-10-28 22:05:43 +00:00
  • a92f6b94dd Semantic and style cleanups. render() should be const. Use for() loops to loop through lists rather than while, fix bracket style. Scott Wheeler 2004-10-28 21:22:33 +00:00
  • d58cde9eca This line is redundant. Scott Wheeler 2004-10-20 23:34:55 +00:00
  • 9087eacd37 Add some more docs on how to use the ID3v1::StringHandler in the ID3v1::Tag documentation. Scott Wheeler 2004-10-20 23:15:08 +00:00
  • 3d5ab8fd10 Move the sanity check before the unknown frame stuff. As the code currently is if a bogus frame is hit it may try to parse it as an UnknownFrame rather than just discarding it. Scott Wheeler 2004-10-18 15:31:12 +00:00
  • 11f732d198 Forgot this. Time to redo the tarballs. Scott Wheeler 2004-09-10 02:23:31 +00:00
  • 06fbb10a4a CVS_SILENT missing doc for the namespace Scott Wheeler 2004-09-10 02:13:40 +00:00
  • d4561d3345 1.3 -- bump the libtool version Scott Wheeler 2004-09-10 01:54:20 +00:00
  • 68982059d0 misplace conditional Scott Wheeler 2004-09-10 01:42:56 +00:00
  • 133f50e356 Patch from Allan to add support for compressed frames. Scott Wheeler 2004-09-10 01:29:49 +00:00
  • cd50355a4c Remove some annoying debuging code. Allan Sandfeld Jensen 2004-09-09 23:49:49 +00:00
  • a51d1cb117 Scott's silly nitpicks... Scott Wheeler 2004-09-09 00:28:57 +00:00
  • e10bc468c8 Some API overview updates. Scott Wheeler 2004-09-08 22:38:00 +00:00
  • c142f9e47c Mention the return type. Scott Wheeler 2004-09-05 17:55:47 +00:00
  • 20fb2bd1ec Don't try to do stuff to files that aren't valid. Scott Wheeler 2004-09-05 17:54:00 +00:00
  • fa643093bd Cleaning up. Better documentation and remove dead code. Allan Sandfeld Jensen 2004-09-02 19:32:19 +00:00