35a8c9a38b
Misspelling.
...
BUG:107847
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@434245 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-07-13 12:22:34 +00:00
1857e61a9d
Instead of returning 0 on finding a deprecated frame type, create an
...
UnknownFrame and set the flag to discard it on write.
As a special bonus this meant implementing the discard-on-tag-alter
flag.
BUG:100515
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 23:57:23 +00:00
6ceb7a8151
Patch from Umesh Shankar to make sure that the frameID is current.
...
CCMAIL:Umesh Shankar <ushankar@cs.berkeley.edu >
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415233 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 22:38:01 +00:00
10d8a4deac
Check to make sure that there's content before trying to return it.
...
Almost the same as a patch from Clemens Fuchslocher
CCMAIL:clemens@allesdurcheinander.de
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415211 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 21:27:51 +00:00
fc8c7d357b
Do a bounds check before trying to find the mid.
...
CCMAIL:Felix Hupfeld <hupfeld@zib.de >
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@415196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-05-17 20:45:05 +00:00
7e325a26aa
Double-deleting won't make it much better
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402896 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:41:17 +00:00
c125032f0e
...or this
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402894 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:37:56 +00:00
9b1eb2f5d6
Didn't mean to check this in.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402892 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:36:17 +00:00
60f73eb537
fix memory leaks
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402891 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-03 16:35:55 +00:00
abbf24ade7
Decode samplerate correctly.
...
BUG: 99829
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@402712 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-04-02 20:53:11 +00:00
119bfc86db
Sorry, that was actually wrong.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398578 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-03-18 00:10:21 +00:00
a89ce9ce0c
Support the new OggFLAC 1.0 standard from FLAC 1.1.2
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@398574 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-03-18 00:02:27 +00:00
1aff3947ef
Nice catch from Gunnar Roth -- the iterator was invalid here.
...
BUG:94662
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@385470 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-02-02 19:04:54 +00:00
af8b4c7291
Don't dereference the iterator before checking to make sure that we're not
...
at the end of the list. Thanks to Gunnar Roth for catching this one.
BUG:96926
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@378404 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2005-01-14 13:04:36 +00:00
3c9f7ec7d6
startsWith() should be used to avoid bugs like: s.mid(0, 4) == "Foo".
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@371832 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-12-19 05:45:33 +00:00
d1eb678b77
Make the private class a friend so that it can access the protected Header
...
class.
BUG:93869
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@369269 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-12-08 16:50:10 +00:00
a2b316f3fa
convert "" comparison to use built in empty() function
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@365215 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-22 20:08:11 +00:00
4175270a45
1.3.1
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@361202 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-07 16:10:40 +00:00
16a9b68154
...and now implement the missing contructor.
...
BUG:92803
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:43:24 +00:00
baed5abcac
Clean up includes and actually install apeitem.h. Prior to this the APE
...
API wasn't usable. Fortunately I'm planning on releasing a 1.3.1 tomorrow.
CCMAIL:Allan Sandfeld Jensen <kde@carewolf.com >
CCBUG:92803
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:31:55 +00:00
e5e3adc58f
Since these headers weren't even usable when installed, might as well go
...
ahead and remove the deprecated crap...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@360969 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-11-06 14:24:40 +00:00
a3e62fb32e
Do bounds checking before assuming that just because we've been told that
...
there are actually more items that there actually are.
BUG:92028
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359382 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-31 20:30:47 +00:00
df700f96f6
Add some text explaining the APE format since it's non-obvious trying to
...
find it online and it's poorly written once found.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359360 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-31 19:27:24 +00:00
6ac3849f13
CVS_SILENT back in here again -- checking in formatting before content...
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@359015 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-30 16:14:35 +00:00
4b47288bca
Don't write a track number if the track is larger than 255.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358768 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-29 13:48:55 +00:00
90772906db
Make sure that the type conversion happens so that this number ends up being
...
the appropriate seek location. I'm pretty sure that this is what was causing
Ogg length information to not work on x86_64. Can you confirm Hamish?
BUG:86806
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358653 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 23:27:29 +00:00
200c608f4f
CVS_SILENT this comment belongs here now
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358639 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:20:00 +00:00
a18866a48b
Make sure that there's (a) data in a bytevector that we're trying to convert
...
to an integer before trying to convert it and (b) make sure that there's data
in an APE::Item before trying to parse it.
BUG:92028
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358637 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:11:41 +00:00
790c1b16c6
More cleanups and some API docs additions.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358636 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 22:05:43 +00:00
a92f6b94dd
Semantic and style cleanups. render() should be const. Use for() loops to
...
loop through lists rather than while, fix bracket style.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@358627 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-28 21:22:33 +00:00
d58cde9eca
This line is redundant.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356359 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-20 23:34:55 +00:00
9087eacd37
Add some more docs on how to use the ID3v1::StringHandler in the ID3v1::Tag
...
documentation.
BUG:90634
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@356354 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-20 23:15:08 +00:00
3d5ab8fd10
Move the sanity check before the unknown frame stuff. As the code currently
...
is if a bogus frame is hit it may try to parse it as an UnknownFrame rather
than just discarding it.
CCMAIL:Espen Tveit <espen.tveit@gmail.com >
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@355686 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-10-18 15:31:12 +00:00
11f732d198
Forgot this. Time to redo the tarballs.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345358 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 02:23:31 +00:00
06fbb10a4a
CVS_SILENT missing doc for the namespace
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345357 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 02:13:40 +00:00
d4561d3345
1.3 -- bump the libtool version
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345355 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 01:54:20 +00:00
68982059d0
misplace conditional
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345352 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 01:42:56 +00:00
133f50e356
Patch from Allan to add support for compressed frames.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345351 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-10 01:29:49 +00:00
cd50355a4c
Remove some annoying debuging code.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345343 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-09 23:49:49 +00:00
a51d1cb117
Scott's silly nitpicks...
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345141 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-09 00:28:57 +00:00
e10bc468c8
Some API overview updates.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@345123 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-08 22:38:00 +00:00
c142f9e47c
Mention the return type.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344197 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-05 17:55:47 +00:00
20fb2bd1ec
Don't try to do stuff to files that aren't valid.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@344196 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-05 17:54:00 +00:00
fa643093bd
Cleaning up. Better documentation and remove dead code.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343588 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-02 19:32:19 +00:00
07f56ac534
Fix typo.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@343576 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-09-02 18:50:26 +00:00
f086fdaba5
Set APELocation to the beginning of the APE-tag
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340956 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-25 15:37:53 +00:00
c538ac3912
Some extra documentation.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340248 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 21:57:07 +00:00
e5944a6f46
Find the starting position.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340210 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 20:39:32 +00:00
3ab81ed05d
Update interface. Just needs more documentation now.
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340209 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 20:38:47 +00:00
d0095d3cd7
Convert from ByteVectorList to StringList
...
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@340107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2004-08-23 15:26:23 +00:00
