mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-08-27 20:56:58 -04:00
Code Issues Packages Projects Releases Wiki Activity
1,502 Commits 5 Branches 37 Tags
eb73612a2b7ae8a9ce32bf42f3fbe55060d7b3de
Commit Graph
885 Commits
Author SHA1 Message Date
Tsuda Kageyu eb73612a2b TrueAudio: AudioProperties improvements 
Add lengthInSeconds(), lengthInMilliseconds() properties. (#503)
Avoid possible arithmetic overflows. (#520)
Remove some data members which are not needed to carry.
Add some tests for audio properties.
Add some supplementary comments.
 2015-06-18 17:52:36 +09:00
Tsuda Kageyu 68ef160dbc Fix mismatched file I/O buffer sizes. 2015-06-18 11:23:31 +09:00
Tsuda Kageyu b37eaace15 Removed an unused data member from MPE::File. 
It seems to be related to scan().
 2015-06-12 14:07:52 +09:00
Tsuda Kageyu c1c70edb76 Remove some unused private function prototypes. 2015-06-12 11:50:38 +09:00
Tsuda Kageyu 2b260fd2e8 Fix some typos in comments. 2015-06-09 10:33:32 +09:00
Scott Wheeler b1a35a8b31 Add const to docs 2015-06-03 01:21:12 +02:00
Tsuda Kageyu 0c0f123a08 Use wmemcpy() rather than memcpy() and sizeof(wchar_t). 2015-06-01 13:52:55 +09:00
Michael Helmling db90f4b358 Prefix #ifndef with TAGLIB_ in tpropertymap.h 2015-05-29 19:53:42 +02:00
Scott Wheeler a06d55ae6f Merge pull request #577 from TsudaKageyu/frameoffset 
Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). (#190)
 2015-05-26 17:53:24 +02:00
Tsuda Kageyu 618a939c56 Fix MPEG::File::firstFrameOffset() and lastFrameOffset(). (#190) 2015-05-25 02:41:27 +09:00
Tsuda Kageyu 9da20a8a52 Skip duplicate chunks when reading AIFF/WAV files. 
Similar to #492.
There is no good reason to use the last chunk rather than the first one.
 2015-05-25 00:40:13 +09:00
Tsuda Kageyu 6d6f544010 Map::erase() can take a key directly so no need to call find() beforehand. 2015-05-23 18:12:01 +09:00
Stephen F. Booth 93da3ba6d9 Merge pull request #571 from TsudaKageyu/fuzzed-wv 
Avoid an infinite loop when reading fuzzed WavPack files. (#482)
 2015-05-22 07:44:41 -04:00
Tsuda Kageyu 3094540a4b Avoid an infinite loop when reading fuzzed WavPack files. (#482) 2015-05-22 14:15:10 +09:00
Tsuda Kageyu 8e21dcc3d4 Fix a typo in comment. 2015-05-22 12:06:01 +09:00
Stephen F. Booth 0ea22348cb Merge pull request #569 from TsudaKageyu/map-erase 
std::map::erase() can take a key directly and has no-throw guarantee.
 2015-05-21 22:46:15 -04:00
Stephen F. Booth 48ca54de1f Merge pull request #484 from TsudaKageyu/fix-rfind 
Fix File::rfind() for small files.
 2015-05-21 22:44:10 -04:00
Tsuda Kageyu 54de66f275 std::map::erase() can take a key directly and has no-throw guarantee. 2015-05-22 01:26:56 +09:00
Lukáš Lalinský d4b0ba2a7a TagLib::XM::Properties is a public class that should be exported 2015-05-20 15:18:01 -07:00
Scott Wheeler e4cf012522 Bring the API more in line with the rest of TagLib 
Like in #255, this also makes it possible to read values from the
tag in a const function.
 2015-05-20 14:26:53 +02:00
Tsuda Kageyu 287078566f No need to call ID3v2::Frame::render() twice when saving an ID3v2 tag. 2015-05-19 17:39:37 +09:00
Scott Wheeler 29f535dc8d Remove *file argument to private members 
This is already covered by d->file, so there's no reason to pass a pointer
to the member dozens of times.
 2015-05-18 23:11:51 +02:00
Scott Wheeler 592522d34c Moar const fixes 2015-05-18 23:00:16 +02:00
Scott Wheeler 6b9e4e4403 1001 Const fixes (plus iterator rename) 2015-05-18 22:48:55 +02:00
Scott Wheeler 089e44f3db Remove unnecessary checks for null before delete 
Closes #343
 2015-05-18 21:40:21 +02:00
Scott Wheeler bd3c4dc1b2 Merge pull request #515 from TsudaKageyu/empty-id3v2-frame 
Skip empty ID3v2 frames when saving an ID3v2 tag.
 2015-05-18 21:36:37 +02:00
Scott Wheeler bba562b557 Add accessors to manipulate MP4 tags without modifying the internal structure 
This brings the MP4 API in line closer to other tag formats and makes it
possible to access the tag data from const functions.

"ItemListMap" has been renamed to "ItemMap" (with the old version
deprecated).  It seems that the "ListMap" notion was copied probably
from Allan's ApeTag implementation, which incorrectly copied the term
from the XiphTag.  Notably, in XiphTag, because a field can have multiple
values, the "ListMap" is a map of lists.  Calling things a "ListMap" where
there can be only one value doesn't fit.

Closes #255
 2015-05-18 21:18:33 +02:00
Scott Wheeler 451d23ca37 Add isEmpty() to MP4 
Closes #457
 2015-05-18 20:30:19 +02:00
Scott Wheeler d248f77ab9 Show something useful for ChapterFrame::toString() 
Closes #517
 2015-05-18 19:51:18 +02:00
Tsuda Kageyu 727a11573a Fix File::rfind() for small files to work just like ByteVector::rfind(). 2015-05-19 01:24:37 +09:00
Scott Wheeler 34da0c0dab Update signature and docs 
Specifically this allows the frame to be constructed and then to have
the children and embedded frames set later.
 2015-05-18 18:19:43 +02:00
Scott Wheeler 7316cd331d Remove the null termination stuff from the ToC frames too 2015-05-18 18:17:10 +02:00
Scott Wheeler a094ce7dd2 Don't underflow if there are no embedded frames 
Closes #513
 2015-05-18 17:11:18 +02:00
Scott Wheeler 941efcba18 This isn't tracked as part of the elementID anymore 2015-05-18 16:53:12 +02:00
Scott Wheeler fc24b3d22b Don't require users to include a padding byte explicitly 
This makes it where the natural construction can be used of something
like:

new ChapterFrame("ID", ... )

Closes #514
 2015-05-18 16:41:30 +02:00
Scott Wheeler 1a5d89d29e Update signature and docs to be more in-line with TagLib's style 2015-05-18 16:00:47 +02:00
Scott Wheeler 650b581f9e Merge pull request #544 from TsudaKageyu/advance 
Use std::advance rather than a loop and increment.
 2015-05-18 15:09:28 +02:00
Scott Wheeler 0739dd232a It doesn't make sense to set the factory after construction 
Closes #259
 2015-05-18 14:21:55 +02:00
Scott Wheeler 41a250a15d Make this macro work with current Qt versions 
Closes #499
 2015-05-18 12:42:24 +02:00
Tsuda Kageyu 6e40361c0e Use std::advance rather than a loop and increment. 2015-05-18 09:31:43 +09:00
Lukáš Lalinský c2570fe115 Merge pull request #521 from TsudaKageyu/gcc-warning 
Fix a GCC/Clang warning about singed/unsigned comparison.
 2015-05-17 10:06:10 -07:00
Tsuda Kageyu 3a3a6a6fda Fix some typos in comment. 2015-05-18 00:31:46 +09:00
Lukáš Lalinský 64c43b0d3f Merge pull request #535 from FestusHagen/fh1.m_UintAmbiguity 
Silenced uint ambiguity error.
 2015-05-16 17:03:53 -07:00
Lukáš Lalinský db2dfa9515 Merge pull request #538 from gogglesmm/optimize-mid-to-uint 
bytevector.mid(pos,4).toUInt() => bytevector.toUInt(pos)
 2015-05-15 20:06:24 -07:00
Lukáš Lalinský 0069debf0c Merge pull request #536 from FestusHagen/fh1.m_CMakeSubProjectFix 
Fix for using Taglib as a CMake sub directory project.
 2015-05-15 19:48:43 -07:00
Sander Jansen 60775306ea Fix code styling 2015-05-15 21:39:34 -05:00
Sander Jansen 4f77420248 replace use of bytevector.mid(pos,4).toUInt() with more optimized bytevector.toUInt(pos) 2015-05-15 21:25:44 -05:00
Tsuda Kageyu b021ed44e9 Revert the last two commits. 
But leave the tests unchanged, and add some comments.
 2015-05-16 11:16:00 +09:00
Tsuda Kageyu 1f99c93a61 Reduce redundant memset when resizing ByteVector. 2015-05-16 03:46:34 +09:00
Tsuda Kageyu a924ca0db7 Expand the internal buffer of ByteVector only if really needed. 
Add tests for all execution paths of ByteVector::resize().
 2015-05-14 11:20:35 +09:00