Commit Graph

397 Commits

Author SHA1 Message Date
Scott Wheeler
ab3c78ffeb Add the docs from my old repository.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@769145 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 17:00:56 +00:00
Scott Wheeler
7997d2cc40 SVN_SILENT docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@769120 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 15:47:10 +00:00
Scott Wheeler
a10600c603 SVN_SILENT turn off doxygen on this file
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@769085 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 13:29:03 +00:00
Scott Wheeler
37e2d6293f Ok, think I've got this all sorted out a bit. Code is much simpler now,
though much of this could be moved into the base class as there's a lot
of copy-paste action going on.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768992 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 05:46:13 +00:00
Scott Wheeler
6f6ec8d7de Another one bites the dust. Removing Yet Another TagUnion
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768980 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 04:11:42 +00:00
Scott Wheeler
be5c25bbfa Move over to the union tag class. Yeah, this is crazy to be doing close
to a release, but you know, momentum.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768978 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 03:41:31 +00:00
Scott Wheeler
f38f6588a2 Add an (internal) TagUnion class. I'll pull out the reimplementation
of this in the next commits.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768954 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-31 00:34:43 +00:00
Scott Wheeler
250d411c31 SVN_SILENT a little prettier
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768943 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 23:49:39 +00:00
Scott Wheeler
5aa1b606aa Try to work around iTunes putting binary data in a comments field by
preferring a comment without an empty description.

FEATURE:137553


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768865 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 20:21:31 +00:00
Scott Wheeler
54202bfd5c This causes TagLib to check to make sure that text values to-be-written as
ISO-8859-1 are in fact ISO-8859-1 values (assuming they were passed into TagLib
properly) and if not automatically switches those frames to UTF8.

FEATURE:90635
CCBUG:90635


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768857 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 19:50:55 +00:00
Scott Wheeler
7f9526113a docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768600 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 12:58:37 +00:00
Scott Wheeler
d26e09926e Don't try to write non-Latin1 values to ID3v1 tags since they'll ugly things will
happen when some of the characters are null.  This behavior can still be customized
via the StringHandler.

CCBUG:99149


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768597 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 12:47:03 +00:00
Scott Wheeler
bdad22b3c6 Add methods to check if this string is Latin1/ASCII compatible.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768593 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 12:42:23 +00:00
Scott Wheeler
3f19588bb1 don't leak
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768586 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 12:16:03 +00:00
Scott Wheeler
9ae596a2e5 include APE tags in the unified tag, switch these over to some not-so-pretty
but more concise macros.

WISH:141381


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768559 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 11:29:23 +00:00
Scott Wheeler
458b2b3335 rename "remove()" to "strip()" to be consistent with MPEG::File
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768450 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 03:31:41 +00:00
Scott Wheeler
adc7c9c841 s/vorbis/speex/ in speex docs
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768449 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 03:16:04 +00:00
Scott Wheeler
e6fa8c4976 bump version
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@768447 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-30 03:01:04 +00:00
Scott Wheeler
d8e6b9f4ee Add a C accessor to isValid()
BUG:153944


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@766868 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-26 20:20:40 +00:00
Scott Wheeler
fdbfa6d6f6 pedantry
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764837 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-22 17:33:48 +00:00
Scott Wheeler
abb8173104 Use XXX for an unknown language, per the spec.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764647 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-22 10:02:47 +00:00
Lukáš Lalinský
b8435c1ad5 Tweaks to preparing UTF-16 strings with BOM
- '\xFF\xFE' and '\xFE\xFF' are valid, but empty, UTF-16 strings -- don't print a warning
 - print a warning on strings that don't start with a valid BOM

BUG:156076


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764385 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-21 16:40:07 +00:00
Lukáš Lalinský
49bcce586a Add a test case for reading APIC frames with descriptions in UTF-16 including BOM
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@764373 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2008-01-21 15:46:12 +00:00
Michael Pyne
aebb9a8690 Adapt API docs for FileRef class to match current function signatures.
Patch by Vincent Castellano

CCMAIL:surye80@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@747837 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-13 02:45:12 +00:00
Lukáš Lalinský
6efe9cfcf2 Add an option to define NO_ITUNES_HACKS.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743543 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 10:13:13 +00:00
Lukáš Lalinský
6cc989eb55 Fix saving of ID3v1 tags to TrueAudio files with removed ID3v2 tags.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743541 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 10:08:43 +00:00
Lukáš Lalinský
c4a21adb8e Add a hack to read ID2v2.4 frames with v2.3-like sizes, written by iTunes.
The code is inside a '#ifndef NO_ITUNES_HACKS' block, so I hope it's ok to add it.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@743534 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-12-01 09:15:23 +00:00
Lukáš Lalinský
fed2c020fe Fix TTA audio properties reading.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740388 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-23 06:54:22 +00:00
Rolf Eike Beer
5506647153 Fix build when building complete kdesupport at once
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740189 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 19:18:18 +00:00
Lukáš Lalinský
46fbd11d8f Use correct frame sizes when calculating length of MPEG 2 or 2.5 streams.
CCBUG:130185


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740177 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 18:55:47 +00:00
Lukáš Lalinský
e06495a7e3 Support for URL link framesSupport for URL link frames, patch by Urs Fleisch.
BUG:151079
CCMAIL:ufleisch@users.sourceforge.net


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740080 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:48:01 +00:00
Lukáš Lalinský
bb9e6fe65f Split BUILD_TESTS to BUILD_TESTS and BUILD_EXAMPLES.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740072 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:20:21 +00:00
Lukáš Lalinský
51a5ae46b1 Revert r735160 and r735161, and set BUILD_TESTS to OFF if CppUnit is not found.
CCMAIL:michael.pyne@kdemail.net


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@740071 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-22 13:17:15 +00:00
Scott Wheeler
363dbf569f Do this the way the other BIC notes are listed.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@739325 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-20 21:14:20 +00:00
Scott Wheeler
f8736f0fe9 Ran my whitespace fixing script -- tabs -> spaces, removes trailing spaces.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@738725 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-19 14:44:09 +00:00
Scott Wheeler
b2e2f0bdba These were missing private copy constructors / assignment operators to make them non-copyable.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@738702 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-19 13:59:33 +00:00
Michael Pyne
438927762c This also breaks compilation of kdesupport. CppUnit won't be found since I commented
out the configure check is fixed.  Once the configure check is fixed this can be
commented back in.

CCMAIL:lalinsky@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735161 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-11 03:30:44 +00:00
Michael Pyne
fd1ad5972d Unbreak compilation for kdesupport users with CppUnit by commenting out the test suite.
This needs to be fixed to fail gracefully for users without CppUnit available.

CCMAIL:lalinsky@gmail.com


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735160 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-11 03:24:31 +00:00
Lukáš Lalinský
049f77f0d9 TrueAudio support.
This is last of the three formats implemented for libtunepimp, now used also by various players.

BUG:114982


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735116 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:55:14 +00:00
Lukáš Lalinský
2462905fe0 Fix ID3v2::UniqueFileIdentifier frame parsing.
According to the spec, the identifier contains arbitrary binary data (which
includes \0). That means splitting it on \0 and checking if we have only
two parts is wrong, because it rejects valid frames.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735109 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:20:33 +00:00
Lukáš Lalinský
41bc6f0686 Fix off-by-one error in ByteVector::find.
In case where the pattern has the same length as the bytevector, it should
degrade to A == B, not just return "not found" (e.g. A.find(A) should
return 0, not -1).


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735107 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 22:16:56 +00:00
Lukáš Lalinský
b44cee48f4 Add methods RelativeVolumeFrame::identification and RelativeVolumeFrame::setIdentification.
BUG:150481


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735098 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 21:32:32 +00:00
Lukáš Lalinský
673b77c3ac - Fixed crash in AttachedPictureFrame and GeneralEncapsulatedObjectFrame
caused by using uninitialized pointer. (BUG:151078)
- Make Frame::readStringField to actually read the string field.
- Fixed parsing of APIC frames -- there is one-byte type between mime type
  and description. The code worked only thanks to the previous bug.


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@735035 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 18:03:25 +00:00
Lukáš Lalinský
db0be6b8c6 Add a CppUnit-based test suite (only very few things is covered for now, but it's a start).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734995 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:46:04 +00:00
Lukáš Lalinský
2302f65964 Speex support.
BUG:129196


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734977 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:07:09 +00:00
Lukáš Lalinský
bb438484da Use Unicode filenames on Windows (this time the correct patch).
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734975 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:06:16 +00:00
Lukáš Lalinský
7b0c053359 Revert r734944 -- this one wasn't meant to go in.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734973 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 16:05:18 +00:00
Lukáš Lalinský
7c4dfa9188 Ignore all autotools and cmake generated files.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734971 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 15:58:10 +00:00
Lukáš Lalinský
b98be427f9 Use Unicode filenames on Windows.
git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@734944 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-10 15:16:49 +00:00
Lukáš Lalinský
5a495c5c11 WavPack support.
CCBUG:114982


git-svn-id: svn://anonsvn.kde.org/home/kde/trunk/kdesupport/taglib@733568 283d02a7-25f6-0310-bc7c-ecb5cbfe19da
2007-11-06 18:50:09 +00:00