69563d83a0
Merge pull request #533 from TsudaKageyu/bytevector-resize
...
Fix the wrong padding of ByteVector::resize().
2015-05-15 19:43:38 -07:00
60775306ea
Fix code styling
2015-05-15 21:39:34 -05:00
4f77420248
replace use of bytevector.mid(pos,4).toUInt() with more optimized bytevector.toUInt(pos)
2015-05-15 21:25:44 -05:00
b021ed44e9
Revert the last two commits.
...
But leave the tests unchanged, and add some comments.
2015-05-16 11:16:00 +09:00
1f99c93a61
Reduce redundant memset when resizing ByteVector.
2015-05-16 03:46:34 +09:00
a924ca0db7
Expand the internal buffer of ByteVector only if really needed.
...
Add tests for all execution paths of ByteVector::resize().
2015-05-14 11:20:35 +09:00
e43c1a3c09
Fix for using Taglib as a CMake sub directory project.
2015-05-09 20:29:52 -04:00
1e9529380d
Silenced uint ambiguity error.
2015-05-09 14:19:33 -04:00
ff8443f33a
Fix the wrong padding of ByteVector::resize().
...
The expanded area will be filled with garbage instead of correct padding in some corner cases.
2015-05-02 02:43:08 +09:00
62ab41fa07
Merge pull request #532 from TsudaKageyu/bytevector-detach-test
...
A little robuster tests for ByteVector iterators after detaching.
2015-04-29 10:14:16 -07:00
00e3504264
A little robuster tests for ByteVector iterators after detaching.
2015-04-29 17:15:13 +09:00
852da79899
Merge pull request #531 from TsudaKageyu/bytevector-detach
...
Fix ByteVector to return correct iterators after detached.
2015-04-28 20:34:53 -07:00
ab047f6054
Fix ByteVector to return correct iterators after detached.
2015-04-29 10:28:08 +09:00
5bad35c4cb
Merge pull request #527 from TsudaKageyu/wma-guid
...
Fix saving WMA files with some GUID fields.
2015-04-28 10:42:06 -07:00
8d708c03e1
Store any GUID fields in Metadata Library Object.
2015-04-28 16:40:24 +09:00
f9a0b50830
Fix saving WMA files with some GUID fields.
2015-04-28 12:06:24 +09:00
8491266b12
Fix a GCC/Clang warning about singed/unsigned comparison.
2015-04-17 09:38:21 +09:00
066b5aa57e
Merge pull request #492 from TsudaKageyu/duplicate-id3v2-aiff-wav
...
Check AIFF/WAV files for duplicate tags.
2015-03-25 08:16:41 -04:00
5f0a7da481
Take into account the frame header version when skipping an empty frame.
2015-03-24 10:41:39 +09:00
d33d684fab
Discard empty ID3v2 frames instead of adding a dummy null byte.
2015-03-24 10:31:52 +09:00
4c4be0a263
Add a dummy byte to an empty ID3v2 frame to stick to the ID3v2 spec.
2015-03-22 22:14:21 +09:00
f476cf2b45
Merge pull request #511 from TsudaKageyu/tag-prop
...
Fix a bug that Tag::setProperties() clears the date instead of the track number
2015-03-20 10:28:20 +01:00
68c0b0591b
Fix a bug that Tag::setProperties() clears the date instead of the track number.
2015-03-20 13:33:13 +09:00
8fccaf30d2
Merge pull request #479 from TsudaKageyu/fuzzed-mp4
...
Fix an infinite loop when parsing MP4 files.
2015-02-18 08:15:50 -05:00
b69973bcf2
Fix infinite loops when parsing MP4 files.
2015-02-18 11:33:10 +09:00
30eac7569f
Check AIFF/WAV files for duplicate tags.
...
AIFF/WAV files can have duplicate tags and it leads to memory leak.
2015-02-18 11:31:55 +09:00
f6081ed32e
Merge pull request #505 from TsudaKageyu/fuzzed-ape-tests
...
Separate the tests for fuzzed APE files.
2015-02-17 09:22:35 +01:00
0839a23902
Separate the tests for fuzzed APE files.
2015-02-17 12:36:57 +09:00
f35a279dd1
Merge pull request #496 from TsudaKageyu/fuzzed-mpc
...
Some fixes for fuzzed MPC files.
2015-02-16 19:26:57 +01:00
e463d14f2e
Check for EOF to fix a segfault while parsing fuzzed MPC files.
2015-02-17 01:22:39 +09:00
829ae2112a
Check the packet size to fix a segfault error while parsing fuzzed MPC files.
2015-02-17 01:22:39 +09:00
65664e6855
Check for EOF to fix an infinite loop while parsing fuzzed MPC files.
2015-02-17 01:22:39 +09:00
2193d6dd84
Fix an out-of-bounds access and consequent errors while parsing fuzzed MPC files.
...
Consequent errors may vary: segfault, zerodiv and so forth.
2015-02-17 01:22:38 +09:00
ef786188ad
Merge pull request #502 from TsudaKageyu/fix-save-wav
...
Fix saving ID3v2/INFO tags of WAV files.
2015-01-31 14:12:18 -05:00
2b5ee8deb9
Fix saving ID3v2/INFO tags of WAV files.
...
The old tag won't be removed when the new tag is empty.
2015-01-30 14:51:28 +09:00
ed09c9cf87
Merge pull request #494 from TsudaKageyu/fix-zlib
...
Fix a wrong parameter for zlib.
2015-01-06 17:06:10 +01:00
9d91610fc0
Fix a wrong parameter for zlib.
...
z_stream.avail_in has to be the length of the input buffer.
It will fail when frameDataLength is smaller than the actual compressed data size.
2015-01-06 18:45:42 +09:00
aed689c145
Merge pull request #491 from TsudaKageyu/aiff-hasid3v2
...
Implement missing AIFF::File::hasID3v2Tag().
2015-01-05 08:17:21 -05:00
c6a63a3a2f
Implement missing AIFF::File::hasID3v2Tag().
2015-01-05 18:20:31 +09:00
2b0a540228
Merge pull request #490 from TsudaKageyu/remove-uncompr
...
Remove an unused file from taglib/CMakeLists.txt.
2015-01-04 22:31:42 -05:00
2685ec1842
Remove an unused file from taglib/CMakeLists.txt.
...
uncompr.c is no longer used since caa53e8
2015-01-05 11:00:47 +09:00
fdea6dcd40
Merge pull request #489 from TsudaKageyu/frame-flag-tests
...
Add some tests for huge memory allocation due to bad ID3v2 frame header ...
2015-01-05 02:03:06 +01:00
ed253d3691
Add some tests for huge memory allocation due to bad ID3v2 frame header flags.
...
The tests covers #466 and #486 .
Also fixes a compilation error on some compilers.
2015-01-05 09:34:30 +09:00
57729b834a
Show a debugging message when we have an error reading
2015-01-04 20:13:24 +01:00
caa53e8de5
Read the compressed data as a stream
...
This avoids allocating the complete buffer at first based solely
on the value read from the frame header. This then does a sanity
check at the end of reading to make sure that the two values match.
At present, it just prints a debugging message if the values do not
match.
Fixes #466
2015-01-04 19:58:18 +01:00
31982660c8
Merge pull request #485 from TsudaKageyu/oga-segfault
...
Fix a segfault when reading faulty Ogg/FLAC files.
2015-01-01 19:48:23 +01:00
bd7b8cc36a
Merge pull request #473 from TsudaKageyu/fix-infotag
...
Fix an infinite loop when parsing an INFO tag.
2015-01-01 19:46:53 +01:00
bc9bbfe3fa
Add a check for faulty Ogg/FLAC files.
2015-01-02 00:10:51 +09:00
7adea3df22
Separate tests for fuzzed WAV files.
2015-01-01 23:18:43 +09:00
5ebb2ece80
Fix a segfault when reading faulty Ogg/FLAC files.
2015-01-01 19:59:30 +09:00
