Tsuda Kageyu
101a330d55
The new test wasn't called.
2015-11-30 18:32:49 +09:00
Tsuda Kageyu
59088096e6
Add some tests for M4V files.
2015-11-30 17:18:50 +09:00
Tsuda Kageyu
fcdf7c2ae2
Add some tests to check if the internal flags are updated when writing WAV files.
2015-11-30 13:46:43 +09:00
Tsuda Kageyu
8c424badad
Avoid writing an empty ID3v2 tag in an AIFF file.
2015-11-30 13:42:25 +09:00
Tsuda Kageyu
1fa677e2ef
Add some tests about splitting/merging Ogg pages.
2015-11-29 01:57:15 +09:00
Tsuda Kageyu
8130b30397
Close temporary files regardless if the tests are successful or not.
...
delete statements are skipped when assertions fail.
2015-11-27 15:20:16 +09:00
Tsuda Kageyu
67cbf2c0a8
Silence a GCC warning in tests about ignoring a return value.
2015-11-27 02:45:33 +09:00
Tsuda Kageyu
477aba9465
Merge pull request #676 from TsudaKageyu/string-hide-private
...
Hide private things from a public header.
2015-11-23 17:48:06 +09:00
Tsuda Kageyu
e44de9f37f
Remove duplicate tags when saving AIFF files.
...
Just the same way as WAV already does.
2015-11-22 21:03:33 +09:00
Tsuda Kageyu
559c6b28c9
Merge pull request #681 from TsudaKageyu/xiph-remove-fields
...
Add alternative methods to XiphComment::removeField() that may cause …
2015-11-22 16:19:15 +09:00
Tsuda Kageyu
f34d73d319
Make FileRef::FileTypeResolver work properly.
2015-11-21 18:29:41 +09:00
Tsuda Kageyu
c3807e59cd
Merge pull request #528 from chouquette/master
...
FileRef: Allow an IOStream to be used
2015-11-21 09:51:03 +09:00
Tsuda Kageyu
84e3582332
Add alternative methods to XiphComment::removeField().
...
Using XiphComment::removeField() may lead to a linkage error, however we can't fix the method itself without breaking the ABI or changing its behavior.
So we added some alternative method and marked the old one deprecated.
2015-11-20 23:28:32 +09:00
Tsuda Kageyu
94c941928a
Merge pull request #654 from TsudaKageyu/xiph-setcomment
...
Fix XiphComment::setComment() for the case that a Vorbis comment has …
2015-11-20 23:02:51 +09:00
Tsuda Kageyu
8c6fe45453
Avoid using String::null where an empty string is required.
...
String::null is not necessarily be empty or remains the same instance.
Using it in a public header may lead to a linkage error.
2015-11-20 22:21:47 +09:00
Tsuda Kageyu
29b0568dec
Revert "Add a test about handing "COMMENT" and "DESCIPRION" fields in XiphComment."
...
This reverts commit 8f147034d6
.
2015-11-20 14:18:40 +09:00
Tsuda Kageyu
6dc8d701a8
Avoid writing duplicate tags when saving ASF files.
...
Reduce memory reallocations and copies when saving ASF files.
2015-11-20 13:48:25 +09:00
Tsuda Kageyu
6d5654028a
Merge pull request #642 from TsudaKageyu/strip-and-properties
...
Fix segfaults when calling File::properties() after strip().
2015-11-20 13:24:01 +09:00
Tsuda Kageyu
e1e1b6c60c
Merge pull request #623 from TsudaKageyu/erase-duplicate-id3v2
...
Skip duplicate ID3v2 tags and treat them as an extra blank of the first one.
2015-11-20 10:49:11 +09:00
Tsuda Kageyu
1cc3e4cc57
Consistent rounding when calculating the MP4 audio length.
2015-11-19 18:24:20 +09:00
Tsuda Kageyu
a3564d8c68
Efficient lookup for the MP4/ASF field name and ID3v1 genre tables.
...
Linear lookup is much faster and memory efficient when an array is very small.
2015-11-19 16:35:55 +09:00
Tsuda Kageyu
95ef0e7882
Add some tests for String::toInt() with too large values.
2015-11-19 14:52:02 +09:00
Tsuda Kageyu
539d951277
Avoid using ByteVector::null where an empty vector is required.
...
ByteVector::null is not necessarily be empty or remains the same instance.
Using it in a public header may lead to a linkage error.
2015-11-19 10:52:46 +09:00
Tsuda Kageyu
7e85d9b202
Simplify overly complicated ByteVector::mid() implementation.
...
Especially remove the useless nested RefCounters.
2015-11-19 09:23:19 +09:00
Tsuda Kageyu
8203ccf04c
Merge pull request #608 from TsudaKageyu/mp4-has-tags
...
Add a method to check if an MP4 file on disk actually has a tag.
2015-11-18 17:14:26 +09:00
Tsuda Kageyu
b01fecd280
Separate some tests for MP4::File::hasMP4Tag().
2015-11-18 14:25:22 +09:00
Tsuda Kageyu
76de4234a1
Add a test for the CRC checksum of Ogg pages.
2015-11-17 15:05:43 +09:00
Tsuda Kageyu
4bac99e3da
Add some notes about ByteVector::isNull() and ByteVector::null.
2015-11-17 13:06:03 +09:00
Tsuda Kageyu
1a942627bf
Add String::clear() method to clear the string.
2015-11-17 11:29:52 +09:00
Tsuda Kageyu
11fbf394a3
Skip duplicate ID3v2 tags and treat them as an extra blank of the first one.
...
This enables all the file formats to handle duplicate ID3v2 tags properly and erase them automatically.
2015-11-13 11:55:56 +09:00
Tsuda Kageyu
762581fe3f
Add a method to check if an MP4 file on disk actually has a tag.
2015-11-13 11:14:12 +09:00
Tsuda Kageyu
8f147034d6
Add a test about handing "COMMENT" and "DESCIPRION" fields in XiphComment.
2015-11-13 11:07:50 +09:00
Tsuda Kageyu
b3cea6cca7
Fix XiphComment::setComment() for the case that a Vorbis comment has the "COMMENT" field.
2015-11-12 17:16:47 +09:00
Erwin Jansen
29be00dc59
Fixes access violation
...
- Fixes access violation when setting empty stringlist on integer
properties in mp4 tag
- Add a unit test that validates the fix.
2015-10-09 22:11:27 -07:00
Hugo Beauzée-Luyssen
e750cb491d
FileRef: Allow an IOStream to be used
2015-09-15 15:01:40 +02:00
Tsuda Kageyu
c7231c58a3
Improve a test about handling duplicate tags in WAV files.
2015-08-25 11:03:00 +09:00
Tsuda Kageyu
c5cf9b93bc
Fix segfaults when calling File::properties() after strip().
...
Backport TagUnion::properties() and TagUnion::removeUnsupportedProperties() from taglib2.
2015-08-25 11:03:00 +09:00
Tsuda Kageyu
e4cd963b12
Improve a test about splitting OGG pages.
...
Check for #529 .
2015-08-08 15:18:16 +09:00
Tsuda Kageyu
eff92fed98
Improve a test about splitting OGG pages.
...
Check for #529 .
2015-08-07 16:47:13 +09:00
Tsuda Kageyu
173c58cf49
Merge pull request #580 from TsudaKageyu/negative-seek
...
Fix inconsistent negative seek behavior between Linux and Windows.
2015-08-07 01:32:26 +09:00
Tsuda Kageyu
8fa86162c7
Add a test to check if the FLAC audio stream remains intact after adding an ID3v1 tag.
2015-08-03 15:40:30 +09:00
Tsuda Kageyu
f830177b3b
Correct the order of #includes in tests.
2015-08-03 11:41:55 +09:00
Tsuda Kageyu
c0f537a155
Merge pull request #581 from FestusHagen/fh2.m_FixUintAmbiguitiesInTests
...
Silence uint ambiguity errors in tests.
2015-08-02 02:40:20 +09:00
Tsuda Kageyu
11f4e4e1ca
Merge pull request #567 from TsudaKageyu/audioprop-wv
...
(wishlist) WavPack: AudioProperties improvements
2015-08-01 01:30:19 +09:00
Tsuda Kageyu
9759bd2dd7
Merge pull request #566 from TsudaKageyu/audioprop-tta
...
(wishlist) TrueAudio: AudioProperties improvements
2015-08-01 01:30:12 +09:00
Tsuda Kageyu
b28784538a
Merge pull request #565 from TsudaKageyu/audioprop-wav
...
(wishlist) WAV: AudioProperties improvements
2015-08-01 01:30:03 +09:00
Tsuda Kageyu
fdea096c8d
Merge pull request #564 from TsudaKageyu/audioprop-aiff
...
(wishlist) AIFF: AudioProperties improvements
2015-08-01 01:29:46 +09:00
Tsuda Kageyu
a9d030544a
Merge pull request #563 from TsudaKageyu/audioprop-vorbis
...
(wishlist) Ogg Vorbis: AudioProperties improvements
2015-08-01 01:29:35 +09:00
Tsuda Kageyu
8344c4d7f8
Merge pull request #562 from TsudaKageyu/audioprop-speex
...
(wishlist) Ogg Speex: AudioProperties improvements
2015-08-01 01:29:22 +09:00
Tsuda Kageyu
8b1e872f81
Merge pull request #561 from TsudaKageyu/audioprop-opus
...
(wishlist) Ogg Opus: AudioProperties improvements
2015-08-01 01:29:13 +09:00