mirror/taglib
1
0
Fork 0
mirror of https://github.com/taglib/taglib.git synced 2026-08-14 06:17:00 -04:00
Code Issues Packages Projects Releases Wiki Activity
2,716 Commits 5 Branches 37 Tags
8e6fdb42959d17bfe70823ff6bfce8aea4e36255
Commit Graph
2716 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Stephen F. Booth f429d6f406 Merge pull request #41 from EliaCereda/master 
Properly initialize frame
 2012-06-30 07:33:25 -07:00
Elia Cereda c68fe9ad7b Fixed error "Branch condition evaluates to a garbage value" (from Xcode 4.3.3 Static Analyzer, mpeg/id3v2/id3v2tag.cpp:377) 
This error occurs when the frame variable is left uninitialized because its id doesn't match any of the ids in the if and else-id cases. Initializing it on declaration fixes this issue.
 2012-06-30 16:25:33 +02:00
Stephen F. Booth 81aac3a590 Merge pull request #39 from robinst/install-build-tests-option 
Mention -DBUILD_TESTS=on in "Unit Tests" of INSTALL
 2012-06-11 04:57:04 -07:00
Robin Stocker 7279b4fb7b Don't duplicate from ID3v1 to ID3v2 when saving only ID3v2 
When saving only v2 with stripOthers (which means stripping v1), the
data from v1 would still be duplicated to v2. Likewise for the other way
around.

This is not the expected outcome when e.g. a frame was removed in v2,
because it would be added again on save from the v1 data. The test shows
that.

This changes save to only duplicate the data when the other tag type
will not be stripped.
 2012-06-10 18:53:25 +02:00
Robin Stocker b0ac79c60e Mention -DBUILD_TESTS=on in "Unit Tests" of INSTALL 2012-06-10 18:26:06 +02:00
Robin Stocker 382aec46f7 Fix docs of MPEG::File::ID3v(1|2)Tag for inexistent tag 
Since 37e2d629, the ID3v1 and ID3v2 tags are always created at the end
of MPEG::File::read. So contrary to what the documentation said, a null
pointer is never returned.

To check if a tag contains data, refer to isEmpty() in the
documentation.
 2012-06-10 15:27:54 +02:00
Michael Palimaka b5ad68d64b Add custom 'check' target that depends on the test_runner target for backwards compatibility. 2012-05-17 03:42:36 +10:00
Michael Palimaka 52e96e48c5 Install examples if built. 2012-05-16 04:37:25 +10:00
Michael Palimaka 5bcfecb6cc Use ctest instead of custom target. 2012-05-16 04:00:22 +10:00
Lukáš Lalinský 2c2a486313 Merge branch 'stable' 
Conflicts:
	CMakeLists.txt
	NEWS
 2012-04-20 18:30:07 +02:00
Lukáš Lalinský 059f2243b3 Prepare 1.7.2 release v1.7.2 2012-04-20 17:57:13 +02:00
Lukáš Lalinský cce6ad46c9 Reverse the version check, similarly to what mp4v2 does 2012-04-20 17:52:12 +02:00
Birunthan Mohanathas 06597123b8 Remove trailing whitespace 2012-04-19 13:09:45 +03:00
Birunthan Mohanathas e5ede410bc Tabs to spaces 2012-04-19 13:04:42 +03:00
Vinnie Falco dafb3af742 Remove 'using namespace std' in tmap.h 2012-04-17 22:05:09 -07:00
Lukáš Lalinský 089643f115 Merge remote-tracking branch 'vinniefalco/rename_enums' 2012-04-17 08:49:02 +02:00
Vinnie Falco 26f458b87f Resolve scope resolution for APE::Footer definitions in apefooter.cpp 2012-04-15 07:58:50 -07:00
Vinnie Falco c22791318c Resolve ambiguous File symbol in apetag.cpp 2012-04-15 07:57:02 -07:00
Vinnie Falco 5081e3cf4f Rename anonymous enumeration symbols to be unique trueaudiofile.cpp 2012-04-15 02:41:27 -07:00
Vinnie Falco 1bde4cea09 Rename anonymous enumeration symbols to be unique in wavpackfile.cpp 2012-04-15 02:40:46 -07:00
Vinnie Falco 0907e86a94 Rename anonymous enumeration symbols to be unique in apefile.cpp 2012-04-15 02:40:23 -07:00
Vinnie Falco 742a3a1dbb Rename anonymous enumeration symbols to be unique in mpcfile.cpp 2012-04-15 02:39:19 -07:00
Vinnie Falco 04a4a6b8d4 Rename anonymous enumeration symbols to be unique in flacfile.cpp 2012-04-15 02:38:15 -07:00
Jeff Mitchell b216b448c5 Fix compilation 2012-04-12 18:41:40 -04:00
Stephen F. Booth 4f8a6fdfaf Verify that an APE text item isn't empty before use 2012-04-12 10:53:32 -04:00
Stephen F. Booth 32a4ac6599 Preserve source code backward compatibility 2012-04-10 18:06:58 -04:00
Stephen F. Booth ca26a9ad3e Added support for APE tag binary items 2012-04-10 07:24:12 -04:00
Stephen F. Booth bd03e352cc Allow tag items to be replaced 2012-04-07 08:54:22 -04:00
Stephen F. Booth 69ac59f5f0 Added sampleFrames() to audio properties 2012-04-06 18:30:13 -04:00
Stephen F. Booth 2297a6d531 Added missing tmap.h 2012-04-06 18:29:56 -04:00
Lukáš Lalinský 2a4850f211 Merge branch 'stable' 
Conflicts:
	CMakeLists.txt
 2012-03-18 09:22:53 +01:00
scottmcandLukáš Lalinský 288c6e4a3f Include <iostream> instead of <ostream> to fix compilation on Haiku 2012-03-18 09:20:26 +01:00
Lukáš Lalinský 606edf8171 Increment the version number v1.7.1 2012-03-17 11:02:24 +01:00
Lukáš Lalinský 3c7b05a900 Merge branch 'stable' 
Conflicts:
	NEWS
 2012-03-17 10:59:34 +01:00
Lukáš Lalinský 009c43952f Changelog 2012-03-17 10:58:22 +01:00
Birunthan MohnathasandLukáš Lalinský 9c1668f28b Fixed (huge) memory leak with ASF. 2012-03-17 10:48:57 +01:00
Lukáš Lalinský 8e67b40bdc Fix compilation errors 2012-03-17 10:45:52 +01:00
Lukáš Lalinský 76222cb1eb Merge branch 'master' of https://github.com/supermihi/taglib 2012-03-17 10:41:02 +01:00
Birunthan Mohnathas 138dfca682 Additional change to previous fix. 2012-03-12 22:13:58 +02:00
Birunthan Mohnathas c4163a26e8 Fixed memory leak of FrameFactory singleton. 2012-03-12 18:56:08 +02:00
Birunthan Mohnathas 4496efe33b Fixed (huge) memory leak with ASF. 2012-03-12 18:44:08 +02:00
Lukáš Lalinský 3a760b060c Merge branch 'stable' 
Conflicts:
	taglib/riff/aiff/aiffproperties.cpp
	taglib/trueaudio/trueaudioproperties.cpp
	tests/test_wav.cpp
 2012-03-10 09:16:37 +01:00
Lukáš Lalinský 110cac8429 Avoid uint overflow in case the length + index is over UINT_MAX 2012-03-10 09:13:04 +01:00
Lukáš Lalinský 258ae751b5 Don't store the output of ByteVector::toUInt() in int, use uint instead 2012-03-10 09:12:32 +01:00
Lukáš Lalinský df1d3e028e Make sure to not try dividing by zero 2012-03-10 09:12:19 +01:00
Stephen F. BoothandLukáš Lalinský 23c86cf27d Check if the header is TTA1 before parsing 2012-03-10 09:11:51 +01:00
Lukáš Lalinský f59c3b67aa Detect RIFF files with invalid chunk sizes 
The bug report has a WAVE file with zero-sized 'data' chunk, which causes
TagLib to iterate over the file, 8 bytes in each iteration. The new code
adds a check for the chunk name, which forces it to mark the file as
invalid if the chunk name doesn't contain ASCII characters.

https://bugs.kde.org/show_bug.cgi?id=283412
 2012-03-10 09:06:55 +01:00
Stephen F. BoothandLukáš Lalinský 294cb22241 Don't crash when wav files have a 0 for bit per channel (sampleWidth) 
I've seen this in a wav that has an audio format of MP3 (0x55)
 2012-03-10 08:58:45 +01:00
Frank LaiandLukáš Lalinský b7ec0d26ab Be more careful when parsing Vorbis Comments 2012-03-10 08:52:59 +01:00
Scott WheelerandLukáš Lalinský 934ce51790 Don't lead the scanned blocks on save 2012-03-10 08:52:17 +01:00